Changeset 897 in tests

Timestamp:

07/09/2012 04:47:34 PM (11 years ago)

Author:

nacin

Message:

Enable PHPUnit strict mode by default.

Mark a test without assertions as incomplete (strict mode will do this implicitly).
Only define a multisite test if is_multisite(), otherwise no assertions are run.

There are now a potential for failures if a test omits output improperly,
or if a test takes too long.

Location:

trunk

Files:

• phpunit.xml (modified) (1 diff)
• tests/jacob/TestFormatting.php (modified) (1 diff)
• tests/test_option.php (modified) (2 diffs)

trunk/phpunit.xml

@@ -3 +3 @@
         backupGlobals="false"
         colors="true"
+        strict="true"
         >
     <testsuites>

trunk/tests/jacob/TestFormatting.php

@@ -48 +48 @@
     }
     function test_returns_false_for_non_utf8_strings() {
+        $this->markTestIncomplete( 'This test does not have any assertions.' );
+
         $big5 = $this->get_testdata('test_big5.txt');
         $big5 = $big5[0];

trunk/tests/test_option.php

@@ -257 +257 @@
 }
 
+if ( is_multisite() ) :
 /**
  * @group options
  */
 class TestBlogOption extends WP_UnitTestCase {
-    function setUp() {
-        parent::setUp();
-    }
-
-    function tearDown() {
-        parent::tearDown();
-    }
-
     function test_from_same_site() {
-        if ( ! is_multisite() )
-            return false;
-
         $key = rand_str();
         $key2 = rand_str();
@@ -309 +299 @@
     }
 }
+endif;