Changeset 9376

Timestamp:

10/28/2008 04:53:52 AM (17 years ago)

Author:

markjaquith

Message:

Make wp_title() sort titles based on separator direction. Reverse the titles in bundled theme. Better SEO. fixes #7338

Location:

trunk

Files:

• wp-content/themes/classic/header.php (modified) (1 diff)
• wp-content/themes/default/header.php (modified) (1 diff)
• wp-includes/general-template.php (modified) (5 diffs)

trunk/wp-content/themes/classic/header.php

@@ -11 +11 @@
     <meta http-equiv="Content-Type" content="<?php bloginfo('html_type'); ?>; charset=<?php bloginfo('charset'); ?>" />
 
-    <title><?php bloginfo('name'); ?><?php wp_title(); ?></title>
+    <title><?php wp_title('&laquo;', true, 'right'); ?> <?php bloginfo('name'); ?></title>
 
     <style type="text/css" media="screen">

trunk/wp-content/themes/default/header.php

@@ -11 +11 @@
 <meta http-equiv="Content-Type" content="<?php bloginfo('html_type'); ?>; charset=<?php bloginfo('charset'); ?>" />
 
-<title><?php bloginfo('name'); ?> <?php if ( is_single() ) { ?> &raquo; Blog Archive <?php } ?> <?php wp_title(); ?></title>
+<title><?php wp_title('&laquo;', true, 'right'); ?> <?php bloginfo('name'); ?></title>
 
 <link rel="stylesheet" href="<?php bloginfo('stylesheet_url'); ?>" type="text/css" media="screen" />

trunk/wp-includes/general-template.php

@@ -377 +377 @@
     $day = get_query_var('day');
     $title = '';
+
+    $t_sep = '%WP_TITILE_SEP%'; // Temporary separator, for accurate flipping, if necessary
 
     // If there's a category
@@ -419 +421 @@
         $my_month = $wp_locale->get_month(substr($m, 4, 2));
         $my_day = intval(substr($m, 6, 2));
-        $title = "$my_year" . ($my_month ? "$sep $my_month" : "") . ($my_day ? "$sep $my_day" : "");
+        $title = "$my_year" . ($my_month ? "$t_sep$my_month" : "") . ($my_day ? "$t_sep$my_day" : "");
     }
 
@@ -425 +427 @@
         $title = $year;
         if ( !empty($monthnum) )
-            $title .= " $sep " . $wp_locale->get_month($monthnum);
+            $title .= "$t_sep" . $wp_locale->get_month($monthnum);
         if ( !empty($day) )
-            $title .= " $sep " . zeroise($day, 2);
+            $title .= "$t_sep" . zeroise($day, 2);
     }
 
@@ -443 +445 @@
         $term = $wp_query->get_queried_object();
         $term = $term->name;
-        if ( 'right' == $seplocation )
-            $title = "$term $sep $tax";
-        else
-            $title = "$tax $sep $term";
+        $title = "$tax$t_sep$term";
     }
 
@@ -457 +456 @@
         $prefix = " $sep ";
 
-    // Determines position of the separator
-    if ( 'right' == $seplocation )
-        $title = $title . $prefix;
-    else
-        $title = $prefix . $title;
+    // Determines position of the separator and direction of the breadcrumb
+    if ( 'right' == $seplocation ) { // sep on right, so reverse the order
+        $title_array = explode( $t_sep, $title );
+        $title_array = array_reverse( $title_array );
+        $title = implode( " $sep ", $title_array ) . $prefix;
+    } else {
+        $title_array = explode( $t_sep, $title );
+        $title = $prefix . implode( " $sep ", $title_array );
+    }
 
     $title = apply_filters('wp_title', $title, $sep, $seplocation);