Changeset 9522 for trunk/wp-includes/comment.php

Timestamp:

11/05/2008 07:09:20 AM (18 years ago)

Author:

markjaquith

Message:

Massive get_comment_link() performance improvements for posts with a lot of comments. props Viper007Bond. fixes #7956

File:

• trunk/wp-includes/comment.php (modified) (2 diffs)

trunk/wp-includes/comment.php

@@ -553 +553 @@
  */
 function get_page_of_comment( $comment_ID, $per_page = null, $threaded = null ) {
+        global $wpdb;
+
         if ( !$comment = get_comment( $comment_ID ) )
                 return;
@@ -569 +571 @@
                 return get_page_of_comment( $comment->comment_parent, $per_page, $threaded );
 
-        $comments = get_comments( array( 'post_id' => $comment->comment_post_ID, 'order' => 'ASC' ) );
-
-        // Start going through the comments until we find what page number the above top level comment is on
-        $page = 1;
-        $comthispage = 0;
-        foreach ( $comments as $com ) {
-                if ( $threaded && 0 != $com->comment_parent )
-                        continue;
-
-                if ( $com->comment_ID == $comment->comment_ID )
-                        return $page;
-
-                $comthispage++;
-
-                if ( $comthispage >= $per_page ) {
-                        $page++;
-                        $comthispage = 0;
-                }
-        }
+        // Count comments older than this one
+        $oldercoms = $wpdb->get_var( $wpdb->prepare( "SELECT COUNT(comment_ID) FROM $wpdb->comments WHERE comment_post_ID = %d AND comment_parent = 0 AND comment_date_gmt < '%s'", $comment->comment_post_ID, $comment->comment_date_gmt ) );
+
+        // No older comments? Then it's page #1.
+        if ( 0 == $oldercoms )
+                return 1;
+
+        // Divide comments older than this one by comments per page to get this comment's page number
+        return ceil( ( $oldercoms + 1 ) / $per_page );
 }