Changeset 9684

Timestamp:

11/14/2008 05:52:38 PM (15 years ago)

Author:

ryan

Message:

Hello Dolly update. Props zedlander and jacobsantos. fixes #8188

File:

• trunk/wp-content/plugins/hello.php (modified) (4 diffs)

trunk/wp-content/plugins/hello.php

@@ -2 +2 @@
 /**
  * @package Hello_Dolly
+ * @author Matt Mullenweg
+ * @version 1.5
  */
 /*
@@ -12 +14 @@
 */
 
-/** These are the lyrics to Hello Dolly */
-$lyrics = "Hello, Dolly
+function hello_dolly_get_lyric() {
+    /** These are the lyrics to Hello Dolly */
+    $lyrics = "Hello, Dolly
 Well, hello, Dolly
 It's so nice to have you back where you belong
@@ -42 +45 @@
 Dolly'll never go away again";
 
-// Here we split it into lines
-$lyrics = explode("\n", $lyrics);
-// And then randomly choose a line
-$chosen = wptexturize( $lyrics[ mt_rand(0, count($lyrics) - 1) ] );
+    // Here we split it into lines
+    $lyrics = explode("\n", $lyrics);
+
+    // And then randomly choose a line
+    return wptexturize( $lyrics[ mt_rand(0, count($lyrics) - 1) ] );
+}
 
 // This just echoes the chosen line, we'll position it later
 function hello_dolly() {
-    global $chosen;
+    $chosen = hello_dolly_get_lyric();
     echo "<p id='dolly'>$chosen</p>";
 }
@@ -62 +67 @@
     #dolly {
         position: absolute;
-        top: 2.3em;
+        top: 4.5em;
         margin: 0;
         padding: 0;
-        right: 10px;
-        font-size: 16px;
-        color: #d54e21;
+        right: 215px;
+        font-size: 11px;
     }
     </style>