Index: src/wp-admin/js/common.js
===================================================================
--- src/wp-admin/js/common.js (revision 34954 (working copy)
@@ -492,10 +492,10 @@
$( this ).closest( 'tr' ).toggleClass( 'is-expanded' );
});
- $('#default-password-nag-no').click( function() {
+ $('#default-password-nag-no').click( function( e ) {
+ e.preventDefault();
setUserSetting('default_password_nag', 'hide');
$('div.default-password-nag').hide();
- return false;
});
// tab in textareas
Index: src/wp-admin/js/dashboard.js
===================================================================
--- src/wp-admin/js/dashboard.js (revision 34954)
+++ src/wp-admin/js/dashboard.js (working copy)
@@ -67,7 +67,8 @@
$( '#quick-press .submit input[type="submit"], #quick-press .submit input[type="reset"]' ).prop( 'disabled' , false );
- t = $('#quick-press').submit( function() {
+ t = $('#quick-press').submit( function( e ) {
+ e.preventDefault();
$('#dashboard_quick_press #publishing-action .spinner').show();
$('#quick-press .submit input[type="submit"], #quick-press .submit input[type="reset"]').prop('disabled', true);
@@ -87,8 +88,6 @@
latestPost.css('background', 'none');
}, 1000);
}
-
- return false;
} );
$('#publish').click( function() { act.val( 'post-quickpress-publish' ); } );
Index: src/wp-admin/js/edit-comments.js
===================================================================
--- src/wp-admin/js/edit-comments.js (revision 34954)
+++ src/wp-admin/js/edit-comments.js (working copy)
@@ -284,13 +284,13 @@
a.attr('class', 'vim-z vim-destructive');
$('.avatar', el).first().clone().prependTo('#undo-' + id + ' .' + action + '-undo-inside');
- a.click(function(){
+ a.click(function( e ){
+ e.preventDefault();
list.wpList.del(this);
$('#undo-' + id).css( {backgroundColor:'#ceb'} ).fadeOut(350, function(){
$(this).remove();
$('#comment-' + id).css('backgroundColor', '').fadeIn(300, function(){ $(this).show(); });
});
- return false;
});
}
@@ -854,7 +854,7 @@
setCommentsList();
commentReply.init();
- $(document).delegate('span.delete a.delete', 'click', function(){return false;});
+ $(document).delegate('span.delete a.delete', 'click', function( e ){ e.preventDefault(); });
if ( typeof $.table_hotkeys != 'undefined' ) {
make_hotkeys_redirect = function(which) {
Index: src/wp-admin/js/gallery.js
===================================================================
--- src/wp-admin/js/gallery.js (revision 34954)
+++ src/wp-admin/js/gallery.js (working copy)
@@ -38,33 +38,33 @@
});
};
- $('#asc').click( function() {
+ $('#asc').click( function( e ) {
+ e.preventDefault();
desc = false;
sortIt();
- return false;
});
- $('#desc').click( function() {
+ $('#desc').click( function( e ) {
+ e.preventDefault();
desc = true;
sortIt();
- return false;
});
- $('#clear').click( function() {
+ $('#clear').click( function( e ) {
+ e.preventDefault();
clearAll(1);
- return false;
});
- $('#showall').click( function() {
+ $('#showall').click( function( e ) {
+ e.preventDefault();
$('#sort-buttons span a').toggle();
$('a.describe-toggle-on').hide();
$('a.describe-toggle-off, table.slidetoggle').show();
$('img.pinkynail').toggle(false);
- return false;
});
- $('#hideall').click( function() {
+ $('#hideall').click( function( e ) {
+ e.preventDefault();
$('#sort-buttons span a').toggle();
$('a.describe-toggle-on').show();
$('a.describe-toggle-off, table.slidetoggle').hide();
$('img.pinkynail').toggle(true);
- return false;
});
// initialize sortable
Index: src/wp-admin/js/inline-edit-post.js
===================================================================
--- src/wp-admin/js/inline-edit-post.js (revision 34954)
+++ src/wp-admin/js/inline-edit-post.js (working copy)
@@ -48,9 +48,9 @@
});
// add events
- $('#the-list').on('click', 'a.editinline', function(){
+ $('#the-list').on('click', 'a.editinline', function( e ){
+ e.preventDefault();
inlineEditPost.edit(this);
- return false;
});
$('#bulk-edit').find('fieldset:first').after(
Index: src/wp-admin/js/plugin-install.js
===================================================================
--- src/wp-admin/js/plugin-install.js (revision 34954)
+++ src/wp-admin/js/plugin-install.js (working copy)
@@ -38,7 +38,8 @@
tb_position();
});
- $( '.plugin-card, .plugins .plugin-version-author-uri' ).on( 'click', 'a.thickbox', function() {
+ $( '.plugin-card, .plugins .plugin-version-author-uri' ).on( 'click', 'a.thickbox', function( e ) {
+ e.preventDefault();
tb_click.call(this);
$('#TB_title').css({'background-color':'#23282d','color':'#cfcfcf'});
@@ -45,8 +46,6 @@
$('#TB_ajaxWindowTitle').html( '' + plugininstallL10n.plugin_information + ' ' + $(this).data( 'title' ) );
$('#TB_iframeContent').attr( 'title', plugininstallL10n.plugin_information + ' ' + $(this).data( 'title' ) );
$('#TB_closeWindowButton').focus();
-
- return false;
});
/* Plugin install related JS */
Index: src/wp-admin/js/post.js
===================================================================
--- src/wp-admin/js/post.js (revision 34954)
+++ src/wp-admin/js/post.js (working copy)
@@ -432,7 +432,8 @@
settingName = 'cats';
// TODO: move to jQuery 1.3+, support for multiple hierarchical taxonomies, see wp-lists.js
- $('a', '#' + taxonomy + '-tabs').click( function(){
+ $('a', '#' + taxonomy + '-tabs').click( function( e ){
+ e.preventDefault();
var t = $(this).attr('href');
$(this).parent().addClass('tabs').siblings('li').removeClass('tabs');
$('#' + taxonomy + '-tabs').siblings('.tabs-panel').hide();
@@ -441,7 +442,6 @@
deleteUserSetting( settingName );
else
setUserSetting( settingName, 'pop' );
- return false;
});
if ( getUserSetting( settingName ) )
@@ -483,11 +483,11 @@
addAfter: catAddAfter
});
- $('#' + taxonomy + '-add-toggle').click( function() {
+ $('#' + taxonomy + '-add-toggle').click( function( e ) {
+ e.preventDefault();
$('#' + taxonomy + '-adder').toggleClass( 'wp-hidden-children' );
$('a[href="#' + taxonomy + '-all"]', '#' + taxonomy + '-tabs').click();
$('#new'+taxonomy).focus();
- return false;
});
$('#' + taxonomy + 'checklist, #' + taxonomy + 'checklist-pop').on( 'click', 'li.popular-category > label input[type="checkbox"]', function() {
@@ -608,7 +608,8 @@
return true;
};
- $( '#visibility .edit-visibility').click( function () {
+ $( '#visibility .edit-visibility').click( function ( e ) {
+ e.preventDefault();
if ( $postVisibilitySelect.is(':hidden') ) {
updateVisibility();
$postVisibilitySelect.slideDown( 'fast', function() {
@@ -616,7 +617,6 @@
} );
$(this).hide();
}
- return false;
});
$postVisibilitySelect.find('.cancel-post-visibility').click( function( event ) {
@@ -742,11 +742,12 @@
revert_e = e.html();
buttons.html(' '+postL10n.cancel+'');
- buttons.children('.save').click(function() {
+ buttons.children('.save').click(function( e ) {
var new_slug = e.children('input').val();
+ e.preventDefault();
if ( new_slug == $('#editable-post-name-full').text() ) {
buttons.children('.cancel').click();
- return false;
+ return;
}
$.post(ajaxurl, {
action: 'sample-permalink',
@@ -768,10 +769,10 @@
real_slug.val(new_slug);
$( '.edit-slug' ).focus();
});
- return false;
});
- buttons.children('.cancel').click(function() {
+ buttons.children('.cancel').click(function( e ) {
+ e.preventDefault();
$('#view-post-btn').show();
e.html(revert_e);
buttons.html(buttonsOrig);
@@ -778,7 +779,6 @@
permalink.html(permalinkOrig);
real_slug.val(revert_slug);
$( '.edit-slug' ).focus();
- return false;
});
for ( i = 0; i < full.length; ++i ) {
Index: src/wp-admin/js/postbox.js
===================================================================
--- src/wp-admin/js/postbox.js (revision 34954)
+++ src/wp-admin/js/postbox.js (working copy)
@@ -56,10 +56,10 @@
e.stopPropagation();
});
- $( '.postbox a.dismiss' ).bind( 'click.postboxes', function() {
+ $( '.postbox a.dismiss' ).bind( 'click.postboxes', function( e ) {
var hide_id = $(this).parents('.postbox').attr('id') + '-hide';
+ e.preventDefault();
$( '#' + hide_id ).prop('checked', false).triggerHandler('click');
- return false;
});
$('.hide-postbox-tog').bind('click.postboxes', function() {