From 221b1108d6accc5a82d8f204b0a33453f0550ade Mon Sep 17 00:00:00 2001 From: Anand Kumria Date: Sat, 22 Nov 2014 16:54:27 +0000 Subject: [PATCH 3/3] Actually perform a test against the string --- tests/phpunit/tests/formatting/SeemsUtf8.php | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/tests/phpunit/tests/formatting/SeemsUtf8.php b/tests/phpunit/tests/formatting/SeemsUtf8.php index 6727f2c..2858b20 100644 --- a/tests/phpunit/tests/formatting/SeemsUtf8.php +++ b/tests/phpunit/tests/formatting/SeemsUtf8.php @@ -28,14 +28,8 @@ class Tests_Formatting_SeemsUtf8 extends WP_UnitTestCase { * @dataProvider big5_strings */ function test_returns_false_for_non_utf8_strings( $big5_string ) { - $this->markTestIncomplete( 'This test does not have any assertions.' ); - $big5 = $big5[0]; - $strings = array( - "abc", - "123", - $big5 - ); + $this->assertFalse( seems_utf8( $big5_string ) ); } function big5_strings() { -- 2.1.0