+ + +
++ + +
++ /> +
+ assertEquals( 'text', $widget->id_base ); + $this->assertEquals( 'widget_text', $widget->widget_options['classname'] ); + $this->assertTrue( $widget->widget_options['customize_selective_refresh'] ); + $this->assertEquals( 400, $widget->control_options['width'] ); + $this->assertEquals( 350, $widget->control_options['height'] ); + } + + /** * Test enqueue_admin_scripts method. * * @covers WP_Widget_Text::_register @@ -152,6 +166,135 @@ class Test_WP_Widget_Text extends WP_UnitTestCase { } /** + * Test is_legacy_instance method. + * + * @covers WP_Widget_Text::is_legacy_instance + */ + function test_is_legacy_instance() { + $widget = new WP_Widget_Text(); + $base_instance = array( + 'title' => 'Title', + 'text' => "Hello\n\nWorld", + ); + + $instance = array_merge( $base_instance, array( + 'legacy' => true, + ) ); + $this->assertTrue( $widget->is_legacy_instance( $instance ), 'Legacy when legacy prop is present.' ); + + $instance = array_merge( $base_instance, array( + 'filter' => 'content', + ) ); + $this->assertFalse( $widget->is_legacy_instance( $instance ), 'Not legacy when filter is explicitly content.' ); + + $instance = array_merge( $base_instance, array( + 'text' => '', + 'filter' => true, + ) ); + $this->assertFalse( $widget->is_legacy_instance( $instance ), 'Not legacy when text is empty.' ); + + $instance = array_merge( $base_instance, array( + 'text' => "One\nTwo", + 'filter' => false, + ) ); + $this->assertTrue( $widget->is_legacy_instance( $instance ), 'Legacy when not-wpautop and there are line breaks.' ); + + $instance = array_merge( $base_instance, array( + 'text' => "One\n\nTwo", + 'filter' => false, + ) ); + $this->assertTrue( $widget->is_legacy_instance( $instance ), 'Legacy when not-wpautop and there are paragraph breaks.' ); + + $instance = array_merge( $base_instance, array( + 'text' => "One\nTwo", + 'filter' => true, + ) ); + $this->assertFalse( $widget->is_legacy_instance( $instance ), 'Not automatically legacy when wpautop and there are line breaks.' ); + + $instance = array_merge( $base_instance, array( + 'text' => "One\n\nTwo", + 'filter' => true, + ) ); + $this->assertFalse( $widget->is_legacy_instance( $instance ), 'Not automatically legacy when wpautop and there are paragraph breaks.' ); + + // Check text examples that will not migrate to TinyMCE. + $legacy_text_examples = array( + '', + '', + "", + '', + "", + "", + '', + "\nStay updated with our latest news and specials. We never sell your information and you can unsubscribe at any time.\n
\n\n
',
+ 'Hello',
+ 'echo 'Hello World!';",
+ );
+ foreach ( $migratable_text_examples as $migratable_text_example ) {
+ $instance = array_merge( $base_instance, array(
+ 'text' => $migratable_text_example,
+ 'filter' => true,
+ ) );
+ $this->assertFalse( $widget->is_legacy_instance( $instance ), 'Legacy when wpautop and there is HTML that is not liable to be mutated.' );
+ }
+ }
+
+ /**
+ * Test update method.
+ *
+ * @covers WP_Widget_Text::form
+ */
+ function test_form() {
+ $widget = new WP_Widget_Text();
+ $instance = array(
+ 'title' => 'Title',
+ 'text' => 'Text',
+ 'filter' => false,
+ 'legacy' => true,
+ );
+ $this->assertTrue( $widget->is_legacy_instance( $instance ) );
+ ob_start();
+ $widget->form( $instance );
+ $form = ob_get_clean();
+ $this->assertContains( 'class="legacy"', $form );
+
+ $instance = array(
+ 'title' => 'Title',
+ 'text' => 'Text',
+ 'filter' => 'content',
+ );
+ $this->assertFalse( $widget->is_legacy_instance( $instance ) );
+ ob_start();
+ $widget->form( $instance );
+ $form = ob_get_clean();
+ $this->assertNotContains( 'class="legacy"', $form );
+ }
+
+ /**
* Test update method.
*
* @covers WP_Widget_Text::update
@@ -161,21 +304,21 @@ class Test_WP_Widget_Text extends WP_UnitTestCase {
$instance = array(
'title' => "The\nTitle",
'text' => "The\n\nText",
- 'filter' => false,
+ 'filter' => 'content',
);
wp_set_current_user( $this->factory()->user->create( array(
'role' => 'administrator',
) ) );
- // Should return valid instance.
+ // Should return valid instance in legacy mode since filter=false and there are line breaks.
$expected = array(
'title' => sanitize_text_field( $instance['title'] ),
'text' => $instance['text'],
'filter' => 'content',
);
$result = $widget->update( $instance, array() );
- $this->assertEquals( $result, $expected );
+ $this->assertEquals( $expected, $result );
$this->assertTrue( ! empty( $expected['filter'] ), 'Expected filter prop to be truthy, to handle case where 4.8 is downgraded to 4.7.' );
// Make sure KSES is applying as expected.
@@ -184,7 +327,7 @@ class Test_WP_Widget_Text extends WP_UnitTestCase {
$instance['text'] = '';
$expected['text'] = $instance['text'];
$result = $widget->update( $instance, array() );
- $this->assertEquals( $result, $expected );
+ $this->assertEquals( $expected, $result );
remove_filter( 'map_meta_cap', array( $this, 'grant_unfiltered_html_cap' ) );
add_filter( 'map_meta_cap', array( $this, 'revoke_unfiltered_html_cap' ), 10, 2 );
@@ -192,11 +335,63 @@ class Test_WP_Widget_Text extends WP_UnitTestCase {
$instance['text'] = '';
$expected['text'] = wp_kses_post( $instance['text'] );
$result = $widget->update( $instance, array() );
- $this->assertEquals( $result, $expected );
+ $this->assertEquals( $expected, $result );
remove_filter( 'map_meta_cap', array( $this, 'revoke_unfiltered_html_cap' ), 10 );
}
/**
+ * Test update for legacy widgets.
+ *
+ * @covers WP_Widget_Text::update
+ */
+ function test_update_legacy() {
+ $widget = new WP_Widget_Text();
+
+ // Updating a widget with explicit filter=true persists with legacy mode.
+ $instance = array(
+ 'title' => 'Legacy',
+ 'text' => 'Text',
+ 'filter' => true,
+ );
+ $result = $widget->update( $instance, array() );
+ $expected = array_merge( $instance, array(
+ 'legacy' => true,
+ 'filter' => true,
+ ) );
+ $this->assertEquals( $expected, $result );
+
+ // Updating a widget with explicit filter=false persists with legacy mode.
+ $instance['filter'] = false;
+ $result = $widget->update( $instance, array() );
+ $expected = array_merge( $instance, array(
+ 'legacy' => true,
+ 'filter' => false,
+ ) );
+ $this->assertEquals( $expected, $result );
+
+ // Updating a widget in legacy form results in filter=false when checkbox not checked.
+ $instance['filter'] = true;
+ $result = $widget->update( $instance, array() );
+ $expected = array_merge( $instance, array(
+ 'legacy' => true,
+ 'filter' => true,
+ ) );
+ $this->assertEquals( $expected, $result );
+
+ // Updating a widget that previously had legacy form results in filter persisting.
+ unset( $instance['legacy'] );
+ $instance['filter'] = true;
+ $result = $widget->update( $instance, array(
+ 'legacy' => true,
+ ) );
+ $expected = array_merge( $instance, array(
+ 'legacy' => true,
+ 'filter' => true,
+ ) );
+ $this->assertEquals( $expected, $result );
+ }
+
+ /**
* Grant unfiltered_html cap via map_meta_cap.
*
* @param array $caps Returns the user's actual capabilities.