From 4f0626ba8bef7a8a803860e51fa8ed396027d9eb Mon Sep 17 00:00:00 2001 From: Achyuth Ajoy Date: Thu, 12 Sep 2019 15:36:49 -0400 Subject: [PATCH 1/2] Added special character decode to menu item title --- src/wp-includes/nav-menu.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wp-includes/nav-menu.php b/src/wp-includes/nav-menu.php index f130d2f3e1..db8a2fcf78 100644 --- a/src/wp-includes/nav-menu.php +++ b/src/wp-includes/nav-menu.php @@ -484,7 +484,7 @@ function wp_update_nav_menu_item( $menu_id = 0, $menu_item_db_id = 0, $menu_item } } - if ( $args['menu-item-title'] == $original_title ) { + if ( $args['menu-item-title'] == wp_specialchars_decode( $original_title ) ) { $args['menu-item-title'] = ''; } -- 2.23.0 From 130812f3c2f3ff20113d98dd48af4f7300cbffee Mon Sep 17 00:00:00 2001 From: Achyuth Ajoy Date: Thu, 12 Sep 2019 19:00:30 -0400 Subject: [PATCH 2/2] Add wp_unslash to menu item title argument to match with DB data --- src/wp-includes/nav-menu.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wp-includes/nav-menu.php b/src/wp-includes/nav-menu.php index db8a2fcf78..a99ddb3cef 100644 --- a/src/wp-includes/nav-menu.php +++ b/src/wp-includes/nav-menu.php @@ -484,7 +484,7 @@ function wp_update_nav_menu_item( $menu_id = 0, $menu_item_db_id = 0, $menu_item } } - if ( $args['menu-item-title'] == wp_specialchars_decode( $original_title ) ) { + if ( wp_unslash( $args['menu-item-title'] ) == wp_specialchars_decode( $original_title ) ) { $args['menu-item-title'] = ''; } -- 2.23.0