__group__,ticket,summary,reporter,component,_version,priority,severity,milestone,type,_status,workflow,_created,modified,_description,_reporter Yesterday,41151,Fatal error on Plugin Activation if it bundled in theme,rinkuyadav999,Plugins,,normal,normal,Awaiting Review,enhancement,new,reporter-feedback,2017-06-24T15:05:18Z,2017-06-24T21:11:00Z,"I have bundled 'Hello Dolly' plugin in 'Twenty Seventeen' theme and it works fine but when i install and activate 'Hello Dolly' plugin, it display 'Plugin could not be activated because it triggered a fatal error.' and 'Fatal error: Cannot redeclare hello_dolly_get_lyric() (previously declared in C:\xampp\htdocs\start\wordpress-svn\src\wp-content\themes\twentyseventeen\hello-dolly\hello.php:46) in C:\xampp\htdocs\start\wordpress-svn\src\wp-content\plugins\hello-dolly\hello.php on line 52' I have modified plugin and added {{{#!php Untitled Document
}}} ",mkrndmane Last Week,41087,Customizer: Deleting a Widget does not remove instance in options,timmydcrawford,Customize,3.9,normal,normal,Awaiting Review,defect (bug),new,reporter-feedback,2017-06-16T21:25:58Z,2017-06-23T22:57:11Z,"When deleting a widget from {{{widgets.php}}}, for example a new Media Image Widget, the widget instance is removed from the {{{widget_media_image}}} site option, along with association/placement value in {{{sidebars_widgets}}}. However, if a widget is removed using the customizer, the widget data ( again in this case testing with an image widget ), still exists in {{{get_option( 'widget_media_image' )}}}, while the entry in {{{sidebars_widgets}}} is again properly removed. It seems removal of a widget in both places ( widgets.php and customizer ) should result in the removal from the associated option in both cases.",timmydcrawford Last Week,41021,Text widget does not show Title field or TinyMCE editor,aholstrya,Widgets,4.8,normal,normal,4.8.1,defect (bug),new,reporter-feedback,2017-06-13T08:48:06Z,2017-06-23T16:54:27Z,"Hello, Further to the update towards the version of WP 4.8 I had a concern(marigold) with the widgets text which do not seem to support(bear) the function(office) "" flex ""... Can you tell it to me more? I am handed on to the version 4.7.5 and my widgets works again correctly (Saddened for the translation Reverso, I do not speak English...) I join(contact) you an image of widgets text (version 4.8) in version blocking. Have a good day. J-P Bourdet",aholstrya Old Tickets,40996,Category's won't load,BlijdorperB,Taxonomy,4.8,normal,normal,Awaiting Review,defect (bug),new,reporter-feedback,2017-06-10T17:41:45Z,2017-06-10T19:34:25Z,"In version 4.8 of WordPress, whenever you press one of the categories you get taken to an empty page on the website. [[Image(http://i.imgur.com/vOWIOE0.png)]]",BlijdorperB Old Tickets,40994,Latest update broke full justification,seasoned_geek,Editor,4.8,normal,normal,Awaiting Review,defect (bug),new,reporter-feedback,2017-06-10T16:16:51Z,2017-06-12T04:30:29Z,"I just applied the latest WordPress update (4.8.x I believe) and full justification of text has been broken. I used to be able to hand edit in the tag, but now it is just ignored.",seasoned_geek Old Tickets,40989,Image Widget not working in wp 4.8,imranaliweb,Widgets,4.8,normal,normal,Awaiting Review,defect (bug),new,reporter-feedback,2017-06-10T09:19:32Z,2017-06-11T11:47:26Z,Not working image widget link in WordPress 4.8,imranaliweb Old Tickets,40964,Wordpress 4.8 Pasting into editor functionality changed,AngusMcKinnon,Editor,4.8,normal,normal,Awaiting Review,defect (bug),new,reporter-feedback,2017-06-09T05:43:45Z,2017-06-17T03:40:12Z,"Hi there, With 4.8 the paste functionality seems to have changed in the visual editor. When I paste a list of items into the 4.8 visual editor from a text editor it now strips all ""line breaks"" and I end up with one big paragraph. I can still paste the list in text view and switch back to visual view and it keeps the line breaks. This has changed in this new version. I do this process as a daily activity. ",AngusMcKinnon Old Tickets,40920,WP 4.8 allows uploading SVG images from the image widget,saqali,Media,4.8,normal,normal,4.8.1,defect (bug),new,reporter-feedback,2017-06-04T19:21:27Z,2017-06-05T17:07:14Z,"Uploaded an SVG to the new image widget, it works but spits out a bunch of php code error, I thin it's because there's no where for me to set the height and width to ` 'flex-width' => true, 'flex-height' => true, ` ` ( ! ) Warning: Illegal string offset 'width' in C:\Users\Saqib\Documents\Websites\example.dev\wp-includes\media.php on line 988 Call Stack # Time Memory Function Location 1 0.0024 202880 {main}( ) ..\index.php:0 2 0.0027 204912 require( 'C:\Users\Saqib\Documents\Websites\example.dev\wp-blog-header.php' ) ..\index.php:17 3 0.8348 38631736 require_once( 'C:\Users\Saqib\Documents\Websites\example.dev\wp-includes\template-loader.php' ) ..\wp-blog-header.php:19 4 0.8389 38729704 include( 'C:\Users\Saqib\Documents\Websites\example.dev\wp-content\themes\genesis\single.php' ) ..\template-loader.php:74 5 0.8389 38729768 genesis( ) ..\single.php:15 6 1.0412 39602808 do_action( ) ..\framework.php:45 7 1.0412 39603240 WP_Hook->do_action( ) ..\plugin.php:453 8 1.0412 39603288 WP_Hook->apply_filters( ) ..\class-wp-hook.php:323 9 1.0412 39603792 call_user_func_array:{C:\Users\Saqib\Documents\Websites\example.dev\wp-includes\class-wp-hook.php:298} ( ) ..\class-wp-hook.php:298 10 1.0412 39603992 genesis_get_sidebar( ) ..\class-wp-hook.php:298 11 1.0413 39604064 get_sidebar( ) ..\layout.php:211 12 1.0413 39604456 locate_template( ) ..\general-template.php:122 13 1.0415 39604616 load_template( ) ..\template.php:647 14 1.0418 39614912 require_once( 'C:\Users\Saqib\Documents\Websites\example.dev\wp-content\themes\genesis\sidebar.php' ) ..\template.php:688 15 1.0549 39615600 do_action( ) ..\sidebar.php:22 16 1.0549 39616040 WP_Hook->do_action( ) ..\plugin.php:453 17 1.0549 39616088 WP_Hook->apply_filters( ) ..\class-wp-hook.php:323 18 1.0549 39616592 call_user_func_array:{C:\Users\Saqib\Documents\Websites\example.dev\wp-includes\class-wp-hook.php:298} ( ) ..\class-wp-hook.php:298 19 1.0550 39616888 blox_frontend_content ( ) ..\class-wp-hook.php:298 20 1.0550 39617088 Blox_Action_Storage->__call( ) ..\class-wp-hook.php:0 21 1.0550 39617120 call_user_func:{C:\Users\Saqib\Documents\Websites\example.dev\wp-content\plugins\blox-master\includes\global\action-storage.php:47} ( ) ..\action-storage.php:47 22 1.0550 39617136 blox_frontend_content( ) ..\action-storage.php:47 23 1.0551 39617672 do_action( ) ..\frontend.php:383 24 1.0551 39618736 WP_Hook->do_action( ) ..\plugin.php:453 25 1.0551 39618784 WP_Hook->apply_filters( ) ..\class-wp-hook.php:323 26 1.0551 39619288 call_user_func_array:{C:\Users\Saqib\Documents\Websites\example.dev\wp-includes\class-wp-hook.php:298} ( ) ..\class-wp-hook.php:298 27 1.0552 39619696 Blox_Widgets_Main->print_widgets_content( ) ..\class-wp-hook.php:298 28 1.0556 39638112 call_user_func:{C:\Users\Saqib\Documents\Websites\example.dev\wp-content\plugins\blox-widgets\blox-widgets.php:368} ( ) ..\blox-widgets.php:368 29 1.0556 39638208 Blox_Widgets_Main->blox_display_widgets( ) ..\blox-widgets.php:368 30 1.0557 39641360 call_user_func_array:{C:\Users\Saqib\Documents\Websites\example.dev\wp-content\plugins\blox-widgets\blox-widgets.php:467} ( ) ..\blox-widgets.php:467 31 1.0557 39641688 WP_Widget->display_callback( ) ..\blox-widgets.php:467 32 1.0559 39647480 WP_Widget_Media->widget( ) ..\class-wp-widget.php:395 33 1.0580 39653168 WP_Widget_Media_Image->render_media( ) ..\class-wp-widget-media.php:226 34 1.0614 39654320 _wp_get_image_size_from_meta( ) ..\class-wp-widget-media-image.php:208 ( ! ) Warning: Illegal string offset 'height' in C:\Users\Saqib\Documents\Websites\example.dev\wp-includes\media.php on line 989 Call Stack # Time Memory Function Location 1 0.0024 202880 {main}( ) ..\index.php:0 2 0.0027 204912 require( 'C:\Users\Saqib\Documents\Websites\example.dev\wp-blog-header.php' ) ..\index.php:17 3 0.8348 38631736 require_once( 'C:\Users\Saqib\Documents\Websites\example.dev\wp-includes\template-loader.php' ) ..\wp-blog-header.php:19 4 0.8389 38729704 include( 'C:\Users\Saqib\Documents\Websites\example.dev\wp-content\themes\genesis\single.php' ) ..\template-loader.php:74 5 0.8389 38729768 genesis( ) ..\single.php:15 6 1.0412 39602808 do_action( ) ..\framework.php:45 7 1.0412 39603240 WP_Hook->do_action( ) ..\plugin.php:453 8 1.0412 39603288 WP_Hook->apply_filters( ) ..\class-wp-hook.php:323 9 1.0412 39603792 call_user_func_array:{C:\Users\Saqib\Documents\Websites\example.dev\wp-includes\class-wp-hook.php:298} ( ) ..\class-wp-hook.php:298 10 1.0412 39603992 genesis_get_sidebar( ) ..\class-wp-hook.php:298 11 1.0413 39604064 get_sidebar( ) ..\layout.php:211 12 1.0413 39604456 locate_template( ) ..\general-template.php:122 13 1.0415 39604616 load_template( ) ..\template.php:647 14 1.0418 39614912 require_once( 'C:\Users\Saqib\Documents\Websites\example.dev\wp-content\themes\genesis\sidebar.php' ) ..\template.php:688 15 1.0549 39615600 do_action( ) ..\sidebar.php:22 16 1.0549 39616040 WP_Hook->do_action( ) ..\plugin.php:453 17 1.0549 39616088 WP_Hook->apply_filters( ) ..\class-wp-hook.php:323 18 1.0549 39616592 call_user_func_array:{C:\Users\Saqib\Documents\Websites\example.dev\wp-includes\class-wp-hook.php:298} ( ) ..\class-wp-hook.php:298 19 1.0550 39616888 blox_frontend_content ( ) ..\class-wp-hook.php:298 20 1.0550 39617088 Blox_Action_Storage->__call( ) ..\class-wp-hook.php:0 21 1.0550 39617120 call_user_func:{C:\Users\Saqib\Documents\Websites\example.dev\wp-content\plugins\blox-master\includes\global\action-storage.php:47} ( ) ..\action-storage.php:47 22 1.0550 39617136 blox_frontend_content( ) ..\action-storage.php:47 23 1.0551 39617672 do_action( ) ..\frontend.php:383 24 1.0551 39618736 WP_Hook->do_action( ) ..\plugin.php:453 25 1.0551 39618784 WP_Hook->apply_filters( ) ..\class-wp-hook.php:323 26 1.0551 39619288 call_user_func_array:{C:\Users\Saqib\Documents\Websites\example.dev\wp-includes\class-wp-hook.php:298} ( ) ..\class-wp-hook.php:298 27 1.0552 39619696 Blox_Widgets_Main->print_widgets_content( ) ..\class-wp-hook.php:298 28 1.0556 39638112 call_user_func:{C:\Users\Saqib\Documents\Websites\example.dev\wp-content\plugins\blox-widgets\blox-widgets.php:368} ( ) ..\blox-widgets.php:368 29 1.0556 39638208 Blox_Widgets_Main->blox_display_widgets( ) ..\blox-widgets.php:368 30 1.0557 39641360 call_user_func_array:{C:\Users\Saqib\Documents\Websites\example.dev\wp-content\plugins\blox-widgets\blox-widgets.php:467} ( ) ..\blox-widgets.php:467 31 1.0557 39641688 WP_Widget->display_callback( ) ..\blox-widgets.php:467 32 1.0559 39647480 WP_Widget_Media->widget( ) ..\class-wp-widget.php:395 33 1.0580 39653168 WP_Widget_Media_Image->render_media( ) ..\class-wp-widget-media.php:226 34 1.0614 39654320 _wp_get_image_size_from_meta( ) `",saqali Old Tickets,40872,Add $item argument to start_lvl (nav menu walker),mireillesan,Menus,4.7.5,normal,normal,Awaiting Review,feature request,new,reporter-feedback,2017-05-26T20:08:47Z,2017-06-13T01:46:02Z,"Would it be possible to add the $item argument inside the start_lvl function? Other than the usual dropdown menu, I'd also like to build megamenus and to make that possible, I need to use different ul tags (along with some JavaScript components). These custom ul tags will be different based on the parent li ((array) $item->classes) and $depth. ",mireillesan Old Tickets,40827,WP Regular post categories bug also affects Woocommerce products categories,raykaii,Menus,4.7.5,normal,normal,Awaiting Review,defect (bug),new,reporter-feedback,2017-05-20T11:12:19Z,2017-06-12T02:24:35Z,"HI, i have found a bug that is causing me lot of frustration when doing menus using categories. There is a bug with the categories nesting/child categories on the menu create page. When having many sub-nesting/child categories when the category list has over 50 nested categories and the category small menu auto creates a second page then it messes up the categories nesting. This is hard to explain. On this 1st image, is when some sub-nesting/child categories fit on one page. this is good. Note:I had to remove the menu box height to show what i mean. [[Image(https://image.ibb.co/eTgfav/nesting_on_one_page.jpg)]] but when a sub-nesting/child categories have too many sub-nesting/child (about 50) that gets chopped on 2 or more pages then the tree of the categories then the tree bugs. [[Image(https://image.ibb.co/jjwfav/bug.jpg)]] This is Tab/page:2 It brakes the tree here too plus it adds the rest of the sub-nesting/child categories at the bottom of the page why? it should be at the top as its the continuing of tab/page 1 of the categories. [[Image(https://image.ibb.co/hDiUJF/page_2.jpg)]] This bugs also affects Woocommerce products categories as we sometimes need many sub products categories. i 1st found this bug when doing a menu with Woocommerce products categories i opened a bug report here: [https://github.com/woocommerce/woocommerce/issues/13040] here or some screen shots of that bug ticket. woocommerce Product Categories tree.jpg: [[Image(https://image.ibb.co/hNZmyF/6db82992_e7fd_11e6_8090_5631505dd16d.jpg)]] [[Image(https://image.ibb.co/ckkFsa/762fb7fc_e7fd_11e6_81a2_7e00aa1b8432.jpg)]] [[Image(https://image.ibb.co/fyVFsa/a496612c_e7fd_11e6_8c69_028e8ea6891d.jpg)]] After talking with some Woocommerce devs they told me this was a WP core bug. i note ""It looks like the problem has to do with the nesting / child categories. The second page starts with the categories that are top-level and their children. Then at the end it has the miscellaneous categories whose parents are on page 1."" "" But it's not something we should be fixing as it's generated and rendered by WP core (all hierarchical categories output in the same way). We don't control that code."" ""If that's broken because of WP core's handling (looks like it is), yeah I think we should raise it."" So this is why i am opening this ticket with WP. '''BUG:''' How to replicate this bug with WP. create a root Categorie with 2 or more Parent Categories in it. then add say 50 subcategories in a parent so on the create menu page the category menu box splits the subcategories on a second page. '''Note:''' it needs to split the subcategories. if the subcategories fits on one page it will not work) EXP: {{{ root cat 1 root cat 2 root cat 3 - Parent Lv 1 -- Parent lv 2 --- Parent lv 3 - category 01 --- (ADD 50 other category in this parent) }}} ",raykaii Old Tickets,40765,Not able to get contents after more tag.,mukeshbeniwal,"Posts, Post Types",4.7.4,normal,normal,Awaiting Review,defect (bug),new,reporter-feedback,2017-05-15T09:18:04Z,2017-05-15T11:30:11Z,"I am not able to get full content of a post, I am getting till the more tag with a link to the post, but I want the complete content of post. Is there any way to get full contents? Currently I am using the following path to get post: /wp-json/wp/v2/posts/{id} ",mukeshbeniwal Old Tickets,40731,locate_template() performance improvement,danielhuesken,Themes,,normal,normal,Awaiting Review,enhancement,new,reporter-feedback,2017-05-11T12:11:51Z,2017-06-18T13:47:42Z,"If the theme uses massive the *_template functions it can come to a slow performance because the the files will be searched again and again. We can improve the performance if we use a static cache like this: {{{ function locate_template($template_names, $load = false, $require_once = true ) { static $template_cache; $located = ''; foreach ( (array) $template_names as $template_name ) { if ( !$template_name ) continue; if ( $template_cache[$template_name] ) { $located = $template_cache[$template_name]; break; } if ( isset( $template_cache[$template_name] ) && ! $template_cache[$template_name] ) continue; if ( file_exists(STYLESHEETPATH . '/' . $template_name)) { $located = STYLESHEETPATH . '/' . $template_name; $template_cache[$template_name] = $located; break; } elseif ( file_exists(TEMPLATEPATH . '/' . $template_name) ) { $located = TEMPLATEPATH . '/' . $template_name; $template_cache[$template_name] = $located; break; } elseif ( file_exists( ABSPATH . WPINC . '/theme-compat/' . $template_name ) ) { $located = ABSPATH . WPINC . '/theme-compat/' . $template_name; $template_cache[$template_name] = $located; break; } $template_cache[$template_name] = false; } if ( $load && '' != $located ) load_template( $located, $require_once ); return $located; } }}}",danielhuesken Old Tickets,40624,MP3 files with ID3v2 information can't be uploaded,sophia4wp,Upload,4.7.4,normal,normal,Awaiting Review,defect (bug),new,reporter-feedback,2017-05-01T19:02:06Z,2017-05-01T19:31:56Z,"When I upload an mp3 to the Media Library that has any ID3v2 information, I receive an error, ""Sorry, this file type is not permitted for security reasons."". When I removed the ID3v2 information, and solely had ID3v1 information, the upload completed successfully. mp3 files are an allowed file type in my WP installation. ALLOW_UNFILTERED_UPLOADS is false. ",sophia4wp Old Tickets,40601,wp_update_post then write_post causes odd revisions.,programmin,Revisions,4.8,normal,normal,Awaiting Review,defect (bug),new,reporter-feedback,2017-04-28T23:30:14Z,2017-05-01T19:27:42Z,"When you wp_update_post( $postarray ) a post, and write_post() a few lines later, it makes two revisions with the same post_name and guid. Weird.",programmin Old Tickets,40574,REST API orderby filter giving wrong output,subrataemfluence,REST API,4.7.4,normal,normal,Awaiting Review,defect (bug),new,reporter-feedback,2017-04-26T10:45:04Z,2017-05-04T09:44:07Z,"When using title as orderby filter in REST API endpoint the I am getting wrong output. == Test cases: == '''[Case -A]''' {{{#!php /wp-json/wp/v2/api/trips?filter[orderby]=title&order=asc&per_page=1 }}} '''Desired output (post title):''' ""Amritsar, the city of Golden Temple"" '''Actual output (post title):''' ""Auli Ski Resort"" '''[Case -B]''' {{{#!php /wp-json/wp/v2/api/trips?filter[orderby]=title&per_page=1 }}} '''Desired output (post title):''' ""Amritsar, the city of Golden Temple"" '''Actual output (post title):''' ""Dharamsala - The deemed smart City"" I did not specify any order as the default order in any query is supposed to be Ascending. '''[Case - C]''' {{{#!php /wp-json/wp/v2/api/trips?filter[orderby]=title&order=desc&per_page=1 }}} '''Desired output (post title):''' ""Sundarvans - the largest mangrove forest"" '''Actual output (post title):''' ""Dharamsala - The deemed smart City"" To cross check I tested with other custom post type but here again REST API gave me wrong result.",subrataemfluence Old Tickets,40573,Problem with wp_guess_url() during installation,pavelevap,General,4.8,normal,normal,Awaiting Review,defect (bug),new,reporter-feedback,2017-04-26T10:13:38Z,2017-05-03T05:14:13Z,"After uploading installation files, I went to `http://domain.cz` and then I was redirected to `http://domain.cz/domains/domain.cz/wp-admin/setup-config.php`, but it should be `http://domain.cz/wp-admin/setup-config.php`. URL `http://domain.cz/readme.html` works well. When I manually changed URL to `http://domain.cz/wp-admin/setup-config.php` then everything worked well but initial redirect caused problems for many users which did not notice that and installed WP with this URL. Popular webhoster is using `.htaccess` to allow installation more sites into subdirectories, but problem is probably inside `wp_guess_url()` function here: https://core.trac.wordpress.org/browser/tags/4.7.4/src/wp-includes/functions.php#L4306 `$script_filename_dir . '/'` == `$abspath_fix` == `/data/web/virtuals/160423/virtual/www/domains/domain.cz/` But `$_SERVER['PHP_SELF']` is `/domains/domain.cz/index.php` There should be `$_SERVER['REQUEST_URI']` or `$_SERVER['REQUEST_URI'] . 'index.php'` instead?",pavelevap 4-7 Days Ago,41111,WP-API JS Client: Add a helper to get model or collection by route,adamsilverstein,REST API,4.7,normal,normal,4.9,enhancement,assigned,needs-unit-tests,2017-06-21T09:51:02Z,2017-06-21T09:51:19Z,"In the process of adding page/custom post type support to Gutenberg, the need arose to identify the models based on their route - the code passes the route from PHP to JavaScript, and the JavaScript needs to know which model to use. See [https://github.com/WordPress/gutenberg/pull/1276 this pull requst] for additional details. We should add helpers to the client to easily find a model or collection based on its route, something like `getModelByRoute` and `getCollectionByRoute` - each would search thru the constructed models/collections and return the matching object, or `false` if none was found. We should also add unit tests to verify the functions work as expected.",adamsilverstein Last Week,41064,Registered and last edited dates on new sites should be identical,desrosj,Networks and Sites,,normal,normal,Awaiting Review,defect (bug),new,needs-unit-tests,2017-06-15T12:15:52Z,2017-06-15T17:24:52Z,"In testing #40035, I discovered that depending on how long the creation process takes for a new site, the last updated and registered date could be different by up to several seconds. Ideally, this should always be identical when a new site is created. Besides it potentially being confusing to a user, I have two use cases for this. 1. It is impossible to write a test for #40035 without these dates being guaranteed the same. 2. A good way to identify sites that were abandoned after creation would be to compare the registered and last updated dates. If these are not guaranteed to be the same this would become more difficult.",desrosj Last Week,41055,WP-API JS Client: Improve support for meta,adamsilverstein,General,4.7,normal,normal,4.9,enhancement,assigned,needs-unit-tests,2017-06-15T08:08:42Z,2017-06-16T12:02:17Z,"The wp.api JavaScript client support for meta needs some attention: * Meta helper isn't available for comments, terms and users * Meta pieces haven't been updated for the new-style meta model The `getMeta` helper should work correctly for all object types that support meta. We should also consider adding a matching `setMeta` helper. See https://github.com/WP-API/client-js/issues/168.",adamsilverstein Last Week,41010,wp_get_object_terms() returns duplicate terms if more than one taxonomy is given in args,mranner,Taxonomy,4.8,normal,normal,4.9,defect (bug),new,needs-unit-tests,2017-06-12T13:34:32Z,2017-06-15T11:38:37Z,"// works correct $list = wp_get_object_terms([ 104627 ], [ 'produkte' ]); print_r($list); // returns all terms for produkte and herkunft and merges all terms related to the post $list = wp_get_object_terms([ 104627 ], [ 'produkte', 'herkunft' ]); print_r($list); Problem is unset( $taxonomies[ $index ] ) followed by $terms = array_merge( $terms, get_terms( $args ) ); foreach ( $taxonomies as $index => $taxonomy ) {} iterates for all given taxonomies and leaves an empty $taxonomies array. get_terms() with an empty array for $args['taxonomy'] returns ""all"" related terms and merges with the terms of the previews loop run. Michael",mranner Old Tickets,40889,REST API: New terms creation with meta causes PHP Notice,caercam,REST API,4.7,normal,normal,Awaiting Review,defect (bug),new,needs-unit-tests,2017-05-30T23:29:06Z,2017-06-21T19:18:03Z,"Creating new terms with the REST API works fine, as long as there is no meta attached: {{{ POST https://localhost:8080/wp-json/wp/v2/categories X-WP-Nonce: 1234567890 Content-Type: application/json {""name"":""A new category"",""description"":""This is a new category."",""meta"":{""custom_meta"":""Custom Meta Value""}} -- response -- 403 Forbidden
Notice: Undefined property: WP_Error::$taxonomy in /var/www/wp47/wp-includes/capabilities.php on line 282
{""code"":""rest_cannot_update"",""message"":""Sorry, you are not allowed to edit the custom_meta custom field."",""data"":{""key"":""custom_meta"",""status"":403}} }}} For the record, here's what happens as far as I can tell. Probably more detailled than what's really needed, but there's two different issues here so I'd rather be precise. 1. `WP_REST_Terms_Controller::create_item()` calls `WP_REST_Meta_Fields::update_value()` with two arguments: `$request['meta']`, which is what we want, and `$request['id']`, which at this point is `null`, because we are creating a new term, not editing an existing one. 2. `WP_REST_Meta_Fields::update_value()` loops through the registered meta keys and calls `WP_REST_Meta_Fields::update_meta_value()` or `WP_REST_Meta_Fields::update_multi_meta_value()`. 3. Because `WP_REST_Terms_Controller::create_item()` casted as integer an ID that does not exist, both meta_value update methods get a `$object_id` = `0`, and use that value to check for permission to edit meta. 4. Now it's capabilities fairy: `current_user_can()` calls `WP_User::has_cap()` which calls `map_meta_cap()` which checks for the term existence with a simple boolean test on the result of `get_term()`. 5. But, because of `$object_id` value being `0`, `get_term()` returns a `WP_Error` instance, the check mentionned in 4. fails, and we get the ""Undefined property"" notice that end up in the REST API request response. TL;DR: Two issues here: 1. `WP_REST_Terms_Controller::create_item()` passes an unexisting value to the meta_value upate methods, indirectly triggering a bug in `map_meta_cap()`; 2. `map_meta_cap()` does not break as it should if `get_term()` returns an error.",caercam Old Tickets,40838,REST API: Inconsistent parameter type handling in `set_param()`,jnylen0,REST API,4.4,normal,minor,Future Release,defect (bug),new,needs-unit-tests,2017-05-22T16:24:37Z,2017-05-22T16:24:37Z,"Calling `set_param()` on a REST API `WP_REST_Request` object may lead to unexpected results. As of #40344, calling `get_param()` after `set_param()` should always work correctly, but the following situation could be improved further: 1. A JSON request comes in with a parameter set in the query string (for example, `?key=value`). 2. `set_param( 'key', 'new_value' )` is called on this request object. Since `JSON` is first in `get_parameter_order()`, the request will now contain the following parameters: - `get_json_params()`: `array( 'key' => 'new_value' )` - `get_query_params()`: `array( 'key' => 'value' )` Instead, I would expect that `set_param()` loops through the parameter order, first checking if the given parameter exists in any parameter type, and updating it if so. Otherwise, it should set the parameter using the first parameter type as a last resort.",jnylen0 Old Tickets,40748,Use REST API for Community Events,iandunn,REST API,4.8,normal,normal,Future Release,enhancement,new,needs-unit-tests,2017-05-12T17:39:23Z,2017-05-30T02:49:10Z,"#40702 introduced new Community Events to the News widget on the Dashboard screen, but it uses admin-AJAX. Converting to the REST API is a good opportunity to lay some groundwork for migration the rest of wp-admin in the future. The work for this was started in #40702, but it'll be easier to keep track of with a new ticket. I'm working on an updated version of `40702.11.diff` and will upload it soon.",iandunn Old Tickets,40704,REST API request includes possibly unintended numeric parameters from regex parsing,flixos90,REST API,4.7,normal,normal,4.8.1,defect (bug),new,needs-unit-tests,2017-05-09T18:04:08Z,2017-05-11T19:05:57Z,"When processing a route such as `/wp/v2/users/(?P[\d]+)`, the route is matched through a regular expression and its matches are stored in a variable `$args`. These `$args` are then passed to the request as URL parameters without any further processing. See the `WP_REST_Server::dispatch()` method. This means that some unnecessary parameters are included that naturally appear in a matches array when parsing a regular expression. In the above example the `$args` array would be `array( 'id' => 10, 1 => '10' )` due to the described bug. This isn't very problematic when accessing specific request parameters, but causes unexpected results when calling the `WP_REST_Request::get_params()` method, since the additional numeric parameters that are a result of regex parsing are included in there. I came across this bug while working on #40263, which uses `WP_REST_Request::get_params()`. Unless it was an intended decision to leave the regex result untouched, we should work on a fix soon.",flixos90 Old Tickets,40672,Undefined property `requireForceForDelete` prevents deleting terms in Backbone.js client,caercam,REST API,4.7.4,normal,normal,4.8.1,defect (bug),assigned,needs-unit-tests,2017-05-05T00:38:01Z,2017-05-16T14:48:02Z,"The REST API Backbone.js client makes it possible to delete terms using Backbone Model's `destroy()` function. However, when it comes to models that can't be trashed (like `Category` and `Tag`), an additional `force=true` URL parameter is required to avoid a `rest_trash_not_supported` error. When the Models are created from endpoints in the `constructFromSchema()` function, a `requireForceForDelete` property is set to `true` to have the required `force` parameter later added to the URL. Problem is, the `requireForceForDelete` property is only set for Models that have a parent in their route, overriding the Model's default `wp.api.WPApiBaseModel.initialize()` function; if the Model does not have a parent, the default `wp.api.WPApiBaseModel.initialize()` function is used, `requireForceForDelete` is `undefined`, and the `DELETE` API request fails because of the missing `force` parameter. Not sure exactly why there's a difference between Models based on whether or not they have parents, but the end result is that it's not possible to properly delete terms without having the `requireForceForDelete` added to the Model before calling `destroy()`.",caercam Old Tickets,40669,Proper query cache invalidation on queries meta queries,spacedmonkey,Query,,normal,normal,4.9,defect (bug),new,needs-unit-tests,2017-05-04T19:21:14Z,2017-06-23T01:16:40Z,"Currently, terms and comments have query caching and meta query support. Queries are cached using the use the last_changed in the object cache group. Query caches are invalidated (busted) when the last_changed value is changed, when a term / comment is changed / created. However, when meta on these objects are changed / deleted, query are not invalidated. Example. - Run a comment query with a meta query foo=bar. Get 4 results. - add_comment_meta to a new comment. - Run a comment query with a meta query foo=bar. It will return cached result of 4, even through the result should be 5. This is an issue, if plugin developers, use the meta functions to add meta to an object, queries should still invalidate. ",spacedmonkey Old Tickets,40661,WP_Term_Query->parse_query() needs filter like 'get_terms',mpol,Taxonomy,,normal,normal,Awaiting Review,enhancement,new,needs-unit-tests,2017-05-04T10:28:28Z,2017-06-23T02:56:22Z,"The new class/method WP_Term_Query->parse_query() does not provide a filter like the old function get_terms() does. Using WP_Term_Query directly has thus different functionality from using the old wp_terms function. Using a plugin like: https://wordpress.org/support/plugin/custom-taxonomy-order-ne/ with a custom term_order field and sorting based on that, gives the default sort based on name. Adding a filter to the method like get_terms, provides backwards compatibility for plugin and theme authors, that are switching to WP_Term_Query directly. This filter gives options to apply a custom order to the list of terms. Reference on support forum: https://wordpress.org/support/topic/doesnt-reorder-when-using-wp_term_query/ If adding a filter is somehow not wanted by core devs, then I will have to answer to add this filter manually to the code when support requests are coming. To be clear, I would consider that a valid response.",mpol Old Tickets,40653,Use PHP `DateTime` class API in `current_time()`,jdgrimes,Date/Time,1.0,normal,normal,Awaiting Review,enhancement,new,needs-unit-tests,2017-05-03T20:41:36Z,2017-05-08T21:12:50Z,"The `current_time()` function has been in WordPress for a long time. It was introduced before PHP offered the robust `DateTime` class and surrounding API that was introduced in 5.2. This was back in the days of hoary old things like PHP 4, and these were still formative years. Without ceremony, in [549], `current_time()` was born as a helper function to replace this code from b2: {{{#!php post_type} filter to check if my single post item is allowed to generate output on a particular REST request. If in my case this isn't allowed, I use this filter to return a WP_Error object I was assuming this was OK to do, since also the doc-block says: @return WP_REST_Response|WP_Error Response object on success, or WP_Error object on failure. But.. if $response becomes a WP_Error object, the call to $response->link_header fails. I will attach a patch to check for the possibility that $response is an WP_Error object Like to hear your thoughts. Thanks, Ruud ",ruud@… Old Tickets,40577,Introduce a capability for viewing the revisions of a post,johnbillion,Revisions,2.6,normal,normal,Future Release,enhancement,new,needs-unit-tests,2017-04-26T11:36:57Z,2017-04-26T19:51:49Z,"In order to view the revisions of a post, a user needs the ability to edit the post. This makes sense because it may be undesirable for users to be able to view older revisions of a post which they cannot edit. However it may be desirable to allow certain users to view the revisions of a post which they cannot edit, for example for auditing purposes, or to allow contributors to browse the revisions of their own published post.",johnbillion Yesterday,41148,Test for ticket 39875 can throw PHP error,schlessera,Media,4.8,normal,normal,Awaiting Review,defect (bug),new,has-patch,2017-06-24T07:53:42Z,2017-06-24T10:03:48Z,"The test that was written for #39875 can throw a PHP error under certain circumstances: `Undefined index: sizes`. The problem arises when then `wp_generate_attachment_metadata()` call does not return the proper array data. As the preview path generation directly access a specific array index, this throws a PHP error.",schlessera Yesterday,41146,Add filter for a site's class (WP_MS_Users_List_Table),kraftbj,Networks and Sites,,normal,normal,Awaiting Review,enhancement,new,has-patch,2017-06-24T03:37:27Z,2017-06-24T03:37:27Z,"In the `WP_MS_Users_List_Table`, each site that is listed is `span`'d with a class of `site-#` where `#` is the ID of the network for a site. Adding a filter to this class would allow site administrators to add addition classes to this output which would easily allow for styling of site items based on the additional classes.",kraftbj 2 Days Ago,41134,Move __autoload compat to pevent deprecation warnings,ayeshrajans,Bootstrap/Load,trunk,normal,normal,Awaiting Review,enhancement,new,has-patch,2017-06-23T08:15:55Z,2017-06-24T06:34:44Z,"Hi everyone, This is my first ticket in WP Trac, so I apologize in advance and appreciate shedding some lights if I'm doing anything unconventional. With Wordpress now recommending PHP 7, I believe we should take care of compatibility issues with modern PHP versions. PHP 7.2 alpha is released, and I decided to see and fix any incompatibilities with it. 7.2 has not reached a feature-freeze yet, but we already know the deprecated features/functions in it. Vanilla Wordpress 4.8, running on PHP 7.2.alpha2 (todays version) has one consistent notice: {{{ Deprecated: __autoload() is deprecated, use spl_autoload_register() instead in wp-includes\compat.php on line 502. }}} There is a comment in compat.php that says SPL ''can'' be disabled. This is true for PHP 5.2 users,but since PHP 5.3, SPL ''can not'' be disabled (http://php.net/manual/en/spl.installation.php). This noticed is raised by the PHP compiler itself, and not during the execution. This means the notice will be raised as soon as the compiler ""sees"" the function. wordpress.org stats show that we only have PHP 5.2 user base of 4.7 (https://wordpress.org/about/stats/). Quite often, one need to recompile PHP in order to disable SPL extension, and it makes a PHP installation hardly usable with modern PHP applications. I suggest that we remove the compat.php `__autoload` and its other compat functions (spl_register_*) to avoid the PHP notice in PHP 7.2, and I believe it's a fair trade-off. ",ayeshrajans 3 Days Ago,41121,Consistency of the _deprecated_function() calls and related documentation.,jrf,General,trunk,normal,normal,4.9,task (blessed),reviewing,has-patch,2017-06-22T03:00:23Z,2017-06-25T01:23:27Z,"While working on [https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/pull/979 updating the `WP.DeprecatedFunctions` sniff] which is part of the [https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/ WordPress Coding Standards] project, we've come across a number of inconsistencies in the application of the function and/or the related documentation. @jdgrimes previously already reported this concerning three functions in #41094 (has its own patch in that ticket), however since then a lot more inconsistencies have been identified. In a series of patches which I will add to this ticket I will address these: === Patch 1: Fix deprecation info in various docblocks * Fix incorrect deprecation comment naming the deprecated function as its own alternative * Fix typo in docblock `@deprecated` tag which meant that deprecation is not indicated on the dev ref website * Add missing `@deprecated` tags for two functions * Add missing alternative in `@deprecated` comment for `wp_get_sites()` === Patch 2: Add missing replacement functions to various `_deprecated_function()` calls * Add missing parentheses to a few deprecated function replacement function strings to be consistent with how this is done everywhere else. * Add missing alternative for the WP_Customize Widget deprecated methods. * Add missing alternative for three deprecated ms functions * Add missing alternative for deprecated `wp_cache_reset()` function === Patch 3: Add missing `_deprecated_function()` function calls to various functions * Add missing `_deprecated_function()` call for `funky_javascript_callback()` * Add missing `_deprecated_function()` call for `_save_post_hook()`. * Add missing `_deprecated_function()` call for `default_topic_count_text()`. * Add missing `_deprecated_function()` call for `screen_meta()`. * Add missing `_deprecated_function()` call for two screen icon related functions * Add missing `_deprecated_function()` call for nine wp_dashboard related functions * Add missing `_deprecated_function()` call for `wp_ajax_wp_fullscreen_save_post()`. * Add missing `_deprecated_function()` call for `ms_deprecated_blogs_file()` === Patch 4: Add missing `_deprecated_function()` calls to various deprecated class methods * Add `_deprecated_function()` calls to all methods within the deprecated WP_User_Search class. * Add missing `_deprecated_function()` call for four methods in WP_Customize_Image_Control === Patch 5: Add missing `_deprecated_function()` calls for four deprecated pluggable functions. Not all functions complied with what the docblock at the top of the files states: > Deprecated warnings are also thrown if one of these functions is being defined by a plugin.",jrf 4-7 Days Ago,41110,"Display full content of ""Pending"" comment on WP Dashboard",puneetsahalot,Comments,4.8,normal,normal,Awaiting Review,enhancement,new,has-patch,2017-06-21T05:42:37Z,2017-06-21T06:23:25Z,"""Recent Comments"" widget in WP dashboard displays a list of Pending and recent comments. A ""Pending"" comment has all the action items - approve, reply, edit, trash, spam. But, these items are of no use, because the complete comment text is not visible. It will be good to display the full content of the ""Pending"" comments. OR Add a toggle to display the full content without having to go to ""Comments"" page. ",puneetsahalot 4-7 Days Ago,41108,Better documentation for the labels array of get_taxonomy_labels() function,truongwp,Taxonomy,3.0,normal,normal,4.9,enhancement,new,has-patch,2017-06-21T03:54:47Z,2017-06-22T02:51:43Z,Make documentation for the labels array of `get_taxonomy_labels()` function better and remove `@todo` tag.,truongwp 4-7 Days Ago,41105,Fire action hook after updating option group.,mdifelice,"Options, Meta APIs",trunk,normal,normal,Awaiting Review,enhancement,new,has-patch,2017-06-20T19:45:35Z,2017-06-20T19:50:52Z,"This suggestion affects the Settings API. There are hooks that fire after updating a single option, but not when a group of options is updated. Options updated via the Settings API are handled by /wp-admin/options.php, which after updating them does a redirection to the previous page, not firing any hook beside the shutdown action hook. In fact, the shutdown hook could be used for the same purpose but it would require some more extra checks. Basically the hook would allow to perform some action that is required after all options in that group are updated.",mdifelice 4-7 Days Ago,41097,Incorrect parsing of Forwarded header generates warnings,tomdxw,Administration,4.8,normal,normal,Awaiting Review,defect (bug),new,has-patch,2017-06-19T13:35:02Z,2017-06-19T13:36:20Z,"WordPress 4.8 adds a function `WP_Community_Events::get_unsafe_client_ip()` which attempts to get the user's IP address from a set of headers (the code: https://github.com/WordPress/WordPress/blob/92175dbd33b51c47089f4c50853987e688b6291b/wp-admin/includes/class-wp-community-events.php#L238-L278 ). It looks at the following headers: {{{ // In order of preference, with the best ones for this purpose first. $address_headers = array( 'HTTP_CLIENT_IP', 'HTTP_X_FORWARDED_FOR', 'HTTP_X_FORWARDED', 'HTTP_X_CLUSTER_CLIENT_IP', 'HTTP_FORWARDED_FOR', 'HTTP_FORWARDED', 'REMOTE_ADDR', ); }}} It treats them all as comma-delimited lists of IP addresses which is incorrect. This is because the `Forwarded` header as defined in RFC 7239 ( https://tools.ietf.org/html/rfc7239 ) looks like this: {{{ Examples: Forwarded: for=""_gazonk"" Forwarded: For=""[2001:db8:cafe::17]:4711"" Forwarded: for=;proto=http;by= Forwarded: for=, for= }}} Steps to reproduce the problem: 1. Install a browser extension that allows setting arbitrary headers (I'm using ModHeader: https://chrome.google.com/webstore/detail/modheader/idgpnmonknjnojddfkpgkljpfnnfcklj ) 2. Use the browser extension to set a realistic `Forwarded` header such as: `Forwarded: for=2001:db8::1, by=2001:db8::2` 3. Visit `/wp-admin/` The following warnings will appear in your logs: {{{ PHP Warning: inet_pton(): Unrecognized address for=2001:db8::1 in /var/www/html/wp-admin/includes/class-wp-community-events.php on line 268 PHP Warning: inet_pton(): Unrecognized address for=2001:db8::1 in /var/www/html/wp-admin/includes/class-wp-community-events.php on line 274 PHP Warning: A non-numeric value encountered in /var/www/html/wp-admin/includes/class-wp-community-events.php on line 274 PHP Warning: inet_ntop(): Invalid in_addr value in /var/www/html/wp-admin/includes/class-wp-community-events.php on line 274 }}}",tomdxw Last Week,41094,Deprecated version not specfied for debug_fopen() et al.,jdgrimes,General,3.4,normal,normal,4.9,defect (bug),new,has-patch,2017-06-18T22:14:20Z,2017-06-23T00:33:38Z,"The `debug_fopen()`, `debug_write()` and `debug_fclose()` functions were deprecated in 3.4.0 ([19935]). However, the calls to `_deprecated_function()` do not include the version number, instead listing the replacement function, `error_log()` as the second parameter. The second parameter is supposed to be the version number, the replacement function should be the third parameter.",jdgrimes Last Week,41063,color-picker.js documentation,jipmoors,Customize,3.5,normal,normal,4.9,defect (bug),new,has-patch,2017-06-15T12:14:18Z,2017-06-20T13:14:24Z,"This patch documents the color-picker.js file. It is part of an ongoing effort to document all core JavaScript files. Participated in creating this ticket: [https://profiles.wordpress.org/carolinegeven carolinegeven], [https://profiles.wordpress.org/jjcomack jjcomack] ",jipmoors Last Week,41059,Prevent `do_not_allow` from being added as a capability,peterwilsoncc,Role/Capability,,normal,normal,Awaiting Review,enhancement,reviewing,has-patch,2017-06-15T09:12:46Z,2017-06-15T13:12:16Z,"In meta capabilities, WordPress uses the keyword `do_not_allow` to indicate a user should be blocked from performing a particular action ([https://core.trac.wordpress.org/browser/tags/4.8/src/wp-includes/capabilities.php?marks=34-37#L34 code ref]). `WP_User`, `WP_Role` and `WP_Roles` do not prevent a theme or plugin from adding `do_not_allow` as a capability. Adding this capability would cause unexpected behaviour so it should be blocked as a hardening measure.",peterwilsoncc Last Week,41058,wp_dropdown_categories documentation is missing arguments,ArnaudBan,Taxonomy,,normal,normal,4.9,enhancement,reopened,has-patch,2017-06-15T09:08:51Z,2017-06-21T03:37:15Z,"`wp_dropdown_categories` use `get_terms` witch use `WP_Term_Query::__construct()`. The documentation should show that you can use all the `WP_Term_Query::__construct()` argument.",ArnaudBan Last Week,41056,WP-API JS Client: Settings is incorrectly registered as a collection,adamsilverstein,General,4.7,normal,normal,4.8.1,defect (bug),assigned,has-patch,2017-06-15T08:15:12Z,2017-06-17T16:06:50Z,"Similar to the `me` endpoint, `/wp/v2/settings` is a model, not a collection. This is incorrectly detected due to the JS code assuming anything not ending with a regex is a collection, which is not true. Potentially, we need to change the API to better expose what is and isn't a collection to the JS. The schema in the returned OPTIONS currently indicates that the response is an object, whereas it's actually a list of objects. If we change this, we need to look carefully at how we retrofit this, as changing it may break compatibility. We should discuss how best to expose collections vs models via the API. Changing the schema is the best way, I think. See [https://github.com/WP-API/proposals/issues/2 WP-API/proposals#2] for that discussion. In the meantime, we should special-case `/settings` as well.",adamsilverstein Last Week,41048,`WP_oEmbed_Controller::get_proxy_item()` should remove `_wpnonce` from cached `$args`,r-a-y,Media,4.8,normal,normal,Awaiting Review,defect (bug),new,has-patch,2017-06-14T19:09:13Z,2017-06-15T19:40:06Z,"When caching oEmbed proxy requests: https://github.com/WordPress/WordPress/blob/4.8-branch/wp-includes/class-wp-oembed-controller.php#L159 The following arguments are used to generate the cache key: {{{ Array ( [format] => json [maxwidth] => 600 [discover] => [url] => URL [_wpnonce] => 94f457a20b ) }}} `_wpnonce` is added because of `wp.media.view.settings.nonce.wpRestApi`. Since `_wpnonce` is variable, I think it would make sense to remove the `_wpnonce` key from the `$args` array so the cache is more likely to be hit. It also makes it easier for plugins to reference the oEmbed transient when overriding `wp_media_shortcode()` for use with the Video Widget.",r-a-y Last Week,41045,Add @since and @access tags to class WP_Query functions,dixitadusara,General,,normal,normal,Awaiting Review,defect (bug),new,has-patch,2017-06-14T12:31:40Z,2017-06-24T07:30:34Z,The @since and @access tags are missing for parse_search_order() protected function,dixitadusara Last Week,41024,File uploader looks misaligned in Mac Chrome,Ankit K Gupta,Plugins,4.8,normal,normal,Awaiting Review,defect (bug),new,has-patch,2017-06-13T11:51:06Z,2017-06-14T21:37:43Z,"Plugin/theme file uploader look misaligned in Mac Chrome. Refer attached screen shots. Browser default uploader text appearing on select file button and it makes text long. I am not expert in CSS but I noticed if change max-width of form. It looks fine in All Browsers. Better solution are welcome :)",Ankit K Gupta Last Week,41014,Add `permalink_structure` to REST API settings endpoint,aduth,REST API,trunk,normal,normal,Awaiting Review,enhancement,new,has-patch,2017-06-12T18:07:52Z,2017-06-21T20:32:12Z,"Related: #38490 It is not currently possible to view or edit the `permalink_structure` option from the REST API. This makes it difficult to reimplement a post editor leveraging the REST API because the ""slug"" field is only applicable for sites configured to include `%postname%` in this option's value. See: https://github.com/WordPress/WordPress/blob/9fb2e79/wp-admin/includes/post.php#L1323-L1324 This is relevant for the Gutenberg post editor reimplementation, where effort is blocked by unavailability of this setting from the REST API: https://github.com/WordPress/gutenberg/pull/1042 A workaround may be to include the option in a server-rendered initialized (localized) JavaScript object, but (a) this is not available to clients which may intend to recreate this experience totally separated from the WordPress PHP environment and (b) is inconsistent with the expectation that settings should be manageable from the REST API (given the presence of the settings endpoint). Caveats: - There is validation that is meant to occur in `sanitize_option` that tests whether the incoming `permalink_structure` includes a ""structure tag"". This feels like something that should be baked into the settings endpoint behavior (calling `sanitize_option`), and isn't entirely relevant to the changes proposed here. - Other `permalink` settings (`category_base`, `tag_base`) may be useful to include, but aren't part of the changes proposed here. I'm not sure the criteria with which settings are decided to be included on this endpoint. To me, it seems anything manageable through the Settings section of the admin dashboard should also be surfaced through these endpoints. https://github.com/WordPress/WordPress/blob/9fb2e79/wp-includes/formatting.php#L4030-L4294",aduth Last Week,41009,Add filter to comment form class,cjbj,Comments,4.7,normal,normal,Awaiting Review,enhancement,new,has-patch,2017-06-12T13:04:09Z,2017-06-14T07:48:19Z,"Almost all html of the comment_form function can be customized using filters, except for this line (current 2285 in comment-template.php), which is the wrapping div of the comment form: {{{
}}} I feel there are legitimate reasons for wanting at least the class to be filterable. For instance if you are using the clearfix class throughout your design to clear floats. So I would like to propose changing this line to this: {{{ $respond_class = 'comment-respond'; $respond_class = apply_filters ('comment_form_respond_class' ,$respond_class); echo '
'; }}} ",cjbj Last Week,41007,Custom_Image_Header::customize_set_last_used() blocking customizer save response from coming through,Collizo4sky,Customize,3.9,normal,normal,4.9,defect (bug),accepted,has-patch,2017-06-12T11:29:54Z,2017-06-19T19:08:39Z,"At my company, we are building a plugin that requires resetting the customizer to a blank slate. using the code in [https://make.xwp.co/2016/09/11/resetting-the-customizer-to-a-blank-slate/ this tutorial] by @westonruter When we try to save changes in customizer, we got the error below {{{ [12-Jun-2017 11:06:39 UTC] PHP Fatal error: Uncaught Error: Call to a member function post_value() on null in /home/vagrant/Code/WordPress/public/wp-admin/custom-header.php:1324 Stack trace: #0 /home/vagrant/Code/WordPress/public/wp-includes/class-wp-hook.php(298): Custom_Image_Header->customize_set_last_used(Object(WP_Customize_Manager)) #1 /home/vagrant/Code/WordPress/public/wp-includes/class-wp-hook.php(323): WP_Hook->apply_filters(NULL, Array) #2 /home/vagrant/Code/WordPress/public/wp-includes/plugin.php(453): WP_Hook->do_action(Array) #3 /home/vagrant/Code/WordPress/public/wp-includes/class-wp-customize-manager.php(2739): do_action('customize_save_...', Object(WP_Customize_Manager)) #4 /home/vagrant/Code/WordPress/public/wp-includes/theme.php(2870): WP_Customize_Manager->_publish_changeset_values(4106) #5 /home/vagrant/Code/WordPress/public/wp-includes/class-wp-hook.php(298): _wp_customize_publish_changeset('publish', 'new', Object(WP_Post)) #6 /home/vagrant/Code/WordPress/public/wp-includes/class-wp-hook.php(323): WP_Hook->apply_filters(NULL, Arr in /home/vagrant/Code/WordPress/public/wp-admin/custom-header.php on line 1324 }}} The submitted patch fixes this issue by making sure `$wp_customize->get_setting( 'header_image_data' )` return an instance of `WP_Customize_Setting` ",Collizo4sky Old Tickets,40997,Maintain expanded nav menu section once expanded section for placeholder is replaced with actual,greuben,Customize,trunk,normal,normal,4.9,defect (bug),new,has-patch,2017-06-10T17:47:07Z,2017-06-10T19:52:37Z,,greuben Old Tickets,40986,Widgets: text widget and media widgets cannot be edited in accessibility mode,designsimply,Widgets,4.8,normal,normal,4.8.1,defect (bug),new,has-patch,2017-06-09T20:44:02Z,2017-06-12T04:42:27Z,"Steps to reproduce: 1. Go to WP-Admin ->Appearance ->Widgets. 1. Add a text widget to any widget area and add some content. 1. Click on Screen Options at the top of the page and enable Accessibility Mode. 1. Attempt to edit the widget. **Result:** there were options to move the widget to different widget areas, but no option to edit the widget itself. The following error appears in the console: > TypeError: b is not a constructor > tinymce.min.js:13:11887 **Video:** [https://cloudup.com/cusOJjA2n6v 1m9s] [[Image(Screen Shot 2017-06-09 at Fri Jun 9 2.35.14 PM.png,100%)]] ^Seen at http://alittletestblog.com/wp-admin/widgets.php?editwidget=text-3&sidebar=sidebar-1&key=0 using Firefox 53.0.3 on Mac OS X 10.12.5 on a site running WordPress 4.9-alpha-40885.^ /hat tip @kokkieh for reporting the issue.",designsimply Old Tickets,40982,Permalink Settings: custom structure field keyboard trap,afercia,Administration,,normal,normal,4.8.1,defect (bug),reopened,has-patch,2017-06-09T17:57:00Z,2017-06-12T14:13:14Z,"In the Permalink Settings string, there's the same keyboard trap that as fixed in #40515 for the General settings date/time custom format fields: When using a keyboard and trying to set a custom permalink structure, the related radio button gets automatically selected and there's basically no way to select a radio button other than the custom format one. For more details, please see #40515",afercia Old Tickets,40981,"Customizer: Menus: it is far too easy to mistakenly delete a menu because the ""Delete Menu"" link and the ""Add Items"" button are too close together",designsimply,Customize,4.7.4,normal,major,4.8.1,defect (bug),new,has-patch,2017-06-09T16:33:34Z,2017-06-15T05:31:22Z,"This came up in WordPress.com support. /hat tip @Droyal for reporting the issue. Steps to reproduce: 1. Go to Customize > Menus. 1. Click on any menu to view details. 1. Click on the empty space below the ""Add Items"" button. **Result:** the menu is deleted without warning because the ""Delete Menu"" link spans the entire column which puts it in very close proximity to the ""Add Items"" button. **Video:** [https://cloudup.com/cfexpLMZBUe 46s] [[Image(Screen Shot 2017-06-09 at Fri Jun 9 10.26.06 AM.png,100%)]] ^Seen at http://alittletestblog.com/wp-admin/customize.php?return=%2Fwp-admin%2Fplugins.php&changeset_uuid=6b3d1591-9d2a-419d-a906-603da35edcf8 using Firefox 53.0.3 on Mac OS X 10.12.5 on a site hosted at WP Engine running WordPress 4.9-alpha-40885 via WordPress Beta Tester 1.1.2 and Jetpack 5.1-beta-12056-d2530de-master via Jetpack Beta Tester 2.0.3.^",designsimply Old Tickets,40977,Widgets: Query param for `loop` added for non-hosted external videos,westonruter,Widgets,4.8,normal,normal,4.8.1,defect (bug),reopened,has-patch,2017-06-09T13:57:16Z,2017-06-09T19:28:53Z,"When embedding an external video file into a video widget, the video shortcode is currently failing to render the video due to the erroneous injection of a `loop` query parameter. The `loop` parameter was specifically added to work around a Vimeo issue, but the logic was not properly restricted to only effect Vimeo URLs. For more background, see https://github.com/xwp/wordpress-develop/pull/232#issuecomment-306861073 Note that the need for the `loop` parameter will be eliminated once the upgrade to ME.js 4.x is done. See #39686.",westonruter Old Tickets,40975,'Empty Spam' and 'Empty Trash' comment buttons not displayed on mobile,SergeyBiryukov,Comments,4.8,normal,normal,4.8.1,defect (bug),new,has-patch,2017-06-09T12:57:04Z,2017-06-09T18:54:08Z,"Since [26134], top navigation for list tables is not displayed on mobile, which means that 'Empty Spam' and 'Empty Trash' buttons were only displayed in bottom navigation. Since [40297], these buttons are not displayed in bottom navigation either (on both mobile and desktop) if there's only one page of comments in Spam/Trash, because `$this->extra_items` is empty, `$this->items` [source:tags/4.8/src/wp-admin/includes/class-wp-comments-list-table.php?marks=458#L445 ends up empty too] in `::display()`, so `$this->has_items()` returns false. The lack of the button also causes the `%s items` string to overlap with the search bar, see the screenshot. If there are two or more pages of comments in Spam/Trash, the buttons are displayed as expected.",SergeyBiryukov Old Tickets,40974,Updated text widget do not save text,rinkuyadav999,Widgets,4.8,normal,normal,4.8.1,defect (bug),accepted,has-patch,2017-06-09T11:58:45Z,2017-06-12T06:23:52Z,"Hi I was testing updated text widget in 4.8. It saves text normally but when i switch visual to text 2-3 time and then when i past text in visual and switch to text and press save button. it does not save text. Screenshot: https://i.gyazo.com/1e760893e6f830a3747204e2772a2407.mp4",rinkuyadav999 Old Tickets,40951,New Text Widget - Switching Between Visual/Text Editor Strips Out Code,dwrippe,Widgets,4.8,normal,major,4.8.1,defect (bug),accepted,has-patch,2017-06-08T16:46:19Z,2017-06-24T15:49:18Z,"Just noticed the issue this morning, after upgrading to WP 4.8 on a few sites. The new Text widget (which defaults to the Visual Editor) is occasionally stripping out existing code that was placed in the widget prior to the existence of the visual editor. For example, if the following code is placed in the widget via the Text editor: {{{
  • List Item 1
  • List Item 2
}}} When the Widgets page is accessed after first updating, the Text widgets default to the Visual editor. This action, or switching between the two editors at any point, is stripping out the link code (presumably because there isn't any text associated with it). Considering the old functionality of the text widget, this may present wide-spread issues with people who have previously used Text Widgets to handle basic HTML code in a way that wasn't subject to the considerations of a Visual editor adjusting it (as it does in Pages/Posts).",dwrippe Old Tickets,40950,wp_terms_checklist() does not pass $post_id to current_user_can(),anigel,Administration,,normal,normal,Awaiting Review,defect (bug),new,has-patch,2017-06-08T15:00:37Z,2017-06-19T05:59:17Z,"An incorrect post_id gets passed in $args to a filter on map_meta_cap, when wp_terms_checklist() does a capability check to see if category checkboxes should get a disabled attribute. `$args['disabled'] = ! current_user_can( $tax->cap->assign_terms );` We had an issue where we were checking the post type in a map_meta_cap filter and it was always showing a standard post type instead of the appropriate custom post type leading to category checkboxes being disabled. Expected behaviour: The post_id passed in $args to the map_meta_cap callback should relate to the post being edited / created How to recreate: 1. Create a custom Post Type 2. Add a filter on map_meta_cap 3. Create or edit a post 4. Check the value passed in $args to your filter when wp_terms_checklist does a capability check to see if categories should get a disabled attribute. Workaround: Use the global $post variable instead of the passed post_id",anigel Old Tickets,40945,Parameter type correction in user.php,sebastian.pisula,Users,,normal,normal,4.8.1,enhancement,reviewing,has-patch,2017-06-08T06:46:38Z,2017-06-08T09:26:59Z,Patch change parametr type in wp-includes/user.php file. For example change `object` to `WP_User`,sebastian.pisula Old Tickets,40935,Facebook Video Works On Preview But Not On Theme,emanweb,Widgets,4.8,normal,normal,4.8.1,defect (bug),new,has-patch,2017-06-07T00:32:10Z,2017-06-13T21:55:52Z,"I am using a vanila Twenty Seventeen with 4.8RC2 and once I add a Facebook video using widget it shows up in the preview but not after adding it. See screenshots below: Enviromments tested: WP: 4.8-RC2-40875 Nginx: 1.10.1 PHP 7.1.4 MySQL 5.6.34 ---- WP: 4.8-RC2-40875 Nginx: 1.10.1 PHP 7.0.3 MySQL 5.6.34 ---- WP: 4.8-RC2-40875 Apache: 2.4.10 PHP 7.0.3 MySQL 5.6.34 Video Preview Works Fine [[Image(https://emanweb.com.br/manny/2017-06-06_17-14-20.png)]] Once Added Video URL It Shows This [[Image(https://emanweb.com.br/manny/2017-06-06_17-14-42.png)]] Then in the front end: [[Image(https://emanweb.com.br/manny/2017-06-06_17-15-11.png)]] p.s.: This is my first time reporting a bug, so please excuse me if I did it the wrong way.",emanweb Old Tickets,40933,Improvements for get_file_data() function,Tkama,Formatting,4.7.5,normal,normal,Awaiting Review,enhancement,new,has-patch,2017-06-06T20:28:37Z,2017-06-09T23:13:11Z,"It seams as a bug or as imperfection at least. I try to explain in example. Assume we have such comments in file: {{{#!php 'Version'] ); echo $data['ver']; //> 1.0 }}} This is works as we need. BUT if we change comments a little, the get_file_data() becomes broken: {{{#!php 'Version'] ); echo $data['ver']; //> '' }}} All we do just add spaces before `:` to make comments more readable... - Solution I think it's better to improve regular expression of the get_file_data() and add `[\t ]*` before `:` {{{#!php Floats are also cast to integers, which means that the fractional part will be truncated. E.g. the key 8.7 will actually be stored under 8. You can see this happening with the following snippet. The Test 2 menu item will show but Test 1 will not. {{{#!php fine-grained capabilities should be introduced for the `customize_changeset` post `caps`, instead of mapping all to `customize`. @westonruter has compiled links to previous discussions and efforts around changeset capabilities here: https://github.com/WP-API/wp-api-customize-endpoints/pull/5#discussion_r118804994. An example of unexpected behavior caused by the current mapping is where a post ID is passed to `current_user_can()`, such as {{{ current_user_can( get_post_type_object( 'customize_changeset' )->cap->edit_post, $changeset_post_id ) }}} This is equivalent to `current_user_can( 'customize' )`, which means the post ID is ignored because `map_meta_cap()` doesn't check the `$args` when mapping the `'customize'` meta cap.",dlh Old Tickets,40892,Documentation for `get_header` and `get_footer` actions are not accurate.,desrosj,Themes,,low,minor,Awaiting Review,enhancement,new,has-patch,2017-05-31T01:37:58Z,2017-05-31T01:39:16Z,"The `get_header` and `get_footer` action hook Docblocks both say ""The hook allows a specific footer/header template file to be used in place of the default footer template file."" This is not entirely accurate. While the hooks allow you to do something before the behavior of `get_header()` or `get_footer()`, it does not allow you to prevent the default output of these functions as the description suggests.",desrosj Old Tickets,40891,map_meta_cap() causing PHP notice on term meta permissions,caercam,Role/Capability,4.7,normal,normal,Awaiting Review,defect (bug),new,has-patch,2017-05-30T23:50:33Z,2017-06-20T09:15:48Z,"Mentioned in #40889: when checking for permission to add/edit/delete term meta, `map_meta_cap()` only performs a simple boolean test to make sure the term exists: https://core.trac.wordpress.org/browser/tags/4.7/src/wp-includes/capabilities.php#L277 If `get_term()` returns a `WP_Error` the test fails and `$term->taxonomy` causes an ""Undefined property"" notice. There should be an additional check using `is_wp_error()`, a simple `isset( $term->taxonomy )` or maybe a simpler `term_exists()` to make sure the term actually exists. ",caercam Old Tickets,40886,REST API: PUT requests fail on Nginx servers when fancy permalinks aren't enabled,Joen,REST API,4.4,normal,normal,Future Release,defect (bug),new,has-patch,2017-05-30T12:00:06Z,2017-06-21T19:15:44Z,"Steps to reproduce: 1. have a web server running nginx, or use wp docker or vvv fresh installs 2. have fancy permalinks disabled, use the stock `?p=123` ones 3. install the Gutenberg editor from https://github.com/WordPress/gutenberg as an activated plugin. Be sure to `npm install`, `npm run build` etc. 4. load the Gutenberg menu item in the sidebar 5. Press Save draft button, then press Update, and you'll see an error message in the console: `PUT http://localhost/?rest_route=/wp/v2/posts/6 405 (Not Allowed)` If you go to Settings > Permalinks, and choosing any fancy permalink option, saving works fine. From @pento: > So, it seems that `ngx_http_index_module`, the nginx module that redirects `/` to `/index.php` ignores all methods except `GET`, `HEAD`, and `POST`. > Editing the post sends a `PUT`, which is rejected. See also, trac discussion starting here: https://wordpress.slack.com/archives/C02RQC26G/p1496136902282711 ",Joen Old Tickets,40885,Update admin color scheme using the REST API,rmccue,Administration,,normal,normal,Awaiting Review,task (blessed),new,has-patch,2017-05-30T05:55:01Z,2017-05-31T13:05:44Z,"Reasonably simple admin-ajax call (notably, with no significant filters) that can be replaced with a call to `/wp/v2/users`. Patch attached. One thing we can't do is provide an enum of valid color schemes, since historically these have only been registered on `admin_init` (including in core). This also applies to the sanitization callback on the meta key, which can only remove invalid characters, not validate the scheme is valid.",rmccue Old Tickets,40875,Add a petabyte constant,henry.wright,General,,normal,normal,Awaiting Review,enhancement,new,has-patch,2017-05-27T14:32:25Z,2017-05-27T15:17:34Z,"I'm hoping I'll need to use this one day on my own site :) {{{define( 'PB_IN_BYTES', 1024 * TB_IN_BYTES );}}} On a serious note, this may now (on soon) be needed by some of the largest websites. It's used just once in core as far as I can tell, and that's in {{{size_format()}}}.",henry.wright Old Tickets,40873,Fatal Error from class-wp-ajax-upgrader-skin.php file,bappi.d.great,Upgrade/Install,,normal,critical,Awaiting Review,defect (bug),new,has-patch,2017-05-26T20:32:03Z,2017-06-19T18:38:49Z,"In the file /wp-admin/includes/class-wp-ajax-upgrader-skin.php line no 86: {{{ public function error( $errors ) { if ( is_string( $errors ) ) { $string = $errors; if ( ! empty( $this->upgrader->strings[ $string ] ) ) { $string = $this->upgrader->strings[ $string ]; } if ( false !== strpos( $string, '%' ) ) { $args = func_get_args(); $args = array_splice( $args, 1 ); if ( ! empty( $args ) ) { $string = vsprintf( $string, $args ); } } // Count existing errors to generate an unique error code. $errors_count = count( $errors->get_error_codes() ); $this->errors->add( 'unknown_upgrade_error_' . $errors_count + 1 , $string ); } elseif ( is_wp_error( $errors ) ) { foreach ( $errors->get_error_codes() as $error_code ) { $this->errors->add( $error_code, $errors->get_error_message( $error_code ), $errors->get_error_data( $error_code ) ); } } $args = func_get_args(); call_user_func_array( array( $this, 'parent::error' ), $args ); } }}} Here the line {{{ $errors_count = count( $errors->get_error_codes() ); }}} will run if it passes {{{ if ( is_string( $errors ) ) }}} condition. But if {{{ $errors }}} is string, then how can it be treated as object in {{{ $errors->get_error_codes() }}} ? Should not it be {{{ $this->errors->get_error_codes() }}} ?",bappi.d.great Old Tickets,40862,Partially visible controls within a pane do not scroll into view,desrosj,Customize,,low,normal,Future Release,enhancement,new,has-patch,2017-05-25T13:51:57Z,2017-06-05T21:02:23Z,"If the widget pane has many widgets, sometimes the widget dialogue will not be visible when the edit shortcut icon is clicked on the page. If any part of the control is visible, it does not fully scroll into view even though the focus is properly set. A few notes: - If the widget is not in view at all wihtin the pane, it properly scrolls it into view and focuses. - The problem also occurs if the pane is not currently visible when the edit shortcut is clicked. Clicked edit shortcut on a widget in view in the sidebar: [[Image(https://cloudup.com/cVy1-KAReQv+)]] Clicked edit shortcut on a widget with part of the header visible in the pane:[[Image(https://cloudup.com/iQyTvRrX_rX+)]]",desrosj Old Tickets,40860,"Post that is ""Pending Review"" and Scheduled shows incorrect ""Last Modified"" date in Post Listing",yearginsm,"Posts, Post Types",4.7.5,low,normal,Future Release,defect (bug),new,has-patch,2017-05-25T03:21:23Z,2017-05-30T08:55:35Z,"Reproduction steps: 1. Create a new post 2. Schedule the post for a date in the future 3. Set the status to ""Pending Review"" 4. Save the post 5. Return to Posts listing 6. Observe that the ""Date"" column has an incorrect ""Last Modified"" flag",yearginsm Old Tickets,40856,PHPUnit tests on Windows,danielhuesken,Build/Test Tools,4.8,normal,normal,Awaiting Review,enhancement,new,has-patch,2017-05-24T20:34:36Z,2017-05-25T06:49:07Z,We can get more PHP unit tests work under windows system if files wil not created in /temp and symlinks will not be used.,danielhuesken Old Tickets,40850,WP_Query->have_posts() -- add action if no results are found,mgibbs189,Query,,normal,normal,4.9,enhancement,new,has-patch,2017-05-23T17:20:29Z,2017-06-21T19:33:18Z,"We can hook into `loop_start` and `loop_end` when results are found, but there's no `loop_no_results` hook. This patch adds that!",mgibbs189 Old Tickets,40840,Missing @deprecated tag for WP_Admin_Bar::recursive_render(),coffee2code,General,,normal,trivial,Awaiting Review,defect (bug),new,has-patch,2017-05-22T20:38:27Z,2017-05-22T22:41:16Z,"`WP_Admin_Bar::recursive_render()` in `wp-includes/class-wp-admin-bar.php` was deprecated in v3.3 via [19501] but a `@deprecated` phpdoc tag was not added. Attached is a patch that adds it. ",coffee2code Old Tickets,40833,"Allow addition of aria-current=""page"" to current page element in paginate_links()",GrahamArmfield,Themes,,normal,normal,4.8.1,enhancement,assigned,has-patch,2017-05-22T08:50:13Z,2017-06-09T16:53:58Z,"Ticket #40359 aims to allow attributes to be added to links in navigation menus - including `aria-current=""page""`. This ticket concerns the output created by `paginate_links()`. It would be useful to add the `aria-current=""page""` attribute to the element representing the current page in the pagination list. The `aria-current` attribute is a new ARIA attribute being introduced in ARIA 1.1 and its aim is to help assistive technology users (often screen readers) orientate themselves within a list of items. There are many possible values for this attribute, but the most appropriate here would be 'page'. Further information on aria-current can be found at: https://www.w3.org/TR/wai-aria-1.1/#aria-current == Examples == Example output from current paginate_links: {{{ }}} Example enhanced with `aria-current` attribute: {{{ }}}",GrahamArmfield Old Tickets,40830,Widgets: add a warning that changes are published instantly on the admin screen,celloexpressions,Widgets,3.9,normal,normal,Future Release,enhancement,new,has-patch,2017-05-20T18:43:49Z,2017-05-31T20:54:22Z,"Every change made on the widgets admin screen is published instantly, making it live on the user's site. This includes adding a widget without configuring any settings and other things that probably shouldn't go live before they're ready. For this reason, we added a ""manage with live preview"" link to this screen previously. To further emphasize the usability problems with this screen and the availability of an alternative, particularly for new users that may find themselves here, we should add a warning to the widgets admin screen that clearly states that changes are published immediately and deep-links to the live preview version. This could also reduce confusion here and elsewhere, as this may be the only place in wp-admin where changes are saved without clicking any sort of publish/submit button.",celloexpressions Old Tickets,40829,Improve wp_dropdown_languages() so it doesn't print out empty attributes,afercia,I18N,,normal,normal,4.9,enhancement,new,has-patch,2017-05-20T17:32:08Z,2017-06-21T15:34:30Z,"`wp_dropdown_languages()` takes an array of arguments with some defaults. Among them, the arguments related to the `name` and `id` HTML attributes [https://core.trac.wordpress.org/browser/trunk/src/wp-includes/l10n.php?rev=40362#L1119 default to empty string]. Later on, these attributes are printed out without any check if they're empty or not: `$output = sprintf( '`, which doesn't look right to me. ",afercia Old Tickets,40826,"Allow items queried in batch via ""slug"" to maintain order",wonderboymusic,REST API,4.7.4,normal,normal,4.8.1,defect (bug),new,has-patch,2017-05-20T06:07:50Z,2017-05-22T22:41:11Z,"When querying endpoints that have items, it is possible to pass an array of values to the `slug` param. This will filter the result set to only include slugs that match. This works for posts, pages, media, users, categories, and tags. Often, the reason this is happening is so that a remote system can collect all relevant queries before sending one HTTP request that contains them all. This was formalized in #40027. One caveat: the endpoints do not currently have a proper `orderby` value that ensures the items are returned in the same order they requested. The best convention I could come up with is: `orderby=slugs`. Patch incoming. This is essential for tools like Dataloader https://github.com/facebook/dataloader#batching ",wonderboymusic Old Tickets,40820,Child theme should appear as broken if parent is itself,davilera,Themes,4.7.5,normal,minor,4.9,defect (bug),reviewing,has-patch,2017-05-19T13:58:49Z,2017-06-18T10:56:25Z,"Child themes are defined as such if they include the `Template` header in `style.css`. In general, if the parent template can't be found, WordPress reports the theme as ''Broken'' and tells the user to install the missing parent theme. However, if the `Template` header is the theme itself, no errors are reported (WordPress can find the ""parent"" theme, because it's itself). The resulting behavior is weird and unexpected: * If there are other themes available, WordPress uses one as the parent theme (I don't know which criteria is used for selecting one or the other). * If there aren't, the front-end is completely blank (but this might depend on the amount of code included in the child theme). Such an (invalid) child theme should be reported as ''Broken''. For instance, the following message could be shown: ''The theme defines itself as its parent theme. Please fix the ""Template"" header.''",davilera Old Tickets,40814,Order of page title parts,henry.wright,Login and Registration,,normal,normal,4.9,enhancement,reviewing,has-patch,2017-05-19T00:39:19Z,2017-06-22T06:15:33Z,"The order of page title parts in wp-login.php is inconsistent with the rest of the site pages. For example, in wp-login.php we have this arrangement: Sitename Separator Pagename For the rest of the site we have this arrangement: Pagename Separator Sitename I suggest we modify the order of the page title parts in wp-login.php to match page titles elsewhere.",henry.wright Old Tickets,40812,Allow wp-login.php page title separator to be filtered,henry.wright,Login and Registration,,normal,normal,4.9,enhancement,new,has-patch,2017-05-19T00:32:30Z,2017-06-23T03:32:03Z,The wp-login.php page title separator is currently hard coded as either {{{›}}} or {{{‹}}} depending on {{{is_rtl()}}}.,henry.wright Old Tickets,40792,Adding Someecards.com as an oEmbed provider,someecards,Embeds,,normal,normal,4.9,enhancement,new,has-patch,2017-05-17T20:50:59Z,2017-06-06T20:10:41Z,"This ticket is a request to have someecards.com added to the list of oEmbed providers. '''Is the service is popular enough for core developers to have heard of it before? Is it “mainstream?” ''' We hope so. Someecards has been around for a while and is pretty popular. '''If similar services are already supported, how does this service compare in terms of size, features, and backing?''' Various image embed exists like imgur that are similar in some ways. Someecards is pretty popular. See social stats below. '''Does this service have a large following on Twitter, Facebook, or other social media? Is its Twitter account verified?''' https://www.facebook.com/someecards/ (5.8M) https://twitter.com/someecards (verified, 2.35M) '''Is its oEmbed endpoint clearly established and properly documented? (Sometimes, they are just a developer’s pet project that may not be supported.)''' https://github.com/someecards/someecards-developer-docs/blob/master/oembed.md '''Does the oEmbed endpoint work with WordPress’ oEmbed auto-discovery? If not, could it be made to work with additional HTML tags or attributes being whitelisted?''' It works. '''Does the service make an effort to build relationships with developers, such as through robust APIs?''' We're not making tons of open APIs currently. '''How old is the service?''' Someecards.com was started in 2006. '''Does it have a well-established Wikipedia article? (Seriously.)''' https://en.wikipedia.org/wiki/Someecards '''Has anyone written a WordPress plugin that leverages the service in some way, whether adding it as an oEmbed provider, creating a shortcode, or leveraging other APIs of the service? Do these plugins have any noticeable adoption or traction that would indicate usage and demand?''' Not that we know of but we're convinced this oembed support would be useful. '''Is the provider frequently proposed?''' Oembed rich media support was added a couple months ago so this is likely the first request. ",someecards Old Tickets,40775,Remove number in placeholder in translation string,rabmalin,Widgets,4.8,low,normal,Future Release,defect (bug),new,has-patch,2017-05-16T04:17:14Z,2017-06-01T18:50:15Z,"`/src/wp-includes/widgets/class-wp-widget-media-video.php` line 45 {{{ 'unsupported_file_type' => sprintf( __( 'Sorry, we can’t display the video file type selected. Please select a supported video file (%1$s) or stream (YouTube or Vimeo) instead.' ), '.' . implode( ', .', wp_get_video_extensions() ) . '' ), }}}",rabmalin Old Tickets,40768,site.com/login should not redirect to login page when user is already logged in,subrataemfluence,Login and Registration,4.7.4,normal,normal,Awaiting Review,defect (bug),new,has-patch,2017-05-15T13:53:08Z,2017-05-15T14:03:28Z,"When I am already logged in I should not be redirected to Login page if I type in `mysite.com/login`. Rather WordPress should be able to decide which page I should be on in this situation. Being redirected to Login page even when I am already logged in must be treated as a bug. The reason is I am being able to login as a different user by going to login page directly when I am already logged in! For example if I am already logged in as admin and type in `mysite.com/login` I should directly be taken to `wp-admin`. Same decision could be taken for different user privileges like if I am logged in as a subscriber or as a participant then I might land on site's home page. Inspired from [#40762] I have modified the decider so that WordPress can take this decision itself and stop landing logged in users to login page.",subrataemfluence Old Tickets,40764,Multisite theme update not showing new version number,afragen,Upgrade/Install,4.6,normal,normal,Future Release,defect (bug),reviewing,has-patch,2017-05-15T05:56:55Z,2017-06-01T18:42:24Z,"When updating plugins via the ajax updater the new version number displays correctly in the plugin row when the update is completed. In multisite, when a theme is updated via the ajax updater the new version number is not displayed in the theme row.",afragen Old Tickets,40763,Use placeholders in translation strings,ramiy,I18N,,normal,normal,Future Release,enhancement,new,has-patch,2017-05-14T20:58:03Z,2017-05-14T21:05:27Z,"The attached patch replaces URLs and HTML tags in translation strings with `%s` placeholders to make it easier to translate the string. ",ramiy Old Tickets,40762,Login: add canonical admin shorthand URL for login.php,lancewillett,Login and Registration,4.8,normal,minor,Awaiting Review,enhancement,new,has-patch,2017-05-14T20:22:11Z,2017-05-15T14:00:50Z,"Users could type `login.php` by accident when trying to access their admin dashboard because `wp-login.php` is a known URL and shorthand, and either they don't remember or get it wrong. Let's make that more friendly. Right now WordPress treats it as a 404, and tries to redirect it to a valid permalink if it's available. It'd be more user-friendly to automatically send to login page, or admin if logged in.",lancewillett Old Tickets,40761,Make Walker_Category::start_lvl more flexible by introducing filters for class name(s) at least,pbiron,Taxonomy,,normal,normal,Awaiting Review,enhancement,new,has-patch,2017-05-14T13:24:12Z,2017-05-15T16:31:15Z," Related: #36163, #40359, #40666, #40760 We should harmonize the filters available in the 3 main `Walker` classes.",pbiron Old Tickets,40760,Make Walker_Page::start_lvl more flexible by introducing filters for class name(s) at least,pbiron,Menus,,normal,normal,Awaiting Review,enhancement,new,has-patch,2017-05-14T13:22:04Z,2017-05-15T16:59:37Z,"Related: #36163, #40359, #40666 We should harmonize the filters available in the 3 main `Walker` classes. ",pbiron Old Tickets,40751,Login form - Consider making Back to {site name} & Lost your password inline.,pratik028,General,4.7.4,normal,normal,Awaiting Review,enhancement,new,has-patch,2017-05-13T06:11:34Z,2017-05-15T14:44:39Z,"Will it not look good, if we make the login and Back to site button below the login-form inline? Or atleast we can remove padding-left from login and back to site button, so it will be aligned with the login form. {{{ .login #nav, .login #backtoblog { font-size: 13px; padding: 0 24px 0; } }}} [[Image(https://goo.gl/KZ7elv)]] ",pratik028 Old Tickets,40747,Semantic elements for non-link links: theme-install.php,Cheffheid,Administration,,normal,normal,Future Release,enhancement,new,has-patch,2017-05-12T16:54:28Z,2017-05-15T16:39:48Z,"The filters on the theme install page (Featured, Popular, Latest, Favorites) are currently marked up with anchor tags, but they should be marked up with buttons. A downside to doing so is that the focus styles persist when the buttons are clicked, which may not look great. Attached first pass patch removes the outline on focus for browsers that add one by default (Chrome, IE11, Edge, possibly Safari) to minimize the effect, but would definitely appreciate some help in coming up with a good solution for it instead.",Cheffheid Old Tickets,40737,Script tags inside unclosed HTML comment in value passed to WP_Script->localize() breaks page,rmarscher,Script Loader,,normal,normal,Awaiting Review,defect (bug),new,has-patch,2017-05-11T19:26:30Z,2017-06-01T18:45:45Z,"Hi. Thanks for your time. I encountered an edge case with the WP_Script->localize() method that can cause malformed html and cause javascript on the page to break. Our site has a custom field for adding pixel tracking code html snippets. On the post edit admin page, the values from the custom fields are run through the localize method by the Wordpress-SEO plugin which adds their values to the wpseoReplaceVarsL10n var. One of our users pasted code into this field like the following: {{{ }}} This gets serialized to JSON by WP_Script->localize and ends up being output like this. I simplified the structure a bit for the example. {{{ }}} Rendering: {{{


Unscaped: Wo&r'l""d

Escaped: W<i>o</i>&r'l""d

}}} While checking the interpolation of the variable, '&' was always converted to '& amp;'. Is this a specification or a bug? ",tmatsuur Old Tickets,40894,Use Webpack instead of Browserify for build process,adamsilverstein,Build/Test Tools,3.5,normal,normal,Future Release,enhancement,new,,2017-05-31T12:16:26Z,2017-06-06T13:03:32Z,"#40834 kicked off a discussion of JavaScript modules in WordPress core. In a recent [https://make.wordpress.org/core/2017/05/24/javascript-chat-summary-for-may-23rd/ JavaScript Core chat ] the decision was made to move in the direction of using Webpack (and ES6 imports) as our bundler of choice, and to work first on switching out browserfy in our current build chain. Since we split the media files in #28510, the core build process [https://core.trac.wordpress.org/browser/tags/4.7.5/Gruntfile.js#L160 has used Browserify] to combine the media files. While browserify has served us well, Webpack is probably a better long term choice for the project, especially with the introduction of a new JavaScript framework that may require a build. ",adamsilverstein Old Tickets,40883,update getid3 to 1.9.14,jkitchen,Media,4.8,normal,normal,Awaiting Review,enhancement,new,,2017-05-29T23:00:58Z,2017-05-29T23:37:08Z,"Greetings! I'd like to make some changes to extract geolocation information from MOV files created by and uploaded from iPhones, and there's an update to the getid3 library to do just that. https://github.com/JamesHeinrich/getID3/compare/v1.9.9...v1.9.14 The update I'm after was shipped in v1.9.11: https://github.com/JamesHeinrich/getID3/commit/a1e96a82d95dffb9ab63009464e8326614dc2373 https://github.com/JamesHeinrich/getID3/compare/v1.9.9...v1.9.11 However, may as well upgrade all the way to 1.9.14? Let me know if there's anything I can do to help make this happen!",jkitchen Old Tickets,40882,Characters omitted when copying and pasting from Word,janthony636,Editor,4.7.5,normal,normal,Awaiting Review,defect (bug),new,,2017-05-29T19:48:44Z,2017-05-29T21:30:50Z,"I have been preparing WordPress pages by arranging the information in Microsoft Word 2016, and then copying it from Word and pasting it into WordPress. My pages almost all include citations that I've copied from Google Scholar and pasted into Word. I noticed recently that in the citations, the following characters would be missing: - the (nonbreaking) space that follows the italicized publication name - the volume number that follows after that - the period that follows after that When I first noticed this, I went back through 70+ pages and it looked like these characters had been omitted every time. Note that when this happened again on another page yesterday, I decided to report a bug. I had already deleted the Word source file, so I tried to reproduce the behavior with a small new Word file. I found that I was never able to reproduce this behavior. Today I saw this behavior again on yet another new page. This time I've saved the Word source file, and I've confirmed that this happened again when I copied and pasted again. Please fix this if at all possible. Copying and pasting is such a reliable operation normally in every modern application that it's fairly easy to not realize that in WordPress this operation introduces errors that need to be fixed. Thanks!",janthony636 Old Tickets,40878,Adding menus route,dingo_bastard,REST API,4.7,normal,normal,Awaiting Review,feature request,new,,2017-05-28T11:43:58Z,2017-05-29T06:53:13Z,"Currently there is no `${appUrl}/wp-json/wp/v2/menus` route inside REST API for WordPress. I know I can create a custom endpoint and define a route for it, or use a plugin, but wouldn't it be better to have it in the core? I couldn't find a ticket for this, and inspecting the routes via postman showed no `menus` which means that it doesn't exists yet. Is there any plan to add it to core?",dingo_bastard Old Tickets,40870,Using underscore in meta box id field metabox is not working correctly,stode,General,4.7.5,normal,normal,Awaiting Review,defect (bug),new,,2017-05-26T11:52:17Z,2017-05-26T17:49:18Z,"To reproduce this issue: 1. Create a meta box with an id that has underscores(id_with_underscores). 2. Try to put the box after the title. Nothing happens. Replace the underscores with dashes and everything works as expected. {{{#!php


<# if ( data.attachment && window.imageEdit ) { #>
"" /> "" />
<# else if ( data.attachment && window.imageEdit ) { #>
"" />
<# } #>
}}} **Todo. While adding a new image to the editor we get a small JavaScript error. ",MacPresss Old Tickets,40864,Standardize strings for missing attachments across media widgets,dimadin,Widgets,4.8,normal,normal,Awaiting Review,enhancement,new,,2017-05-25T18:06:09Z,2017-05-25T18:46:48Z,"While translating 4.8 strings, I noticed that strings for missing attachments in the new media widgets do not refer to the same thing: > We can’t find that audio file. Check your media library and make sure it wasn’t deleted. > We can’t find that image. Check your media library and make sure it wasn’t deleted. > We can’t find that video. Check your media library and make sure it wasn’t deleted. > We can’t find that file. Check your media library and make sure it wasn’t deleted. In two occasions we only use media type, but once we use ""file"" alongside of it and once we only use ""file"" and remove any mention of media (type). I propose removing ""file"" completely and just using type of media. Second possibility is to always use ""file"", though I don't see that as needed.",dimadin Old Tickets,40863,WP 4.7.5 XMLRPC new method for parsing arguments omits menu_order,bjminihan,XML-RPC,4.7.5,normal,normal,Awaiting Review,defect (bug),reopened,,2017-05-25T15:35:22Z,2017-06-05T12:22:52Z,"In WP 4.7.5, in wp-includes/class-wp-xmlrpc-server.php, on line 1327, this line: {{{ $post_data = wp_parse_args( $content_struct, $defaults ); }}} was changed to: {{{ $post_data = wp_parse_args( array_intersect_key( $content_struct, $defaults ), $defaults ); }}} Unfortunately, the new intersection strips out any arguments from $content_struct that don't exist in $defaults. So you can no longer edit a post and change the ""menu_order"" field, because it doesn't exist in the $defaults declared just before this line. Please provide either an updated list of acceptable defaults (e.g. including menu fields), or allow for additional fields to pass through to wp_parse_args. Tested with latest version of WP, and confirmed that swapping the changed line above enables/disables the ability to change menu_order in posts. ",bjminihan Old Tickets,40861,Rest Api create media,redcastor,REST API,4.7.5,normal,normal,Awaiting Review,defect (bug),new,,2017-05-25T12:08:11Z,2017-05-25T12:08:11Z,"On windows, create media with rest api insert the meta ""_wp_attached_file"" not correctly. It save the absolute path and not the relative path. the function ""wp_slash"" add backslash in windows file path. file: class-rest-attachements-controller.php line: 150 {{{#!php array( 'contact' => array( 'template' => 'page-templates/list-of-child-pages.php', ), 'contact-dublin' => array( 'post_type' => 'page', 'post_title' => 'Dublin Office Contact', 'post_content' => 'Page content here...', 'parent' => '{{contact}}', // <-- Here's the magic: // Making this a child page of our ""Contact"" page. ), ), ); }}} Thanks for consideration!",webmandesign Old Tickets,40806,Subtitles show no media files in browser when there are some,karmatosed,Media,,normal,normal,Awaiting Review,defect (bug),new,,2017-05-18T17:42:45Z,2017-05-19T10:51:06Z,"This may be a case of it looking for a very particular file, the trouble is that isn't clear if the case. I discovered this whilst testing the video widget, but assume its media library. I see the following: [[Image(https://cldup.com/jLgqBIQbvi.png, 60%)]] Somewhat of a surprise when my media library shows... [[Image(https://cldup.com/pCAJry0o1a.png, 60%)]]",karmatosed Old Tickets,40804,Display important informations in plugins list,xsweb,Plugins,4.7.5,normal,normal,Awaiting Review,enhancement,new,,2017-05-18T17:27:03Z,2017-05-18T17:37:33Z,Showing last plugin update date in plugins list and compatibility with current wordpress version may quickly give a look if any plugins are no more up to date by his creator.,xsweb Old Tickets,40802,Allow filtering of the hard coded pipe character in wp-login.php,henry.wright,Login and Registration,,normal,normal,Awaiting Review,enhancement,new,,2017-05-18T14:01:49Z,2017-06-21T17:11:46Z,"{{{

""> | "">

}}} The pipe character is hard coded in wp-login.php as can be seen from the snippet above. It would be nice to have the ability to remove or modify the character.",henry.wright Old Tickets,40796,Overriding WordPress globals is prohibited,maneshtimilsina,Bundled Theme,4.7.5,normal,normal,Awaiting Review,defect (bug),new,,2017-05-18T06:04:14Z,2017-05-18T07:47:03Z,"In Twenty Seventeen theme, global variable $post is overridden at line 145 of /inc/template-tags.php As per theme review guidelines Overriding WordPress globals is prohibited. ",maneshtimilsina Old Tickets,40795,"If plugin zip file has very long name, windows systems can fail to upgrade",rogerlos,Plugins,4.7.5,normal,normal,Awaiting Review,defect (bug),new,,2017-05-17T23:17:52Z,2017-05-17T23:20:44Z,"If a plugin upgrade zip file has an extremely long name and the plugin a deep directory structure, windows can fail to create directories and therefore the plugin upgrade will fail. I suggest WordPress have an upper limit on the working directory name that is well-shy of that limit--and realistically, even 32 characters might be plenty, as the upgrader only needs to avoid other plugins being upgraded at the same time. Windows has a 247-character limit to the total ''path'' name for directories, as said directory needs to be able to hold, at a minimum, an ""8+3"" file, and allow for a null byte or similar at the end of path + file (260 total characters). As an example, SearchWP fails to upgrade on my local system (WAMP running on top of Windows 10) because the downloaded zip filename is 142 characters long ''sans'' extension (redacted in case this is a license key): {{{ XXX0XXX0XxxxXXxxXXX0XxXxXxX0XXXxXxXxXXXxXxXxXXX0XXx 0X0XxXXx0XxX0XXxxXXX0XXx0X0XxXXX0Xxx0XxX0XXXxXXX0XX XxXxx0xXXXXx0xXXXxxxxxXxxxX0XxXxX-0xxXXx.zip }}} Combine that with my wordpress location on disk: {{{ C:/wamp/www/example/wp-content/upgrade/ }}} And this directory cannot be created because the total path is 254 characters long (including the hidden null): {{{ C:/wamp/www/example/wp-content/upgrade/XXX0XXX0Xxxx XXxxXXX0XxXxXxX0XXXxXxXxXXXxXxXxXXX0XXx0X0XxXXx0XxX 0XXxxXXX0XXx0X0XxXXX0Xxx0XxX0XXXxXXX0XXXxXxx0xXXXXx 0xXXXxxxxxXxxxX0XxXxX-0xxXXx/searchwp/vendor/ pdfparser/vendor/smalot/pdfparser/src/Smalot/PdfParser }}} I think that while this may be an outlier, it's a hard bug to chase for a vendor who may not have windows systems available...and even they do have such an environment available, the results returned by Apache when running WAMP (or in similar environments) does not reflect the actual cause of the error. Looking at the structure above as pretty much as edge-case as you are likely to get, even a truncate at 64 characters would have been more than adequate, while 32 characters would give quite a bit of room for flexibility. I believe that this could be affected by altering `wp_tempnam()` in `file.php`: {{{ /** * Returns a filename of a Temporary unique file. * Please note that the calling function must unlink() this itself. * * The filename is based off the passed parameter or defaults to the current unix timestamp, * while the directory can either be passed as well, or by leaving it blank, default to a writable temporary directory. * * @since 2.6.0 * * @param string $filename Optional. Filename to base the Unique file off. Default empty. * @param string $dir Optional. Directory to store the file in. Default empty. * @return string a writable filename * * @since x.x.x * @param int|string $maxlen Optional. Maximum length (excluding extension) of returned filename */ function wp_tempnam( $filename = '', $dir = '', $maxlen = 32 ) { if ( empty( $dir ) ) { $dir = get_temp_dir(); } if ( empty( $filename ) || '.' == $filename || '/' == $filename || '\\' == $filename ) { $filename = time(); } // Use the basename of the given file without the extension as the name for the temporary directory $temp_filename = basename( $filename ); $temp_filename = preg_replace( '|\.[^.]*$|', '', $temp_filename ); // new: truncate the filename if longer than specified $max = intval( $maxlen ) > 0 ? intval( $maxlen ) - 6 : 32; $temp_filename = strlen( $temp_filename ) > $max ? substr( $temp_filename, 0, $max ) : $temp_filename; // ... remainder omitted for clarity return $temp_filename; } }}} An alternative would be to require plugin upgrade files to have filenames shorter than [insert recommendation here], though actually checking that would mean a similar chunk of code would need to be added elsewhere in WP. (Not sure exactly where the best place to document this for plugin authors, which could be done immediately.)",rogerlos Old Tickets,40794,WordPress needs a privacy policy,johnbillion,Help/About,,normal,normal,4.8.1,enhancement,new,,2017-05-17T22:44:18Z,2017-05-26T19:49:13Z,"It's been many years since an installation of WordPress operated in isolation. The software sends data to various endpoints on `api.wordpress.org`, most visibly for update checks, but also for fetching translations, checking browser compatibility, and (since 4.8) determining the user's location and fetching nearby WordPress events. WordPress needs a privacy policy which covers data that gets sent to wordpress.org. The wordpress.org website [https://wordpress.org/about/privacy/ has a privacy policy], and it may be sufficient to link to this, or it may be required to extend this with information specifically regarding the data that installations of WordPress send to api.wordpress.org. I recommend the addition of a new `Privacy` tab on the `About WordPress` screen. It's worth noting that the pending [https://ico.org.uk/for-organisations/data-protection-reform/overview-of-the-gdpr/ EU GDPR] affects everyone because it covers the export of data outside of the EU. Adding to the 4.8 milestone as the `WordPress Events and News` dashboard widget is a particularly visible example of data collection in WordPress. Related: Long-running discussion on #16778.",johnbillion Old Tickets,40793,Events widget on back button loses location,karmatosed,Widgets,,normal,normal,Awaiting Review,defect (bug),new,,2017-05-17T21:21:01Z,2017-05-17T21:22:38Z,"I noticed that if you save a location, visit a meetup, then click back button in browser, you will lose your location. It returns on refreshing your browser. Here is video: [[Image(https://cldup.com/pyYG5Z4gtz.gif, 50%)]] ",karmatosed Old Tickets,40791,paginate_links outputs unnecessary dots,rphelan,General,4.7.5,normal,normal,Awaiting Review,enhancement,new,,2017-05-17T19:46:55Z,2017-05-22T16:47:16Z,"== Steps to reproduce: == A) Call paginate_links with current=2, total=6 B) Call paginate_links with current=5, total=6 (assume defaults for everything else: mid_size=2, end_size=1, show_all=false) == Actual results: == A) `[1] ... [3] [4] [5] [6]` B) `[1] [2] [3] [4] ... [6]` The output includes dots that are unnecessary because they are taking up space that an actual page link could occupy. == Expected results: == A) `[1] [2] [3] [4] [5] [6]` B) `[1] [2] [3] [4] [5] [6]` When `total <= mid_size + end_size * 2 + 2`, no dots should be included in the pagination output.",rphelan Old Tickets,40790,Ability to filter $post_type in _get_last_post_time,toddlevy,General,4.7.5,normal,normal,Awaiting Review,enhancement,new,,2017-05-17T15:30:09Z,2017-05-17T15:30:09Z,"This function starts on line 5610 of https://github.com/WordPress/WordPress/blob/4.7.5/wp-includes/post.php Currently, there is no way to filter the `$post_type` argument of the `_get_last_post_time` function. This creates situations where it's impossible to filter/modify the default post type when `_get_last_post_time` is called without the `$post_type` argument. Suggested enhancement is to add a `_get_last_post_time_post_type` filter inside the `_get_last_post_time` function, right after the `$field` is validated or the timezone gets lowercased. Something like this... {{{#!php $post_type = apply_filters( '_get_last_post_time_post_type', $post_type ); }}} Thank you for considering this enhancement. ",toddlevy Old Tickets,40789,pre_get_lastpostdate filter,toddlevy,General,4.7.5,normal,normal,Awaiting Review,enhancement,new,,2017-05-17T15:03:25Z,2017-05-17T15:03:25Z,"This is line 5530 of https://github.com/WordPress/WordPress/blob/4.7.5/wp-includes/post.php Currently, there is no way to filter `get_lastpostdate` in advance of it calling `_get_last_post_time`. This creates situations where it's impossible to filter/modify the default post type because... a) `get_lastpostdate` is called without the `$post_type` argument (e.g. as happens in `get_lastpostmodified` and sometimes in 3rd party plugins), and b) The `_get_last_post_time` function that gets called doesn't allow `$post_type` to be filtered as best I can tell If you take a look at `get_lastpostmodified` you can see the `pre_get_lastpostmodified` filter, which is great and would solve this problem. Suggested enhancement is to add a similar `pre_get_lastpostdate` filter for `get_lastpostdate` with the same naming convention and functionality. Something like this... {{{#!php "" name="""" rows=""7"" cols=""80"" style=""width:100%"" maxlength="""" placeholder="""" required> }}} But whenever I go to edit the post, inside all textarea metaboxes values are pre-loaded with leading spaces (exactly 10 spaces) and additional line breaks! Also tried `esc_atr(trim(br2nl($meta_value)))` with no avail.",subrataemfluence Old Tickets,40785,Image caption in WYSIWYG is not displaying in post page,subrataemfluence,Media,4.7.5,normal,normal,Awaiting Review,defect (bug),new,,2017-05-17T13:53:07Z,2017-05-19T11:15:53Z,"I have uploaded an image to my post via Media upload utility of WYSIWYG editor and added a caption to it. When I go the post page, the image is there but the caption is not showing up anywhere, which ideally should be underneath the image. In wp_posts table the content was saved as: {{{
Nestled among ski slopes in the Garhwal Himalayas, this secluded hotel is 23 km from Panch Prayag temple and 25 km from Nanda Devi National Park. In winter, the property is only accessible by cable car.
Ranging from studios to 2-bedroom suites, the cosy lodgings come with cable TV and kitchenettes with minifridges, microwaves and stoves. Suites add living rooms and dining areas.
Breakfast is free. There's also a relaxed restaurant, a game room and a bonfire area with regular entertainment. Ski equipment rentals and lessons are available, as are guided hikes and in-room massages. The property has a generator.
[caption id=""attachment_713"" align=""alignnone"" width=""1600""] Cliff Top Restaurant at 10000ft[/caption]
}}}",subrataemfluence Old Tickets,40784,WP_HTTP_IXR_Client constructor needs to check that $server is valid,chrispecoraro,HTTP API,4.7.4,normal,normal,Awaiting Review,defect (bug),new,,2017-05-17T12:11:28Z,2017-05-20T06:25:48Z,"ErrorException is thrown: {{{Undefined index: host}}} and {{{Undefined index: scheme }}} When WP_HTTP_IXR_Client is instantiated in {{{pingback()}}}, {{{$path}}} is checked, but {{{$server}}} may still be invalid or false, which sends an invalid URL to {{{parse_url()}}}. Instantiation: {{{ $client = new WP_HTTP_IXR_Client($pingback_server_url); }}} Excerpt from class: {{{#!php scheme = $bits['scheme']; $this->server = $bits['host']; ... }}} In the code that instantiates {{{WP_HTTP_IXR_Client}}}, it is clear that {{{discover_pingback_server_uri}}} could return false, which then gets passed as a constructor parameter. Relevant code block: {{{ $pingback_server_url = discover_pingback_server_uri( $pagelinkedto ); if ( $pingback_server_url ) { @ set_time_limit( 60 ); // Now, the RPC call $pagelinkedfrom = get_permalink( $post ); // using a timeout of 3 seconds should be enough to cover slow servers $client = new WP_HTTP_IXR_Client($pingback_server_url); $client->timeout = 3; }}} Possible resolution: {{{filter_var($server, FILTER_VALIDATE_URL) }}} should be used to test the URL prior to {{{parse_url($server)}}}",chrispecoraro Old Tickets,40780,Update docblocks & parameters in wp-includes/link-template.php for post-related functions,GunGeekATX,General,4.8,normal,normal,Awaiting Review,enhancement,new,,2017-05-16T19:11:20Z,2017-05-16T19:11:20Z,"The following functions have docblocks and parameters that appear to only accept the post ID, but the underlying code calls `get_post()` so either post ID or a post object can be accepted. * get_post_permalink() * get_edit_post_link() * edit_post_link() * get_delete_post_link() ",GunGeekATX Old Tickets,40777,Using a static 404 HTML file (dynamically generated) (and/ or .htaccess instead of favicon.ico),design_dolphin,Bootstrap/Load,4.8,normal,normal,Awaiting Review,enhancement,new,,2017-05-16T09:37:24Z,2017-05-16T09:37:24Z,"This is a follow-up to #3426. '''Issue:''' favicon.ico is loaded and this causes an additional request when loading a page, even when a website is not using this browser feature. I'm not going to rehash the pro and con arguments in the previous ticket, and instead will focus on continuing towards the future from here. ''' Possible Solution:''' If the issue is that serving 404 costs too much CPU, etc, wouldn't it be better to serve a static 404 then? E.g. a (cached from the theme) html page and/or through .htaccess '''For example in .htaccess:''' {{{ ErrorDocument 404 ""

Page not found

"" }}} or {{{ ErrorDocument 404 /404.html }}} '''Additional performance benefit:''' This could eliminate a broader range of performance issues with generating a dynamic 404. '''Source .htaccess example:''' http://www.inmotionhosting.com/support/website/how-to/set-404-via-htaccess ",design_dolphin Old Tickets,40776,"Feature request : Need class parameter for ""Twitter"" embed share",sanjaydabhoya,Embeds,,normal,normal,Awaiting Review,enhancement,new,,2017-05-16T06:47:48Z,2017-05-16T06:47:48Z,"'''Note:''' Twitter embedded share already working nicely. This is an only feature request. I want to update twitter embed share, but I can't edit or modify that default twitter embed share because it's an iframe. ''For example'', I want to make twitter share as a 'center aligned' within my content area when writing blog posts. (There are number of possibilities as well.) Yes, I found the solution for twitter share center alignment. We need to add one class with iframe - '''''tw-align-center''''' but there is no input box/area available in popup where I can write down my custom classes. Please check this screenshot for more detail - https://d.pr/f32E0",sanjaydabhoya Old Tickets,40774,Refine error message when embedding invalid Video (URL),Presskopp,Media,4.8,normal,normal,Awaiting Review,enhancement,new,,2017-05-16T02:11:00Z,2017-05-16T15:42:47Z,"like in #40771 you get the following error when your link is invalid: {{{ Sorry, we can’t display the video file type selected. Please select a supported video file (...) or stream (YouTube or Vimeo) instead. }}} When posting an incomplete youtube link for example it's not the file type but a character wrong or missing. I propose to change the error message like in the patch attached: {{{ Sorry, either the selected file type is not supported or the video stream is invalid. Please make sure to select one of the following video file types (%1$s) or a valid stream (YouTube or Vimeo) instead. }}} ",Presskopp Old Tickets,40773,"Hello, I found the problem with permalink on the site in the latest version of WordPress.",prografika,Permalinks,2.9,normal,normal,Awaiting Review,defect (bug),new,,2017-05-15T22:32:32Z,2017-06-12T06:22:07Z,"Hello, I found the problem on the site in the latest version of WordPress. If we open a page or record on any site version 4.7.4 and add arbitrary numbers to the address, then instead of page 404 we will see a copy of the content. For example: Https://mybilet.info/moskva-gruziya-aviabilety/ And the same can be seen from the link Https://mybilet.info/moskva-gruziya-aviabilety/6546/ Because of this, search engines define pages as non-canonical.",prografika Old Tickets,40769,Translators' note required for singular/plural strings where both strings are in the singular form,pidengmor,I18N,4.8,normal,normal,Awaiting Review,enhancement,new,,2017-05-15T14:33:18Z,2017-05-17T10:14:25Z,"There is some confusion for translators in GlotPress over WordPress 4.8.x as some of the singular/plural strings are singular in the originals. For example: Singular: Audio Widget (%d) Plural: Audio Widget (%d) A translators' note would be handy here to explain why the plural is not Audio Widget'''s''' in this case. This currently relates to four strings: [https://translate.wordpress.org/projects/wp/dev/en-gb/default?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=4483096&filters%5Btranslation_id%5D=49716087/ Audio Widget] [https://translate.wordpress.org/projects/wp/dev/en-gb/default?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=4483106&filters%5Btranslation_id%5D=49716079/ Image Widget] [https://translate.wordpress.org/projects/wp/dev/en-gb/default?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=4483125&filters%5Btranslation_id%5D=49716063/ Media Widget] [https://translate.wordpress.org/projects/wp/dev/en-gb/default?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=4483114&filters%5Btranslation_id%5D=49716070/ Video Widget]",pidengmor Old Tickets,40759,Word Count Discrepancies,pento,Editor,,normal,normal,Awaiting Review,defect (bug),new,,2017-05-14T12:36:09Z,2017-05-15T08:02:05Z,"I've noticed several discrepancies between how WordPress, Pages, Google Docs, and Word count words. Given the following text, all four count things quite differently. {{{ a 1 foo-bar e.g. jack & jill 5 @ $4.99 . fuzz@baz.blog }}} || ||= WordPress =||= Word =||= Pages =||= Docs =|| || Individual Words (a, jack, jill) || 3 || 3 || 3 || 3 || || Individual Numbers (1, 5) || 0 || 2 || 2 || 2 || || Hyphenated Words (foo-bar) || 1 || 1 || 2 || 1 || || Abbreviations (e.g.) || 1 || 1 || 2 || 2 || || Punctuation that translates to a word (&) || 0 || 1 || 0 || 0 || || Punctuation that translates to a word in this usage (@) || 0 || 1 || 0 || 0 || || Punctuation that doesn't translate to a word (.) || 0 || 1 || 0 || 0 || || Compound number ($4.99) || 0 || 1 || 1 || 2 || || Email address (`fuzz@baz.blog`) || 1 || 1 || 3 || 3 || I tend to fall in the camp of ""what would a reasonable native speaker count as a word"", which is probably closest to Word's definition, minus the punctuation that doesn't translate to a word.",pento Old Tickets,40757,Standardize Application of 'the_category' Filter,bcworkz,Taxonomy,4.7.4,normal,normal,Awaiting Review,defect (bug),new,,2017-05-13T21:32:30Z,2017-05-13T21:32:30Z,"According to the [https://developer.wordpress.org/reference/functions/get_the_category_list/ Code Reference], application of 'the_category' filter passes three parameters (line 210). There are a number of instances in core where only the first parameter is passed. This causes PHP warnings to be issued when plugin or theme code that hooks 'the_category' asks for more than the first parameter to be passed when their callback is added. For example {{{add_filter('the_category', 'add_class_to_category', 10, 3 );}}} All applications of this filter in core should comply with documentation by passing all three of the documented parameters, even if it is just the default empty string. Granted, plugin and theme devs can prevent the warning by providing default parameter values for their callback function or by conditionally adding their callback only when {{{!is_admin()}}}, but many people using this filter are not experienced developers, they are site owners tweaking their installation using very minimal PHP skills. They are not capable of adapting to situations that do not match the provided documentation. Core code should consistently comply with the provided documentation. Alternately, update documentation to clearly indicate the two additional parameters are optional. For the reasons just mentioned, documentation would need some good examples for how to avoid PHP warnings. Given people's propensity to not read documentation, I'm not convinced this is a good alternative. If it is the chosen direction Trac #[ticket:39130] may be related. For reference, the documented application of 'the_category' that passes three parameters is in the declaration for [https://core.trac.wordpress.org/browser/tags/4.7.4/src/wp-includes/category-template.php#L205 get_the_category_list()]. (Also at lines 135 and 151) Locations that only pass one parameter (which are all other applications in core): source:tags/4.7.4/src/wp-admin/includes/class-walker-category-checklist.php#L99 source:tags/4.7.4/src/wp-admin/includes/class-walker-category-checklist.php#L106 source:tags/4.7.4/src/wp-admin/includes/template.php#L217 source:tags/4.7.4/src/wp-admin/includes/template.php#L258 source:tags/4.7.4/src/wp-admin/edit-tags.php#L540 4.7.4 references are from my initial research, the included patch is for changeset:40663. Props to @biellebrunner and @csloisel for bringing attention to this in the [https://wordpress.org/support/topic/missing-argument-2-on-a-custom-function/ Forums]. ",bcworkz Old Tickets,40746,Error on adding .ico icon in customizer.,kruglikov,Customize,4.3,normal,normal,Awaiting Review,defect (bug),new,,2017-05-12T15:32:17Z,2017-05-16T00:34:16Z,"I'm trying to add site icon in Cutomizer according to this manual: https://codex.wordpress.org/Creating_a_Favicon#WordPress_Version_4.3_or_later - I go to Administration Screen > Appearance > Customize - I click Site Identify - then I click Select Image at Site Icon sectiona and select my favicon.ico file. On step when WP asks me to crop the image, I got error ""Image could not be processed"". I debugged and found that this is because system (neither GD nor ImageMagick) cannot operate with .ico (image/x-icon mimetype) files. It seems not very logical that I can't upload ready for use favicon.ico with the tool that is created for this. It seems as bug for me. Why just not use uploded .ico file if system cannot operate it?",kruglikov Old Tickets,40742,wp_upload_dir() returns wrong value after provider changes disk,opajaap,General,2.9,normal,normal,Awaiting Review,defect (bug),new,,2017-05-12T08:37:24Z,2017-05-12T08:37:24Z,"wp_upload_dir() returns wrong value after provider changes disk. This is because in: {{{#!php This is only a partial sample of the file. ",jaendres Old Tickets,40716,WordPress's magic quotes emulation doesn't slash keys like PHP's built-in magic quotes,jdgrimes,General,0.71,normal,normal,Awaiting Review,defect (bug),new,,2017-05-10T14:56:49Z,2017-06-06T06:48:41Z,"PHP's built-in magic quotes feature [https://secure.php.net/manual/en/security.magicquotes.disabling.php#69024 not only slashed values, but also keys]. However, although WordPress emulates the magic quotes feature even when it is disabled/unavailable, it has apparently never slashed keys of the GPC arrays, only the values. As a consequence of this, I was just dealing with a bug in a plugin that a user was experiencing on PHP 5.2, but I had never witnessed on newer versions of PHP (5.6, 7.0), which did not have magic quotes enabled. The plugin POSTs data via Ajax that includes both keys and values containing backslashes. This data will be double-slashed by the magic quotes feature. So in the Ajax handler, this data is passed through `wp_unslash()`, and so the original, single-slashed values can then be utilized. However, `wp_unslash()` does not unslash the keys. When PHP's magic quotes are disabled, this is not a problem, because WordPress's magic quotes do not slash keys. But on older versions of PHP where magic quotes are enabled by default, PHP will slash both the keys and values, and `wp_unslash()` will not unslash the keys. Data flow: {{{ # WordPress's magic quotes emulation: POST => Data containing slashes in keys and values posted. add_magic_quotes() => Slashes in values are escaped. wp_unslash() => Escaping slashes in values removed. result: data is unchanged. --- # PHP's magic quotes: POST => Data containing slashes in keys and values posted. magic_quotes_gpc => Slashes in values *and keys* escaped. wp_unslash() => Escaping slashes in values removed. result: values unchanged, keys still double-slashed. }}} In other words, there is an inconsistency in how data is slashes on different PHP configurations, despite WordPress's efforts to standardize it. The values are consistent in the way that they are slashed, but keys are not.",jdgrimes Old Tickets,40715,TinyMCE should use the site language instead of the user one,7studio,General,4.7,normal,normal,Awaiting Review,defect (bug),new,,2017-05-10T12:19:51Z,2017-05-10T12:19:51Z,"Since the [https://core.trac.wordpress.org/changeset/36802 change 36802], TinyMCE in the admin panel uses the language defined by the default translated string (`html_lang_attribute`) based on locale. In almost all cases, the locale is defined by the site language. Except that since the 4.7, the user is able to select their preferred locale (language) when editing their profile. In this specific case, if the selected language is different from the site language, TinyMCE will use a wrong locale (the user one) for the `lang` attribute on its `` element. This wrong behaviour is due to `get_bloginfo( 'language' )` which is used to define the `wp_lang_attr` entry. That's a shame especially when you want to use the `:lang` CSS pseudo-class and you get a different result in the admin panel and on your site. For the moment, I'm able to resolve this issue by overriding the value via the filter `tiny_me_before_init`: {{{#!php $label ) : ?> }}} This will allow: {{{ function me_filter_gallery_settings( $settings ) { $settings['galleryDefaults']['size'] = 'large'; return $settings; } add_filter( 'media_view_settings', 'me_filter_gallery_settings' ); }}} Thereby allowing plugin and theme developers to set a default value for the image size in galleries.",Catapult_Themes Old Tickets,40688,there is a bug in deleting a photo and replacing it by the new photo with the same name,Navid.abazari,Gallery,4.7.4,normal,normal,Awaiting Review,defect (bug),new,,2017-05-07T21:04:41Z,2017-05-07T21:04:41Z,there is a bug when you want to permanently delete some photo from library and replace some other one with the same name in library. when you do this the first photo in web page wont be changed i mean the first photo still appears on the web page so you should change the name of the new photo for uploading it and showing it instead of the older one. ,Navid.abazari Old Tickets,40687,pre_option_upload_url_path filter no longer working,QROkes,General,4.7.4,normal,normal,Awaiting Review,defect (bug),new,,2017-05-07T20:42:53Z,2017-05-07T20:42:53Z,"“pre_option_upload_url_path” filter is not working since WP 4.7. This is my use case that used to work like a charm before, it's pretty simple and seems like an issue in the {{{wp_upload_dir()}}} function in {{{/wp-includes/functions.php}}} file. {{{ function cdn_url() { return 'http://cdn.domain/wp-content/uploads'; } add_filter( 'pre_option_upload_url_path', 'cdn_url' ); }}} ",QROkes Old Tickets,40686,CSS: introduce naming and usage conventions for JS targeting,afercia,Administration,,normal,normal,Awaiting Review,enhancement,new,,2017-05-07T13:34:50Z,2017-05-07T13:34:50Z,"As part of the broader goal of the [https://make.wordpress.org/core/2014/12/19/core-css-roadmap/ CSS roadmap], it would be great to start introducing CSS classes naming and usage conventions for JS targeting. This need clearly emerged during the ongoing exploration to revamp the Settings API, and woud benefit all the codebase. Work on the Settings API is happening on GitHub and [https://github.com/wpaccessibility/settings-api-enhanced/issues/11 there's an open issue for this]. Quoting from the doc @helen prepared to share some thoughts (the doc is available on the GitHub issue): > Reusing styling class names is fragile and obscures intent when doing long-term maintenance. Personally, I can only add that I can't count the number of times when touching some CSS class or ID forced me to check all the codebase to make sure they weren't used also for JavaScript related purposes :) ",afercia Old Tickets,40685,/wp-includes/class-wp-hook.php function resort_active_iterations not working correct,tim2017,General,4.7.4,normal,normal,Awaiting Review,defect (bug),new,,2017-05-06T19:23:26Z,2017-06-08T00:02:14Z,"if you have current priority of 5, whose only hook is cancelling itself (remove_filter) and the new priority list is for example (2,7,12), then this part {{{#!php while ( current( $iteration ) < $current ) { if ( false === next( $iteration ) ) { break; } } }}} sets the current pointer to 7, so the next priority worked on is the 12 in apply_filters function, while it should be 7. ",tim2017 Old Tickets,40682,get_current_blog_id() and get_current_network_id() are loaded before absint(),wonderboymusic,Networks and Sites,3.5,normal,normal,Awaiting Review,defect (bug),new,,2017-05-06T06:41:04Z,2017-05-06T06:41:04Z,"In r21484, these functions were moved to `wp-includes/load.php`. Regardless of when they are *supposed* to be called, they are available to be called by cache plugins before `absint()` exists in the ether. If caching plugins are indeed accessing `global $blog_id` this early, seems like a race condition somewhere.",wonderboymusic Old Tickets,40681,"The ""Edit Post"" page appears to MOVE a category to the top based on bad logic, instead of leaving it under its parent.",DScotese,Editor,4.7.4,normal,normal,Awaiting Review,defect (bug),new,,2017-05-06T03:30:11Z,2017-05-06T03:30:11Z,"I recommend updating this page so that you have a more concise list of these questions, just to cut down on the size of the descriptions we submit to you (from those who simply copy/paste them, like me): Are you using either the latest version of WordPress, or the latest development version? If not, please update first. I understand that our installation keeps itself up to date. What steps should be taken to consistently reproduce the problem? 1. Create a Top level category. 2. Create a category under it. 3. Create a new post in the child. 4. Observe that after saving the new post, the child category is displayed at the top of the category list. Does the problem occur even when you deactivate all plugins and use the default theme? We don't have a test version of the site yet, and we don't want to disturb visitors on the site, so we have not yet tested this with any of the following disabled: Disqus Comment System; MailChimp for WordPress; Recent Posts Widget Extended; Swifty Image Widget by WPGens; Yoast SEO In case it's relevant to the ticket, what is the expected output or result? What did you see instead? Good point. I expected the list to leave the category in the list under the parent category. It does seem smart to move it to the top, but if you do that, I suggest that since it's a child category, it still be indented - at least once - maybe with a circled question-mark tooltip explaining that the indentation only means ""This category has a parent category that can be found below.""",DScotese Old Tickets,40678,Editing menus in WP admin for blind people,juliemoynat,Menus,,normal,normal,Future Release,defect (bug),new,,2017-05-05T15:37:25Z,2017-05-22T16:59:58Z,"Hi, I've first created this ticket in WordPress accessibility support (https://wordpress.org/support/topic/editing-menus-in-wp-admin-for-blind-people/) but this is not a support ticket so I re-post it here. With a blind person, we noticed that navigate through the page to create menus with a keyboard and a screen reader is not easy. Then, I tried to help him by giving him a page description. We noticed that : * this page lacks titles at the top of blocks to explain what these blocks are. This would help blind people to better find each block and to navigate easily from one block to another. * there are some masked explanations but not everywhere so, for example, he can’t imagine that clicking on links in “Menu structure” would have opened an accordion * there are some tabs navigation (at the top: “Edit menus” and “Manage locations”, in the left column: “Most recent”, “View all”, “Search”) but blind people can’t know which one is active not either that they are tabs. So, I think there are 2 steps to enhance editing menus in WP admin : 1. giving more informations by screen reader texts 2. using ARIA design patterns for tabs and accordions: https://www.w3.org/TR/wai-aria-practices-1.1/#aria_ex For step 1, we could : * for all tabs: add a screen reader text on the active one “(current tab)” * for tabs at the top (“Edit menus” and “Manage locations”): remove the “h2” tag and use an unordered list (“ul”) with an “aria-label” attribute that would tell “Main tabs for editing menus” * add a title before each block: for left column, this could be “Choose which links you want to have in your menu”, for right column, this could be “Change parameters for the links you added in your menu (order, label, title…)” * add a screen reader text to “Add to menu” button, like “(after that, don’t forget to active “Save menu” button)” * add a screen reader text to links in the right column (just like in the left one): “Press return or enter to open this section” * add a screen reader text after the 2 first tabs, in a paragraph that would tell users something like “don’t forget to active “Save menu” button to save all your modifications”. So, if they don’t find that button, they could search it with their screen reader thanks to its name. These texts would help blind people to navigate title by title and to understand how it works. What do you think about it? Could it be added to WordPress admin? ",juliemoynat Old Tickets,40677,Widgets page is not accessible for keyboard users,juliemoynat,Widgets,,normal,normal,Future Release,defect (bug),reopened,,2017-05-05T15:18:41Z,2017-05-22T17:06:09Z,"Hi, I noticed that widgets page is not accessible for users that navigate with keyboard. A good point is that drag and drop is not the only solution to add a widget into an area but this page needs some enhancements to be accessible for keyboard users (blind people, people with motor disability, and even people with no handicap). This is my list: * Available widgets can't be focused. Solution : If we add a ""tabindex=""0"""" attribute on "".widget.ui-draggable"" elements, we can focus them and open it just like a click. And we need to add a focus style to see focus on elements. * A keyboard user can't select the area where he wants to add the widget because a TAB or arrow navigation automatically select the following choice. So he can just add widgets in the last area. Solution : deactivate TAB navigation on elements and just allow arrow navigation. This would be equivalent to radio buttons navigation. TAB would be just to go to ""Cancel"" or ""Add widget"" button. Also add a screen reader text to tell which choice is selected (blind people can't see the checked icon). * This page is divided into 3 parts : ""Available widgets"", ""Inactive widgets"" and all widgets areas. The ""all widgets areas"" has not title to quickly navigate into it. Solution : add a ""h2"" title on the third zone (""Widgets areas"" for example) and replace ""h2"" title of widgets areas by ""h3"" (logical, right?) * Widgets in areas can't be deactivated with keyboard because we need to drag them back. Solution : Add a link ""Deactivate"" next to the ""Delete"" one. * Widgets areas can't be opened with keyboard because arrows are ""div""s and not buttons. Solution : be inspired by the left column of the page to add menus (there is tabindex and screen reader text to explain) * Widgets in areas also have an arrow to hide / show. The arrow is a link and that's a good point but there no text in it. Solution : add a screen reader text to explain what that link does (blind people can't see the arrow) Thank you for your help",juliemoynat Old Tickets,40676,"wpautop adds opening & closing p tags around the opening a tag and around the closing a tag when the link contains certain flow content elements like div, h1, h2...",diegocanal,Formatting,4.7.4,normal,major,Awaiting Review,defect (bug),new,,2017-05-05T10:55:47Z,2017-06-15T07:18:42Z,"Hi, == Description == wpautop leaves {{{}}} (opening tag of the link) in between {{{

}}} tags and {{{
}}} (closing tag of the link) in between {{{

}}} tags when the link contains certain flow content elements like div, h1, h2... == Example 1 == If I add this to the HTML editor: {{{
DIV inside link
}}} The output source code is: {{{

DIV inside link

}}} ---- == Example 2 == If I add this to the HTML editor: {{{

H1 inside link

}}} The output source code is: {{{

H1 inside link

}}} ---- == Note 1 == I would like to point out that html '''''flow content'' elements such as {{{
}}} or headings ({{{



}}} ,...) belong to the category of permitted content for the {{{}}} element'''. References: [https://html.spec.whatwg.org/multipage/semantics.html#the-a-element WHATWG HTML Living Standard |The definition of a] [http://www.w3.org/TR/html5/text-level-semantics.html#the-a-element HTML5 | The definition of a] [https://developer.mozilla.org/en/docs/Web/HTML/Element/a MDN | The definition of a.] ---- == Note 2 == This issue might be related to ticket #34722",diegocanal Old Tickets,40675,Accented letter at end of line displays wrong,niente0,Editor,4.7.4,normal,normal,Awaiting Review,defect (bug),new,,2017-05-05T09:48:17Z,2017-05-08T07:41:04Z,"In Wordpress (last version) if a line of text '''ends with an accented letter''' (ie ""Università""), the accented letter is displayed as a ""?"" (unknown character). If replaced with à it displays correctly. It happens on all wordpress sites I have (different plugins, different themes).",niente0 Old Tickets,40674,Images still cannot be uploaded within ALL of the sections in the wp-admin Selection: All Content section.,wordpresshater2,Gallery,4.5.1,normal,normal,Awaiting Review,defect (bug),new,,2017-05-05T06:56:16Z,2017-05-05T06:56:16Z,"Images still canmot be uploaded within ALL of the sections in the wp-admin Selection: All Content section. Also, if you could allow the user or hired web devs for IT clients to have server access to remove non-working element linked into a web page, for example, Google Maps, that don't always work; maybe add a button into the wp-admin UI like Ubuntu OS that has to give the user or dev the ability to connect to the server of their IT client if the client has a separate server than the server the web dev uses for other IT clients. Why do I ask this? Because in order to take out a non-working element linked within a website, for example, Google Maps, the div tags and content within the div tags will need to be deleted out of the HTML of the web pabe in which the non-working element was embedded. And the way to do that is to go into the server and then access the web page to then delete the elememt (div tags and content within the div tags within the HTML (markup language) of the web page).",wordpresshater2 Old Tickets,40671,"Calling get_term() with just ID, then calling it again with ID and a different taxonomy returns the same term",GunGeekATX,Taxonomy,4.7.4,normal,normal,Awaiting Review,defect (bug),new,,2017-05-04T21:13:37Z,2017-05-04T21:13:37Z,"I have a category term ID of 29, and calling get_term() with that ID returns the category. However, if get_term() is called again with both ID and 'post_tag' taxonomy, the original category term is returned. It appears that the $_term variable is not getting cleared out in WP_Term::get_instance() when there is a term already in the cache, so it's always using that term even when the taxonomy does not match. Some sample code to replicate this: {{{#!php '; // Shows the correct category term. $term = get_term( $category_term_id ); var_dump( $term ); // Still shows the category term, but should be empty // due to the different taxonomy. $term = get_term( $category_term_id, 'post_tag' ); var_dump( $term ); die(); } ); }}} Working on a patch, bug was originally brought to light by @ninnypants in our company Slack while working on a project.",GunGeekATX Old Tickets,40668,Duplicate anchor text word,anupviews,General,4.7.4,normal,normal,Awaiting Review,defect (bug),new,,2017-05-04T17:02:58Z,2017-05-17T03:44:17Z,"Hi, There is a bug in anchor link placing tool. When I highlight a word to anchor link and press “anchor link” option and after putting the URL and hitting “OK”, it does not anchor the actual link I highlighted, but instead it creates the duplicate word right next to the word I highlighted and anchors that duplicated word instead. This way I have to manually delete the actual word in the end, which what we don’t want. Please fix this bug ASAP. Thank you!",anupviews Old Tickets,40665,Edit control on Video inside editor should not show up before selecting,subrataemfluence,Editor,4.7.4,normal,normal,Awaiting Review,defect (bug),new,,2017-05-04T14:33:15Z,2017-05-04T14:33:15Z,"I added a video using `wp_video_shortcode` in a page. When I come to edit the page the floating action panel (with Edit and Delete buttons) appears if I just hover the mouse over the video. When I click on these buttons, nothing happens as if they are not functional! They however work once I select the video. The action panel should never appear without the video selected. Hope the attached screen cast would help to understand the issue better. Above does not happen for images.",subrataemfluence Old Tickets,40664,Handling of empty comments,zakalwe,Comments,4.7.4,normal,normal,Awaiting Review,enhancement,new,,2017-05-04T14:21:01Z,2017-05-04T14:21:01Z,"I couldn't find any decent way of avoiding the ""ERROR: please type a comment"" message to appear if an empty comment is submitted. I was hoping to hook in somewhere and perform some custom action if an empty comment is encountered. The attached patch simply provides an action ""require_valid_comment"" that can be hooked into passing the post ID as the only argument. For my own use, I would redirect the user back to the post and tag on an error to be picked up in a custom comments template.",zakalwe Old Tickets,40660,the_post_navigation not excluding terms - wp 4.7.4,Sbaxter_Quba,General,4.7.4,normal,normal,Awaiting Review,defect (bug),new,,2017-05-04T10:05:34Z,2017-05-04T10:05:34Z,"I'm retrieving the post navigation as so {{{#!php true, 'excluded_terms' => '129', 'taxonomy' => 'category' ); the_post_navigation( $args ) }}} I've debugged and it constructs the $where clause here as it should (properly excluding the term) https://github.com/WordPress/WordPress/blob/master/wp-includes/link-template.php#L1647 {{{ $where = AND tt.taxonomy = 'category' AND tt.term_id IN (127) AND p.ID NOT IN ( SELECT tr.object_id FROM wp_term_relationships tr LEFT JOIN wp_term_taxonomy tt ON (tr.term_taxonomy_id = tt.term_taxonomy_id) WHERE tt.term_id IN (129) ) AND ( p.post_status = 'publish' OR p.post_status = 'private' ) }}} This is then replaced here https://github.com/WordPress/WordPress/blob/master/wp-includes/link-template.php#L1716 it improperly constructs the where clause so that the result is as follows {{{ $where = WHERE p.menu_order > '2' AND p.post_type = 'post' AND p.post_status = 'publish' }}} This means i cannot excluded other categories from the post navigation or specify which categories to exclude. ",Sbaxter_Quba Old Tickets,40657,Deprecate current_time( 'timestamp' ),jdgrimes,Date/Time,,normal,normal,Awaiting Review,enhancement,new,,2017-05-03T22:49:35Z,2017-05-04T13:46:02Z,"I've just opened #40653 to address some issues with how `current_time()` operates internally. That ticket provides a bit of background on the age of the `current_time()` function and why it does what it does. In this ticket I'd like to specifically address the use of `current_time( 'timestamp' )`, which 'gets the Unix timestamp of the current time in the site's timezone.' The problem is that timestamps are actually timezoneless, they are UTC, meaning that they are always counting the number of seconds from the Unix epoch, which is a certain point in time, simultaneous across all timezones. What WordPress is trying to do is [http://lists.automattic.com/pipermail/wp-testers/2010-April/012671.html explained by Otto here]: >Basically, in order to maintain consistency across older PHP 4 installations, it was decided to have WP force the PHP environment to be using UTC dates for everything. [I.e., `date()` is always GMT.] Then WordPress itself applies the adjustments when needed. > >... > >A call to current_time( 'timestamp' ) will give you the current timestamp adjusted by the necessary amount to get the correct time display. So to get the correct date in WordPress using date(), you'd do this: > >`date('Y-m-d', current_time( 'timestamp' ));` > >How it breaks down: >- PHP date and time functions should always give you the info in UTC. >- current_time( 'timestamp' ) will give you a UTC timestamp adjusted by the amount necessary to show the local date. So this was deemed necessary for legacy reasons (PHP 4), but it is very confusing and tends to fool learning devs into a complete misunderstanding of timestamps, causing them to think that timestamps somehow have a timezone. In reality, this is just a quirk of legacy handling provided by WordPress. But it actually is no longer necessary, and probably ought to be deprecated, or at least discouraged. I say that it isn't necessary because the `current_time()` function now allows for any format string to be passed. This means that instead of this: `date('Y-m-d', current_time( 'timestamp' ));` You can skip the step of getting the ""non-GMT"" timestamp, and just do this: `current_time( 'Y-m-d' );` Also, because the timestamp does not actually carry any timezone information, if you do it the first way and try to format it later in a manner that includes timezone information, it will be UTC. (`current_time()` actually has this same problem right now, but it would be fixed by #40653.) In summary: - `current_time( 'timestamp' )` is not necessary to use, the format you want to convert the timestamp to can be passed directly. - It confuses devs into thinking that timestamps are timezone-relative, when they are not. - It won't work when ultimately converted to formats that include timezone information, since the timestamp does not actually include timezone info. It might not be worth it to actually fully deprecate the `'timestamp'` arg when `$gmt` is false, just because of the volume of legacy code that might be using this, but I thought at least I would open a ticket to raise awareness.",jdgrimes Old Tickets,40655,DB error during installation,FlyerUA,General,4.7.4,normal,normal,Awaiting Review,defect (bug),new,,2017-05-03T22:29:22Z,2017-05-03T22:29:22Z,"`$wpdb->query( ""SELECT $prefix"" );` at line 279 of setup-config.php throws a DB error and that's not exactly nice thing to have during installation. If you insist on having a check like this, perhaps suppress the error from this call?",FlyerUA Old Tickets,40651,Plugins: Make it easier to find plugin settings after install,melchoyce,Plugins,,normal,normal,Awaiting Review,feature request,new,,2017-05-03T18:24:19Z,2017-05-04T14:01:14Z,"After installing new plugins, I invariably end up spending time hunting down wherever I need to configure or use it. Some plugins add a ""Settings"" link to their plugin card (very useful!) but this isn't always the case. It would be great to find a way to direct people to the settings screens upon activation. ",melchoyce Old Tickets,40649,parent_file filter seems to be overwritten by get_admin_page_parent call,jontis,Menus,4.7.4,normal,normal,Awaiting Review,defect (bug),new,,2017-05-03T13:37:51Z,2017-05-23T03:47:46Z,"In wp-admin/menu-header.php the filter `parent_file` seems to have little to no impact most of the time. This is because the global `$parent_file` variable often gets immediately overwritten by the `get_admin_page_parent` function call. {{{#!php slug; }}} to {{{#!php $values[] = $term->name; }}} in file /wp-admin/includes/media.php at line number 1652. The code fragment: [[Image(http://caseforyou.pro/three.png)]] Could you do this change and inlclude in one of the followings releases? Thank you!",snookerist Old Tickets,40634,Media handling: No fil shows when press filter in list view moduls,plingplong,Media,4.7.4,normal,normal,Awaiting Review,defect (bug),new,,2017-05-02T12:02:48Z,2017-05-08T11:02:18Z,"Found what i beleeve is a bug with the media function. howto reproduse: in list mode, (all mediafile), (All dates), press filter button. All file dissapairing, the reset button is grayed out. and Apache2 log show following errors. [Tue May 02 13:50:34.876816 2017] [:error] [pid 17377] [client] WordPress database error You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '))) AND wp_posts.post_type = 'attachment' AND ((wp_posts.post_status = 'inherit' at line 1 for query SELECT SQL_CALC_FOUND_ROWS wp_posts.ID FROM wp_posts LEFT JOIN wp_postmeta AS sq1 ON ( wp_posts.ID = sq1.post_id AND sq1.meta_key = '_wp_attached_file' ) WHERE 1=1 AND ((())) AND wp_posts.post_type = 'attachment' AND ((wp_posts.post_status = 'inherit' OR wp_posts.post_status = 'private')) GROUP BY wp_posts.ID ORDER BY wp_posts.post_date DESC LIMIT 0, 20 made by WP_Media_List_Table->prepare_items, wp_edit_attachments_query, wp, WP->main, WP->query_posts, WP_Query->query, WP_Query->get_posts, referer: https://alfton.no/ankenes/wp-admin/upload.php I think this is not expectet, spessially when you not have selectet any filtering options. What i meen is correct behavior is that nothing should happend, file should stil be showing. ",plingplong Old Tickets,40633,Update wp-admin gray colors aka 50 Shades of WordPress,netweb,General,,normal,normal,Awaiting Review,enhancement,new,,2017-05-02T10:40:27Z,2017-05-02T11:10:49Z,"Via https://github.com/WordPress/gutenberg/issues/573#issuecomment-298542708 > > My process was one of matching values (how light or dark a color is) with the old ones to attempt and reduce them to a smaller list of grays. > > The thing with this is, these new ones haven't actually been used in wp-admin - What needs to happen is a search and replace for each color on the left, for their corresponding substitute on the right column, and look at them to make sure everything looks (aesthetically balanced) and works (accessibility-wise) well. > > I could use some help with structuring this process. Do we go by individual color form the left column (a ticket per color)? Or a one per color on the right column? Or per groups of colors (dark vs light grays)? etc... help! Related resources and discussions: * https://codepen.io/hugobaeta/full/grJjVp/ - ''This codepen serves as a playground to analyse and improve the use of colors (specifically the numerous shades of gray) in the WordPress Admin. There are currently 174 colors in the Admin. The right column is a proposal to merge multiple values together for consistency and brevity.'' * https://codepen.io/hugobaeta/full/RNOzoV/ '- 'The official color palette repository for WordPress (core, .org, and related projects). More information available on the Design Handbook pages.'' * https://make.wordpress.org/design/handbook/design-guide/foundations/colors/#grays * https://make.wordpress.org/design/2015/04/05/default-admin-color-scheme-update/ * Previously #31234 Update wp-admin default colors",netweb Old Tickets,40632,Fix undefined index notice in wp-includes/user.php,arkimedia,Users,4.7.4,normal,normal,Awaiting Review,defect (bug),new,,2017-05-02T09:49:50Z,2017-05-02T09:49:50Z,"Current solution only checks if {{{$userdata['user_pass']}}} is not empty, but it doesn't test if index exists. In attached diff file, isset check have been added in order to fix undefined index notice in wp-includes/user.php on line 1431. ",arkimedia Old Tickets,40631,Safari issues with wp-includes/ms-files.php,Brandicoot,General,4.7.4,normal,normal,Awaiting Review,defect (bug),new,,2017-05-02T07:33:43Z,2017-05-02T07:33:43Z,"We have a multi-site network with over 200 sites on it. Whilst the network is running WP 4.7.4–en_AU the network was originally built on a version prior to 3.5 and has been continually updated as versions become available. That being said, our network still uses the old file structure wp-content/blogs.dir/[site#]/files to store media. I've tried converting this over with no success and haven't really been able to find any good resources to help me do this beyond the things I've tried. So, our network continues to use the above path with the compatibility option of using wp-includes/ms-files.php which is called in the .htaccess file. However, there seems to be a bug in the ms-files.php that are causing some resources not to load properly when the sites are loaded into Safari or an iOS device. 1. PDF documents fail to load 2. CSS files that have been cached by our theme (it has it's own caching function) also fail to load. I've narrowed down the culprit to the lines of code in ms-file.php that output the headers. If I comment out the code on line 43: {{{#!php header( 'Content-Length: ' . filesize( $file ) ); }}} ...then the problem goes away. Not sure what impact commenting the above has but it doesn't seem to break the site so I've left it commented out. My best guess is that Safari doesn't like this header being sent out separately from the earlier one on line 41. It may even be a bug with Safari - not sure on this one. Anyway, thought I'd report it here to begin with. Cheers Chris ",Brandicoot Old Tickets,40629,Change default template,pratikgandhi,General,4.7.4,normal,normal,Awaiting Review,feature request,new,,2017-05-02T06:17:50Z,2017-05-02T06:17:50Z,"I recently required to change the default template of theme to another template. The site is already working since 3 months and now client wants to change the default template to the sidebar template while publishing new pages. There is no such action or filter available for it. I am trying to add filter for it but if anyone have other suggestions, please let me know.",pratikgandhi Old Tickets,40627,Remove SWFUpload,azaozz,Upload,,normal,normal,Future Release,task (blessed),new,,2017-05-02T02:04:18Z,2017-05-02T02:09:15Z,"Development of SWFUpload stopped in 2010. It has been deprecated in core since 2011 when we switched to using Plupload in WordPress 3.3. Most of its functionality is now native in all browsers. We've been maintaining it for over five years, but in the spirit of https://make.wordpress.org/core/2017/04/23/target-browser-coverage/ it's time to say ""Goodbye!"".",azaozz Old Tickets,40614,REST API: String argument for rest_do_request/rest_ensure_request does not work as expected.,TimothyBlynJacobs,REST API,4.4,normal,normal,Awaiting Review,defect (bug),new,,2017-04-30T22:07:12Z,2017-05-01T00:03:03Z,"According to the `rest_do_request()` php docs, a `string` parameter type is accepted. Currently, this is forwarded to `rest_ensure_request()` which only accepts a `WP_REST_Request` object or an array. When a string argument is passed a request object is instantiated with a string value for the request attributes which is improper. Either the docs should be updated, or, ideally, the `rest_do_request` and `rest_ensure_request` functions would be updated. I could see those two functions either accepting a route path, like `/wp/v2/posts` or a full url, `www.example.org/wp-json/wp/v2`. Since those API functions are internal to the API instance, it makes most sense, in my mind at least, to accept a path style argument. Otherwise, there would be needless boiler plate: `rest_do_request( rest_url( '/wp/v2/posts' ) )`. The simplest implementation would then be to instantiate a `WP_REST_Request` object with the given path as the second constructor argument if the `$request` parameter is a string. However, this would make it impossible to quickly make a request with any query parameters attached. That gives us a few options. 1. Change `rest_ensure_request` to do `WP_Rest_Request::from_url( rest_url( $request ) )` in case of a string argument. 2. Introduce `WP_Rest_Request::from_path` that accepts a path and does the proper `parse_url` and `wp_parse_str` handling. 3. Only accept a full URL to `rest_do_request`. If it might be confusing that `rest_ensure_request` accepts a path argument instead of a URL, conceivably it could accept both and switch on the presence of a `/` at the start of the string. Happy to submit a patch to whichever makes most sense.",TimothyBlynJacobs Old Tickets,40613,Add query cache to WP_User_Query class,johnjamesjacoby,Users,,normal,normal,Awaiting Review,defect (bug),new,,2017-04-30T18:36:40Z,2017-04-30T18:46:03Z,"When calling `get_users()` the query itself is not cached. If multiple calls to `get_users()` with the same `$args` array occur, each will result in a database hit. Note that each individual user object is cached, and that query caches will need to be invalidated when users are added/removed/edited. Theoretically, on busy sites with many users who are constantly changing passwords and things, caching user queries may not yield a significant performance improvement. For the majority of installations (where users are not shifted around nearly as much) this could result in several additional cache hits per page load (especially with persistent caches in place.) Functions like `wp_dropdown_users()` are called multiple times when viewing the Posts list-table, and many plugins also call `get_users()` knowing that user objects are cached (but not noticing the additional database hits for each call itself.) Membership plugins like BuddyPress would have inherent benefits, and bbPress could operate more efficiently when querying for the intersection of many topics with many users who are engaged in them. Patch imminent.",johnjamesjacoby Old Tickets,40609,Cannot register an application/foo+xml mime type without also registering application/xml,paulsowden,Upload,,normal,normal,Awaiting Review,defect (bug),new,,2017-04-30T04:05:08Z,2017-06-01T19:21:11Z,"In wp_check_filetype_and_ext() there is a block that uses finfo_file to sniff the mime type of a file. When registering an application/foo+xml type the returned type from finfo_file is application/xml so to allow application/foo+xml using the upload_mimes filter one must also allow application/xml otherwise this real_mime check fails. It seems like the check should allow the original mime type if the real_mime is application/xml and the $mime is of the form application/foo+xml",paulsowden Old Tickets,40607,"The slug of a menu-item of type ""Custom Links"" interferes with pages/posts slugs.",Karimeo,General,,normal,normal,Awaiting Review,defect (bug),new,,2017-04-29T16:02:48Z,2017-04-29T16:02:48Z,"How to reproduce: - Add a menu-item of type ""Custom Links"" to a menu. Let's say with content ""URL = http://google.com / Link Text = Google"" - Create a page with the same name as the ""Link Text"" used. In the example with Google, the slug ""google"" will be taken and ""google-2"" will be used. My suggestion would be to just add ""-menu"" to the slugs of such menu-items as they are not visible anyway ? ",Karimeo Old Tickets,40606,wp_filter_nohtml_kses escaping single quotes even when no HTML tags are being used in the string,samuelaguilera,General,4.7.4,normal,normal,Awaiting Review,defect (bug),new,,2017-04-29T11:29:07Z,2017-04-29T11:29:07Z,"According to Codex wp_filter_nohtml_kses( $data ) should only '''strip all of the HTML in the content'''. But it also escapes single quotes in plain text. Example: {{{#!php

Running `wpautop` on it incorrectly adds a misplaced `

` in there:

Same goes when the block element goes first then an inline element:


You get a misplaced `




",bfintal Old Tickets,40602,Implement immutable cache headers,programmin,Script Loader,,normal,normal,Awaiting Review,enhancement,new,,2017-04-29T00:01:18Z,2017-04-29T15:35:05Z,"When you have js files that will not change in a certain version of Wordpress, why not set the immutable cache that is enabled on various browsers? https://hacks.mozilla.org/2017/01/using-immutable-caching-to-speed-up-the-web/ For example this url should never change output unless user changed the wordpress version, in which case the ver= will change, forcing browser to load that url. /wp-admin/load-scripts.php?c=gzip&load%5B%5D=jquery-core,jquery-migrate,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,underscore,mediaelement,jquery-ui-sortable&ver=4.7.4",programmin Old Tickets,40598,PHP Fatal error: Call to a member function switch_to_locale() on null,hiheaven01,General,4.7.4,normal,normal,Awaiting Review,defect (bug),new,,2017-04-28T17:59:46Z,2017-04-28T17:59:46Z," Wordpress 4.7.4, WooCommerce 3.0.4. Please help. My front page won't display images of products, get this error in log: PHP Fatal error: Call to a member function switch_to_locale() on null in /nas/content/live/lhsupply/wp-includes/l10n.php on line 1277 ",hiheaven01 Old Tickets,40595,wp_authenticate_username_password() should respect WP_Error object generated by higher priorities,gilzow,Login and Registration,4.7.4,normal,normal,Awaiting Review,defect (bug),new,,2017-04-28T13:46:54Z,2017-04-28T13:59:39Z,"If I've read through #19714 but believe this issue should be reopened. This issue affects anyone who needs to alter the normal authentication process by hooking into the authenticate filter at a high priority. Functions in the process flow should respect a WP_Error object if that is what it is handed, including wp_authenticate_username_password(). '''Expected Behavior''' function hooks ''authenticate'' filter, assigns priority 10. Function invalidates authentication attempt and returns a WP_Error object. Authentication should fail and error message displayed to user. '''Current Behavior''' Function hooks ''authenticate'' filter, assigns priority 10. Function invalidates authentication attempt and returns a WP_Error object. wp_authenticate_username_password() ignores WP_Error object, attempts authentication and returns its own error message, or goes ahead and authenticates the user. Functions could assign a priority less than 20 (i.e. 30), but then when will be required to decipher error codes and/or the user object to then determine if authentication should continue, '''after''' an authentication attempt has already been processed by wp_authenticate_username_password(), even if no authentication should have been attempted. In additon, if wp_authenticate_username_password() is not going to respect WP_Errors from higher priorities, why not assign it a priority of 1 and make it the very first item in the authentication process? ",gilzow Old Tickets,40593,Media library replace image popup not displaying completely below 641px width,subrataemfluence,Media,4.7.4,normal,normal,Awaiting Review,defect (bug),new,,2017-04-28T10:04:38Z,2017-04-28T10:04:38Z,"When trying to Replace Media with screen width below 641px the right panel of the popup gets hidden and there is no way to update image information like description and title. Tested in Chrome (Version 58.0.3029.81 64-bit) and Firefox (53.0 - 64 bit). Screenshots attached.",subrataemfluence Old Tickets,40583,TinyMCE Paste Plugin Copy Paste Issue,swsdreams19,TinyMCE,4.7.4,normal,critical,Awaiting Review,defect (bug),new,,2017-04-26T20:43:41Z,2017-06-08T09:35:30Z,"I am using Annotum theme and for some reason tinyMCE editor doesn't allow me to paste content in custom post type. Here is the error: tinymce.min.js?ver=4506-20170408:12 Uncaught TypeError: n.$.contains is not a function at L.focus (tinymce.min.js?ver=4506-20170408:12) at Object.m [as execCommand] (tinymce.min.js?ver=4506-20170408:8) at L.execCommand (tinymce.min.js?ver=4506-20170408:12) at L.insertContent (tinymce.min.js?ver=4506-20170408:12) at s (plugin.min.js?wp-mce-4506-20170408:1) at Array. (plugin.min.js?wp-mce-4506-20170408:1) at Object.n [as each] (tinymce.min.js?ver=4506-20170408:3) at l (plugin.min.js?wp-mce-4506-20170408:1) at Object.u [as insertContent] (plugin.min.js?wp-mce-4506-20170408:1) at s (plugin.min.js?wp-mce-4506-20170408:1) If this is theme error just let me know, I see js links to wp-includes/js/ folder.",swsdreams19 Old Tickets,40582,"Capitalize character - ""CTRL + a"" -> ""CTRL + A""",Presskopp,Text Changes,4.7.4,normal,minor,Awaiting Review,enhancement,new,,2017-04-26T20:01:37Z,2017-04-26T20:15:21Z,,Presskopp Old Tickets,40571,PHP Notice error: Undefined index: hook_suffix,thamaraiselvam,General,4.7.4,normal,normal,Awaiting Review,defect (bug),new,,2017-04-26T06:51:47Z,2017-04-26T06:51:47Z,"I get this error on debug.log when WordPress installed on sub dir {{{ PHP Notice error: Undefined index: hook_suffix in /wordpress/subdir1/wp-admin/includes/class-wp-screen.php on line 229 }}} ",thamaraiselvam Old Tickets,40569,"next_post_link parameters $format and $link, have default values that produce awkward to use output",bhartlenn,Formatting,4.7.4,normal,normal,Awaiting Review,enhancement,new,,2017-04-26T02:45:16Z,2017-04-26T02:49:11Z,"The default output when using the default next_post_link() is: {{{
Post Title Linked here » }}} Note how the » is left outside of the linked text by default. I believe for most users this will cause a styling issue to fix as soon as you use this function, and otherwise, seems improper for a default output. I used next_post_link() with the following values to get what I think should be default output behavior {{{ next_post_link( ""%link"", ""%title »"" ); }}} Which outputs: {{{ Post Title Linked here » }}} Note that the » is now inside of the linked text, and any css applied to the next post link will also affect the » by default, and no changes to function parameters would be required by users. To implement this enhancement, I believe you would simply move the » into the default value for the $link parameter, and out of the $format parameter default value.",bhartlenn Old Tickets,40568,Add an action in WP_Error::add(),Shelob9,General,2.1,normal,normal,Awaiting Review,defect (bug),new,,2017-04-26T01:55:31Z,2017-04-26T02:11:33Z,"It would be very useful if when an error was added in WP_Error. Such an action would allow for the following: 1) Logging specific errors conditionally based on code. 2) A plugin that created a WP_Error log 3) Plugin developer could have an optional error logging feature for every time their plugin created a WP_Error object. ",Shelob9