__group__ ticket summary reporter component _version priority severity milestone type _status workflow _created modified _description _reporter 4-7 Days Ago 41416 styleselect no longer displaying webfont from editor style smerriman TinyMCE trunk normal normal Awaiting Review defect (bug) new reporter-feedback 2017-07-24T04:38:41Z 2017-07-24T10:36:13Z "Webfonts enqueued as an editor style no longer render in the styleselect dropdown. They definitely used to; perhaps a change in 4.8. Steps to replicate: - add in the styleselect dropdown and a simple style: {{{ add_filter('mce_buttons_2','my_mce_buttons_2'); function my_mce_buttons_2( $buttons ){ array_splice( $buttons, 0, 0, 'styleselect' ); return $buttons; } add_filter('tiny_mce_before_init', 'my_mce_mod'); function my_mce_mod( $init ) { $style_formats = array ( array( 'title' => 'Test', 'block' => 'p', 'classes'=>'test'), ); $init['style_formats'] = json_encode( $style_formats ); $init['style_formats_merge'] = false; return $init; } }}} - enqueue an editor style which uses font-face, and apply the styling to the test class. The font appears fine in the editor, but has a big ugly default in the styleselect dropdown. I'm hoping there is a solution to this that doesn't include having to repeat the whole font definition in wp-admin itself." smerriman Last Week 41388 Insert Media window does not remember state for custom tabs angel8888 General 4.8 normal normal Awaiting Review defect (bug) new reporter-feedback 2017-07-20T16:13:27Z 2017-07-28T14:34:28Z "Hi! I use Edd plugin (easy digital downloads) and Amazon S3 plugin (https://easydigitaldownloads.com/downloads/amazon-s3/). After WordPress update to 4.8, I have encounted problem with filling my downloadable files. I upload them via cyberduck and then create 5 instances of “add new price” – push “upload to file”, then – “Amazon S3 Library”. Before update I had to do so for first price – but next 4 prices pulled the path from the previous price – that was much easier and time-saving. Now – I need to enter whole path each time for each price. When I rollback to wordpress 4.7.5 – problem gone. Here is video that will describe my problem more clear – https://www.youtube.com/watch?v=GeaJrLYtMZI&authuser=0 I asked for help EDD team, but they say “'''''Unfortunately that issue is caused by a change in WordPress itself so is not something we can affect, sorry. It’s possible it was an accidental change with WordPress that will be resolved in a new update by the core WordPress team'''''.”" angel8888 Old Tickets 41335 dbDelta() does not recognize MySQL's IF NOT EXISTS statement kmaxim Upgrade/Install normal normal Awaiting Review enhancement new reporter-feedback 2017-07-15T12:24:51Z 2017-07-16T02:17:21Z "When a new table is creating with {{{IF NOT EXISTS}}} MySQL statement in query then array {{{$cqueries}}}(creational queries) will have invalid table names as keys. The keys of the array use below in the function's code for fetch the table column structure in {{{DESCRIBE}}} statement. Example query: {{{CREATE TABLE wp_delta_table...}}} The extracted table name: wp_delta_table Example query: {{{CREATE TABLE IF NOT EXISTS wp_delta_table...}}} The extracted table name: IF" kmaxim Old Tickets 41330 Auto complete TAG not working suryaaab Administration 4.8 normal normal Awaiting Review defect (bug) new reporter-feedback 2017-07-14T15:11:07Z 2017-07-14T16:30:07Z "[[Image([])]]I have 2 sites and since I updated WP (4.6) the auto complete TAG don´t work. In old times when I started writing the word tag a list of suggestion words appear, but now nothing happen. I updated do 4.8 but the problem continues. " suryaaab Old Tickets 41256 Core hardcoded translations sisalik I18N normal normal Awaiting Review feature request new reporter-feedback 2017-07-06T08:51:41Z 2017-07-21T10:06:20Z "There is so many hardcoded words/texts (""Search"", ""Search results for"", ""Tag"", ""Tags"", ""Category"", ""Categories"", ""Pages"" etc) in Wordpress templates (Pages, Posts, General). Instead of hardcoding, they should be in a language table/file. Wordpress needs a function that checks for a metatag ""hreflang"" or for a language tag in url (default ""en"" or empty). If any other language tag is found, then use a translation from the table, and if doesn't exist, then use default (en). This way it's easier to use other language translations or any translation plugins and add own languages. Else every Wordpress update might overwrite these hardcoded translations, that someone has written especially into code instead of English. Also if there would be an additional admin page to add languages to the table/file, this would make things much more easier. This is not a translation plugin! It is needed for Wordpress core, instead of template-hardcoded English." sisalik Old Tickets 41100 Cannot delete categories, plugins, themes when using Firefox 54 on Ubuntu 17.04 freudianslit Administration 4.8 normal normal Awaiting Review defect (bug) new reporter-feedback 2017-06-20T11:29:54Z 2017-06-20T12:11:47Z "Hi, Using Firefox 54.0+build3-0ubuntu0.17.04.1 I am unable to delete categories, plugins, or themes using wp-admin. I click delete and nothing happens. This bug does not occur on Chromium. Thanks! Adrienne" freudianslit Old Tickets 41089 Video Player Full screen issue without play mkrndmane External Libraries 4.8 normal normal Awaiting Review defect (bug) new reporter-feedback 2017-06-17T21:16:42Z 2017-06-18T10:59:55Z "''After embedding mp4 video on page and without playing'', I clicked on full screen button. Full screen does not work normally. '''It takes size inside browser width'''. Sometimes looks weird. [http://plugins.gallery/full-screen-bug/] [[BR]] ''After playing video'', clicked on full-screen button. Then video gets actual whole screen size.[[BR]] First I saw issue while working with WPLMS theme. To confirm where is bug I switched theme, updated all plugins and WordPress, issue not resolved.[[BR]] I tested video with theme twenty seventeen, issue exist there also.[[BR]] I have attached screenshots below. '''Twenty seventeen Theme''' [[Image(http://plugins.gallery/wp-content/uploads/2017/06/player-normal1.jpg)]] [[Image(http://plugins.gallery/wp-content/uploads/2017/06/player-after-fullscreen1-without-play.jpg)]] '''WPLMS theme''' [[Image(http://plugins.gallery/wp-content/uploads/2017/06/player-normal.jpg)]] [[Image(http://plugins.gallery/wp-content/uploads/2017/06/player-after-fullscreen.jpg)]] To try with only HTML code, Took mediaelement folder from wp-includes and created index.html file to check issue, same issue happens. I have paste code below.[[BR]] I think there might be issue in wp-mediaelement.min.css OR wp-mediaelement.min.js[[BR]] {{{ Untitled Document
}}} " mkrndmane Old Tickets 41002 I do not work this type of link with the last update zontir TinyMCE 4.8 normal normal Awaiting Review defect (bug) new reporter-feedback 2017-06-11T18:28:37Z 2017-07-22T16:59:41Z "Hello everyone! I hope they are well. I am here because I present some problems with the links of shink.in When you have any of them in the clipboard and select a text by pressing the ""Ctrl + V"" key combination, the text is replaced and not linked. With any other url the simple text becomes hyperlink when pressing that combination of keys ... Also the clicks of this address are shown in the statistics of Jetpack. I have also had problems when paste text without formatting with the combination of keys Ctrl + Shift + V. Before the text was pasted without format but respected the breaks of lines ... Now when to paste a text of this way autistically eliminates all The jumps of line and fence that is tedious put to place all the jumps of line when it is a long paragraph. I hope you can solve these small problems. A greeting!" zontir Old Tickets 40996 Category's won't load BlijdorperB Taxonomy 4.8 normal normal Awaiting Review defect (bug) new reporter-feedback 2017-06-10T17:41:45Z 2017-06-10T19:34:25Z "In version 4.8 of WordPress, whenever you press one of the categories you get taken to an empty page on the website. [[Image(http://i.imgur.com/vOWIOE0.png)]]" BlijdorperB Old Tickets 40994 Latest update broke full justification seasoned_geek Editor 4.8 normal normal Awaiting Review defect (bug) new reporter-feedback 2017-06-10T16:16:51Z 2017-06-12T04:30:29Z I just applied the latest WordPress update (4.8.x I believe) and full justification of text has been broken. I used to be able to hand edit in the tag, but now it is just ignored. seasoned_geek Old Tickets 40989 Image Widget not working in wp 4.8 imranaliweb Widgets 4.8 normal normal Awaiting Review defect (bug) new reporter-feedback 2017-06-10T09:19:32Z 2017-07-24T21:56:05Z Not working image widget link in WordPress 4.8 imranaliweb Old Tickets 40964 Wordpress 4.8 Pasting into editor functionality changed AngusMcKinnon Editor 4.8 normal normal Awaiting Review defect (bug) new reporter-feedback 2017-06-09T05:43:45Z 2017-06-17T03:40:12Z "Hi there, With 4.8 the paste functionality seems to have changed in the visual editor. When I paste a list of items into the 4.8 visual editor from a text editor it now strips all ""line breaks"" and I end up with one big paragraph. I can still paste the list in text view and switch back to visual view and it keeps the line breaks. This has changed in this new version. I do this process as a daily activity. " AngusMcKinnon Old Tickets 40920 WP 4.8 allows uploading SVG images from the image widget saqali Media 4.8 normal normal 4.9 defect (bug) new reporter-feedback 2017-06-04T19:21:27Z 2017-07-12T03:44:59Z "Uploaded an SVG to the new image widget, it works but spits out a bunch of php code error, I thin it's because there's no where for me to set the height and width to ` 'flex-width' => true, 'flex-height' => true, ` ` ( ! ) Warning: Illegal string offset 'width' in C:\Users\Saqib\Documents\Websites\example.dev\wp-includes\media.php on line 988 Call Stack # Time Memory Function Location 1 0.0024 202880 {main}( ) ..\index.php:0 2 0.0027 204912 require( 'C:\Users\Saqib\Documents\Websites\example.dev\wp-blog-header.php' ) ..\index.php:17 3 0.8348 38631736 require_once( 'C:\Users\Saqib\Documents\Websites\example.dev\wp-includes\template-loader.php' ) ..\wp-blog-header.php:19 4 0.8389 38729704 include( 'C:\Users\Saqib\Documents\Websites\example.dev\wp-content\themes\genesis\single.php' ) ..\template-loader.php:74 5 0.8389 38729768 genesis( ) ..\single.php:15 6 1.0412 39602808 do_action( ) ..\framework.php:45 7 1.0412 39603240 WP_Hook->do_action( ) ..\plugin.php:453 8 1.0412 39603288 WP_Hook->apply_filters( ) ..\class-wp-hook.php:323 9 1.0412 39603792 call_user_func_array:{C:\Users\Saqib\Documents\Websites\example.dev\wp-includes\class-wp-hook.php:298} ( ) ..\class-wp-hook.php:298 10 1.0412 39603992 genesis_get_sidebar( ) ..\class-wp-hook.php:298 11 1.0413 39604064 get_sidebar( ) ..\layout.php:211 12 1.0413 39604456 locate_template( ) ..\general-template.php:122 13 1.0415 39604616 load_template( ) ..\template.php:647 14 1.0418 39614912 require_once( 'C:\Users\Saqib\Documents\Websites\example.dev\wp-content\themes\genesis\sidebar.php' ) ..\template.php:688 15 1.0549 39615600 do_action( ) ..\sidebar.php:22 16 1.0549 39616040 WP_Hook->do_action( ) ..\plugin.php:453 17 1.0549 39616088 WP_Hook->apply_filters( ) ..\class-wp-hook.php:323 18 1.0549 39616592 call_user_func_array:{C:\Users\Saqib\Documents\Websites\example.dev\wp-includes\class-wp-hook.php:298} ( ) ..\class-wp-hook.php:298 19 1.0550 39616888 blox_frontend_content ( ) ..\class-wp-hook.php:298 20 1.0550 39617088 Blox_Action_Storage->__call( ) ..\class-wp-hook.php:0 21 1.0550 39617120 call_user_func:{C:\Users\Saqib\Documents\Websites\example.dev\wp-content\plugins\blox-master\includes\global\action-storage.php:47} ( ) ..\action-storage.php:47 22 1.0550 39617136 blox_frontend_content( ) ..\action-storage.php:47 23 1.0551 39617672 do_action( ) ..\frontend.php:383 24 1.0551 39618736 WP_Hook->do_action( ) ..\plugin.php:453 25 1.0551 39618784 WP_Hook->apply_filters( ) ..\class-wp-hook.php:323 26 1.0551 39619288 call_user_func_array:{C:\Users\Saqib\Documents\Websites\example.dev\wp-includes\class-wp-hook.php:298} ( ) ..\class-wp-hook.php:298 27 1.0552 39619696 Blox_Widgets_Main->print_widgets_content( ) ..\class-wp-hook.php:298 28 1.0556 39638112 call_user_func:{C:\Users\Saqib\Documents\Websites\example.dev\wp-content\plugins\blox-widgets\blox-widgets.php:368} ( ) ..\blox-widgets.php:368 29 1.0556 39638208 Blox_Widgets_Main->blox_display_widgets( ) ..\blox-widgets.php:368 30 1.0557 39641360 call_user_func_array:{C:\Users\Saqib\Documents\Websites\example.dev\wp-content\plugins\blox-widgets\blox-widgets.php:467} ( ) ..\blox-widgets.php:467 31 1.0557 39641688 WP_Widget->display_callback( ) ..\blox-widgets.php:467 32 1.0559 39647480 WP_Widget_Media->widget( ) ..\class-wp-widget.php:395 33 1.0580 39653168 WP_Widget_Media_Image->render_media( ) ..\class-wp-widget-media.php:226 34 1.0614 39654320 _wp_get_image_size_from_meta( ) ..\class-wp-widget-media-image.php:208 ( ! ) Warning: Illegal string offset 'height' in C:\Users\Saqib\Documents\Websites\example.dev\wp-includes\media.php on line 989 Call Stack # Time Memory Function Location 1 0.0024 202880 {main}( ) ..\index.php:0 2 0.0027 204912 require( 'C:\Users\Saqib\Documents\Websites\example.dev\wp-blog-header.php' ) ..\index.php:17 3 0.8348 38631736 require_once( 'C:\Users\Saqib\Documents\Websites\example.dev\wp-includes\template-loader.php' ) ..\wp-blog-header.php:19 4 0.8389 38729704 include( 'C:\Users\Saqib\Documents\Websites\example.dev\wp-content\themes\genesis\single.php' ) ..\template-loader.php:74 5 0.8389 38729768 genesis( ) ..\single.php:15 6 1.0412 39602808 do_action( ) ..\framework.php:45 7 1.0412 39603240 WP_Hook->do_action( ) ..\plugin.php:453 8 1.0412 39603288 WP_Hook->apply_filters( ) ..\class-wp-hook.php:323 9 1.0412 39603792 call_user_func_array:{C:\Users\Saqib\Documents\Websites\example.dev\wp-includes\class-wp-hook.php:298} ( ) ..\class-wp-hook.php:298 10 1.0412 39603992 genesis_get_sidebar( ) ..\class-wp-hook.php:298 11 1.0413 39604064 get_sidebar( ) ..\layout.php:211 12 1.0413 39604456 locate_template( ) ..\general-template.php:122 13 1.0415 39604616 load_template( ) ..\template.php:647 14 1.0418 39614912 require_once( 'C:\Users\Saqib\Documents\Websites\example.dev\wp-content\themes\genesis\sidebar.php' ) ..\template.php:688 15 1.0549 39615600 do_action( ) ..\sidebar.php:22 16 1.0549 39616040 WP_Hook->do_action( ) ..\plugin.php:453 17 1.0549 39616088 WP_Hook->apply_filters( ) ..\class-wp-hook.php:323 18 1.0549 39616592 call_user_func_array:{C:\Users\Saqib\Documents\Websites\example.dev\wp-includes\class-wp-hook.php:298} ( ) ..\class-wp-hook.php:298 19 1.0550 39616888 blox_frontend_content ( ) ..\class-wp-hook.php:298 20 1.0550 39617088 Blox_Action_Storage->__call( ) ..\class-wp-hook.php:0 21 1.0550 39617120 call_user_func:{C:\Users\Saqib\Documents\Websites\example.dev\wp-content\plugins\blox-master\includes\global\action-storage.php:47} ( ) ..\action-storage.php:47 22 1.0550 39617136 blox_frontend_content( ) ..\action-storage.php:47 23 1.0551 39617672 do_action( ) ..\frontend.php:383 24 1.0551 39618736 WP_Hook->do_action( ) ..\plugin.php:453 25 1.0551 39618784 WP_Hook->apply_filters( ) ..\class-wp-hook.php:323 26 1.0551 39619288 call_user_func_array:{C:\Users\Saqib\Documents\Websites\example.dev\wp-includes\class-wp-hook.php:298} ( ) ..\class-wp-hook.php:298 27 1.0552 39619696 Blox_Widgets_Main->print_widgets_content( ) ..\class-wp-hook.php:298 28 1.0556 39638112 call_user_func:{C:\Users\Saqib\Documents\Websites\example.dev\wp-content\plugins\blox-widgets\blox-widgets.php:368} ( ) ..\blox-widgets.php:368 29 1.0556 39638208 Blox_Widgets_Main->blox_display_widgets( ) ..\blox-widgets.php:368 30 1.0557 39641360 call_user_func_array:{C:\Users\Saqib\Documents\Websites\example.dev\wp-content\plugins\blox-widgets\blox-widgets.php:467} ( ) ..\blox-widgets.php:467 31 1.0557 39641688 WP_Widget->display_callback( ) ..\blox-widgets.php:467 32 1.0559 39647480 WP_Widget_Media->widget( ) ..\class-wp-widget.php:395 33 1.0580 39653168 WP_Widget_Media_Image->render_media( ) ..\class-wp-widget-media.php:226 34 1.0614 39654320 _wp_get_image_size_from_meta( ) `" saqali 2 Days Ago 41463 Improve REST API tests that don't perform any assertions johnbillion REST API 4.7 normal normal 4.9 enhancement accepted needs-unit-tests 2017-07-27T18:02:35Z 2017-07-27T19:03:46Z "There are a bunch of REST API tests that don't perform any assertions. This creates noise in the test results as they get marked as risky tests. These tests are present because their test class extends the abstract `WP_Test_REST_Controller_Testcase` class, which requires several methods to be implemented which don't make sense for all REST API routes. These tests can be improved so they do actually perform assertions related to their behaviour." johnbillion 2 Days Ago 41457 WP_REST_Comments_Controller::check_read_post_permission() counts an uncountable value johnbillion Comments 4.7 normal normal 4.9 defect (bug) new needs-unit-tests 2017-07-27T16:43:18Z 2017-07-28T13:55:47Z "From #40109. In `WP_REST_Comments_Controller::check_read_post_permission()`, `count()` is called on `$request['post']`, but the value of this variable isn't always countable. This causes a warning in PHP 7.2. From some testing, `$request['post']` can be an integer, an empty array, an array of integers, or null. All of these types need to be accounted for in this method's logic." johnbillion 3 Days Ago 41453 Users with no role on a site on a multisite network see inaccessible links in the admin toolbar johnbillion Users 3.0 normal normal 4.9 defect (bug) new needs-unit-tests 2017-07-26T23:52:46Z 2017-07-27T00:26:07Z "Previously, for single site installations: #25162 A user who is a member of a site on a multisite network but has no role on the site will encounter mostly the same problems as those which were fixed for single site users in #25162: * An immediate ""You do not have sufficient permissions"" error upon logging in. * An admin toolbar link to `My Sites`, which they cannot access. * An admin toolbar link to their profile, which they cannot edit. * An admin toolbar submenu link to the `Dashboard` of their site, which they cannot access. * A link to the `Dashboard` from `My Sites`, which they cannot access (if they're a member of at least one site with a role)." johnbillion 3 Days Ago 41451 Use pretty permalinks by default in the test suite johnbillion Build/Test Tools normal normal Awaiting Review enhancement new needs-unit-tests 2017-07-26T21:16:09Z 2017-07-27T01:22:17Z "There are 118 instances of `$this->set_permalink_structure( ... )` in the test suite. The majority of these calls are present simply to enable pretty permalinks, regardless of the permastructure for posts. Pretty permalinks should be enabled by default for the test suite. Let's try it and see if anything breaks." johnbillion Last Week 41370 REST API: Attempting to create an existing term yields HTTP 500 jnylen0 REST API 4.7 normal normal Future Release defect (bug) new needs-unit-tests 2017-07-19T13:41:30Z 2017-07-26T19:45:36Z "Reported at https://github.com/WordPress/gutenberg/pull/1490. I haven't had time to investigate yet, but this should be a fairly quick win. HTTP 5xx error codes should be reserved for unexpected server errors like database failures, out of memory, etc. This one should be `400 Bad Request` or maybe `409 Conflict` instead." jnylen0 Last Week 41357 test_comment_query_should_be_cached() doesn't perform an assertion johnbillion Comments 4.6 normal normal Awaiting Review defect (bug) new needs-unit-tests 2017-07-18T14:44:26Z 2017-07-18T14:44:26Z "The unit test `Tests_Comment_Query::test_comment_query_should_be_cached()` isn't complete and doesn't perform an assertion. Introduced in [37608] for #36906. cc @boonebgorges" johnbillion Old Tickets 41318 list_files() function bug Tkama Filesystem API 4.8 normal normal Future Release enhancement new needs-unit-tests 2017-07-14T01:41:06Z 2017-07-26T19:51:16Z "If we set first parameter of `list_files( $folder )` with trailing slash, we get incorrect paths in result. Example: {{{#!php /home/t/tkamab32/wp-kama.ru/public_html//xmlrpc.php [1] => /home/t/tkamab32/wp-kama.ru/public_html//wp-mail.php [2] => /home/t/tkamab32/wp-kama.ru/public_html//wp-includes/ms-settings.php ... */ }}} We see double slash `//` in path... Maybe better to filter incoming $folder parametr with `untrailingslashit()`: {{{#!php is_embed`: boolean property indicating whether the request is a ""child"" embedded request - `$request->embed_parent`: `WP_REST_Request` object pointing to parent request, or `null` if none" jnylen0 Old Tickets 41064 Registered and last edited dates on new sites should be identical desrosj Networks and Sites normal normal Awaiting Review defect (bug) new needs-unit-tests 2017-06-15T12:15:52Z 2017-06-15T17:24:52Z "In testing #40035, I discovered that depending on how long the creation process takes for a new site, the last updated and registered date could be different by up to several seconds. Ideally, this should always be identical when a new site is created. Besides it potentially being confusing to a user, I have two use cases for this. 1. It is impossible to write a test for #40035 without these dates being guaranteed the same. 2. A good way to identify sites that were abandoned after creation would be to compare the registered and last updated dates. If these are not guaranteed to be the same this would become more difficult." desrosj Old Tickets 41055 WP-API JS Client: Improve support for meta adamsilverstein General 4.7 normal normal 4.9 enhancement assigned needs-unit-tests 2017-06-15T08:08:42Z 2017-06-16T12:02:17Z "The wp.api JavaScript client support for meta needs some attention: * Meta helper isn't available for comments, terms and users * Meta pieces haven't been updated for the new-style meta model The `getMeta` helper should work correctly for all object types that support meta. We should also consider adding a matching `setMeta` helper. See https://github.com/WP-API/client-js/issues/168." adamsilverstein Old Tickets 40922 Use finer-grained capabilities with `customize_changeset` post type dlh Customize 4.7 normal normal 4.9 enhancement new needs-unit-tests 2017-06-05T04:44:01Z 2017-07-28T02:21:27Z "The `customize_changeset` post type is currently registered with all of its post type capabilities set to `customize`. As part of adding changeset endpoints in the REST API (#38900): > fine-grained capabilities should be introduced for the `customize_changeset` post `caps`, instead of mapping all to `customize`. @westonruter has compiled links to previous discussions and efforts around changeset capabilities here: https://github.com/WP-API/wp-api-customize-endpoints/pull/5#discussion_r118804994. An example of unexpected behavior caused by the current mapping is where a post ID is passed to `current_user_can()`, such as {{{ current_user_can( get_post_type_object( 'customize_changeset' )->cap->edit_post, $changeset_post_id ) }}} This is equivalent to `current_user_can( 'customize' )`, which means the post ID is ignored because `map_meta_cap()` doesn't check the `$args` when mapping the `'customize'` meta cap." dlh Old Tickets 40889 REST API: New terms creation with meta causes PHP Notice caercam REST API 4.7 normal normal Awaiting Review defect (bug) new needs-unit-tests 2017-05-30T23:29:06Z 2017-07-10T08:09:22Z "Creating new terms with the REST API works fine, as long as there is no meta attached: {{{ POST https://localhost:8080/wp-json/wp/v2/categories X-WP-Nonce: 1234567890 Content-Type: application/json {""name"":""A new category"",""description"":""This is a new category."",""meta"":{""custom_meta"":""Custom Meta Value""}} -- response -- 403 Forbidden
Notice: Undefined property: WP_Error::$taxonomy in /var/www/wp47/wp-includes/capabilities.php on line 282
{""code"":""rest_cannot_update"",""message"":""Sorry, you are not allowed to edit the custom_meta custom field."",""data"":{""key"":""custom_meta"",""status"":403}} }}} For the record, here's what happens as far as I can tell. Probably more detailled than what's really needed, but there's two different issues here so I'd rather be precise. 1. `WP_REST_Terms_Controller::create_item()` calls `WP_REST_Meta_Fields::update_value()` with two arguments: `$request['meta']`, which is what we want, and `$request['id']`, which at this point is `null`, because we are creating a new term, not editing an existing one. 2. `WP_REST_Meta_Fields::update_value()` loops through the registered meta keys and calls `WP_REST_Meta_Fields::update_meta_value()` or `WP_REST_Meta_Fields::update_multi_meta_value()`. 3. Because `WP_REST_Terms_Controller::create_item()` casted as integer an ID that does not exist, both meta_value update methods get a `$object_id` = `0`, and use that value to check for permission to edit meta. 4. Now it's capabilities fairy: `current_user_can()` calls `WP_User::has_cap()` which calls `map_meta_cap()` which checks for the term existence with a simple boolean test on the result of `get_term()`. 5. But, because of `$object_id` value being `0`, `get_term()` returns a `WP_Error` instance, the check mentionned in 4. fails, and we get the ""Undefined property"" notice that end up in the REST API request response. TL;DR: Two issues here: 1. `WP_REST_Terms_Controller::create_item()` passes an unexisting value to the meta_value upate methods, indirectly triggering a bug in `map_meta_cap()`; 2. `map_meta_cap()` does not break as it should if `get_term()` returns an error." caercam Yesterday 41475 TinyMCE switches to on deleted, then replaced text cainm TinyMCE 4.3 normal normal Awaiting Review defect (bug) new has-patch 2017-07-28T15:21:02Z 2017-07-29T09:52:12Z "=== Steps to reproduce === 1. Go to the visual editor or the new TinyMCE text widget. 2. Write some text. Highlight it and use TinyMCE to make it bold. 3. View Text mode - TinyMCE correctly used for bolding. 4. Return to Visual mode, highlight bolded text, //delete//, then replace text.* 5. View Text mode - TinyMCE switched `` to ``. *If you just replace the bolded text without deleting first, `` is still used. === Expected === The same tag (``) should be used when deleting and replacing TinyMCE bolded text. === Actual === `` is correctly used for general replacing of TinyMCE bolded text, except when text is fully deleted before being replaced. === Browser / OS version === Chrome 59.0.3071.115 / macOS Sierra 10.12.6 === Video === https://cloudup.com/i0I4EEt1TiG Possibly related: #6026 Additional note: Similar issue in Gutenberg, although `` is used instead of ``. Opening a separate issue in the Gutenberg repo." cainm 3 Days Ago 41452 Remove @access tags from core DocBlocks DrewAPicture General normal normal 4.9 task (blessed) accepted has-patch 2017-07-26T23:43:26Z 2017-07-27T15:49:51Z "Per discussion in #core-docs last week, we're finally to the point where we can remove `@access` notations from DocBlocks throughout core, with a few exceptions: * Any standalone core functions marked private * Any classes marked private (such as the List Table classes, for instance) The [https://github.com/WordPress/phpdoc-parser parser] that builds the [https://developer.wordpress.org/reference/ Code Reference] already references actual method visibility as derived with phpDocumentor, meaning that output will be unchanged following the removals. In terms of anything marked private (including the aforementioned exceptions) the Code Reference theme already handles displaying a specially-designed callout box." DrewAPicture 4-7 Days Ago 41426 Admin: Password protected text class in the posts list slaFFik Administration trunk normal normal Future Release enhancement new has-patch 2017-07-24T17:55:32Z 2017-07-26T13:56:19Z "Password protected posts (and CPTs) have this text as a fallback for excerpt in the list of posts: {{{ There is no excerpt because this is a protected post. }}} They should have a proper span with a class like `.post-password-state`, like it's done with ""Password protected"" text and its `.post-state`. This will allow to better customize the styles of the screen." slaFFik 4-7 Days Ago 41425 Killing phpunit may result in a broken database bobbingwide Build/Test Tools trunk normal normal Awaiting Review enhancement new has-patch 2017-07-24T15:50:00Z 2017-07-24T16:23:19Z "While running phpunit for wordpress-develop under Windows I hit ctrl-break during the Install processing. The next time I ran phpunit it didn't work. === Actual output === ""Error establishing a database connection""

One or more database tables are unavailable. The database may need to be repaired.

=== Expected output === The install routine should drop and recreate the tables during Install === Explanation === The process was killed after the wp_options table was dropped but before wp_install() had completed. === Workaround === Either change $table_prefix in wp-tests-config.php or drop all the other tables that are missing and re-run. " bobbingwide 4-7 Days Ago 41419 needs documents improvement upadalavipul Users normal normal Awaiting Review defect (bug) new has-patch 2017-07-24T07:02:02Z 2017-07-24T09:50:48Z the static function is defined in the code file but not mention in the documentation of the function. upadalavipul 4-7 Days Ago 41411 REST API: Terms endpoint responses for PUT & POST requests don't set context to edit westonruter REST API 4.7 normal normal Awaiting Review defect (bug) new has-patch 2017-07-23T06:48:12Z 2017-07-23T06:48:43Z The endpoints for posts, users, and comments all set the `context` to `edit` when returning the resource in the response for POST and PUT requests. The terms endpoint, however, unexpectedly returns the resource with the `view` context. In practice this won't cause a problem since all of the fields (in core) have both the `view` and `edit` contexts, but if a plugin adds additional fields that should only appear in the `edit` context then this could cause a problem where the unexpected fields would be returned in the response. westonruter Last Week 41407 Updating a plugin from the Plugin Install Screen throws a JavaScript error imath Upgrade/Install trunk normal normal 4.9 defect (bug) reviewing has-patch 2017-07-22T15:02:54Z 2017-07-22T17:15:22Z "Hi, `/wp-admin/js/updates.js` when refreshing the screen to decrement the count needs `window._wpUpdatesItemCounts` to be set. This is done using `wp_localize_script()` in the regular plugins list table. But this is not done in the plugin *install* list table. When going into the Plugin Install screen having a plugin to upgrade we get this : [[Image(https://cldup.com/U0tmTYg-Dr.png)]] If from there i click on the ""Update Now"" button, i get this result : [[Image(https://cldup.com/NWin8FrfHg.png)]] The plugin is updated, but the screen is not refreshed. Bubbles in the WP Admin Bar and in the menu still show there's one plugin to upgrade. [[Image(https://cldup.com/bwTZrH0S9G.png)]] And there's actually a JavaScript error because `window._wpUpdatesItemCounts` is undefined. Using the patch i'm adding to this ticket, it's solving the issue. " imath Last Week 41402 Needs documentation improvement nileshdudakiya94 General normal normal Awaiting Review defect (bug) new has-patch 2017-07-21T18:02:29Z 2017-07-21T18:03:41Z The statics variables are use in the functions but not mention in documentation of the function. nileshdudakiya94 Last Week 41401 Needs documentation improvement nileshdudakiya94 General normal normal Awaiting Review defect (bug) new has-patch 2017-07-21T17:47:09Z 2017-07-21T17:48:33Z The static function is define but not mention in documentation of the function. nileshdudakiya94 Last Week 41400 Needs documentation improvement nileshdudakiya94 Mail normal normal Awaiting Review defect (bug) new has-patch 2017-07-21T17:21:07Z 2017-07-21T17:43:52Z The static variable $streamok use in the function but not mention in documentation of the function. nileshdudakiya94 Last Week 41399 Needs documentation improvement nileshdudakiya94 General normal normal Awaiting Review defect (bug) new has-patch 2017-07-21T17:11:28Z 2017-07-21T17:12:44Z The static variable $ini_all use in the function but not mention in documentation of the function. nileshdudakiya94 Last Week 41387 Avoid 403's from AJAX requests from postbox.js bobbingwide Administration trunk normal normal Awaiting Review defect (bug) new has-patch 2017-07-20T15:34:23Z 2017-07-20T17:04:14Z "While making some improvements to a plugin's admin pages I changed the HTML in my meta boxes to be more inline with WordPress core. I then noticed that I was getting 403's from the closed-postboxes AJAX request each time I toggled the display of the postbox. Since I don't have a requirement for the open/closed state of my postboxes to persist I don't need the AJAX requests. Consequently I don't have a #closedpostboxesnonce. So, to avoid the 403's I changed postbox.js to not perform the AJAX request if the nonce isn't set. " bobbingwide Last Week 41380 Documentation needs improvement. ronakganatra HTTP API normal normal Awaiting Review defect (bug) new has-patch 2017-07-20T12:03:14Z 2017-07-22T11:55:21Z Documentation needs improvement.parameter passed but not defined. ronakganatra Last Week 41351 Searching for a category returns nothing if category is empty jackjohansson Menus normal normal Awaiting Review defect (bug) new has-patch 2017-07-17T21:53:56Z 2017-07-22T00:47:59Z "Hi, In the navigation menu creation page, when you are trying to add a category to the menu, if the category is empty, it won't show up in the search results. However, if the category itself is empty but has a child that is not empty, it will still be shown. I have a blog with over 500 categories, and I'm trying to add some of them to the menu but they have no posts yet. Navigating through category list is going to take time, and is also frustrating. Now I've tracked down the issue to `/wp-admin/includes/nav-menu.php`, ( starting at line 588 ) but can't find a filter or hook to do so. This line (109) seems to be responsible for doing the search: {{{ $terms = get_terms( $matches[2], array( 'name__like' => $query, 'number' => 10, )); }}} According to the documentations, this function accepts an argument for showing empty terms 'hide_empty' => false, but I can't see such option in this part of core's code. I've added this option to the core (temporarily) to see if it solves the issue, and it does. The other `get_term()` functions withing this template file mostly use `'hide_empty' => false` so I'm not sure either this one was overlooked or not, I tagged this as a bug though." jackjohansson Last Week 41348 Improved caching on WP_Comment_Query spacedmonkey General 3.1 normal normal Awaiting Review enhancement reviewing has-patch 2017-07-17T17:39:06Z 2017-07-17T19:33:15Z As WP_Site_Query are based on the WP_Comment_Query, changes that are found in #41197 can also be applied to WP_Comment_Query spacedmonkey Old Tickets 41339 WP_Comments_Query::__construct() should allow a 'status__not_in' parameter pbiron Comments trunk normal normal Awaiting Review enhancement new has-patch 2017-07-15T19:47:02Z 2017-07-15T20:00:47Z "`WP_Comments_Query::__construct()` (and hence, `get_comments()`) currently allows a `status` parameter to get comments with a specific status. It would be useful to also allow `$status__not_in` to exclude comments with specific stati. Related: #41338" pbiron Old Tickets 41338 description of $status parameter in WP_Comment_Query::__construct() is incorrect pbiron Comments trunk normal normal Awaiting Review defect (bug) new has-patch 2017-07-15T19:26:58Z 2017-07-17T13:46:22Z "The description of the `$status` parameter suggests that only a single status can be provided. However, `WP_Comment_Query::get_comment_ids()` treats it as an array of stati (either a true array or a space/comma separated list). The description should be updated to reflect this." pbiron Old Tickets 41336 Changeset saved with `publish` status and future date is not scheduled dlh Customize 4.7 normal normal Awaiting Review defect (bug) new has-patch 2017-07-15T17:09:55Z 2017-07-15T17:09:55Z "The behavior of `WP_Customize_Manager::save_changeset_post()` differs from `wp_insert_post()` in how it handles a post date in the future with a post status of `publish`. `wp_insert_post()` will keep the date and change the post status to `future`: https://github.com/WordPress/WordPress/blob/4.8-branch/wp-includes/post.php#L3161 whereas `save_changeset_post()` resets the date and publishes the changeset immediately: https://github.com/WordPress/WordPress/blob/4.8-branch/wp-includes/class-wp-customize-manager.php#L2510 I found this difference unexpected, although I apologize if I've overlooked discussions about it. The attached patches propose different updates to `save_changeset_post()` that would try to reduce the discrepancy. One patch would switch the changeset status from `publish` to `future` when the changeset date is in the future, in the style of `wp_insert_post()`. The other would return a `WP_Error` to at least prevent the changeset from being published immediately. " dlh Old Tickets 41322 Needs improvements in the documentation of the function ajayghaghretiya1 Editor normal normal Awaiting Review defect (bug) new has-patch 2017-07-14T09:28:58Z 2017-07-18T12:14:58Z bool $default_scripts passed as a parameter in the function but not mention in the documentation of the function. ajayghaghretiya1 Old Tickets 41319 needs documents improvement upadalavipul Editor normal normal Awaiting Review defect (bug) new has-patch 2017-07-14T06:55:13Z 2017-07-18T12:17:32Z the static function is defined in the code file but not mention in the documentation of the function. upadalavipul Old Tickets 41317 Consistent submenu item spacing when count indicator is present pauldechov Administration normal normal 4.9 enhancement assigned has-patch 2017-07-14T00:40:22Z 2017-07-19T19:33:23Z "The ""awaiting-mod"" count indicator looks good and doesn't affect top-level menu items, but causes inconsistent spacing with submenu items: https://cloudup.com/cF_VyRXScwF https://core.trac.wordpress.org/browser/trunk/src/wp-admin/css/admin-menu.css#L527 Possible fix: {{{ #adminmenu .wp-submenu .awaiting-mod, #adminmenu .wp-submenu .update-plugins { margin-top: 0; margin-bottom: -2px; } }}} Results in consistent spacing among submenu items: https://cloudup.com/cr4DtYq4lWS " pauldechov Old Tickets 41314 If the required fields are not set on user profile's save, every field's value will be dropped jackjohansson Users 4.8 normal normal Awaiting Review defect (bug) new has-patch 2017-07-13T17:43:36Z 2017-07-22T10:49:39Z "Hi, In the user profile screen, there are some required fields such as email and nickname. Let's say I have added some extra fields using `edit_user_profile` and `show_user_profile` action hooks. These fields are filled by the user, and do not have to be required. If the user fills every field (let's say 20 fields, took 10 minutes to fill) but clears the email field and save the form, there will be shown an admin error: '''ERROR''': Please enter an email. Every field that was filled by the user will be dropped, and has to be refilled. The point is, until the required fields are empty, there is no reason to let the user save the form in the first place. This issue has been discussed in the WordPress Development StackExchange. I've posted 3 solutions for this issue, which can be improvement or bug resolve. Below is a link to the question on WPSE. I would be happy to write an accurate solution, in case the development team decides to push this into their future patches. https://wordpress.stackexchange.com/q/272940/94498 King regards, Jack" jackjohansson Old Tickets 41305 Add lazily evaluated translations schlessera I18N 4.8 normal normal Awaiting Review enhancement new has-patch 2017-07-13T11:16:56Z 2017-07-14T06:18:06Z "In the context of #40988, I did a few performance tests and experimented with adding a lazily evaluated translation object. The general principle is this: Instead of returning the resulting string of a translation, return an object for which the `__toString()` and `jsonSerialize()` methods will fetch the resulting string instead. I tested by having the `__()` method return such a proxy object, instead of the actual translated string. From a quick profiling run on `wptrunk.dev/wp-json/wp/v2/posts`, I got the following results: Returning a `translate()` from `__()`: {{{ Wall Time 162ms CPU Time 157ms I/O Time 5.48ms Memory 16.5MB Network n/a n/a n/a SQL 4.41ms 13rq }}} Returning a `TranslationProxy` from `__()`: {{{ Wall Time 144ms -19ms -14.9% CPU Time 138ms -18ms -15.4% I/O Time 5.33ms -154µs -3.0% Memory 16.6MB +81.6KB n/s Network n/a n/a n/a SQL 4.33ms 13rq }}} As you can see, this shaved off almost 15% from this simple request. It saved 2255 calls to `translate()`, 2157 calls to `get_translations_for_domain()` and, more importantly still, 2156 calls to `apply_filters()` (which could involve a lot of additional processing in some cases). The main problem with this approach is that WordPress does not contain real type-hinting, so BC is broken wherever the proxy is not echoed, but used directly. As we cannot possibly foresee how plugins might use their localized strings, I suggest adding new lazy variations of the translation functions. To mirror the ""echo"" variations that prefix the translation functions with an `e`, I'd suggest using the `l` prefix for these variations: {{{#!php // Lazily retrieve the translation of $text. _l( $text , $domain = 'default' ); // Lazily retrieve the translation of $text and escape it for safe use in an attribute. esc_attr_l( $text, $domain = 'default' ); // Lazily retrieve the translation of $text and escape it for safe use in HTML output. esc_html_l( $text, $domain = 'default' ); // Lazily retrieve translated string with gettext context. _lx( $text, $context, $domain = 'default' ); // Lazily translate string with gettext context, and escape it for safe use in an attribute. esc_attr_lx( $text, $context, $domain = 'default' ); // Lazily translate string with gettext context, and escape it for safe use in HTML output. esc_html_lx( $text, $context, $domain = 'default' ); }}} Arbitrary testing has shown that using such lazily evaluated translations strategically can improve the performance by 10-30% for certain scenarios. Implementing them in this BC fashion allows us to fine-tune Core usage and make it available to plugins, while playing it safe with existing code." schlessera Old Tickets 41288 wp admin bar WordPress about and updates icon can't show in Smartphone. mp518 Toolbar trunk normal normal Awaiting Review enhancement new has-patch 2017-07-11T09:26:39Z 2017-07-21T09:16:40Z WordPress admin side WordPress about and Updates can't show in smartphone it should be display none in Very narrow screens.that can be helpfully for smartphone user. mp518 Old Tickets 41285 Remove $site_id and $public multisite globals that are no longer used earnjam Networks and Sites normal normal 4.9 defect (bug) new has-patch 2017-07-10T18:13:17Z 2017-07-20T10:34:23Z "As @jeremyfelt noted in [https://core.trac.wordpress.org/ticket/39419#comment:3 #39419] and [https://core.trac.wordpress.org/ticket/34217#comment:3 #34217], there are two globals used in ms-settings.php that are no longer used anywhere else by core, `$site_id` and `$public`. Can we explore removing these?" earnjam Old Tickets 41282 Needs documentation improvement ajayghaghretiya1 HTTP API normal normal 4.9 defect (bug) new has-patch 2017-07-10T08:03:07Z 2017-07-10T11:51:09Z access specifier not mention in the documentation of the function. ajayghaghretiya1 Old Tickets 41259 Editing an image link in the Editor produces one additional, empty link afercia Editor 4.8 normal normal 4.9 defect (bug) new has-patch 2017-07-06T11:10:02Z 2017-07-20T16:21:38Z "I can reproduce this consistently in WordPress 4.8 but only using Chrome (v. 59) or Safari (10) and '''only if an image is the first thing in the post content'''. To reproduce: - insert an image as first thing in the content - when inserting the image, link it to the ""Attachment Page"" - save the post - on the front-end, inspect the HTML: everything looks fine - edit the post and update the image link to, for example, ""Media File"" or set a ""Custom URL"" - save the post - inspect the HTML in the front end: the previous link to the ""Attachment Page"" is still there (before the image) and it's empty Seems this happens whatever link is set. Tested on two different machines, macOS and Windows. Couldn't reproduce using Firefox, so seems something specific to webkit browsers. Couldn't reproduce in WordPress 4.7. Note: you can't see the doubled, empty link switching the Editor to ""Text mode"" because TinyMCE will strip it out. Not sure why the empty link doesn't get removed when saving the post. Screenshots: [[Image(https://cldup.com/-fHYEoCUPd.png)]] Happens also with an image after another image: [[Image(https://cldup.com/0FKdDgTHwr.png)]] On Windows: [[Image(https://cldup.com/7SR2nTCIJK.png)]]" afercia Old Tickets 41257 "translate( null, ""domain"" ) returns translation of ""0"" rather than null" bobbingwide I18N trunk normal minor Awaiting Review defect (bug) new has-patch 2017-07-06T09:13:15Z 2017-07-07T08:49:46Z "This could be a case of garbage in = garbage out but I noticed that calling `translate( null, ""domain"" )` or `translate( """", ""domain"" )` produces an unexpected result when - the text domain for ""domain"" is loaded - and it contains a translation for ""0"". === Expected output === null or null string === Actual output === translation of the `""0""` string === Workaround === Don't call translate() this way. === Question === Could/should there be a unit test to confirm what should happen? " bobbingwide Old Tickets 41228 No way to get the post ID after a comment is deleted henry.wright Comments normal normal 4.9 enhancement new has-patch 2017-07-03T10:56:07Z 2017-07-04T17:02:38Z "If we hook to {{{deleted_comment}}} we get given {{{$comment_ID}}} but at this point the comment has been removed from the database so we can't do things like this: {{{ $comment = get_comment( $comment_ID ); echo $comment->comment_post_ID; }}} Can we pass a 2nd arg to {{{do_action()}}}? For example: {{{do_action( 'deleted_comment', $comment->comment_ID, $post_id );}}}" henry.wright Old Tickets 41227 Ability to pass post_modified and post_modified_gmt to wp_insert_post shamim51 Posts, Post Types normal normal Awaiting Review enhancement new has-patch 2017-07-03T10:07:07Z 2017-07-03T13:45:47Z It is hard-coded that post_modified and post_modified_gmt will be current time or post_date. But sometimes it can be needed to have custom date passed to wp_insert_post/wp_update_post. shamim51 Old Tickets 41226 "Static ""posts page"" preview not working" emross Posts, Post Types normal normal Awaiting Review defect (bug) reopened has-patch 2017-07-03T09:41:05Z 2017-07-04T00:57:01Z "My site has both a static front page and a static posts page. The former is intended to be the site's home page, the latter the blog section home page. The static posts page is a regular page, created through the admin interface. Some parts of it are editable by admin - this is a design choice driven by project needs. Whenever I update the static posts page through the editor, the preview doesn't work: '''clicking on the ""preview"" shows the preview of the ""front page"" instead.''' Apart from that, everything works on the front-end side, and I can edit and save the posts page as needed. Unfortunately, as the project is being currently developed, I can't publicly publish urls or screenshots at the time." emross Old Tickets 41224 "WP strips query vars if post contains ""wp-admin""" khromov Query trunk normal normal Awaiting Review defect (bug) new has-patch 2017-07-03T00:09:50Z 2017-07-03T10:48:55Z "I'm running up against this rather obscure issue in the WP Query parser. If a post name contains ""wp-admin"", the query vars are emptied which results in loading the front page instead of the post. Repro steps: - Use built-in PHP web server to start a WP site. - Create a post or CPT called ""test-wp-admin"" - View the post, you will be redirected to the frontpage. Here is the relevant code from class-wp.php {{{ if ( isset($perma_query_vars) && strpos($_SERVER['PHP_SELF'], 'wp-admin/') !== false ) unset( $perma_query_vars ); }}} https://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-wp.php#L276 If you inspect $_SERVER['PHP_SELF'], the resulting value is ""/index.php/test-wp-admin/"" which triggers the conditional. It is not immediately clear to me why this is being done at all." khromov Old Tickets 41221 Throw error notice after wp-header-end shivapoudel Upgrade/Install 4.8 normal normal Awaiting Review defect (bug) new has-patch 2017-07-01T16:47:31Z 2017-07-01T17:40:40Z Append admin notice for AJAX updates after `wp-header-end` shivapoudel Old Tickets 41217 WP_Community_Events Disable Event Logs Howdy_McGee Administration 4.8 normal normal 4.9 enhancement accepted has-patch 2017-06-30T19:25:17Z 2017-07-27T16:01:55Z "Every time a user logs into WordPress, WP_Community_Events triggers maybe_log_events_response() writing to the error log that it received data, even whenever it's valid data: {{{ [14-Jun-2017 11:16:07 UTC] WP_Community_Events::maybe_log_events_response: Valid response received. Details: {$JSON_DATA} }}} Where $JSON_DATA is the returned information. It's valid, there's no real issue I would just like the ability to turn off these logs or disable it from writing whenever the response is successful. It's just additional unnecessary noise in the debug log. " Howdy_McGee Old Tickets 41206 Add embed handler for GitHub gists swissspidy Embeds normal normal Awaiting Review enhancement new has-patch 2017-06-29T17:47:43Z 2017-07-09T07:27:53Z "Gutenberg currently explores adding adding a new block for embedding gists from GitHub (gist.github.com). See: https://github.com/WordPress/gutenberg/issues/1567. Although Gist supports oEmbed, it only returns raw HTML with code excerpts. There's a superior JS method for embeds, which is also shown when viewing a Gist in the browser. Jetpack supports this method as well. If Gutenberg wants to add a new block for gists, it should definitely be supported natively by core. See attached patch as a PoC" swissspidy Old Tickets 41203 autosave.js documentation carolinegeven Autosave 3.9 normal normal 4.9 defect (bug) new has-patch 2017-06-29T12:55:25Z 2017-06-30T01:35:22Z "This patch documents the autosave.js core JavaScript file. It is part of an ongoing process on documenting all core JavaScript files. Props go out to [https://profiles.wordpress.org/terwdan], [https://profiles.wordpress.org/thulshof], [https://profiles.wordpress.org/andizer] and [https://profiles.wordpress.org/carolinegeven] Please make sure to give props to the mentioned profiles." carolinegeven Old Tickets 41180 ABSPATH definition - incorrect on chrooted vhost dacartpl Bootstrap/Load 4.8 normal normal Awaiting Review defect (bug) new has-patch 2017-06-27T08:17:39Z 2017-07-01T15:28:48Z "ABSPATH defined in wp-load.php (and in other files) returns incorrect string on chrooted vhosts (double slash '/' instead of a single): {{{#!php Sites -> Edit -> Themes` screen, the currently active theme for the site is not identified. There should be some form of identification of the active theme." johnbillion Old Tickets 41166 .htaccess config should not be shown on network setup screen when Nginx is in use johnbillion Networks and Sites 3.0 normal normal Future Release enhancement assigned has-patch 2017-06-25T19:27:35Z 2017-07-28T19:03:13Z "When Nginx is in use, the `.htaccess` configuration shouldn't be shown after multisite installation on the `Tools -> Network Setup` screen. It should probably be replaced with a link to the Nginx page on the Codex. Same behaviour as the `Settings -> Permalinks` screen for Nginx." johnbillion Old Tickets 41164 Display theme screenshot in network admin johnbillion Themes 3.0 normal normal Future Release enhancement reviewing has-patch 2017-06-25T19:20:31Z 2017-07-29T06:02:07Z "The screenshot for each theme should be displayed in a new column on the following list tables: * Network Admin -> Themes * Network Admin -> Sites -> Edit -> Themes " johnbillion Old Tickets 41160 Placeholder height too big in Menus page in WordPress alexvorn2 Menus 4.8 normal normal Awaiting Review enhancement new has-patch 2017-06-25T14:51:54Z 2017-06-26T19:52:53Z "We need to decrease the height of the placeholder. Maybe the latest jQuery made them bigger who knows. Please look at the video I uploaded on youtube that shows what is the problem. https://www.youtube.com/watch?v=jSnGVJGpqzc" alexvorn2 Old Tickets 41155 WordPress 4.8 Admin Sidebar Sub Menu Navigation Issue codexdemon Administration normal trivial Awaiting Review defect (bug) new has-patch 2017-06-25T05:17:30Z 2017-07-19T19:16:27Z "Hello Team As this is really awesome as working with the community of wordpress CMS. While reviewing themes of WordPress Me and my colleague @amolebonde face issue about accessing sub-menu navigation when we are theme detail page Wordpress Admin > Appearance > Themes > Theme Details. Once we are on Theme Detail page then in case if the user wants to access any Sub Menu Navigation it not shows well, which goes behind the popup theme detail page. For Ref. Screen Shot Attach [[Image(https://s4.postimg.org/qvkwram4d/Screen-_Shot-2017-06-25-at-10.26.18-_AM.jpg)]] Wordpress Version 4.8 Browser Check: SAFARI 10.1.1, Google Chrome 58.0 " codexdemon Old Tickets 41153 Formally deprecate screen_icon() and get_screen_icon() DrewAPicture Administration 3.8 normal normal Awaiting Review defect (bug) assigned has-patch 2017-06-25T00:13:23Z 2017-06-25T21:01:14Z "Previously, `screen_icon()` and `get_screen_icon()` were ""informally"" deprecated during the 3.8 cycle in [26537] for #26119. The informal deprecation happened due to the proximity to final release. We're now more than 10 releases later and these two functions were never formally deprecated – that is, completed with `_deprecated_function()` calls. This has now come up in #41121. So I think we should probably formally deprecate them now without much issue." DrewAPicture Old Tickets 41148 Test for ticket 39875 can throw PHP error schlessera Media 4.8 normal normal Awaiting Review defect (bug) new has-patch 2017-06-24T07:53:42Z 2017-06-24T10:03:48Z "The test that was written for #39875 can throw a PHP error under certain circumstances: `Undefined index: sizes`. The problem arises when then `wp_generate_attachment_metadata()` call does not return the proper array data. As the preview path generation directly access a specific array index, this throws a PHP error." schlessera Old Tickets 41146 Add filter for a site's class (WP_MS_Users_List_Table) kraftbj Networks and Sites normal normal Awaiting Review enhancement accepted has-patch 2017-06-24T03:37:27Z 2017-07-18T17:05:04Z "In the `WP_MS_Users_List_Table`, each site that is listed is `span`'d with a class of `site-#` where `#` is the ID of the network for a site. Adding a filter to this class would allow site administrators to add addition classes to this output which would easily allow for styling of site items based on the additional classes." kraftbj Old Tickets 41143 Theme/plugin editing: if you don't select a function it just returns without message karmatosed Themes normal normal 4.9 defect (bug) reviewing has-patch 2017-06-23T18:22:52Z 2017-07-11T13:04:23Z "The drop down simply returns nothing, could we have a message to say something like 'please search for something'? It feels a little of a hitch in the flow otherwise. [[Image(https://cldup.com/B7kYDlxlUF.png)]]" karmatosed Old Tickets 41121 Consistency of the _deprecated_function() calls and related documentation. jrf General trunk normal normal 4.9 task (blessed) reviewing has-patch 2017-06-22T03:00:23Z 2017-06-26T13:51:49Z "While working on [https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/pull/979 updating the `WP.DeprecatedFunctions` sniff] which is part of the [https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/ WordPress Coding Standards] project, we've come across a number of inconsistencies in the application of the function and/or the related documentation. @jdgrimes previously already reported this concerning three functions in #41094 (has its own patch in that ticket), however since then a lot more inconsistencies have been identified. In a series of patches which I will add to this ticket I will address these: === Patch 1: Fix deprecation info in various docblocks * Fix incorrect deprecation comment naming the deprecated function as its own alternative * Fix typo in docblock `@deprecated` tag which meant that deprecation is not indicated on the dev ref website * Add missing `@deprecated` tags for two functions * Add missing alternative in `@deprecated` comment for `wp_get_sites()` === Patch 2: Add missing replacement functions to various `_deprecated_function()` calls * Add missing parentheses to a few deprecated function replacement function strings to be consistent with how this is done everywhere else. * Add missing alternative for the WP_Customize Widget deprecated methods. * Add missing alternative for three deprecated ms functions * Add missing alternative for deprecated `wp_cache_reset()` function === Patch 3: Add missing `_deprecated_function()` function calls to various functions * Add missing `_deprecated_function()` call for `funky_javascript_callback()` * Add missing `_deprecated_function()` call for `_save_post_hook()`. * Add missing `_deprecated_function()` call for `default_topic_count_text()`. * Add missing `_deprecated_function()` call for `screen_meta()`. * Add missing `_deprecated_function()` call for two screen icon related functions * Add missing `_deprecated_function()` call for nine wp_dashboard related functions * Add missing `_deprecated_function()` call for `wp_ajax_wp_fullscreen_save_post()`. * Add missing `_deprecated_function()` call for `ms_deprecated_blogs_file()` === Patch 4: Add missing `_deprecated_function()` calls to various deprecated class methods * Add `_deprecated_function()` calls to all methods within the deprecated WP_User_Search class. * Add missing `_deprecated_function()` call for four methods in WP_Customize_Image_Control === Patch 5: Add missing `_deprecated_function()` calls for four deprecated pluggable functions. Not all functions complied with what the docblock at the top of the files states: > Deprecated warnings are also thrown if one of these functions is being defined by a plugin." jrf Old Tickets 41112 Show WordCamps higher up in the News Dashboard widget grapplerulrich Administration 4.8 normal normal WordPress.org enhancement assigned has-patch 2017-06-21T09:59:43Z 2017-07-24T17:07:22Z "WordCamp Bern is planned for 9th September. Till then we have three Meetups planned for June, July and August. Due to this the WordCamp is not being displayed on the list of events. It is not really important for us that people see the Meetup happening in August but that people see that there is a WordCamp in September. As there is less organising for meetup it does not mater if people sign up a few days before but for WordCamp we want people to buy their tickets as soon as possible. If there is a WordCamp nearby it should be shown at the top of list of events. Related #40702" grapplerulrich Old Tickets 41110 "Display full content of ""Pending"" comment on WP Dashboard" puneetsahalot Comments 4.8 normal normal Awaiting Review enhancement new has-patch 2017-06-21T05:42:37Z 2017-06-21T06:23:25Z """Recent Comments"" widget in WP dashboard displays a list of Pending and recent comments. A ""Pending"" comment has all the action items - approve, reply, edit, trash, spam. But, these items are of no use, because the complete comment text is not visible. It will be good to display the full content of the ""Pending"" comments. OR Add a toggle to display the full content without having to go to ""Comments"" page. " puneetsahalot Old Tickets 41105 Fire action hook after updating option group. mdifelice Options, Meta APIs trunk normal normal Awaiting Review enhancement new has-patch 2017-06-20T19:45:35Z 2017-06-20T19:50:52Z "This suggestion affects the Settings API. There are hooks that fire after updating a single option, but not when a group of options is updated. Options updated via the Settings API are handled by /wp-admin/options.php, which after updating them does a redirection to the previous page, not firing any hook beside the shutdown action hook. In fact, the shutdown hook could be used for the same purpose but it would require some more extra checks. Basically the hook would allow to perform some action that is required after all options in that group are updated." mdifelice Old Tickets 41101 Add filter to prevent the addition of a user to a blog jmdodd Users trunk normal normal 4.9 enhancement reviewing has-patch 2017-06-20T15:45:31Z 2017-07-27T15:48:26Z "In some multisite instances, we may want to establish a policy that only certain users may be added to a given blog. The current option available for preventing the addition of a user to a given blog is hooking into the `add_user_to_blog` action and undoing the user addition after it has already taken place. This is problematic because the user has already been added to the blog and any related actions may have already fired, depending on their priority. This introduces a filter to allow a plugin to override the addition of a user to a given blog. There is already precedent in `add_user_to_blog()` for returning a WP_Error if the user does not exist." jmdodd Old Tickets 41097 Incorrect parsing of Forwarded header generates warnings tomdxw Administration 4.8 normal normal Awaiting Review defect (bug) new has-patch 2017-06-19T13:35:02Z 2017-06-19T13:36:20Z "WordPress 4.8 adds a function `WP_Community_Events::get_unsafe_client_ip()` which attempts to get the user's IP address from a set of headers (the code: https://github.com/WordPress/WordPress/blob/92175dbd33b51c47089f4c50853987e688b6291b/wp-admin/includes/class-wp-community-events.php#L238-L278 ). It looks at the following headers: {{{ // In order of preference, with the best ones for this purpose first. $address_headers = array( 'HTTP_CLIENT_IP', 'HTTP_X_FORWARDED_FOR', 'HTTP_X_FORWARDED', 'HTTP_X_CLUSTER_CLIENT_IP', 'HTTP_FORWARDED_FOR', 'HTTP_FORWARDED', 'REMOTE_ADDR', ); }}} It treats them all as comma-delimited lists of IP addresses which is incorrect. This is because the `Forwarded` header as defined in RFC 7239 ( https://tools.ietf.org/html/rfc7239 ) looks like this: {{{ Examples: Forwarded: for=""_gazonk"" Forwarded: For=""[2001:db8:cafe::17]:4711"" Forwarded: for=;proto=http;by= Forwarded: for=, for= }}} Steps to reproduce the problem: 1. Install a browser extension that allows setting arbitrary headers (I'm using ModHeader: https://chrome.google.com/webstore/detail/modheader/idgpnmonknjnojddfkpgkljpfnnfcklj ) 2. Use the browser extension to set a realistic `Forwarded` header such as: `Forwarded: for=2001:db8::1, by=2001:db8::2` 3. Visit `/wp-admin/` The following warnings will appear in your logs: {{{ PHP Warning: inet_pton(): Unrecognized address for=2001:db8::1 in /var/www/html/wp-admin/includes/class-wp-community-events.php on line 268 PHP Warning: inet_pton(): Unrecognized address for=2001:db8::1 in /var/www/html/wp-admin/includes/class-wp-community-events.php on line 274 PHP Warning: A non-numeric value encountered in /var/www/html/wp-admin/includes/class-wp-community-events.php on line 274 PHP Warning: inet_ntop(): Invalid in_addr value in /var/www/html/wp-admin/includes/class-wp-community-events.php on line 274 }}}" tomdxw Old Tickets 41094 Deprecated version not specfied for debug_fopen() et al. jdgrimes General 3.4 normal normal 4.9 defect (bug) new has-patch 2017-06-18T22:14:20Z 2017-06-23T00:33:38Z The `debug_fopen()`, `debug_write()` and `debug_fclose()` functions were deprecated in 3.4.0 ([19935]). However, the calls to `_deprecated_function()` do not include the version number, instead listing the replacement function, `error_log()` as the second parameter. The second parameter is supposed to be the version number, the replacement function should be the third parameter. jdgrimes Old Tickets 41083 IP with port number triggers warnings in WP_Community_Events EatonZ Administration 4.8 normal normal 4.9 defect (bug) assigned has-patch 2017-06-16T17:01:12Z 2017-07-22T16:17:16Z "Hello, I'd like to assume this is probably a duplicate report, but I couldn't find anything via the search, so I thought I would report this anyway to ensure it gets fixed in the next update, as it's very annoying. After upgrading to the latest WordPress, the following errors appear in my PHP errors log: {{{ [16-Jun-2017 16:53:03 UTC] PHP Warning: inet_pton(): Unrecognized address 104.xxx.xxx.98:58749 in C:\home\site\wwwroot\wp-admin\includes\class-wp-community-events.php on line 268 [16-Jun-2017 16:53:03 UTC] PHP Warning: inet_pton(): Unrecognized address 104.xxx.xxx.98:58749 in C:\home\site\wwwroot\wp-admin\includes\class-wp-community-events.php on line 274 [16-Jun-2017 16:53:03 UTC] PHP Warning: A non-numeric value encountered in C:\home\site\wwwroot\wp-admin\includes\class-wp-community-events.php on line 274 [16-Jun-2017 16:53:03 UTC] PHP Warning: inet_ntop(): Invalid in_addr value in C:\home\site\wwwroot\wp-admin\includes\class-wp-community-events.php on line 274 [16-Jun-2017 16:53:04 UTC] PHP Warning: inet_pton(): Unrecognized address 104.xxx.xxx.98:4108 in C:\home\site\wwwroot\wp-admin\includes\class-wp-community-events.php on line 268 [16-Jun-2017 16:53:04 UTC] PHP Warning: inet_pton(): Unrecognized address 104.xxx.xxx.98:4108 in C:\home\site\wwwroot\wp-admin\includes\class-wp-community-events.php on line 274 [16-Jun-2017 16:53:04 UTC] PHP Warning: A non-numeric value encountered in C:\home\site\wwwroot\wp-admin\includes\class-wp-community-events.php on line 274 [16-Jun-2017 16:53:04 UTC] PHP Warning: inet_ntop(): Invalid in_addr value in C:\home\site\wwwroot\wp-admin\includes\class-wp-community-events.php on line 274 }}} I have replaced parts of the IP address with ""xxx"" because it is my computer's IP address (not the server's). This error is 100% reproducible by simply loading the admin dashboard page with the WordPress Events and News box shown. This is new to WordPress 4.8. PHP version is 7.1.6. Windows Server 2012 R2/IIS 8.5" EatonZ Old Tickets 41069 tags.js documentation jipmoors General 2.8 normal normal Awaiting Review defect (bug) new has-patch 2017-06-15T13:25:40Z 2017-07-03T18:55:29Z "This patch documents the tags.js core JavaScript file. It is part of an ongoing process on documenting all core JavaScript files. Props go out to [https://profiles.wordpress.org/atimmer atimmer] and [https://profiles.wordpress.org/jipmoors jipmoors] " jipmoors Old Tickets 41068 editor-expand.js documentation jipmoors Editor 4.0 normal normal Awaiting Review defect (bug) new has-patch 2017-06-15T12:49:36Z 2017-07-03T18:56:08Z "This patch documents the comment.js core JavaScript file. It is part of an ongoing process on documenting all core JavaScript files. Props go out to [https://profiles.wordpress.org/ireneyoast IreneYoast] and [https://profiles.wordpress.org/terwdan terwdan]" jipmoors Old Tickets 41063 color-picker.js documentation jipmoors Customize 3.5 normal normal 4.9 defect (bug) new has-patch 2017-06-15T12:14:18Z 2017-06-20T13:14:24Z "This patch documents the color-picker.js file. It is part of an ongoing effort to document all core JavaScript files. Participated in creating this ticket: [https://profiles.wordpress.org/carolinegeven carolinegeven], [https://profiles.wordpress.org/jjcomack jjcomack] " jipmoors Old Tickets 41058 wp_dropdown_categories documentation is missing arguments ArnaudBan Taxonomy normal normal 4.9 enhancement reopened has-patch 2017-06-15T09:08:51Z 2017-06-21T03:37:15Z "`wp_dropdown_categories` use `get_terms` witch use `WP_Term_Query::__construct()`. The documentation should show that you can use all the `WP_Term_Query::__construct()` argument." ArnaudBan Old Tickets 41024 File uploader looks misaligned in Mac Chrome Ankit K Gupta Plugins 4.8 normal normal Awaiting Review defect (bug) new has-patch 2017-06-13T11:51:06Z 2017-06-14T21:37:43Z "Plugin/theme file uploader look misaligned in Mac Chrome. Refer attached screen shots. Browser default uploader text appearing on select file button and it makes text long. I am not expert in CSS but I noticed if change max-width of form. It looks fine in All Browsers. Better solution are welcome :)" Ankit K Gupta Old Tickets 41014 Add `permalink_structure` to REST API settings endpoint aduth REST API trunk normal normal Awaiting Review enhancement new has-patch 2017-06-12T18:07:52Z 2017-06-21T20:32:12Z "Related: #38490 It is not currently possible to view or edit the `permalink_structure` option from the REST API. This makes it difficult to reimplement a post editor leveraging the REST API because the ""slug"" field is only applicable for sites configured to include `%postname%` in this option's value. See: https://github.com/WordPress/WordPress/blob/9fb2e79/wp-admin/includes/post.php#L1323-L1324 This is relevant for the Gutenberg post editor reimplementation, where effort is blocked by unavailability of this setting from the REST API: https://github.com/WordPress/gutenberg/pull/1042 A workaround may be to include the option in a server-rendered initialized (localized) JavaScript object, but (a) this is not available to clients which may intend to recreate this experience totally separated from the WordPress PHP environment and (b) is inconsistent with the expectation that settings should be manageable from the REST API (given the presence of the settings endpoint). Caveats: - There is validation that is meant to occur in `sanitize_option` that tests whether the incoming `permalink_structure` includes a ""structure tag"". This feels like something that should be baked into the settings endpoint behavior (calling `sanitize_option`), and isn't entirely relevant to the changes proposed here. - Other `permalink` settings (`category_base`, `tag_base`) may be useful to include, but aren't part of the changes proposed here. I'm not sure the criteria with which settings are decided to be included on this endpoint. To me, it seems anything manageable through the Settings section of the admin dashboard should also be surfaced through these endpoints. https://github.com/WordPress/WordPress/blob/9fb2e79/wp-includes/formatting.php#L4030-L4294" aduth Old Tickets 41009 Add filter to comment form class cjbj Comments 4.7 normal normal Awaiting Review enhancement new has-patch 2017-06-12T13:04:09Z 2017-06-14T07:48:19Z "Almost all html of the comment_form function can be customized using filters, except for this line (current 2285 in comment-template.php), which is the wrapping div of the comment form: {{{
}}} I feel there are legitimate reasons for wanting at least the class to be filterable. For instance if you are using the clearfix class throughout your design to clear floats. So I would like to propose changing this line to this: {{{ $respond_class = 'comment-respond'; $respond_class = apply_filters ('comment_form_respond_class' ,$respond_class); echo '
'; }}} " cjbj Old Tickets 40966 Double clicking the Update plugins-button gives... interesting experience! bitnissen Upgrade/Install 4.6 normal normal Future Release defect (bug) assigned has-patch 2017-06-09T08:45:39Z 2017-07-15T19:51:25Z "Hi there, I just updated to 4.8 on a bunch of sites and in one site I accidentally clicked the ""Update""-button multiple times. What then happened, was a rather weird experience: After the update of the plugins successfully completed, it did another run where all updates apparently failed. I tried this on multiple 4.8-installs, all has the same behaviour, so I guess it's fairly easy to reproduce. I've also recorded a video: http://d.pr/v/qmoc7E/5MFtrVpY.mp4 Steps to reproduce: - Upgrade to 4.8. - Go to ""Plugins"" » ""Updates available"" (you need at least a plugin that has updates ready for it) - Select all update-ready plugins. - Click the ""Update""-button. Then click it again. - Observe the table of plugins :-) Kind regards, Morten" bitnissen Old Tickets 40959 Twenty Seventeen: Periscope Social Icon Missing neildaniels Bundled Theme normal normal 4.9 enhancement new has-patch 2017-06-08T21:53:12Z 2017-07-12T21:13:07Z "It would be great to have a Periscope icon provided in the icon set that shows up in the ""Social Icons Menu"" at the bottom of the Twenty Seventeen theme. As of Twenty Seventeen 1.3, providing a Periscope link just shows a generic ""link chain"" icon." neildaniels Old Tickets 40950 wp_terms_checklist() does not pass $post_id to current_user_can() anigel Role/Capability normal normal Awaiting Review defect (bug) new has-patch 2017-06-08T15:00:37Z 2017-06-29T10:04:11Z "An incorrect post_id gets passed in $args to a filter on map_meta_cap, when wp_terms_checklist() does a capability check to see if category checkboxes should get a disabled attribute. `$args['disabled'] = ! current_user_can( $tax->cap->assign_terms );` We had an issue where we were checking the post type in a map_meta_cap filter and it was always showing a standard post type instead of the appropriate custom post type leading to category checkboxes being disabled. Expected behaviour: The post_id passed in $args to the map_meta_cap callback should relate to the post being edited / created How to recreate: 1. Create a custom Post Type 2. Add a filter on map_meta_cap 3. Create or edit a post 4. Check the value passed in $args to your filter when wp_terms_checklist does a capability check to see if categories should get a disabled attribute. Workaround: Use the global $post variable instead of the passed post_id" anigel Old Tickets 40945 Parameter type correction in user.php sebastian.pisula Users normal normal 4.9 enhancement reviewing has-patch 2017-06-08T06:46:38Z 2017-07-10T23:23:26Z Patch change parametr type in wp-includes/user.php file. For example change `object` to `WP_User` sebastian.pisula Old Tickets 40938 Add npm `package-lock.json` for npm v5.x netweb Build/Test Tools normal normal Future Release task (blessed) new has-patch 2017-06-07T04:05:11Z 2017-06-28T23:34:42Z "npm v5 now by default generates a `package-lock.json` file Some paraphrased notes from the announcement post: http://blog.npmjs.org/post/161081169345/v500 * `package-lock.json` and `npm-shrinkwrap.json` are aware of each other and happy to coexist * package locks no longer exclude optionalDependencies that failed to build. This means `package-lock.json` and `npm-shrinkwrap.json` should now be cross-platform. * This will hopefully mitigate the optionalDependencies issue with our build server in #38657 / r39368, when the build server is bumped to use the upcoming Node.js v8.x LTS release this can be tested and confirmed. * Running npm while offline will no longer insist on retrying network requests. npm will now immediately fall back to cache if possible, or fail, npm's caching is vastly improved in npm 5 * On performance, NodeJS 6.9.1 and NPM 3.10.8 running `npm install` in tests took ~67.39 seconds on average, with NodeJS v7.10.0 and npm v5.0.0 this is halved to ~28.938 seconds on average, once npm modules are cached reinstalling `node_modules` averages 23.091 seconds, just shy of a 3x speed boost * Detailed bbPress, BuddyPress, and WordPress performance tests can be seen in [https://docs.google.com/spreadsheets/d/1UJHm_dzezZK4ZPz48X-K39bND0y_0p5kLJl8jvybNgk/edit?usp=sharing this spreedsheet] * The performance boost is comparable to that of Yarn, initial install 21.40 seconds, and subsequent installs 18.82 seconds, see #38603 Related: #38603 Explore adding Yarn and a `yarn.lock` file for NPM module management " netweb Old Tickets 40933 Improvements for get_file_data() function Tkama Formatting 4.7.5 normal normal Awaiting Review enhancement new has-patch 2017-06-06T20:28:37Z 2017-07-18T09:20:04Z "It seams as a bug or as imperfection at least. I try to explain in example. Assume we have such comments in file: {{{#!php 'Version'] ); echo $data['ver']; //> 1.0 }}} This is works as we need. BUT if we change comments a little, the get_file_data() becomes broken: {{{#!php 'Version'] ); echo $data['ver']; //> '' }}} All we do just add spaces before `:` to make comments more readable... - Solution I think it's better to improve regular expression of the get_file_data() and add `[\t ]*` before `:` {{{#!php Floats are also cast to integers, which means that the fractional part will be truncated. E.g. the key 8.7 will actually be stored under 8. You can see this happening with the following snippet. The Test 2 menu item will show but Test 1 will not. {{{#!php nothing shows on the page. Maybe we should add a text message that will inform the user that the menu is empty or is not selected?" alexvorn2 Old Tickets 40985 Lack of Screen Options toggle on mobile prevents accessing features johnbillion Administration normal normal Future Release defect (bug) new dev-feedback 2017-06-09T20:34:35Z 2017-06-26T16:14:17Z "I recently needed to disable comments on a particular post while away from my laptop. I opened the post editing screen on my mobile device but the `Discussion` meta box was hidden and there is no way to access Screen Options on mobile to show/hide meta boxes. This meant I was unable to disable comments on the post from my mobile device. I'd like to propose that when the Screen Options toggle is hidden to to a narrow viewport width, that all meta boxes are shown but the ""hidden"" ones are simply collapsed, thus making them accessible on mobile devices." johnbillion Old Tickets 40969 RFE: get_template_part() to return something or warn when nothing found sphakka Themes normal normal Awaiting Review enhancement new dev-feedback 2017-06-09T10:13:08Z 2017-06-11T13:36:30Z "AFAIK `get_template_part()` doesn't return anything. This is a nightmare when args are misspelled -- think of a leading/trailing space. Given that internally `locate_template()` **does** return what it finds, could we please either expose this return value or warn when nothing is found? " sphakka Old Tickets 40953 Empty values are handled inconsistently between wpdb->get_results() and wpdb->get_col() DrewAPicture Database 0.71 normal normal Awaiting Review defect (bug) new dev-feedback 2017-06-08T17:18:39Z 2017-06-08T17:51:19Z "As outlined and discussed yesterday in Slack [https://wordpress.slack.com/archives/C02RQBWTW/p1496821047585923 here], [https://wordpress.slack.com/archives/C02RQBWTW/p1496844209230845 here], and [https://wordpress.slack.com/archives/C02RQBWTW/p1496850305693715 here], `wpdb` treats empty stored values differently in the `get_results()` and `get_col()` methods. This is because of the use of `get_var()` inside of `get_col()`, which defaults to null for empty values. For example, let's say you're running a query like `SELECT rate FROM sometable` through `get_results()`. With the default parameters and empty values for the column, you'd get something like the following: {{{ array(2) { [0]=> object(stdClass)#1734 (1) { [""rate""]=> string(0) """" } [1]=> object(stdClass)#1735 (1) { [""rate""]=> string(0) """" } } }}} If you ran that same query through `get_col()`, you'd instead get an array of `null` values: {{{ array(4) { [0]=> NULL [1]=> NULL } }}} This seems oddly inconsistent. And writing tests for the workaround is annoying in that creates the need to understand the core workaround in the future. Now, this code goes all the way back to [112], so changing the default behavior is not even on the table. Some solutions brainstormed with @boonebgorges and @johnjamesjacoby include: * A global flag to check against, i.e. `wpdb_get_col_force_strings( true );` * A global flag in the form of a constant * A settable `wpdb`-level flag * A new argument for `get_col()` to selectively change the behavior. The global flag ideas are attractive because they cover the entire DB stack: whether you're using the abstraction layers like `get_posts()`, `WP_Query`, or any of the other query classes, it ''just works'' all the way down the line. The settable `wpdb` flag is attractive only if you're really working with direct queries like we are in our custom table query classes. The same goes for a new argument in `get_col()`, though both could be implemented higher up the stack in the form of arguments or filters. I think a good first step here would be to try to benchmark performance for all of the listed options, just to see what we're looking at. The global flag choices seem like they could be the least impactful. In the short term, our workaround for AffiliateWP will probably be to create a wrapper for `get_results()` that simply plucks the values out so we can maintain consistency, but I'm not a big fan of writing and maintaining core workarounds in perpetuity. Whichever way we go in core, this is something that we should probably address. Who knows how many workarounds there are currently in the wild to fix this." DrewAPicture Old Tickets 40947 Backward compatability _sort_nav_menu_items PieWP Menus 4.7 normal normal Awaiting Review defect (bug) new dev-feedback 2017-06-08T10:50:36Z 2017-06-08T13:20:30Z "The function {{{ _sort_nav_menu_items() }}} does no longer seem to be backwards compatible. This is due to the global {{{ $_menu_item_sort_prop }}} no longer being set. Its sibling function {{{ wp_get_nav_menu_items() }}} should be responsible for setting this var and in the doc also actually refers to it, codewise it does nothing with it though. I've attached a file fixing the backwards compatibility, not quite sure what is more important though. Fixing backwards compatibility or removing/cleaning up an additional global var. Either way I suggest either the patch gets applied or the PHP doc of {{{ $_menu_item_sort_prop }}} gets updated. " PieWP Old Tickets 40934 Allow PHP version requirements for plugins & themes joostdevalk Plugins normal normal 4.9 task (blessed) assigned dev-feedback 2017-06-06T20:34:46Z 2017-07-26T13:57:19Z "Not all plugins can work on PHP 5.2, like WordPress core currently does. Not all plugin developers ''want'' to support PHP 5.2, like core does. As a project, WordPress would like to move forward and have people on more recent PHP versions. One of the ways to reach that goal would be to show them that they cannot install a certain plugin or theme because their install does not meet the required criteria. As such, I'm proposing to allow plugins and themes to have a minimum PHP version requirement. Not a maximum, just a minimum. This minimum version requirement should not mean that plugins should not be shown in the new plugins screen, for instance, instead, they should be shown but ""disabled"", with links to Wordpress.org pages explaining why, and how to upgrade their PHP. To do this, the following work would have to be done: '''Core''' - Plugin header parser changes for minimum PHP version requirement. - Disallow activating incompatible plugins from plugins list. Mockups required. - Add new plugins screen changes for plugins whose criteria do not match. Mockup attached. - Check plugin header on manual plugins installation to prevent fatal errors. Mockup required for error. '''Meta''' - Plugin readme parser changes for minimum PHP version requirement. Source location: https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/readme - Plugins API changes. Source location: https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/standalone '''Plugin directory''' - Show minimum required PHP version on plugins page. Source location: https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/template-parts/plugin.php Mockups required. - (Optional) Allow filtering plugin directory. Mockups required. - (Optional) Report PHP version usage per plugin’s users. Mockups required. '''WordPress dot org / Codex''' - Create pages on how to upgrade PHP, preferably with links to specific instructions for specific hosts If this gets ""blessed"" I'll proceed to make individual smaller tickets for the individual changes. " joostdevalk Old Tickets 40921 Inconsistent Handling of mp4 by Audio Widget toddhalfpenny Media 3.6 normal normal Future Release defect (bug) new dev-feedback 2017-06-04T20:14:25Z 2017-07-14T13:25:46Z "The audio media widget does not render the audio player when displaying the widget on the front-end when an mp4 file is referenced; it is rendered (and plays) as expected in the admin screens. This behaviour is the same whether using the wp-core-media-widget plugin or built-in widgets in 4.8. Attaching a gif (hope these are OK). " toddhalfpenny Old Tickets 40916 "Add ""noreferrer"" to comments in dashboard" Cybr Comments normal normal Awaiting Review enhancement assigned dev-feedback 2017-06-03T21:14:22Z 2017-06-26T17:50:43Z "Within `/wp-admin/edit-comments.php`, one might check out a posted link before verifying the comment's legitimacy. While doing so, we're sending the linked site that their comment got through; plausibly opening yourself to complications. Whatever the reason may be, I don't think we should give spammers any information. To resolve this, simply add `rel=noreferrer` to those links." Cybr Old Tickets 40911 Replacing an image in the text editor causes text below to get deleted jpenningroth Editor 4.7.5 normal normal Awaiting Review defect (bug) new dev-feedback 2017-06-02T16:24:26Z 2017-07-05T23:28:05Z "We've run into the following problem when editing a post using the text editor: if you have an image inserted with paragraphs of text below it and you go back to try to remove and replace the image, text below is getting deleted. Here are the steps to recreate this problem: 1. Select the image code 2. Delete the image 3. Hit ""Add Media"" to add in a new image 4. When the image is inserted, you can see that the first few lines of copy below it are getting deleted, and the remaining copy is getting shifted up so that it's on the same line as the image code. We were also able to reproduce this issue on a fresh install of WordPress. It seems this does only occur in a specific edge case, though: 1. When using the editor in the ""Text"" tab 2. Deleting an existing image (and caption) 3. Not creating a new line 3. Inserting an image We're able to avoid this by doing either of the following workarounds: - Only adding and removing images in the ""Visual"" tab of the editor - If using the ""Text"" tab, first create a new line after deleting the image, return to the previous line and insert image." jpenningroth Old Tickets 40909 Focus in attachment custom fields is lost when updating the value. lucymtc Media 4.7.5 normal normal Awaiting Review defect (bug) new dev-feedback 2017-06-02T12:24:55Z 2017-07-28T22:07:17Z "I ran into a bug related to attachment custom fields in the media modal as well as the attachment edit screen. It's an accessibility issue where the focus of the text inputs is lost when their value is modified, needing to click twice to update their value. Reproducible when having multiple custom fields. This is caused by a re-render of the view used for this region, which is `wp.media.view.AttachmentCompat` In the initialize function the view re-renders when the model changes. {{{ initialize: function() { this.listenTo( this.model, 'change:compat', this.render ); } }}} Steps to reproduce: - Create some custom attachment fields using the appropriated hooks `attachment_fields_to_edit` and `attachment_fields_to_save` - Open the Medial Modal through Add Media button and click on an image to view details. - Click on the one of the custom fields input and type any text. - Then directly click on the next custom field input. - Focus gets lost and needs to click again in the input in order to modify the value. I don't see the reason for the view needing to be re-rendered, removing the listener fixes the issue. If re-rendering is needed for a particular reason, a possible solution would be to keep track of the last focused input and re-focus on re-render. The code was added in this commit https://github.com/WordPress/wordpress-develop/commit/57b09463e67" lucymtc Old Tickets 40894 Use Webpack instead of Browserify for build process adamsilverstein Build/Test Tools 3.5 normal normal Future Release enhancement assigned dev-feedback 2017-05-31T12:16:26Z 2017-07-27T23:02:31Z "#40834 kicked off a discussion of JavaScript modules in WordPress core. In a recent [https://make.wordpress.org/core/2017/05/24/javascript-chat-summary-for-may-23rd/ JavaScript Core chat ] the decision was made to move in the direction of using Webpack (and ES6 imports) as our bundler of choice, and to work first on switching out browserfy in our current build chain. Since we split the media files in #28510, the core build process [https://core.trac.wordpress.org/browser/tags/4.7.5/Gruntfile.js#L160 has used Browserify] to combine the media files. While browserify has served us well, Webpack is probably a better long term choice for the project, especially with the introduction of a new JavaScript framework that may require a build. " adamsilverstein Old Tickets 40888 PHP Warnings when POSTing keys as arrays to wp-login.php johnjamesjacoby Login and Registration normal normal 4.9 defect (bug) new dev-feedback 2017-05-30T17:12:26Z 2017-07-17T17:43:14Z "I'm seeing bots filling up my error logs by POSTing to `wp-login.php` with `user_login` as an array instead of a string. The `user_login` value is blindly passed through functions that assume it's a string, like `trim()`, `register_new_user()`, `reset_password()` and so on. For me, they're hitting `/wp-login.php?action=lostpassword`, but upon further review, the majority of actions and functions in (and related to) `wp-login.php` are equally susceptible to a similar log-filling type of attack. (I'm seeing this on PHP7.1, so it's possible that upped the priority to a warning which is why I'm seeing this now, but it's also possible this is new, or I haven't seen this myself before.) It is possible to setup web-server rules to prevent malformed values in these fields, but I think it's better for everyone if `wp-login.php` protect against them at the application level anyways. FWIW, I am not against modifying `$_POST` directly in cases like this (where the core code has never supported array values in these keys, there's no imaginable reason for these values to ever not be strings, and a complex plugin stack means other code probably also trusts these values are strings, too.) To duplicate, send the following `$_POST` request to the following URL: {{{ URL: http://src.wordpress-develop.dev/wp-login.php?action=lostpassword POST: user_login['test'] => 'hello' }}} Somewhat related: #34192" johnjamesjacoby Yesterday 41472 Travis CI: Use the latest PHPUnit 6.x branch netweb Build/Test Tools normal normal 4.9 defect (bug) new commit 2017-07-28T03:39:53Z 2017-07-28T14:13:00Z "Follow up to #39822 / [40536] where PHPunit 6.x support was added to use PHPUnit 6.1 for Travis CI PHP 7.x versions PHPUnit 6.2 was released 2nd June 2017, and the latest 6.2.3 released 3rd July 2017 We should use the latest 6.x branches rather than the 6.1.x branch Here's a Travis CI job testing this patch as at current SVN revision [41179] https://travis-ci.org/ntwb/wordpress/builds/258400758 via https://github.com/ntwb/wordpress/pull/4" netweb Last Week 41396 set_post_format: inconsistency between edit_post and bulk_edit_posts Chouby Post Formats 3.3 normal normal 4.9 defect (bug) new commit 2017-07-21T11:24:12Z 2017-07-24T14:03:08Z "In `edit_post()`, `set_post_format()` is called before the post is saved. In `bulk_edit_posts()`, it is called after. This can cause trouble to the plugins expecting to have the right post format, when hooking to the action `save_post`." Chouby Old Tickets 41331 Update links in docs to HTTPS when available johnpgreen General trunk normal normal 4.9 enhancement new commit 2017-07-14T16:54:41Z 2017-07-19T05:03:26Z "There are URLs in the code docs which use HTTP when HTTPS is available for those domains. Previously: #40732, #36993, #37622 Patch incoming." johnpgreen Old Tickets 40946 Update `.editorconfig` and `*.json` files to use tabs for indentation netweb Build/Test Tools normal normal 4.9 task (blessed) new commit 2017-06-08T06:53:47Z 2017-06-08T06:55:26Z "When the `.editorconfig` file was added in [27198] it included the option to indent `*.json` files with 2 spaces, this was inherited from the jQuery projects `.editorconfig` There's no inherent reason^([#hn note])^ to require this, see https://stackoverflow.com/a/18698771/1911294 Originally discussed here https://github.com/WordPress/gutenberg/pull/1029#issuecomment-306362413 Note: An existing issue with npm 3 and 4 causes indentation issues, as such `package.json` needs to remain indented with spaces until WordPress chooses to use npm 5 as the required minimum." netweb Yesterday 41480 filter_var() is not working below php 5.2 version umangvaghela123 External Libraries normal normal Awaiting Review defect (bug) new close 2017-07-29T11:49:22Z 2017-07-29T12:21:44Z I found the filter_var() function in class-phpmailer.php file , so I replace the filter_var function to is_email() because validate_email() function is deprecated. umangvaghela123 4-7 Days Ago 41427 wp_set_object_terms creates new terms instead of linking existing ones martin.krcho Taxonomy 4.8 normal normal Awaiting Review defect (bug) new close 2017-07-24T18:22:04Z 2017-07-24T19:36:11Z "Function {{{wp_set_object_terms}}} doesn't behave as expected. When I pass an ID of an existing term (integer) as {{{$terms}}} parameter, it creates a new term with given ID as a slug. This is most likely due to one of the plugins I use, but the problem goes away when I change lines 2241 and 2242 in {{{taxonomy.php}}} to the following: {{{ $term_ids[] = intval($term_info['term_id']); $tt_id = intval($term_info['term_taxonomy_id']); }}} Would you consider adding this to the next version as a failsafe?" martin.krcho Last Week 41366 WordPress makes uses of decimal prefix and uses binary multiplicator for constant memory size value sebm78 General 4.8 normal trivial Awaiting Review enhancement new close 2017-07-19T10:40:36Z 2017-07-19T13:08:48Z "defined here: wp-includes/default-constants.php line 25-28 constants in: define('{decimal_prefix}_IN_BYTES' , 1024 * {decimal_prefix}_IN_BYTES ); should be: define('{binary_prefix}_IN_BYTES' , 1024 * {binary_prefix}_IN_BYTES ); or should be: define('{decimal_prefix}_IN_BYTES' , 1000* {decimal_prefix}_IN_BYTES ); where {decimal_prefix} is one of: ,K, M, G, T and {binary_prefix} is one of: ,Ki, Mi, Gi, Ti. See https://en.wikipedia.org/wiki/Binary_prefix." sebm78 Old Tickets 41232 Cache translations and nav menus szepe.viktor General trunk normal normal Awaiting Review enhancement new close 2017-07-03T17:32:32Z 2017-07-03T21:35:11Z "I've noticed caching translations and navigation menus HTML output makes WordPress load much faster. (Using persistent object cache) I am experimenting with these two (an the_content() caching) in this repo https://github.com/szepeviktor/tiny-cache Please consider caching these two in the core. Thanks. " szepe.viktor Old Tickets 41186 4.8 Video Widget Not Working for External YouTube URL foreverlearning Media 4.8 normal normal Awaiting Review defect (bug) new close 2017-06-27T16:33:04Z 2017-07-19T22:54:29Z "The problem occurs when trying to use the new 4.8 video widget when selecting external URL and using a YouTube URL - an error is returned stating that it's an incorrect file type. I""ve tried this on two different domains and have gone through the process of disabling/deleting all plug ins, switching to default themes etc. and the issue still occurs. I will attempt to attach a screenshot of the error Thank you. DAn PS: Be kind this it the first time I've reported a bug. " foreverlearning Old Tickets 41152 New Function to Require a file rinkuyadav999 Themes normal normal Awaiting Review feature request new close 2017-06-24T15:32:09Z 2017-06-25T09:51:10Z "Right now theme developers need to use php require and file path to require a file. It will better, WordPress code provide a function to supply path of file in a function and it will do reset of work. Like: {{{#!php roles ) && empty( array_intersect( $allowed_roles, $user->roles ) ) ) { return new WP_Error( 'term_addition_blocked', 'You are not allowed to create new tags.' ); } return $term; } }}} Now, a restricted user goes to the edit post and trying to assign existing tags to the post and its work fine. But when a user adds a tag which does not exist along with existing tags then existing tags also not assigned to that post. Because `wp_set_object_terms()` function will create new tag if it's not exists and I've return WP_Error object using `pre_insert_term` hook. So once it get WP_Error object then it returns from the `wp_set_object_terms()` function and it's also not execute for other terms. See https://core.trac.wordpress.org/browser/tags/4.8/src/wp-includes/taxonomy.php#L2237 To complete my functionality I hook into `admin_init` action and remove new tags from $_POST so that remaining existing tags can assign to the post. I believe, instead of returning, it should continue execution for other terms. Also, I'm not sure whether it's valid use case or not. So main question is, do we need to return if there is WP_Error while creating term or don't return and continue execution for other terms. I hope, I'm able to explain it properly. :) " chandrapatel Old Tickets 41006 Upon update from 4.75 to 4.8 Redirects failed. georgiel Administration 4.8 normal normal Awaiting Review defect (bug) new close 2017-06-12T10:46:09Z 2017-06-14T02:07:39Z "I've just had to restore a site from a backup because wordpress is ignoring the redirects set (wordpress install in subdirectory using [https://codex.wordpress.org/Giving_WordPress_Its_Own_Directory#Method_I_.28Without_URL_change.29.]) This happened after I allowed WordPress to auto-update. After resetting the .htaccess to that recommended here, the site still was having issue as it was requesting /css/ /javascript/ and other resources from the root folder rather than the subdirectory and ignoring the redirect. There have been no changes to the site between Thursday and the update. " georgiel Old Tickets 40979 add_rewrite_endpoint() doesn't work when applied to unattached media henry.wright Rewrite Rules normal normal Awaiting Review defect (bug) new close 2017-06-09T14:52:15Z 2017-06-12T08:43:41Z "{{{add_rewrite_endpoint( 'foo', EP_ATTACHMENT );}}} doesn't seem to be working for unattached media items. For example visiting the following returns a 404: example.com/attachment-slug/foo/" henry.wright Old Tickets 40912 An image without a caption is not centered aeric325 General 4.7.5 normal normal Awaiting Review defect (bug) new close 2017-06-02T18:39:38Z 2017-06-05T05:31:55Z "First observed the problem in 4.7.4, and now in 4.7.5. An image with a caption is centered properly in the page, when that option is chosen. An image without a caption is centered in the editor, but is not centered in the post. The workaround is to place the image in a paragraph, and center that. Note: The proper category for this report may be ""Formatting"". I'm just not sure what you mean when you use that term. (A glossary of categories would help!)" aeric325 Old Tickets 40897 "Receiving Error Message with Failed to load plugin: wplink from ""my url"" /wp-includes/js/tinymce/plugins/wplink/plugin.min.js" stackmod General 4.7.5 normal normal Awaiting Review defect (bug) new close 2017-06-01T00:18:45Z 2017-06-01T10:28:03Z "I am receiving a error message which says: Failed to load plugin: wplink from url http://myurl.com/wp-includes/js/tinymce/plugins/wplink/plugin.min.js Does anyone know how to fix this?" stackmod Yesterday 41481 Support subfolders in mu-plugins onnimonni Plugins trunk normal normal Awaiting Review enhancement new 2017-07-29T12:43:00Z 2017-07-29T12:43:00Z "Currently we are able to load plugins and themes from subfolders like {{{ wp-content/plugins/plugin-subfolder }}} but somehow we don't use the same logic for mu-plugins. I would want {{{ wp-content/mu-plugins/plugin-subfolder }}} to act in similiar manner. I have been using bedrock-autoloader.php for long time for this but I think it's finally time to support this feature without extra hacks. For example if I use a hack like bedrock-autoloader.php the wp-cli won't list the used mu-plugins from subfolders as activated mu-plugins causing confusion for admins. Supporting subfolders from mu-plugins helps using dependency managers like composer. Links: https://github.com/roots/bedrock/blob/master/web/app/mu-plugins/bedrock-autoloader.php " onnimonni Yesterday 41479 Docs need improvement!! sagarladani Themes normal normal Awaiting Review defect (bug) new 2017-07-29T11:35:56Z 2017-07-29T11:42:03Z "@global wpdb $wpdb @global WP_Customize_Manager $wp_customize " sagarladani Yesterday 41478 Documentation need to be improved tejas5989 Administration normal normal Awaiting Review defect (bug) new 2017-07-29T10:16:46Z 2017-07-29T10:21:34Z tejas5989 Yesterday 41477 Back Button issue to Login page with Safari robersolari Cache API trunk normal normal Awaiting Review defect (bug) new 2017-07-28T19:14:26Z 2017-07-28T19:14:26Z "Only when a user that has the proper credentials to access our wordpress site, is directed to any of our site pages, and then uses a link within that page, is redirected to the login page when they hit the back button. This does not happen when user other browsers' like Chrome, only happens in safari. We use page builder as the plugin. " robersolari Yesterday 41476 Pasting from Word saved in OneDrive doesn't create proper footnote links repwolfe Formatting 4.8 normal normal Awaiting Review enhancement new 2017-07-28T16:44:29Z 2017-07-29T12:33:09Z "I'm using WordPress 4.8 and Microsoft Word 2016. I made a document with footnotes, and I'm saving it to my OneDrive account for automatic syncing to the cloud. When I copy and paste the document into Wordpress, the footnote links don't simply link to ""#_ftn1"", but rather it links to the file on OneDrive (incorrectly) such as: [1] Using a file not saved to OneDrive doesn't exhibit this problem. " repwolfe Yesterday 41474 Feature Request: Download Media button from Attachment Details Page countrymusicchicago Media 4.8 normal normal Awaiting Review enhancement new 2017-07-28T14:30:15Z 2017-07-28T14:30:15Z "Hello, Sorry if this has been posted but would love a simple ""Download Media"" button or link from the media Attachment Details lightbox popup. This this is super simple yet would be helpful if you are trying to simply grab a photo that is in your WP media library. [[Image(https://swinterroth.com/wp-content/uploads/2017/07/Screen-Shot-2017-07-28-at-9.26.45-AM-squashed.png)]]" countrymusicchicago Yesterday 41471 Page dropdown walker must check selected against value field geminorum General trunk normal normal Awaiting Review defect (bug) new 2017-07-28T03:36:18Z 2017-07-28T03:36:18Z `Walker_PageDropdown` only checks `selected` with the page `ID` and ignores `value_field` option. geminorum Yesterday 41469 test_charset_switched_to_utf8() is not tested on Travis CI johnbillion Database 4.7.1 normal normal Awaiting Review defect (bug) new 2017-07-28T00:26:11Z 2017-07-28T02:09:13Z "The `Tests_DB::test_charset_switched_to_utf8()` test (introduced in #37982) is skipped on Travis, because the test gets skipped when the environment's database driver supports utf8mb4. This makes the test useless. What sort of environment does not support utf8mb4? Presumably an older MySQL version. We should look into adding a build to Travis with a specific environment that allows this test to run. Related: #30462" johnbillion 2 Days Ago 41468 "Provide contextual info about what ""attached"" and ""detached"" means regarding media objects" mor10 Media trunk normal normal Awaiting Review defect (bug) new 2017-07-27T22:10:56Z 2017-07-27T22:10:56Z "From user testing: ""I have no idea what it means when it says an image is 'Attached' to a post. Does it mean the image is in the post? Does it mean if I 'Detach' the image from the post it will go away from the post? I'm worried a client might 'Detach' an image from a post to remove it, or 'Attach' an image to add it. What is this for? How can an image be 'Unattached' to the post it is displayed in anyway?""" mor10 2 Days Ago 41467 Disassociate image alt text from media object mor10 Media trunk normal normal Awaiting Review enhancement new 2017-07-27T22:03:29Z 2017-07-28T17:45:29Z "Sounds confusing, but bear with me: Image alt text should not be a property of the media object because the alt text of the image will change depending on what context the image is presented in. Saving a ""default"" alt text for the image as we do now promotes a misunderstanding of the purpose of the alt text. Unique alt text should be added for each instance an image is used to ensure it follows the Alt Text Decision Tree (https://www.w3.org/WAI/tutorials/images/decision-tree/) and is accurate to the current context the image is presented in. " mor10 2 Days Ago 41466 Allow cropping of images from inside the content editor mor10 Media trunk normal normal Awaiting Review enhancement new 2017-07-27T21:59:16Z 2017-07-27T21:59:16Z "In user testing, several people have requested the ability to crop images in the editor context after they have been placed. The expectation seems to be that this should be possible, and the abstraction of having to go to the edit media panel to do this results in the user having to crop the image multiple times to ""get it right"". This suggestion has several significant sticking points: 1. The idea of cropping images to ""fit"" within the context of content makes no sense when considering RWD. 2. Users who crop images also expect to be able to uncrop them later or in other contexts when the image is reused. 3. Hard cropping images by changing the file is becoming a somewhat archaic practice thanks to CSS masking and cropping. Possible solutions: 1. Provide tools for theme developers to provide display sizes and shapes for images in the editor through CSS and take full advantage of RICG image scaling (related to #35094). 2. Allow ""soft"" cropping through CSS (introduces complications with RWD, but better than hard cropping). 3. Disallow cropping at all." mor10 2 Days Ago 41465 Drag-and-drop image placement is confusing mor10 Media trunk normal normal Awaiting Review defect (bug) new 2017-07-27T21:52:14Z 2017-07-27T21:52:14Z "When a user drags-and-drops an image onto the editor, the image placement is not obvious and the experience leaves users confused: - At the start of the process, the text caret is somewhere in the text. - on drag-and-drop, the add media panel appears abstracting the user from the task of placing the image in the correct context in the text. - When the add image panel is exited by clicking ""Add Image"", the image appears where the cursor was originally placed. The introduction of the abstraction layer of the Add Image panel causes the user to shift focus enough that the final location of the image placed in the text seems arbitrary. Possible solutions: 1. Allow the user to drag the image onto the canvas and place it in context by visualizing a placeholder container before the modal is opened. The modal should only open after placeholder placement is made so the user knows where they placed the image before dealing with metadata. 2. If the sequence of events must start with the add media modal, allow the user to place the image within context after clicking Add image: Rather than the image being placed at the current caret position, show a placeholder with an interactive outline the user can drag around and position before the actual image is placed. Image placement via drag-and-drop is an issue that shows up often in user testing. It is poorly understood and leads users to feel like WordPress is either acting at random or worse making decisions on their behalf." mor10 2 Days Ago 41462 Promote media details admin page to full post page mor10 Media trunk normal normal Awaiting Review enhancement new 2017-07-27T17:43:26Z 2017-07-27T17:43:26Z "Currently when editing media metadata, you either get the modern library modal with the image on the left and various fields on the right. When you click ""Edit more details"" you get a blast from the past with an old-school version of WordPress admin where everything looks uninspired and, for new users, broken. Based on user feedback it turns out some site owners use the Attachment Page feature to provide contextual info, commenting, etc for media items. One example was a teacher who uploaded student images to a gallery, then had each image link to the attachment page where further information and images were provided in the ""description"" field (so the post content) and parents could leave comments. Since media items in reality are full fledged posts with their own post content, the media details admin view should be upgraded to a full post page with proper WYSIWYG editing for the Description field, custom fields, and ability to control things like commenting. This would also be an ideal place to visualize in what posts a media item is in use across the site." mor10 2 Days Ago 41461 Sort out missing attachment.php template somehow mor10 Media trunk normal normal Awaiting Review defect (bug) new 2017-07-27T17:35:51Z 2017-07-27T17:35:51Z "When a visitor goes to an attachment page (typically linked from a gallery) and the theme does not have an attachment template, they get a random and most often broken user experience. This is largely due to theme developers not creating an attachment.php template (and starter themes like Underscores not providing one), but it is perceived by visitors and site owners as an error. There must be some way of gracefully capturing requests for attachment pages when the theme has no support for them so the info is displayed in a non-broken format." mor10 2 Days Ago 41459 Introduce a REST API endpoint for networks flixos90 Networks and Sites normal normal Future Release task (blessed) new 2017-07-27T16:55:56Z 2017-07-27T16:55:56Z "Similar to sites in #40365, there should be a networks endpoint as part of the REST API. Through recent multisite discussions, we have come to the conclusion that, while multi-network should never be part of core, there should be basic and unopinionated APIs present that can be used by whoever wants to implement it. A basic networks API in these terms implies that it's a simple CRUD API for the `wp_site` database table. #29411 will introduce the internal core functions that this endpoint will be able to use. The endpoint should be able to do the following: * List networks: `GET wp/v2/networks/` * Retrieve a network: `GET wp/v2/networks/` * Create a network: `POST wp/v2/networks/` * Update a network: `PUT wp/v2/networks/` * Delete a network: `DELETE wp/v2/networks/` Once the changes in #25344 is in place, a network meta endpoint should be created as well. For now this will be part of this ticket too. Note that this ticket is an early one and will lay around for a while. The other non-network-related roadmap items have a higher priority." flixos90 2 Days Ago 41458 Class gets stripped out when inserting a link in author biography box neodjandre General 4.8 normal normal Awaiting Review defect (bug) new 2017-07-27T16:44:55Z 2017-07-27T16:44:55Z "Class gets stripped out when inserting a link in author biography box For example My link becomes My link" neodjandre 2 Days Ago 41456 needs documents improvement upadalavipul Editor normal normal Awaiting Review defect (bug) new 2017-07-27T14:09:24Z 2017-07-27T14:16:06Z the function in parameter $mce_buttons define but documentation parameter define in $buttons upadalavipul 3 Days Ago 41448 Contributors shouldn't be able to change the date of their drafts davilera Posts, Post Types 2.7 low normal Future Release defect (bug) new 2017-07-26T12:33:48Z 2017-07-26T16:08:09Z "(I'm guessing that) contributors shouldn't be able to change a post's publication date—that's why the ''Publish'' box doesn't include the date when logged in as a contributor in the first place. However, if a contributor quick edits a post in the ''All Posts'' screen, they'll be able to change the post's date. We should remove the date field from the ''Quick Edit'' form. Or, alternatively, we should allow contributors to edit this date while they're editing a post. Either way, both screens should be consistent." davilera 3 Days Ago 41447 global variable sescription was not proper tejas5989 Import normal normal 4.9 defect (bug) new 2017-07-26T11:30:21Z 2017-07-26T12:54:17Z tejas5989 3 Days Ago 41446 The PHP notice displayed after the overwriting global $posts by a new empty query. danielpietrasik Query 4.8 normal normal Awaiting Review defect (bug) new 2017-07-26T07:57:45Z 2017-07-26T12:42:21Z "'''Tested in WordPress 4.8, twentyseventeen theme with default configuration (just installed).''' After the overwriting a global variable {{{$posts}}} by a new {{{get_posts()}}} query (which return an empty array (no posts)) there is a PHP notice displayed: {{{ Notice: Undefined offset: 0 in /.../wp-includes/class-wp-query.php on line 3162 }}} The overwriting is not a best choice, but some themes and plugins do it, so we should solve this problem. The problem is in {{{WP_Query}}} class in {{{rewind_posts()}}} method in {{{wp-includes/class-wp-query.php}}} file. '''The original method:''' {{{#!php current_post = -1; if ( $this->post_count > 0 ) { $this->post = $this->posts[0]; } } }}} '''The problem:''' the global query has at least one posts, but a new query has not. So the {{{$this->post_count}}} property is always positive, but the {{{$this->posts[0]}}} is not exists. In this step, the PHP notice is displayed. '''An example of solution:''' {{{#!php current_post = -1; if ( $this->post_count > 0 && isset( $this->posts[0] ) ) { $this->post = $this->posts[0]; } } }}} Right now the method checks that the query has posts and the first post is set and is not null." danielpietrasik 3 Days Ago 41445 post_parent can prevent media from embedding correctly loboyle REST API 4.7.5 normal normal Awaiting Review defect (bug) new 2017-07-26T06:29:28Z 2017-07-26T06:29:28Z "If media is uploaded for a post, then used as a featured image on another post, and the original parent is not accessible via the REST API (e.g. because it's in the trash, not published etc), then it cannot be embedded on the post that ''is'' accessible. To reproduce * make a new post with a featured image * trash the post * make a new post, using the first image as the featured image * request the second post over the rest API with media embedding enabled The media will not be embedded, instead a forbidden result will be embedded error {{{#!json { ""wp:featuredmedia"":[ { ""code"":""rest_forbidden"", ""message"":""You don't have permission to do this."", ""data"":{ ""status"":403 } } ] } }}} See https://github.com/WP-API/WP-API/issues/2596 for the original issue. Also related is https://core.trac.wordpress.org/ticket/30691. " loboyle 4-7 Days Ago 41443 Update /wp-admin/network/site-new.php to use wpmu_validate_blog_signup() neversettle Networks and Sites 4.8 normal normal Awaiting Review enhancement new 2017-07-25T21:29:37Z 2017-07-25T21:29:37Z Is there a good reason that /wp-admin/network/site-new.php uses it's own hard-coded blogname validation rules? Shouldn't it just call wpmu_validate_blog_signup() for DRY as well as a consistent / universal application of filters across all new site names? It seems crazy to have two different sets of validation for the same thing. And as multisite plugin developers we see network admins confused by the different behavior of site-new.php and sites created through plugins which use wpmu_validate_blog_signup(). neversettle 4-7 Days Ago 41442 Show nearby events in dashboard events widget in a per country basis fernandot Administration 4.8 normal normal Awaiting Review enhancement new 2017-07-25T18:51:10Z 2017-07-26T00:23:26Z "Hi! I've noticed that the new events dashboard widget don't show all WordCamps in a country basis. It shows only that ones nearby in kilometres, 400 kms as seen in code (https://meta.trac.wordpress.org/browser/sites/trunk/api.wordpress.org/public_html/events/1.0/index.php?rev=5559&marks=707,708#L703). That way, i.e., for an Spanish WordPress user from Madrid (in the geographical center of the Country) it going to be impossible to know about WordCamps in Chiclana (Cádiz) or others far away from that 400 kms standard, and totally impossible for anybody to know about a WordCamp in Las Palmas (Canary Islands), and impossible for anyone that lives in Canary Islands to know about continent WordCamps. It could be possible to extend/change the range to a country basis (best) or more kilometres?" fernandot 4-7 Days Ago 41441 Deleting a theme from a single site's Themes screen should not be allowed johnbillion Themes normal normal Awaiting Review defect (bug) new 2017-07-25T18:42:40Z 2017-07-25T18:42:40Z "With Multisite enabled, it's not possible to delete a plugin from the Plugins screen in individual sites' dashboards. The `Delete` link is removed. The same should be true for themes. Currently, a `Delete` button is shown when a super admin views the Themes screen on an individual site." johnbillion 4-7 Days Ago 41439 A super admin cannot remove themselves from a site johnbillion Users 3.0 normal normal Awaiting Review defect (bug) new 2017-07-25T17:52:24Z 2017-07-25T17:52:24Z A super admin cannot remove themselves from a site, either from the `Users` listing screen in the site's dashboard or from the `Users` tab when editing the site. There's no reason to prevent this from being possible. johnbillion 4-7 Days Ago 41434 $wpdb need to be mentioned for documentation tejas5989 General normal normal Awaiting Review defect (bug) new 2017-07-25T12:32:58Z 2017-07-25T12:32:58Z tejas5989 4-7 Days Ago 41432 Allow ircs protocol handler in default allowed whitelist for hyperlinks arealnobrainer General normal normal Awaiting Review feature request new 2017-07-25T11:41:29Z 2017-07-25T11:41:29Z "Would it not be an idea to allow for protocol `ircs://` in default allowed whitelist of protocols in WP ? Today only `irc://` is allowed. But not the secure handler `ircs://` ..." arealnobrainer 4-7 Days Ago 41431 Need autocomplete attributes in wp_login_form() for security purpose tejas5989 General normal normal Awaiting Review defect (bug) new 2017-07-25T09:28:56Z 2017-07-25T09:31:23Z For security purpose need autocomplete attribute. tejas5989 4-7 Days Ago 41430 "TinyMCE: ""highlight"" the image caption DL when the image is selected" azaozz TinyMCE normal normal 4.9 enhancement new 2017-07-25T08:16:03Z 2017-07-25T08:16:03Z Follow up from #41408. When an image with a caption is selected, or the caption field is focused, it would be good to indicate that the image is part of a larger object. azaozz 4-7 Days Ago 41428 Editor: long URLs are not broken in notifications eliorivero Editor trunk normal normal Awaiting Review defect (bug) new 2017-07-24T21:55:25Z 2017-07-24T21:55:25Z "I have Google Fonts blocked in `/etc/hosts` and I get this notification when I edit a post, which is fine, except by the fact that it overflows: [[Image(https://cldup.com/t7l1Z2fRi0-3000x3000.png)]] The attached patch solves this by allowing to break the long string and it looks like this: [[Image(https://cldup.com/sMxEn8Cxn3-3000x3000.png)]] " eliorivero 4-7 Days Ago 41424 loose error message: Error establishing a database connection tthorp Database trunk normal normal Awaiting Review enhancement new 2017-07-24T14:24:44Z 2017-07-24T15:05:29Z "In multisite, if this query returns no results, the database connection error is triggered: SELECT blog_id FROM wp_blogs WHERE domain IN ( 'example.com' ) AND path IN ( '/' ) ORDER BY blog_id ASC LIMIT 1 I think the error should not mention database connection but allude to the fact that the site was not found. For my use case, I had migrated a production database into QA and didn't update the domain to be qa.example.com so the connection failed. I hope this is helpful. I'm not sure I know what the exact solution is but I thought the connection attempt had failed, when in fact the connection had been made but the data was not as expected. Also, the failure was not found in debug.log." tthorp 4-7 Days Ago 41422 Need replace_filter() function for improved Just In Time filter adjusment bobbingwide Formatting trunk normal normal Awaiting Review enhancement new 2017-07-24T09:42:10Z 2017-07-25T12:00:24Z "In the new solution for text widgets there is some Just In Time code that adjusts the attached filter functions. The logic finds the priority before removing the filter function then re-instates the filter with the same priority. This logic assumes that the sequence in which the filter functions have been attached with the same priority are performed doesn't matter. If this is not the case then the order change could affect processing where the filter is shared but invoked for different purposes. e.g. the 'widget_text' filter for Text widget and Custom HTML widget The logic could be improved by implementing a new suite of filter functions including replace_filter(), restore_filter(), disable_filter() and a dummy filter function disabled_filter(). Instead of calling remove_filter() and add_filter() we'd use disable_filter() and restore_filter() disable_filter() is simply replace_filter() using the disabled_filter() function. Example: Filters attached at priority 10 have been set to do_shortcode and balanceTags. With the current logic after JIT replacement the attached filters would have become balanceTags then do_shortcode. Using disable_filter() and restore_filter() the attached filters at priority 10 would be unchanged. " bobbingwide 4-7 Days Ago 41417 Error when opening up Thickbox lightbox on plugins page moeloubani1 Administration 4.8 normal normal Awaiting Review defect (bug) new 2017-07-24T05:06:07Z 2017-07-24T05:06:07Z "When opening up the Thickbox modal from a Toolbar link on the plugins page it seems to hang and wait for something to load - once it's closed you can see an error that comes up in the console: Uncaught TypeError: Cannot read property 'focus' of undefined at HTMLBodyElement. (load-scripts.php?c=0&load[]=hoverIntent,common,admin-bar,underscore,wp-util,wp-a11y,updates,jquery-…:364) at HTMLBodyElement.dispatch (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils&ver=4.8:3) at HTMLBodyElement.r.handle (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils&ver=4.8:3) at Object.trigger (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils&ver=4.8:3) at Object.a.event.trigger (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils&ver=4.8:9) at HTMLBodyElement. (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils&ver=4.8:3) at Function.each (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils&ver=4.8:2) at a.fn.init.each (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils&ver=4.8:2) at a.fn.init.trigger (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils&ver=4.8:3) at HTMLDivElement. (load-scripts.php?c=0&load[]=hoverIntent,common,admin-bar,underscore,wp-util,wp-a11y,updates,jquery-…:314)" moeloubani1 Last Week 41409 No point in storing empty EXIF/IPTC data on post meta table geminorum Media trunk normal normal Awaiting Review enhancement new 2017-07-22T15:37:02Z 2017-07-22T15:37:02Z "- Post meta tables are bloated with often not used EXIF/IPTC data for each image attachments. - `wp_read_image_metadata()` generates `aperture`, `credit`, `camera`, `caption`, `created_timestamp`, `copyright`, `focal_length`, `iso`, `shutter_speed`, `title`, `orientation`, `keywords`. and the data often stored as empty key/value pairs on each attachment metadata. - I see no problem on filling default/empty values upon retrieving the data. - and mentioning the core currently has no way of using ''stored'' `image_meta`." geminorum Last Week 41404 Sunset Windows Live Writer Manifest File jhabdas General trunk normal normal Awaiting Review enhancement new 2017-07-22T08:54:08Z 2017-07-23T01:45:07Z "Given the following code produced on the front-end for users: {{{ }}} Following the link to the manifest XML file produces a node in the tree looking like: {{{ }}} Manifest produced by the `wlwmanifest_link()` function in `general-template.php` and was added to core in version `2.3.1` with [https://core.trac.wordpress.org/ticket/5023 ticket/5023] 10 years ago. Assuming usage of Windows Live Writer is less than 2% is there anything which would prevent this code from being deprecated in an upcoming minor and (ideally) removed from the codebase altogether? I suspect removing this from Core will have the following benefits: - Improved security by greater obscurity of the admin URL - Less code to download by the browser - Less code to maintain in Core - Less cognitive load on users inspecting generated site source " jhabdas Last Week 41403 "Support ""class"" and ""id"" attributes on wp_oembed_get()" ramiy General normal normal Awaiting Review defect (bug) new 2017-07-21T19:58:48Z 2017-07-21T19:58:48Z "The oembed function `wp_oembed_get( $url, $args )` allows us to set additional arguments for retrieving embed HTML. The problem is that currently the function supports two arguments, only `width` and `height`. In some cases developers need more flexibility, to set other HTML attributes like `id`, `class` and maybe even `title` (for better accessibility). ---- I was trying to thinking of an example and I think that the simplest example would be [https://v4-alpha.getbootstrap.com/utilities/responsive-helpers/ bootstrap responsive embeds]. {{{
}}} Currently you can't set custom classes in iframe with the attributes: {{{ wp_oembed_get( 'https://...', array( 'class' => 'embed-responsive-item' ) ); }}} " ramiy Last Week 41391 Links to media in password protected pages sdoffing Security 4.7.5 normal normal Awaiting Review defect (bug) new 2017-07-20T21:38:59Z 2017-07-24T09:06:28Z "I was able to see a google search and view a pdf that was housed on a password protected page. This was one of 2 pages I found: http://www.mspcommercial.net/wp-content/uploads/2012/07/4-tessar-14.pdf. Please confirm that the other PDFs we have stored on pages that are set up the exact same way are safe. Thank you. Samantha Doffing" sdoffing Last Week 41390 "Comment page numbers feel wrong when using ""Other comment settings""" henry.wright Comments normal normal Awaiting Review defect (bug) new 2017-07-20T18:41:56Z 2017-07-21T10:13:04Z "The ""Other comment settings"" section can be found under Settings > Discussion. Steps to reproduce: 1. Break comments into pages with '''3''' top level comments per page and the '''last''' page displayed by default. Comments should be displayed with the '''newer''' comments at the top of each page 2. Go to a post which already has more than, say, 10 comments 3. Navigate to the previous comments using the comment pagination If you now look at the URL, it won't be ""comment-page-2"". Depending on the number of comments the post you're looking at has, it will read something like ""comment-page-4"" or ""comment-page-7"". This doesn't feel right to me. This should be comment page ""2""." henry.wright Last Week 41379 Documentation needs improvement in do_action parameters ronakganatra HTTP API normal normal 4.9 defect (bug) new 2017-07-20T11:18:55Z 2017-07-20T11:38:30Z Documentation needs improvement in do_action parameters in class file. parameter is passed in do_action() but not defined in documentation. ronakganatra Last Week 41375 Editor not working in older versions of Safari, or Roccat Browser on older versions of macOS orbitcarrot TinyMCE 4.8 normal normal Awaiting Review defect (bug) new 2017-07-20T09:51:47Z 2017-07-22T14:18:51Z "When using WordPress 4.8 on Safari 5 or Safari 6 (possibly Safari 7) the editor doesn't show the two rows of tools and the content area is blank. The same thing happens when using Roccat Browser on macOS 10.5, 10.6 and 10.7. The errors which show in the console are: ReferenceError: Can't find variable: URL - that's line 11 on tinymce.min.js ReferenceError: Can't find variable: tinymce - that's line 1 on plugin.min.js ReferenceError: Can't find variable: tinymce - that's line 10043 on post.php All versions of WordPress 4.7 have worked perfectly." orbitcarrot Last Week 41373 Wordpress 4.8 and WPML returns NULL on retrieve of translated slugname. Only ID works BackuPs General 4.8 normal normal Awaiting Review defect (bug) new 2017-07-20T08:18:06Z 2017-07-25T09:06:21Z "Hi There are mayor issues with wp 4.8 and wpml, polylang or any other multilanguage plugin. Since wp 4.8 the shortcode executed in the translated page is not calling the translated category anymore I have one category for my custom post type ""portfolio"" called ""gallery"" the category is translated to ""gallerij"" for the dutch language. They both have 3 posts attached. Each for their own language. I have this in my english page. [portfolio category=""gallery""] calling the posts from the category gallery and it is showing 3 posts. The page is duplicated into Dutch but the shortcode is the SAME. So the dutch page also has [portfolio category=""gallery""] and NOT [portfolio category=""gallerij""]. So the dutch page is calling the English category. Now in wp 4.7.x this works perfectly and the dutch page shows the dutch portfolio items, or if you use a blog shortcode the blog items for each language. But the moment wp 4.8 is installed the dutch pages with shortcodes are empty and i need to set the Dutch page with the shortcode to translated independently and change the shortcode manually to [portfolio category=""gallerij""] so that it is calling the dutch category called ""gallerij"" What changed in the wp code? The theme i am using did not change the theme code. Moreover it happens in any theme i try. The return is NULL when calling a slugname. I tested this 3 x times now in a clean wp install on my local host and i get similar results all the time. The moment i revert to wp 4.7 there is no issue. If i activate wp 4.8 the issue occurs and the translated page is empty not showing any portfolio or blog items. Note : i tested this in my local host and was able to reproduce the same issue over and over again by reverting back and forth to wp 4.7.4 and 4.8. Note : the categories are synchronized !! There is no issue in using the settings wrong or whatever. in wp 4.7.x this {{{#!php term_id; echo 'term-id :'.$term_id; }}} returns the id of the translated category in the translated page. in wp 4.8 and above it returns 0 for that category in the translated page but the correct id in the page with primary original language. So there are two faillures here. The get_term_by fails but also the query fails... see previous reply. They both return nothing when wp 4.8 is used. $cat a list of category slugnames in the original default language {{{#!php 'category', 'field' => 'slug', 'terms' => explode(',', $cat) ) ); $r = new WP_Query($query); }}} $cat has the slugname(s) selected separated by a ',' I reported this to wpml, https://wpml.org/forums/topic/translated-category/ but further testing learned that it happens in any multilanguage plugin so it must be a wp issue. As said it does not happen in wp 4.7.x or below. The solution provided for wpml does not work for me as all users have already generated shortcodes that use the slugnames, but more over these slugnames are used to filter the items by ajax filtering. its a big problem and serious bug. Pls provide a fix." BackuPs Last Week 41372 when no any media. at that time this section is not usable. so Please hide when no any media. rushabh4486 Media normal normal Awaiting Review defect (bug) reopened 2017-07-20T07:57:16Z 2017-07-22T12:14:25Z When no any media at that time this section is not usable. So please hide when no any media. rushabh4486 Last Week 41371 Copy & paste of html tables stopped working irzig TinyMCE trunk normal normal Future Release defect (bug) new 2017-07-19T23:05:56Z 2017-07-20T10:27:58Z "Dear WordPress team, we are experiencing a problem after upgrading to 4.8. Copy and Paste of tables using the visual editor copies only the content of the first cell. Steps to reproduce: 1. create a new article 2. insert a new table by changing to text mode and pasting the following html code: {{{
}}} 3. go back to visual mode 4. create a copy of the table (Ctrl+C, Ctrl+V) Expected result: two copies of the same table, and this worked reliably a couple of weeks ago Actual result: Only the content of the first cell (R1C1 in this case) is pasted. I also tried, instead of step 2, to create a table in Word (or rather LibreOffice) and copy it over to the editor. However, same result after step 4. Please, can anybody verify that this is a bug? Since it also is about losing information by copying, I feel like this might be related to #41026." irzig Last Week 41367 Documentation needs improvement akbarhusen Login and Registration normal normal Awaiting Review defect (bug) new 2017-07-19T11:59:11Z 2017-07-19T12:45:47Z akbarhusen Last Week 41363 Needs improvements in the documentation of the function ronakganatra Administration normal normal Awaiting Review defect (bug) new 2017-07-19T07:57:14Z 2017-07-19T11:10:22Z nocache_headers(); is used but unclear as to what it actually does. documentation need improvement ronakganatra Last Week 41362 Make locate_template() filterable to change the template locations kylejennings83 Themes 4.8 normal normal Awaiting Review enhancement new 2017-07-19T02:07:03Z 2017-07-19T15:36:04Z "Right now WordPress expects all templates to reside in the root of your theme directory. We have all come across a theme with dozens of templates and well, that can get messy. With 6 lines of code we can easily, and vastly enhance the templating system. This would provide a number of benefits: 1) This would allow developers to logical group functionally similar files / separates functional dissimilar files 2) It allows the root of the theme directory to be cleaned up and used for ""resources"" such as the functions.php and style.css files 3) By having the ability to pick and choose which templates go where, we can turn WordPress into an MVC application framework (personally what I use this technique for) 4) Related - this plays really nice with Timber 5) This lays the groundwork for future enhancements which I also use and plan to introduce shortly = Examples = == Moving all templates with the {{{""templates_path""}}} filter == Say I wanted to move all my templates into a directory named ""templates"" because as mentioned, this theme I inherited has dozens of templates, maybe one for each page. A good start would be to just move all the templates into a directory named ""templates"": {{{#!php ID; $obj = get_queried_object(); if($obj->post_parent == $parent_id) $path = rtrim($path, '/') . '/' . 'team'; return $path; } add_filter('page_templates_path', 'move_team_pages'); }}} Now your theme might look something like: {{{ /twentyseventeen/ |-- /assets/ |-- /inc/ |-- /templates/ |-- index.php |-- single.php |-- /team/ |-- page-mortimer.php |-- page-biff.php }}} As we see, the two filters can (and perhaps should) be used together, but can also be used alone. == Timber == As mentioned before, I use something like this on every project. I generally put all my templates into a directory called ""controllers"" and my twig files (if using Timber) into a directory called ""views"" so I have something akin to an MVC application. My functions file sets Timber to look for twig files in a directory called ""views"" which is right inside the theme directory (next to ""templates""): {{{ $timber = new \Timber\Timber(); Timber::$dirname = array('views'); }}} so my {{{ templates/index.php}}} could set up my Timber context and pass it all the way to the {{{ index.twig }}} file in the ""views"" directory: {{{ $context = Timber::get_context(); $context['posts'] = Timber::get_posts(); Timber::render('index.twig', $context); }}} " kylejennings83 Last Week 41359 Timeout login popup window loads admin instead of closing ritterml Security 4.8 normal normal Awaiting Review defect (bug) new 2017-07-18T20:10:48Z 2017-07-19T20:09:34Z "* I am logged into admin. * I leave my browser inactive. * I see a small login window in front of my active admin screen because my session has timed out. * I enter my login credentials. * I see my active admin screen in the small window and in the window behind. * I _SHOULD_ see the login window close upon successful login." ritterml Last Week 41358 Shutdown hooks can significantly slow down REST API responses mikejolley REST API normal normal Awaiting Review defect (bug) new 2017-07-18T16:36:56Z 2017-07-18T16:36:56Z "If you have a site with some slow, maybe deferred actions hooked into `shutdown`, these actions will slow the response from the REST API unnecessarily. To test, simply add the following then do a request to the WP Rest API: {{{#!php select IMAGES in the 'All media items' dropdown, select a month from the dropdown and click FILTER. I am being redirected to the websites homepage rather than the filter results. 3 people have replicated this bug, I personally have replicated it across 3 of our Wordpress websites. I tried disabling media related plugins and it had no affect. " mikedtv Last Week 41350 Support for random order in WP_Term_Query::query() camthor Taxonomy 4.8 normal normal Awaiting Review feature request new 2017-07-17T21:00:17Z 2017-07-17T21:00:17Z "As already valid and useful for posts, it should be possible to choose a random order also for terms. This could be achieved by adding ""rand"" as additional allowed value for ""orderby"". The function ""parse_orderby"" would need to be modified, translating ""orderby => ""rand"" into ""ORDER BY RAND()"" " camthor Last Week 41349 Media Library insert from URL doesn't give a message when a URL fails check karmatosed Media normal normal Awaiting Review defect (bug) new 2017-07-17T20:32:53Z 2017-07-17T20:32:53Z "There is a check to see if something is a valid URL. This is awesome, but it doesn't give a message when fails. This is a weird user experience as you are left wondering what happened. There is some strange behaviour, it sometimes has 'link text' vanishing, other times doesn't. It also can appear to flash as a block and then vanish. The logic of when the link text input shows or doesn't, seems a little confusing to work out. What would be better would be to have a message when it's not a correct URL and check for inconsistencies in the link text input showing. [[Image(https://cldup.com/bnlQYzjP04.gif)]]" karmatosed Last Week 41346 Introduce a hook for individual plugin loaded Rarst Plugins trunk normal normal Awaiting Review feature request new 2017-07-17T16:16:36Z 2017-07-17T17:23:09Z "The current plugin load during core boot is essentially a series of `include` firing: {{{#!php // Load active plugins. foreach ( wp_get_active_and_valid_plugins() as $plugin ) { wp_register_plugin_realpath( $plugin ); include_once( $plugin ); } unset( $plugin ); }}} Currently it is ''exceptionally'' hard to fire off arbitrary code between these includes. The closest I got over years is the following code, which I consider highly unstable: https://gist.github.com/Rarst/c32575ffc26df59a45c0 Distinguishing between load events of individual plugins is highly desirable for performance troubleshooting. In current state it is defacto impossible to troubleshoot with PHP code, requiring manual toggling of plugins or low level PHP profiler set up. Adding individual plugin load event will make it '''much''' easier to profile and diagnose performance issues at this load stage. Can be as simple as: {{{#!php include_once( $plugin ); do_action( 'plugin_loaded', $plugin ); }}} " Rarst Last Week 41344 Secure Email Integration ina2n Administration 4.8 normal normal Awaiting Review enhancement new 2017-07-17T13:36:30Z 2017-07-17T14:49:12Z "By the time an entrepreneur decides to use WP multisite, the need for extensive email integration is a requirement. Whether the new startup company is on shared or dedicated hosting, the need for proper secure email integration into their WP sites is a must. The necessary code to deliver secure email with PHPMailer is minimal, and the need to do so in today's email environment is critical. As you may know, Gmail (possibly others) has placed more strict requirements on using their SMTP email servers for outside accounts, and this has created a greater need for private email servers. Please integrate secure email into WP multisite core with proper admin menus. I've been using the following code as a personal plugin for more than a year: IsSMTP(); $phpmailer->Host = 'mail.youremailserver.com'; // SMTP Host $phpmailer->SMTPAuth = true; // Authentication, other option is false, but reckless and ill advised $phpmailer->Username = 'yourusername@youremailserver.com'; $phpmailer->Password = 'yourpassword'; $phpmailer->SMTPSecure = 'ssl'; // enable if required, 'tls' is another possible value $phpmailer->Port = 587; // SMTP Port $phpmailer->SMTPOptions = array ( 'ssl' => array('verify_peer' => false,'verify_peer_name' => false,'allow_self_signed' => true)); //Enable SMTP on email servers with self-signed certificates // The following settings are optional and can be set for static emails, however, if you're using a dynamic email newsletter plugin such as Woocommerce or SendPress, then you want to comment out these lines by leaving the // at the front of each line. Any variables placed here will override all other email sending plugins. You can change any one of these settings to override all email sending plugins. For example, you might want your email 'FromName' to read as your company name, regardless of what you have setup in Woocommerce, SendPress or other email sending plugins. // $phpmailer->From = 'yourusername@youremailserver.com'; // $phpmailer->FromName = 'Your Company Name'; //This can be your company, website, or your your name // $phpmailer->Subject = 'Your Company Title'; // Leave this blank '' if you don't want the subject line automatically populated // $phpmailer->SMTPDebug = 2; // 1: show client -> server messages only. Don't use this - it's very unlikely to tell you anything useful. // 2: show client -> server and server -> client messages - this is usually the setting you want // 3: As 2, but also show details about the initial connection; only use this if you're having trouble connecting (e.g. connection timing out) // 4: As 3, but also shows detailed low-level traffic. Only really useful for analysing protocol-level bugs, very verbose, probably not what you need. }" ina2n Last Week 41341 Theme update notification appearing multiple times hardeepasrani Themes trunk normal normal Future Release defect (bug) new 2017-07-17T06:19:52Z 2017-07-17T06:24:40Z "So I went to my dashboard and there were 5-6 themes which were out of date. So I clicked on Update on all, and opened the model of one of the themes (see the picture if you're confused). And as the themes were getting updated, the update alert started to appear on the opened theme for all the themes. Looks like a bug to me." hardeepasrani Last Week 41340 fsockopen HTTP Proxy support is broken for HTTPS URLs flameeyes General 4.8 normal normal Awaiting Review defect (bug) new 2017-07-16T12:47:02Z 2017-07-16T12:47:02Z "First of all, a little bit of background on HTTP proxies. ""HTTP proxies"" can exist with and without TLS at the proxy level. Both varieties allow you to connect to HTTPS hosts, through the CONNECT method (https://tools.ietf.org/html/rfc7231#section-4.3.6). This means that there are four different valid combinations of TLS at proxy connection level and TLS at remote host connection level. WordPress only allows setting a single proxy host (and port), but provides no configuration for whether it should be connected through TLS. The curl code correctly interprets this as using a non-TLS HTTP proxy for both HTTP and HTTPS connections. fsockopen instead will use the remote host TLS (ssl) option even when opening the connection to the Proxy, effectively forcing the same host:port pair to be used both as TLS and not, which does not generally work. Resulting in these error connections: HTTP proxy with no TLS: - https://api.wordpress.org/ -> tries connecting to proxy with tls, fail. - http://api.wordpress.org/ -> works HTTP proxy with TLS: - https://api.wordpress.org/ -> (probably? -- haven't tried) works - http://api.wordpress.org/ -> tries connecting to proxy without tls, fail. " flameeyes Old Tickets 41329 Undefined constants in class WP_Filesystem_Direct nabil_kadimi Filesystem API trunk normal normal Awaiting Review defect (bug) new 2017-07-14T15:09:02Z 2017-07-14T15:13:24Z "I'm using the WordPress filesystem classes, it seems the classes assume some constants are always defined. Anyways, the errors: {{{ Notice: Use of undefined constant FS_CHMOD_FILE - assumed 'FS_CHMOD_FILE' in /var/www/public/wp-admin/includes/class-wp-filesystem-direct.php on line 152 Notice: Use of undefined constant FS_CHMOD_FILE - assumed 'FS_CHMOD_FILE' in /var/www/public/wp-admin/includes/class-wp-filesystem-direct.php on line 152 Notice: Use of undefined constant FS_CHMOD_FILE - assumed 'FS_CHMOD_FILE' in /var/www/public/wp-admin/includes/class-wp-filesystem-direct.php on line 152 }}} I thought I would suggest a patch... Thanks, Nabil" nabil_kadimi Old Tickets 41328 lightbox plugins cannot get image address to open except from image link qdinar Gallery 4.8 normal normal Awaiting Review feature request new 2017-07-14T14:43:04Z 2017-07-14T14:44:25Z "it would be good if you put image sizes specially for lightbox plugins. it is already possible to edit A tag's href attributes manually by adding something like ""-768x1024"" but that endings differ for different images so it is not easy. it is not possible to edit links of images of gallery at all, though it is possible to copy-past gallery code from preview's html source and then edit it manually. by default single images and gallery images link to full version of image or to attachment page, and it is not possible to change to smaller version from gui. it would be good if it would be possible to easily select smaller image from gui because as i said they can have different endings. and it would be especially more comfortable for galleries because it would change many links at once. maybe it would be good to provide additional image address in additional attribute for usage by lightbox plugins. so A tags around image might link to full image or attachment as configured and lightboxes would get get image address from custom attribute." qdinar Old Tickets 41324 Action of password-protect form. gulliver Posts, Post Types normal normal Awaiting Review defect (bug) new 2017-07-14T12:38:49Z 2017-07-14T12:43:17Z "The default form action too-easily (I think just two submissions of a blank or incorrect password) loads wp-login.php?action=postpass with a 'service unavailable' message'). Simple validation to ensure correct password can prevent this. " gulliver Old Tickets 41316 "Introduce ""Try Gutenberg"" callout" melchoyce Editor normal normal Future Release task (blessed) new 2017-07-13T21:47:00Z 2017-07-24T18:59:17Z "At the WordPress Community Summit, we talked about getting more eyes on Gutenberg early by introducing it as a beta feature for folks to test out before being officially released. This could be some kind of pointer or notice in your dashboard with a link to install the plugin, and also a link to https://make.wordpress.org/test/handbook/call-for-testing/gutenberg-testing/ (or similar site). cc @matveb and @joen" melchoyce Old Tickets 41309 Theme and plugin editing experience improvements at smaller screens karmatosed Themes normal normal Awaiting Review defect (bug) assigned 2017-07-13T13:52:03Z 2017-07-14T10:13:38Z "It was running some tests and noticed how bad the editing experience is when there is a smaller screen. An example is: [[Image(https://cldup.com/6dnk2TUA53-3000x3000.png, 80%)]]" karmatosed Old Tickets 41304 Bad protocol sanitization in KSES for URLs NOT RFC 3986 compliant bogdanpreda Formatting 4.8 normal normal Awaiting Review defect (bug) new 2017-07-13T10:41:29Z 2017-07-13T14:10:32Z "For URL's that are passed through the kses sanitizer. As specified in RFC 3986, Section 3.3 The path component contains data, usually organized in hierarchical form, that, along with data in the non-hierarchical query component (Section 3.4), serves to identify a resource within the scope of the URI's scheme and naming authority (if any). The path is terminated by the first question mark (""?"") or number sign (""#"") character, or by the end of the URI. If a URI contains an authority component, then the path component must either be empty or begin with a slash (""/"") character. If a URI does not contain an authority component, then the path cannot begin with two slash characters (""//""). In addition, a URI reference (Section 4.1) may be a relative-path reference, in which case the first path segment cannot contain a colon ("":"") character. The ABNF requires five separate rules to disambiguate these cases, only one of which will match the path substring within a given URI reference. We use the generic term ""path component"" to describe the URI substring matched by the parser to one of these rules. So colon(':') is allowed inside URL's. When trying to split the URL like this: {{{#!php chmod( $file, $mode ); return true; }}} Steps to replicate: 1-Fresh XAMPP installation 2-Install the beta-tester plugin 3-Switch to Bleeding Edge Nightlies 4-Head to update" KhalidAl Old Tickets 41302 WordPress not stopping queries which have reached limit and preventing users to load WordPress until query times out juslintek Database 4.8 normal normal Awaiting Review defect (bug) new 2017-07-13T07:28:09Z 2017-07-14T07:58:38Z "[[Image(Pasted image at 2017_07_13 10_14 AM.png)]] I have problem with WordPress mysql `max_questions=600, max_updates=600` limit {{{ User 'id1561843_wp_ac6601cd835d82e22d89d11a3ea228a0' has exceeded the 'max_queries_per_hour' resource (current value: 500) }}} After {{{ wp-db.php:830 }}} comes timeout. I suspect that that after limit is reached {{{ public function set_charset( $dbh, $charset = null, $collate = null ) { }}} throws and error. After that WordPress gets stuck on loading something. And you cannot make any other queries on other browser windows. Proper script should just kill the query after error that limit has been exceeded." juslintek Old Tickets 41293 wp_get_post_terms do not work with 'id=>name' argument dany2217 Taxonomy 4.7.5 normal normal 4.9 defect (bug) reopened 2017-07-12T07:56:31Z 2017-07-13T13:37:55Z "Hi, i'm not sure is that really bug, let me explain it. When i used code below it doesn't worked for me. {{{#!php 'id=>name', )); // returns // array(0 => 'term name 1', 1 => 'term name 2') }}} The term ID is just an index of array, so i tried to find the reason. After trace the core code i found the problem in wp_get_object_terms function. {{{#!php https://blog.travis-ci.com/2017-07-11-trusty-as-default-linux-is-coming Incoming patch will allow us to continue having PHP 5.2 and 5.3 Travis CI jobs until September 2017 ---- The current availability of PHP 5.2 and 5.3 in the Travis CI build environment is the following: 1. `dist: precise` with `sudo: false` 2. `dist: trusty` with `sudo: false` 3. `dist: precise` with `sudo: false` 4. `dist: precise` with `sudo: required` WordPress' current Travis CI config uses option `1` above Travis CI will override this configuration with option `2` come July 18th 2017 Workaround this issue for PHP 5.2 & 5.3 until September 2017 using option `3` for the PHP 5.2 and 5.3 Travis CI jobs Come September 2017 Travis CI will overwrite option `3` above with option `4` I've created the following Travis CI issue on the subject: https://github.com/travis-ci/travis-ci/issues/8072" netweb Old Tickets 41290 Embedded videos not keyboard accessible once video is playing GrahamArmfield Embeds normal normal Awaiting Review defect (bug) new 2017-07-11T18:51:34Z 2017-07-17T22:34:27Z "There are problems trying to operate videos embedded with the native editor in WordPress if I'm a keyboard only user. Before the video has started playing I can tab to most of the various video controls and clearly see where I am. However, a few seconds after the video has started playing, the controls disappear. It's now impossible to see where keyboard focus is and to easily operate the rest of the controls using a keyboard. Ideally, the controls should become visible again whenever I press tab or shift-tab - like they do if I hover over the video with a mouse pointer. I have made a video to demonstrate the issue: https://youtu.be/7N1-Ch7QbtA I'm running Chrome 59 on Windows 10. WP version 4.8 on PHP7." GrahamArmfield Old Tickets 41286 Focus style and High Contrast Mode afercia Administration normal normal Future Release defect (bug) new 2017-07-10T20:20:24Z 2017-07-17T16:33:21Z "Noticed during work done on Gutenberg, thanks to Simply Accessible. See https://github.com/WordPress/gutenberg/issues/1562#issuecomment-313476750 Operating systems have a high contrast mode to switch to a few-colors/high contrast version of what's rendered on the screen. While this seems to not cause issues on macOS, it does on Windows High Contrast Mode. People with various vision issues use high contrast mode. People working in dark environments, for example TV production studios, often use it. Windows High Contrast Mode removes any CSS box-shadow. Most of the WordPress focus styles in the admin are built with multiple box-shadows. As a consequence, with Windows High Contrast Mode turned on, there's no focus indication at all. In order to be visible in High Contrast Mode, focus styles need to use an outline or a border. There are different techniques that work, they'd need to be tested across different platforms, browsers. etc. Also, WordPress sometimes makes use of the ""circular focus"" that would need some special treatment. Worth noting, on Windows the High Contrast Mode works well with just Internet Explorer and Edge. Chrome doesn't support it (it has a dedicated extension and alternative themes). Firefox supports it partially. It would be great to experiment new and improved focus styles. At the very least, the inner box-shadow could be replaced with an outline, that would probably change very little visually and allow focus to work in High Contrast Mode. However, there are pending tickets on Trac and ongoing discussions to experiment new focus styes. See for example #34957, #34904, and #28599. This could be a good opportunity to give some new traction to those tickets and improve the focus styles both visually and for accessibility. Screenshots in Microsoft Edge: Current (note: the ""Published"" link is focused): [[Image(https://cldup.com/rV8cVtW6ll.png)]] Native browser outline: [[Image(https://cldup.com/spJ88EG268.png)]] Testing a 1px solid outline: [[Image(https://cldup.com/-pFMs0tz_C.png)]] " afercia Old Tickets 41284 HHVM + WordPress Multisite 4.8 occasional slow query aedelgod General 4.8 normal normal Awaiting Review defect (bug) new 2017-07-10T17:52:28Z 2017-07-10T17:52:28Z "Was wondering if anyone else has come across this besides me on Multisite environments. Occasionally I get a slow query ONLY with HHVM active, details are as follows: Query: SELECT option_name, option_value FROM _options WHERE autoload = 'yes' Caller executing: wp_load_alloptions() wp-includes/option.php:189 Rows: 218 Execution time: 0.0553s Environment: WordPress 4.8 as Multisite Cloud VM with 6 VCPU cores and 6 GB VRAM Apache 2.4.25 PHP 5.6.99-hhvm HHVM 3.6.0-dev MySQL 5.6.36" aedelgod Old Tickets 41281 attachment_url_to_postid results in very slow query Takahashi_Fumiki Database trunk normal normal Awaiting Review enhancement new 2017-07-10T07:53:25Z 2017-07-10T07:53:25Z "`attachment_url_to_postid` throws query like this: {{{ # wp-includes/media.php ll.3922 $sql = $wpdb->prepare( ""SELECT post_id FROM $wpdb->postmeta WHERE meta_key = '_wp_attached_file' AND meta_value = %s"", $path ); }}} But wp_postmeta table has index only of `meta_key`, this may cause file sort. == Why this is problem == Let's assume that you have 20,000 posts and each post has 10 attachments in your WP news site. MySQL filters rows with `meta_key` but still remain 200,000 possible rows. This causes file sort. `attachment_url_to_postid` is used not only in admin screen, but also in public area(e.g. AMP Plugin https://wordpress.org/plugins/amp/ ). Now twitter changes URL for mobile device if AMP version is available. So, MySQL CPU raises up to 100% by `attachment_url_to_postid` if site traffic is high, == Solution == To avoid slow query, I suggest adding another index. {{{ ALTER TABLE $wpdb->postmeta ADD INDEX meta_key_meta_value (meta_key(191), meta_value (64)); }}}" Takahashi_Fumiki Old Tickets 41279 Make PDF Thumbnail (WP 4.7 feature) accessible via the Media Manager sflwa Media normal normal Awaiting Review feature request new 2017-07-09T19:24:26Z 2017-07-13T19:08:09Z "When you upload a PDF file WordPress creates a ""preview image"" - This was added as of WP 4.7 This feature request to have that image also added into the database so that it is accessible via the Media Manager. The use case for this feature is that I have a Monthly Newsletter and want to use the preview image (page 1 of the PDF) as the featured image for the post where I am putting the link to the PDF Additionally some plugins (like visual composer) allow you to insert single images, however, you need to be able to select it from the media manager, not just put in a URL" sflwa Old Tickets 41278 SQL_CALC_FOUND_ROWS slow query lubimow Database 4.8 normal normal Awaiting Review defect (bug) new 2017-07-09T17:12:10Z 2017-07-19T18:41:46Z "In the logs of slow queries when searching for steel, the following types of logs appear: {{{ SELECT SQL_CALC_FOUND_ROWS wp_posts.ID FROM wp_posts WHERE 1=1 AND (((wp_posts.post_title LIKE '%donald%') OR (wp_posts.post_excerpt LIKE '%donald%') OR (wp_posts.post_content LIKE ‘%donald%’)) AND ((wp_posts.post_title LIKE '%trump%') OR (wp_posts.post_excerpt LIKE ‘%trump%’) OR (wp_posts.post_content LIKE '%trump%'))) AND wp_posts.post_type IN ('post', 'page', 'attachment') AND (wp_posts.post_status = 'publish' OR wp_posts.post_status = 'acf-disabled' OR wp_posts.post_author = 186 AND wp_posts.post_status = 'private') ORDER BY (CASE WHEN wp_posts.post_title LIKE ‘%donald trump%' THEN 1 WHEN wp_posts.post_title LIKE ‘%donald%’ AND wp_posts.post_title LIKE '%trump%' THEN 2 WHEN wp_posts.post_title LIKE '%donald%' OR wp_posts.post_title LIKE '%trump%' THEN 3 WHEN wp_posts.post_excerpt LIKE '%donald trump%' THEN 4 WHEN wp_posts.post_content LIKE '%donald trump%' THEN 5 ELSE 6 END), wp_posts.post_date DESC LIMIT 0, 30; }}} How can I eliminate it?" lubimow Old Tickets 41277 Random post returned by get_permalink when on post type archive espellcaste Permalinks 4.8 normal normal Awaiting Review defect (bug) new 2017-07-09T15:04:09Z 2017-07-09T15:04:09Z "get_permalink has an odd behavior when on post type archives. It fetches a radom article from the taxonomy archive, instead of returning the link from the archive itself. Maybe it was supposed to. But if I do this: ""> When the link is on a category archive, it will redirect the user to a radom article from that particular category, because the get_permalink is returning that particular random post." espellcaste Old Tickets 41273 WP REST API: allow separate add_post_type_support() for post when accessing via REST vs WP Admin lougreenwood REST API 4.8 normal normal Awaiting Review feature request new 2017-07-08T13:17:33Z 2017-07-11T16:31:10Z "I have a number of CPTs where I have disabled various features (post_title, author etc) so that these fields are disabled in WP Admin. However, I have code which is triggered aftershave which auto-sets values for these fields. The reason for disabling the fields in WP Admin is to maintain the integrity of these field values and know that the post_title will always be an auto-set value. I also have functional tests which use WP REST API to check that these post_titles are automatically set correctly. It seems that when features are disabled using add_post_type_support(), its not possible to override this when accessing WP REST API. this means that in my scenario it's not possible to pass my tests because post_title is not present in REST API response (because it's disabled using add_post_type_support()) I have an idea for a short term hack, which is to check for user ID or role (to identify a test user which I used by functional tests) and then enable these features when REST API is being used. but it seems overly hacky. Is there any plan for separating add_post_type_support() for REST and standard WP?" lougreenwood Old Tickets 41272 Unattached media URLs broken for anything over 1000 henry.wright Permalinks normal normal Awaiting Review defect (bug) new 2017-07-07T23:09:21Z 2017-07-08T16:26:17Z "'''Steps to reproduce''' 1. On your local computer, rename a file to {{{1180.jpg}}} 2. Upload the file to the Media Library 3. Visit {{{example.com/1180}}} You will get a 404 broken link. If you do the same for a 1, 2 or 3 digit filename, you won't see the issue. {{{ example.com/31.jpg // Works example.com/872.jpg // Works }}} The problem isn't just related to images. {{{ example.com/1871.mp3 // 404 }}} " henry.wright Old Tickets 41271 Customizer sanitize_callback gets called multiple times on setting change kylejennings83 Customize 4.8 normal normal Awaiting Review defect (bug) new 2017-07-07T19:24:23Z 2017-07-11T04:23:44Z "I've noticed that the my Customizer setting sanitize_callback get's called multiple times (4). I think I have deduced that it's not anything weird I'm doing and that it's not a result of a conflicting plugin. Using VVV, I spun up a new site, deactivated all the plugins and using only the default Twenty Seventeen theme I added the following to functions.php file: {{{#!php add_setting( 'sidebar_size_setting', array( 'default' => 'wide', 'sanitize_callback' => function($val) { error_log('boom'); // to test }, ) ); $wp_customize->add_control( 'sidebar_size_control', array( 'label' => 'Sizebar Size', 'section' => 'title_tagline', 'settings' => 'sidebar_size_setting', 'type' => 'select', 'choices' => array( 'wide' => 'Wide', 'narrow' => 'Narrow', ), ) ); } add_action('customize_register', 'wp_132423_customize_settings'); }}} Then I opened the Customizer and changed my ""Sizebar Size"" control from wide to narrow while tailing the error log which shows: {{{ [07-Jul-2017 18:12:22 UTC] boom [07-Jul-2017 18:12:22 UTC] boom [07-Jul-2017 18:12:22 UTC] boom [07-Jul-2017 18:12:22 UTC] boom }}} I noticed this while trying to find a way to run a function in the backend whenever a particular setting was changed. Seemed like the sanitize_callback was a good place to hook into and noticed this." kylejennings83 Old Tickets 41270 Allow deletion of plugins or themes from the Updates screen melchoyce Upgrade/Install normal normal 4.9 enhancement new 2017-07-07T18:59:05Z 2017-07-07T20:18:33Z "A suggestion from @matt on a recent [https://make.wordpress.org/core/2017/06/20/dev-chat-agenda-for-june-21st-4-8-1-week-1/#comment-32735 dev chat update thread]: > Sometimes when you get an update notice for something, you realize you don’t need it. (Like old twenty* themes.) Ability to delete a plugin or theme from the updates screen, instead of updating it." melchoyce Old Tickets 41266 Not hard coding the table alias prefix in WP_Meta_Query would make class more extendable thomaslhotta Query 4.8 normal normal Awaiting Review enhancement new 2017-07-07T13:36:44Z 2017-07-07T13:36:44Z "Hi, I am extending the WP_Meta_Query class for my own uses with custom tables that have the same structure as meta tables. It is an incredibly useful class for this. However the fact that the table alias prefix {{{mt}}} on line 535 is hard coded forces me to do awkward and complex string replaces if I want to use my extensions alongside built in meta queries. I think changing the prefix from being hard coded to a property/function of the meta query object would make this class much more versatile for plugin developers. " thomaslhotta Old Tickets 41265 Extension of WP_Query (tax_query with tax meta) Blackbam Query normal normal Awaiting Review enhancement new 2017-07-07T12:28:28Z 2017-07-07T15:05:37Z "In WP_Query we have a possibility to query posts depending on their meta value. Look at the following example: {{{ $args = array( 'post_type' => 'product', 'meta_query' => array( array( 'key' => 'color', 'value' => 'blue', 'compare' => 'NOT LIKE', ), ), ); $query = new WP_Query( $args ); }}} We also have a possibility to query by terms (custom taxonomy). Look at the following example: {{{ $args = array( 'post_type' => 'post', 'tax_query' => array( array( 'taxonomy' => 'people', 'field' => 'slug', 'terms' => 'bob', ), ), ); $query = new WP_Query( $args ); }}} In WordPress '''4.4.0''' we have introduced two important functions for developers. We can add and remove meta data to terms. Have a look at the following functions: https://developer.wordpress.org/reference/functions/get_term_meta/ https://developer.wordpress.org/reference/functions/update_term_meta/ https://developer.wordpress.org/reference/functions/delete_term_meta/ This introduction was great. However there is still NO WAY to use term meta within WP_Query. In my understanding '''a term meta query should be an extension of the tax_query'''. Currently a tax_query allows for the following parameters: - taxonomy - field - terms - include_children - operator More information here: https://codex.wordpress.org/Class_Reference/WP_Query#Taxonomy_Parameters '''We should add a meta_query functionality to the tax_query'''. My suggestion is to do it like this: For tax_query we allow the same parameters as for meta_query. https://codex.wordpress.org/Class_Reference/WP_Meta_Query - (tax_)meta_key - (tax_)meta_value - (tax_)meta_type - (tax_)meta_compare - (tax_)meta_query Example use case of what it could look like (renaming the parameters to (tax_) is maybe not needed): {{{ $args = array( 'post_type' => 'post', 'tax_query' => array( array( 'taxonomy' => 'people', 'tax_meta_query' => array( 'key' => 'color', 'value' => 'blue', 'compare' => 'NOT LIKE', ) ), ), ); $query = new WP_Query( $args ); }}} For the best exact implementation my knowledge of the WordPress core is not good enough however I think this feature will be needed! Here you can also see a use case of what I mean: https://wordpress.stackexchange.com/questions/272585/wp-query-tax-query-and-term-meta-how-to/272589" Blackbam Old Tickets 41258 Password protected pages don't show up when filling in password ferdinandzanda General 4.8 normal normal Awaiting Review defect (bug) new 2017-07-06T11:00:07Z 2017-07-13T09:07:20Z "Lately I encounter a problem with pasword protected pages on two different sites: https://www.zonnewijzerkring.nl/bulletin/login/ https://www.zeistervrijeschool.nl/onze-organisatie/medewerkers/ Both return a page not found message after sending the right password. The problem doesn't occur while being logged in on another tab. " ferdinandzanda Old Tickets 41251 """Add post"" overwriting a previous post in 4.8" putarguy@… Posts, Post Types 4.8 normal normal Awaiting Review defect (bug) new 2017-07-06T01:27:53Z 2017-07-10T05:55:23Z "I am running the 2012 theme on 4.8. with a few basic plugins. I am also experiencing the problem described in this closed ticket: #37889 In testing I disabled all plugins, and when I try to ""Add new"" under pages, I get a fresh empty page, and on the right it confirms the status is ""draft"" with ""0"" revisions and a ""Publish"" button for my finished work. I give the new page a test title and some fake content and ""Publish"" it. Immediately the ""Publish Info"" box shows 20 revisions and a publish date of a week earlier. I am now editing my previous post/page. Just trying to publish the new page overwrites the content fields in my previous page so the whole article is lost unless I restore from the revisions list at the bottom of the new page I just created. Regardless of which page I try to edit, the last page gets overwritten. I have a stock standard .htaccess file. " putarguy@… Old Tickets 41249 "Improve the ""collapse menu"" interface" JoshuaWold General normal normal Awaiting Review enhancement new 2017-07-05T20:31:56Z 2017-07-05T21:01:21Z "I would like to propose an update to how the left sidebar collapses in the WordPress admin. Right now I can shrink the sidebar down by shrinking the screen, but there are times I'd like to make the sidebar smaller to focus on the content I'm writing. It's also important that I don't have to go into fullscreen mode. It takes and a short delay to open/close it. While I'm in fullscreen mode I can't do anything else. Having a smaller sidebar visible at all times - with the option to easily make it bigger again - would be ideal. So, my proposal is: What if we had 3 stages to the left navigation sidebar? * As is, full size * Partially collapsed (like how it shows on tablet view) * Fully hidden In order to drag between these states there would be a button that appears on hover to pull the sidebar left or right. Kind of like how Things 3 does it: https://v.usetapes.com/mi3p2NxN3Z The attachment shows my recommendations for how I'd envision the 3 states: *Note:* While the interface shows the Gutenberg plugin (this conversation originated on this issue: https://github.com/WordPress/gutenberg/issues/1522), the impact of this feature request applies to the WordPress admin as a whole, as such the discussion was moved to Trac. " JoshuaWold Old Tickets 41248 Resource interpreted as Document but transferred with MIME type application/json casiepa REST API 4.8 normal normal Awaiting Review defect (bug) new 2017-07-05T20:12:29Z 2017-07-10T20:52:02Z "Lauching a /wp-json/wp/v2/posts seems to result in a warning in chrome console that says ""Resource interpreted as Document but transferred with MIME type application/json"" " casiepa Old Tickets 41246 Filter to short circuit term query 'terms_pre_query' jarocks Taxonomy normal normal Awaiting Review enhancement new 2017-07-05T17:36:33Z 2017-07-05T17:42:19Z "It would be nice to be able to effectively short-circuit a terms query so that you could return results from an external data source (`WP_Query` already has a filter like this in the form of `posts_pre_query`). My patch would add a similar filter `terms_pre_query` into the `::parse_query()` method of the `WP_Term_Query` class. This is more a proof of concept than anything else, I'm not sure if it makes sense to leave the burden of handling term caching as well as the hide_empty and the pad_counts parameters on the callback function. Hopefully some more experienced contributors will have some better insight into that." jarocks Old Tickets 41245 Attempting to update to wp 4.8 and receiving this message: wp-includes/comment-template.php palooka65 General 4.7.5 normal normal Awaiting Review defect (bug) new 2017-07-05T15:04:43Z 2017-07-05T15:04:43Z "I performed all the recommended questions and tips to no avail. No changes have been made to the theme since the last update. not using multisite; PHP version - 5.6.3 Appreciate any help. Thanks, Chet " palooka65 Old Tickets 41242 Image crop not working in mobile screen. yahil Media normal normal defect (bug) reopened 2017-07-05T05:46:20Z 2017-07-14T20:22:44Z "Hello Team, I am trying to crop the image from a mobile device, but it's not working. is there any solution? Dashboard -> media -> select media -> edit image" yahil Old Tickets 41241 questioning for sftp-hostname while update does not accept final slash jonny-s Upgrade/Install 4.8 normal normal Awaiting Review enhancement new 2017-07-04T22:42:11Z 2017-07-04T22:42:11Z "Trying to update themes/plugins/translations you will be asked to put the servers sftp login-dates if the files-owner isn't the server. Putting in there the hostname with a final / (slash) I get an error (without final slash works fine). Is there a missing if-clause to try wether there a a slash yet or no? I hope I've written understandable, cheers" jonny-s Old Tickets 41235 New load_screen_** action aussieguy123 General trunk normal normal Awaiting Review enhancement new 2017-07-04T04:03:54Z 2017-07-10T06:17:54Z "WordPress includes a load- hook, however this is not specific enough to have a function that runs only on one single screen in the admin area without additional logic. Lets say I have a custom post type ""killed_attachment"" and I want to have a function which will only run on the edit posts screen for this post type. My proposed solution: {{{#!php id : null; do_action('load_screen_' . $current_screen); } }}} With this new action, instead of requiring logic to detect the screen as in: {{{#!php id : null; switch ( $current_screen ) { case 'edit-killed_attachment': //Code which will only run on the killed attachment edit posts screen break; default: break; } } }}} You could simplify this as: {{{#!php comment_ID ); }}} to modify comment notification mails." ravisakya Old Tickets 41211 When the /category/category-name portion is repeated in the URL, it serves content instead of 404 sjwright1986 Rewrite Rules 4.8 normal normal Awaiting Review defect (bug) new 2017-06-30T10:28:53Z 2017-06-30T10:28:53Z "'''Scenario''' We have two urls: * http://example.com/category/category-name/ * http://example.com/category/category-name/category/category-name/ The second URL above has the '/category/category-name/' portion of the URL repeated. '''Expected outcome''' * When visiting http://example.com/category/category-name/category/category-name/ the displays a 404 page as it's not a valid URL. '''Actual outcome''' * The page with the same content as http://example.com/category/category-name/ is served when visiting http://example.com/category/category-name/category/category-name/ " sjwright1986 Old Tickets 41208 Dashboard News & Events widget does not properly handle entities (e.g. en/em dash) nickciske Administration 4.8 low normal Future Release defect (bug) accepted 2017-06-29T19:47:57Z 2017-07-24T16:56:59Z """WordCamp Minneapolis – St. Paul, Minnesota, USA"" is displayed as ""WordCamp Minneapolis – St. Paul, Minnesota, USA""" nickciske Old Tickets 41204 Placement of wp_redirect() in template milana_cap Themes normal normal Awaiting Review enhancement new 2017-06-29T13:15:03Z 2017-07-12T18:32:02Z "It doesn't say on [https://developer.wordpress.org/reference/functions/wp_redirect/ | this page] where in template file should wp_redirect() function be called. If placed in wrong place, there could be created confusion and impression that function doesn't work. So, it should be placed '''before''' get_header(); In case page is redirected only under certain condition, it would be something like: {{{ /** * Redirect only if this condition is met */ if ( certain_condition ) { wp_redirect( $location ); exit; } /** * Otherwise render the page */ get_header(); }}} " milana_cap Old Tickets 41199 Allow the optional editing of an author slug dartiss Users normal normal Awaiting Review enhancement reopened 2017-06-29T09:40:26Z 2017-06-30T13:35:17Z "At the moment an author slug cannot be changed, although plugins are available to allow this. I believe that WordPress should be able to do this, ""out of the box"". Changes to names, whether through marriage, change of sexual orientation or many other reasons, are important to the individuals that go through it. The original slug, by remaining unchanged, is still the link to an authors page on WordPress and may be the last thing an author, post name change, wants to see. I think, as a very basic change, there should be the option to change this slug, if required (but not a requirement because of how it will affect existing author links). To take this a stage further, if possible, we should also add the option to allow the original slug to also work too." dartiss Old Tickets 41196 add _doing_it_wrong to get_query_var and prevent fatal errors netweblogic Query trunk normal normal Awaiting Review defect (bug) new 2017-06-28T20:32:21Z 2017-06-28T20:32:21Z "The following scenario will throw a fatal error: {{{#!php deprecated
since version 4.4.0! Use WP_Http instead. in /Applications/MAMP/htdocs/themedev/wp-includes/functions.php on line 3831 You can reproduce the error by importing WordPress site data from a live site with images and other content to the site and enabling Debug mode to TRUE. I have also added the screenshot. [[Image(https://www.kamaldeveloper.com/wp-content/uploads/2017/06/Screen-Shot-2017-06-27-at-11.00.19-PM.png)]] Thank you very much. " kamalahmed Old Tickets 41185 current_priority() in WP_Hook broken after adding callback inside same hook kraftner Plugins 4.8 normal normal Awaiting Review defect (bug) new 2017-06-27T15:04:05Z 2017-07-06T13:47:16Z "If you add a callback for a hook inside a callback on the very same hook current_priority() (introduced in https://core.trac.wordpress.org/changeset/39430) returns false. Simple example: {{{#!php current_priority(); if( false === $priority ){ echo "":(""; exit(); } }, 0); }}} The problem seems to be that when you add another callback `add_filter()` in `WP_Hook` triggers `resort_active_iterations()` which runs a `foreach` over `$this->iterations`. In PHP<=5.6 (not in PHP7+) `foreach` moves the internal array pointer and leaves it at the end of the array. This in turn then makes the `false === current( $this->iterations )` check at the beginning of `current_priority()` return `false`. So what I think we need to do is ensure that at the the end of `resort_active_iterations()` the array pointer of `$this->iterations` is back to where it was before. As this touches the very very heart of WP I'm looking for feedback and confirmation before even trying to come up with a patch." kraftner Old Tickets 41182 Twenty Seventeen - author.php is missing for overriding blog author page Girishpanchal Bundled Theme 4.7 normal normal Awaiting Review enhancement new 2017-06-27T12:26:31Z 2017-06-27T12:26:31Z "Related: #20307, #38085 I saw that the themes (twentyseventeen) hasn't provided author.php. I think that we need to add author.php template for override template purpose." Girishpanchal Old Tickets 41175 Twenty Seventeen: The letters in words with i, j, l look all the same in h3-headings that are also formatted strong. transl8or Bundled Theme 4.8 normal normal Awaiting Review enhancement new 2017-06-26T19:18:31Z 2017-06-26T21:22:51Z "I stumbled across a website today (brent.fm/how-we-work) that is using the Twenty Seventeen Theme. There are some pages that have text paragraphs that are formatted with the '''h3''' and '''strong''' HMTL-tag. Unfortunately these paragraphs contain a lot of words with ""i"" and ""l"" and even ""j"" like: like, guide, communicators, projects, etc. and these three letters (i,l,j) in the choosen theme font look all the same on Desktop mode, which makes it quite a bit difficult to read. The font-size though gets smaller on Mobile mode and is better readable then, because the letters look like they should: different. I'm not sure if this is really a bug because usually an h3-heading is not meant to be strong formatted also, but as it seems, that's what some people do and the font behaves quite unpleasant in this case, it would be good to have the designers (@melchoye ?) to pay attention to that, with this specific font. I was able to reproduce that on a fresh local installation of WordPress 4.8 on Windows. Screenshot is attached. " transl8or Old Tickets 41172 Allow autosaving to be disabled on a per post type basis Frank Klein Autosave normal normal Awaiting Review enhancement new 2017-06-26T08:24:58Z 2017-06-26T08:24:58Z Autosaving should be a post type feature, so that individual post types can opt out. Disabling this feature should remove both the server-side and the client-side saving. Frank Klein Old Tickets 41170 Allow the newbloguser screen to be themed johnbillion Login and Registration 3.0 normal normal Awaiting Review feature request new 2017-06-25T19:59:04Z 2017-06-26T07:58:12Z "The appearance of the `newbloguser` screen is not themeable. It should be. Related: #37921" johnbillion Old Tickets 41156 Refactor Emoji browser support tests to prevent repetition. peterwilsoncc Emoji normal normal 4.9 enhancement new 2017-06-25T06:44:42Z 2017-06-25T06:44:42Z "The tests for [https://core.trac.wordpress.org/browser/tags/4.8/src/wp-includes/js/wp-emoji-loader.js?marks=39-97#L39 Emoji browser support] writes to and clears the canvas several times. The code to do this is repeated a number of times and should be refactored. The repitition lead to a couple of (unreleased) bugs recently. " peterwilsoncc Old Tickets 41149 Editor looses cursor once wpview is removed (reopen #40730) bduclos TinyMCE 4.8 normal normal Awaiting Review defect (bug) new 2017-06-24T10:29:42Z 2017-06-24T10:29:42Z "[https://core.trac.wordpress.org/ticket/40730 #40730] bug is still happening in WP4.8 & Trunk. Steps to reproduce: - start from a brand new page - insert a gallery (or any wpview like video & audio) - delete the gallery using the remove icon/backspace/cut(ctrl+x) (Delete key works fine) Result: there's no cursor, impossible to enter some content Bugs in all browsers. " bduclos Old Tickets 41142 Theme editing: inconstancies with messages between this and plugin editing karmatosed Themes normal normal Awaiting Review defect (bug) new 2017-06-23T18:14:52Z 2017-06-23T18:25:28Z "The process is the same but we have different ways of saying it. For example even this: [[Image(https://cldup.com/ndD0DpUtS2.png)]] In the plugin it says: [[Image(https://cldup.com/MQ09SZmEdS.png)]] " karmatosed Old Tickets 41141 Plugin edit: Missed message about making file writeable karmatosed Plugins normal normal Awaiting Review defect (bug) new 2017-06-23T18:09:08Z 2017-06-23T18:25:28Z "Again, the messages are easy to miss. This may get scooped up in one improving ticket, but worth reporting. [[Image(https://cldup.com/zzF9FEjMvT.png)]] " karmatosed Old Tickets 41140 Theme/plugin editing: Long file list goes off page karmatosed Plugins normal normal Awaiting Review defect (bug) new 2017-06-23T18:01:40Z 2017-06-23T18:25:28Z "If you have a long list of files, the list goes a long way down. Could we paginate? Have a 'scrollbox' (probably bad idea)? Have some better way of showing these? [[Image(https://cldup.com/91gj2sr2jz.png)]] " karmatosed Old Tickets 41139 Plugin editing: Should the 'browsing' stand out more? karmatosed Plugins normal normal Awaiting Review defect (bug) new 2017-06-23T17:56:50Z 2017-06-23T18:25:28Z "This message seems to get lost on the page: [[Image(https://cldup.com/ZKUO4NfdPq.png)]] While we are reviewing this making it not just say 'active' and making the message a bit more relatable could be good. " karmatosed Old Tickets 41138 Add classes to Widgets in widgets.php and customize.php pages alexvorn2 Widgets normal normal Awaiting Review enhancement new 2017-06-23T16:37:07Z 2017-06-23T21:27:29Z "Add widget base id class to widgets so developers could add custom CSS styles to their custom widgets. Currently the widgets have only ""widget"" class and ""ui-draggable"". What do you think? I think it's a great idea to highlight custom widgets with different colors, so users can easily find new installed widgets from plugins. (Maybe some one with have other purposes)" alexvorn2 Old Tickets 41136 Login forms lacking autocomplete attributes johnjamesjacoby Users normal normal Awaiting Review defect (bug) new 2017-06-23T13:22:11Z 2017-07-25T09:30:14Z "The security team received a report via HackerOne related to `autocomplete` attributes being omitted from various form fields in `wp-login.php`. Since there is no direct security issue (and we've handled this type of improvement publicly previously) I'm creating a new ticket here to continue that. In my research, form fields in `wp_login_form()`, `show_user_form()`, and `show_blog_form()` need similar scrutiny and improvements. Related: #24364" johnjamesjacoby Old Tickets 41132 permalinks are broken when using PHP7.0-fpm with nginx Towlieban General 4.8 normal normal Awaiting Review defect (bug) new 2017-06-22T21:34:07Z 2017-06-22T21:34:07Z "Setting permalinks to anything but plain causes a white screen of death with the nginx error message: the error is ""2017/06/22 19:55:49 [error] 20482#20482: *28040 FastCGI sent in stderr: ""Primary script unknown"" while reading response header from upstream, client: MYIPHERE, server: MYSERVER, request: ""GET /apps/my-secret-drinks-android/ HTTP/1.1"", upstream: ""fastcgi://unix:/var/run/php/php7.0-fpm.sock:"", host: ""MYHOST"", referrer: ""https://MYDOMAIN/apps/"" This is my Nginx site configuration: https://paste.ngx.cc/7e It was working when I was using php5-fpm and only started after upgrading php5-fpm to php7.0-fpm" Towlieban Old Tickets 41130 Link boundaries for links contaning images look bad mahu2401 Editor 4.8 normal normal Awaiting Review defect (bug) new 2017-06-22T18:31:40Z 2017-06-22T18:31:40Z "In 4.8, the new link boundaries were introduced. For normal links they are fine and they highlight the link really nice. But if there's an image (inline-block element) in the link, the link boundaries look quite ugly. This is the case when you embed an image from the media library. The following code was used to generate the screenshot: {{{ [caption id=""..."" align=""alignnone"" width=""300""] Test[/caption] }}} If you click on the image, two narrow link boundary markers appear above and below the image (see screenshot). These are taking up extra vertical space, so the image 'jumps' a bit. Maybe it would be the best to disable the link boundary feature for links containing only images, in my opinion they don't provide any useful information and may irritate the user." mahu2401 Old Tickets 41128 404 Page not found after using same URL in post / page jpgos Posts, Post Types 4.8 normal normal Awaiting Review defect (bug) new 2017-06-22T15:40:28Z 2017-06-22T17:13:21Z "Starting from a clean Wordpress 4.8 installation. 1. Configure permalinks to: http://domain.com/post-title/ 2. Create a post with title 'new' 3. Remove the post with title 'new' to trash 4. Create a new page with title 'new' 5. Remove post 'new' from trash (not necessarily, both cases result in 404) 6. The page you created trows a 404 due to a database error since it has two different objects with the same URL, though different objects. " jpgos Old Tickets 41127 Extending the featured image to be able to use a video paaljoachim Media normal normal Awaiting Review enhancement new 2017-06-22T14:58:41Z 2017-06-22T14:58:41Z It would be nice to include any visual media element as a featured image. Meaning one could add a video, a gif, a png etc. paaljoachim Old Tickets 41126 Customizer does not work if both wp_footer() and wp_head() functions are not present in the theme. mdifelice Customize 4.7 normal normal Future Release enhancement new 2017-06-22T14:56:18Z 2017-07-05T21:06:03Z I know there is another ticket (#14752) that refers to when wp_head() and wp_footer() are not present in the theme and it was discarded. But in this case, I refer specifically to the Customizer. Since it will not work when those functions are missing, maybe we can disable it completely (maybe with a dismissible notice in the head) or find a way to include the necessary files and data and make it work even when those functions are missing. mdifelice Old Tickets 41125 Add new `_deprecated_class()` function jrf General trunk normal normal Awaiting Review enhancement new 2017-06-22T14:28:35Z 2017-06-25T01:25:49Z "Up to now, there is only one class I know of that is completely deprecated (there may be more). As the newer WP Core code is more and more class based, it is likely that more classes will be deprecated in the future. With that in mind, I'd like to propose adding a new `_deprecated_class()` method to be used for classes which have been completely deprecated. I propose the new function should be used in the constructor and possibly the `get_instance()` method for those classes set up as a singleton. The other methods in the class should (continue to) use the `_deprecated_function()` method. This way developers using the class will be informed with more accurate and better actionable information. This will still not inform devs for every single type of usage of a class, but should improve things. Additionally, the [https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards WordPress Coding Standards PHPCS ruleset] (WPCS) can sniff for nearly all of the other uses and notify those developers who use WPCS of the class deprecation. A new `WP.DeprecatedClasses` sniff will be added to WPCS to this end. Some examples of how classes can be used in code: * `$a = new WP_User_Search;` - This should throw the new `_deprecated_class()` error. * `echo \WP_User_Search::prepare_query();` - This should throw the existing `_deprecated_function()` error. * `$a = new WP_User_Search->query();` - This should throw the new `_deprecated_class()` as well as the existing `_deprecated_function()` error. * `class My_User_Search extends WP_User_Search {}` - Depending on which methods are used/overloaded, the dev may or may not receive notification about this. WPCS however will detect this & notify the dev. * `echo WP_User_Search::$users_per_page;` - The dev will generally not be notified about this, though may receive a `static vs non-static` PHP notice. WPCS however will detect this as usage of a deprecated class & notify the dev. * `echo $a->users_per_page;` - This will go undetected completely, but the user should have received a `_deprecated_class()` error when `$a` was being instantiated. Related to and based on the same investigation as ticket: #41121 === Important note about the suggested function implementation as per the attached patch: The new `_deprecated_class()` method uses the `E_USER_DEPRECATED` constant which is only available since PHP 5.3. Ticket #36561 addresses this and can therefore be considered a blocker for this ticket. Ticket #36561 has been earmarked for 4.9. " jrf Old Tickets 41124 TinyMCE popup doesn't works with latest release UmeshSingla TinyMCE 4.8 normal normal 4.9 defect (bug) new 2017-06-22T11:01:29Z 2017-06-24T09:03:22Z "I'm using TinyMCE popup for a custom plugin, with latest WordPress 4.8, it throws a error. [[Image(https://monosnap.com/file/3vlSZSNz47BObS8KfSKKvaTOzYH3Yw.png)]] I dig in deeper, and found out, the changes in https://core.trac.wordpress.org/changeset/40583 https://build.trac.wordpress.org/changeset/40453/, are causing the issue. https://build.trac.wordpress.org/browser/trunk/wp-includes/js/tinymce/tiny_mce_popup.js#L56 https://build.trac.wordpress.org/browser/trunk/wp-includes/js/tinymce/utils/mctabs.js#L15 `dom` and `util` are loaded directly and not as plugins, and hence when `createInstance` is called in https://build.trac.wordpress.org/browser/trunk/wp-includes/js/tinymce/plugins/compat3x/plugin.js#L284, tinymce is unable to resolve the Classnames and it throws the above error. The fix is to revert the path to `tinymce.util.Dispatcher` and `tinymce.dom.DOMUtils` I couldn't locate the use of these at other places in core, so not sure, if that's gonna break something else. But I did test the regular text editor in WordPress and TinyMCE Advance plugin, they both worked fine with the changes." UmeshSingla Old Tickets 41119 Plugins failing trying to use wp_generate_password() function jamiefryatt Plugins 4.8 normal normal Awaiting Review defect (bug) new 2017-06-21T17:29:21Z 2017-06-21T17:29:21Z "I've been using a plugin called Woozone, and found a problem when i moved my site to AWS Lighttail, i don't know if this is the same elsewhere. I didn't have this problem with the same setup using AWS EC2, so there might be something in that or how the errors are handled. Basically i found that the plugin wanted to use wp_generate_password, but couldn't and was throwing a 500 fatal error... I did some debugging and found that in the wp-settings.php file, the pluggable.php and its depreciated version were loading after the plugins. To fix my error i just moved that to load before the plugins and everything worked again. Not sure if this is a bug, or worth reporting, but it was causing me issues so i thought i'd let you know. " jamiefryatt Old Tickets 41118 Add post type classes to internal link search results guidod Editor trunk normal normal Awaiting Review enhancement new 2017-06-21T16:22:00Z 2017-06-21T16:22:00Z "Would be useful to have post-type classes (and maybe others, like post-status or whether the post type is hierarchical or not) in the internal link search results of the post editor. Currently the output looks like this: {{{
  • ExamplePage
  • }}} I believe there is no hook that would allow one to add post type classes to this output, (I know about the wp_link_query filter that can change the query results, but it can't add classes to the LI). (Use case: adding custom color indentations or other styles to distinguish important post types from non-important post types in these results)." guidod Old Tickets 41114 "Installation: ""Search Engine Visibility"" not keeping checked on error" screamingdev Administration 4.8 normal normal Awaiting Review enhancement new 2017-06-21T10:25:48Z 2017-06-21T10:26:29Z "Given your installing WordPress and you reach the screen about site title, admin login and ""Search Engine Visibility"". When you enable the checkbox for/near ""Search Engine Visibility"" And fill nothing out for mail address And press continue Then an error message appears And most fields are still filled out as before --- Problem: The ""Search Engine Visibility"" is no longer checked. IMHO this should also stay as intended to." screamingdev Old Tickets 41111 WP-API JS Client: Add a helper to get model or collection by route adamsilverstein REST API 4.7 normal normal 4.9 enhancement assigned 2017-06-21T09:51:02Z 2017-07-29T12:14:56Z "In the process of adding page/custom post type support to Gutenberg, the need arose to identify the models based on their route - the code passes the route from PHP to JavaScript, and the JavaScript needs to know which model to use. See [https://github.com/WordPress/gutenberg/pull/1276 this pull requst] for additional details. We should add helpers to the client to easily find a model or collection based on its route, something like `getModelByRoute` and `getCollectionByRoute` - each would search thru the constructed models/collections and return the matching object, or `false` if none was found. We should also add unit tests to verify the functions work as expected." adamsilverstein Old Tickets 41106 wp_editor() doesn't support attributes besides id and class Shelob9 General normal normal Awaiting Review defect (bug) new 2017-06-20T20:31:16Z 2017-06-20T20:31:16Z "I'm replacing a generic textarea with a WYSIWIG field. My textarea has an `aria-describedby` attribute, but wp_editor() -- really `_WP_Editors::editor()` -- can't set any HTML attributes besides ID and class on the WYSIWIG. Would be better if I could do something like this: {{{ wp_editor( 'hi-roy', 'Some text', array( 'attrs' => array( 'aria-describedby' => 'description' ) )); echo '

    Some description

    '; }}} " Shelob9 Old Tickets 41099 update_option return value ambiguous cloughit Options, Meta APIs 4.8 normal normal Awaiting Review enhancement new 2017-06-19T20:58:45Z 2017-06-21T09:33:23Z "WordPress 4.8 The return value 'false' does not allow for differentiating if there was an error saving or if the option value already exists and is the same as the new value. Consider this scenario: a plugin sends option values via AJAX to be updated. The AJAX function returns the return value of 'update_option' which determines the feedback provided to the user, such as a 'success' or 'failure' message. Rather than returning 'false' if an option already exists and is the same as the new option, I suggest returning NULL. In this way the return value of 'update_option' can be checked as follows: {{{#!php if ( is_null( update_option( $option, $value, $autoload) ) ) { ... } // option exists and value is the same as existing option value if ( false === update_option( $option, $value, $autoload) ) { ... } // an error occured when saving the option if ( update_option( $option, $value, $autoload) ) { ... } // option updated successfully }}} The 'update_option' function would need line 308 changed from: {{{#!php return false; }}} to: {{{#!php return NULL; }}} " cloughit Old Tickets 41093 Theme Languages Problem dingdang General 4.8 normal normal Awaiting Review defect (bug) new 2017-06-18T18:49:29Z 2017-06-18T18:49:29Z "Short description: When changing the language AFTER a theme is installed, it doesn't update the po/mo files. To replicate: CASE A: 1. fresh install of WordPress 2. install any theme that has translation at wordpress.org for language X (not English) 3. change the language (Dashboard > Settings > General > Site Language) to X Problem: the theme is not updated. That happens at some point in 24 hours (may be a cron job?) CASE B: However it is OK if done the following way: 1. fresh install of WP 2. change the language to X 3. install of any theme translated to X at wordpress.org If in CASE A wordpress core is reinstalled, then it downloads the respective language X files for the theme. So to solve this an action should be performed on language change to check for language X and update the theme if it is present." dingdang Old Tickets 41092 PHP Fatal error: Uncaught Error: Call to undefined function get_bloginfo parsmizban General 4.8 normal normal Awaiting Review defect (bug) new 2017-06-18T06:17:10Z 2017-06-18T06:17:10Z "Hi, I think there is a bug when Direction is RTL in themes, I get many of these errors these days on our hosted wordpress web sites using PHP 7.1 '''Sample stack trace:''' PHP Fatal error: Uncaught Error: Call to undefined function get_bloginfo() in /home/username/public_html/wp-includes/class-wp-locale.php:233 Stack trace: #0 /home/username/public_html/wp-includes/class-wp-locale.php(113): WP_Locale->init() #1 /home/username/public_html/wp-includes/load.php(925): WP_Locale->__construct() #2 /home/username/public_html/wp-includes/functions.php(1403): wp_load_translations_early() #3 /home/username/public_html/wp-includes/load.php(538): is_blog_installed() #4 /home/username/public_html/wp-settings.php(140): wp_not_installed() #5 /home/username/public_html/wp-config.php(80): require_once('/home/username/...') #6 /home/username/public_html/wp-load.php(37): require_once('/home/username/...') #7 /home/username/public_html/wp-blog-header.php(13): require_once('/home/cryhhctz/...') #8 /home/username/public_html/index.php(17): require('/home/username/...') #9 {main} thrown in /home/username/public_html/wp-includes/class-wp-locale.php on line 233 " parsmizban Old Tickets 41088 4.8 audio widget isn't working correctly stridentconservative Media 4.8 normal normal Awaiting Review defect (bug) new 2017-06-17T06:32:36Z 2017-06-19T02:14:29Z "I'm having two problems... First, I'm unable to upload .mp3 files. When it looks like it has successfully uploaded, I get a message ""An error occurred in the upload. Please try again later."" Second, I have tried using the .ftp URL where one of my clients keeps copies of these files. That seems to work, but my readers who use IE are unable to play it. It only plays for Firefox and Chrome. " stridentconservative Old Tickets 41086 Conditional loading of CSS files from (for example) shortcodes theMikeD Shortcodes 4.8 normal normal Awaiting Review feature request new 2017-06-16T19:51:47Z 2017-06-16T19:53:27Z "The nature of HTTP/2 is such that loading several smaller CSS files instead of one monolithic CSS file is best practice now. Great! However. I have found several cases where loading css files as required via `wp_enqueue_style()` doesn't work because I won't know what CSS file I need until I start rendering the page, which is well past when that function is called. For example, with shortcodes. I have a plugin installed and active that provides a `[shortcode]`. But this `[shortcode]` is not used on every page; or even most pages (such as a goldilock pricing table). So: how do I prevent the CSS for that shortcode from being loaded when `[shortcode]` is not used? Or from the other direction: how do you load the CSS for `[shortcode]` only when that shortcode is used, and only once if the shortcode is used multiple times? If I understand `wp_enqueue_styles()` correctly, anything enqueued after that action is run is sent to `print_late_styles()` but those go into the footer, leading to jank. The only solution I have found is to write the HTML to load the css file directly into the output stream. To that end I wrote this to avoid dupes: https://gist.github.com/th…/f002f696f365aff7c8252f6365cc7d5e It works but it feels hacky. To my way of thinking a better solution would be either a mod to `wp_enqueue_style()` or a new function that allows for the enqueueing of styles but their output on demand, and once per page, similar to what I wrote above. If the answer is just, ""don't do that,"" (which is what I've heard at least once while trying to find a solution) so be it. But the shortcode in question is loading 63k of CSS on every page and, caching be damned, I don't want it to." theMikeD Old Tickets 41084 Multiple WYSIWYG editors ( wp_editor function) not working in widgets due to tinymce.js error Blackbam Editor trunk normal normal Awaiting Review defect (bug) new 2017-06-16T18:03:55Z 2017-06-16T18:03:55Z "The wp_editor()-output is not working within widgets if it appears more than once. Have a look at the following discussion on stackexchange.wordpress.com where the bug is described in detail. The community has not found a fix yet: https://wordpress.stackexchange.com/questions/269853/wordpress-4-8-using-multiple-wysiwyg-editors-with-media-inside-of-widgets-how-t With more and more Plugins (e.g. page builders) using widgets this is a serious limitation a fix is desired." Blackbam Old Tickets 41082 Wordpress edit page flickering in Chome browser only mkeanu17 General 4.8 normal major Awaiting Review defect (bug) new 2017-06-16T15:49:27Z 2017-06-16T16:47:07Z When editing a wordpress page, scrolling down to the SEO section, my page starts to flicker/vibrate on the sides. It is only happening in Chrome. I have contacted Apple and have confirmed it is not a apple software issue. This issue began yesterday. mkeanu17 Old Tickets 41080 Clear List for recently active plugins requires selecting at least one item johnbillion Plugins 4.6 normal normal Awaiting Review defect (bug) assigned 2017-06-15T20:26:23Z 2017-06-16T06:03:47Z [37714] broke the `Clear List` button on the `Recently Active` tab of the plugins screen. The user now needs to select at least one plugin, otherwise the action is prevented with the message `Please select at least one item to perform this action on.`. johnbillion Old Tickets 41079 PHP Notice: Undefined offset: -1 in /var/www/html/live/wp-includes/rewrite.php myrmidon16 Rewrite Rules 4.3 normal normal Awaiting Review defect (bug) new 2017-06-15T17:22:51Z 2017-06-16T01:27:50Z "Low priority, but I'm trying to reduce the size of my error logs, and this notice is a vast majority of it. Issue lies at lines 376 & 378 in the ""wp_resolve_numeric_slug_conflicts"" function. Occurs when $postname_index is 0. With my limited understanding, it seems like that scenario can be skipped, so I added the below snippet to the ""if"" statement at line 363 in my build: {{{ || 0 === $postname_index }}} Please resolve in the next update. Thanks." myrmidon16 Old Tickets 41078 Detect if someone’s site is under version control, and suggest better ways to edit their sites karmatosed Administration normal normal Awaiting Review defect (bug) new 2017-06-15T14:51:12Z 2017-06-21T20:37:41Z Can we detect if someone’s site is under version control, and suggest better ways to edit their sites if they try to make changes using the Code Editors? karmatosed Old Tickets 41077 Revisions for code edits karmatosed Administration normal normal Awaiting Review defect (bug) new 2017-06-15T14:47:58Z 2017-06-16T13:46:35Z "We should let people restore previous versions of their code in case they make mistakes. More details TBA." karmatosed Old Tickets 41076 Themes: Add more help and documentation when editing theme files karmatosed Themes normal normal Awaiting Review defect (bug) new 2017-06-15T14:45:50Z 2017-06-21T14:25:54Z "Add: “Looks like you’re trying to edit your theme! We recommend creating a [child theme](link)"" instead. This will let you make changes to your theme without accidentally breaking anything.” Except with better copy. Maybe also a “make child theme” one-click button that generates a child theme with a functions.php and style.css." karmatosed Old Tickets 41074 Create new Dashicons (4.9) EmpireOfLight Editor trunk normal normal Awaiting Review enhancement new 2017-06-15T14:19:41Z 2017-06-30T15:42:03Z "This ticket is for new Dashicons for the 4.9 release cycle. It is a continuation of the ticket [https://core.trac.wordpress.org/ticket/39296] The following icons has been requested: '''Flip of Editor-RTL''': https://github.com/WordPress/dashicons/issues/111 A reverse of https://developer.wordpress.org/resource/dashicons/#editor-rtl '''Rest API''': https://github.com/WordPress/dashicons/issues/152 '''Variation on earth/world icon (admin-site)''': https://github.com/WordPress/dashicons/issues/95 '''Yes Alt''': https://github.com/WordPress/dashicons/issues/108" EmpireOfLight Old Tickets 41071 Twenty Seventeen: Font Creates a Single Point of Failure jhabdas Bundled Theme normal normal Awaiting Review defect (bug) new 2017-06-15T13:50:42Z 2017-06-26T16:04:13Z "In attempting to develop locally using the Twenty Seventeen theme I have noticed the round trip to Google to pull down a Web Font creates a single point of failure. Steve Souders did quite a bit of work in this area several years ago: https://www.afasterweb.com/2015/08/15/avoiding-a-single-point-of-failure/ For Web Fonts the problem is quite bad because they cannot be deferred like scripts without creating a FOUT/FOUC. So I'm curious, why not simply host the Web Fonts locally? Why create a SPOF by relying on an external stylesheet to load the Web Font?" jhabdas Old Tickets 41070 register_sidebar and dynamic_sidebar inconsistency derkjanspeelman Widgets 4.8 normal normal Awaiting Review defect (bug) new 2017-06-15T13:30:11Z 2017-06-23T07:15:20Z "Let's register a sidebar in functions.php and use digits for the value of the id key. {{{#!php 'test123', // or 'id' => '123', // or 'id' => 123, 'name' => 'test - Mega Menu', ) ); }}} After that, the Widget is showing up at ''Appearance > Widgets''. But when we'd like to retrieve this widget using the dynamic_sidebar function, it won't work: {{{#!php https://make.wordpress.org/core/handbook/contribute/code-refactoring/ >> ''""That said, we want to be internally consistent and follow our own rules. Code is poetry, and our code should be beautiful.""'' > https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/ As a first pass there are 8 files to this ticket for the initial patch, 4 patches, and 4 file lists of the files to be patched, these files lists exclude and 3rd party external PHP libraries so that the only files changed are WordPress' PHP files * `41057-src-root.diff` generated from the `41057-filelist-src-root.txt` PHP file list * `41057-src-wp-admin.diff` generated from the `41057-filelist-src-wp-admin.txt` PHP file list * `41057-src-wp-content.diff` generated from the `41057-filelist-src-wp-content.txt` PHP file list * `41057-src-wp-includes.diff` generated from the `41057-filelist-src-wp-includes.txt` PHP file list Each of the above diff/patches are generated programmatically by `phpcbf` part of `phpcs` using the `WordPress-Core` version `0.11.0` PHP Codesniffer ruleset from https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards * `phpcbf --file-list=41057-filelist-src-root.txt --standard=WordPress-Core --extensions=php` * `phpcbf --file-list=41057-filelist-src-wp-admin.txt --standard=WordPress-Core --extensions=php` * `phpcbf --file-list=41057-filelist-src-wp-content.txt --standard=WordPress-Core --extensions=php` * `phpcbf --file-list=41057-filelist-src-wp-includes.txt --standard=WordPress-Core --extensions=php`" netweb Old Tickets 41054 Use sargable date filtering where possible ComputerGuru Database normal normal Awaiting Review enhancement new 2017-06-15T07:54:13Z 2017-06-15T12:13:22Z "Currently, many queries generated by WP use post_date in a non-sargable fashion, namely by filtering based on the output of a MySQL function taking post_date as a parameter. These can be easily rewritten to use the index on post_date without, to my eyes, breaking anything to boost performance. Here's an example: {{{ MariaDB [blog]> EXPLAIN SELECT * FROM blog.wp_posts WHERE YEAR(post_date) = 2017; +------+-------------+----------+------+---------------+------+---------+------+------+-------------+ | id | select_type | table | type | possible_keys | key | key_len | ref | rows | Extra | +------+-------------+----------+------+---------------+------+---------+------+------+-------------+ | 1 | SIMPLE | wp_posts | ALL | NULL | NULL | NULL | NULL | 2684 | Using where | +------+-------------+----------+------+---------------+------+---------+------+------+-------------+ }}} vs {{{ MariaDB [blog]> EXPLAIN SELECT * FROM blog.wp_posts WHERE post_date >= ""2017-01-01"" AND post_date < ""2018-01-01""; +------+-------------+----------+-------+---------------+-----------+---------+------+------+-----------------------+ | id | select_type | table | type | possible_keys | key | key_len | ref | rows | Extra | +------+-------------+----------+-------+---------------+-----------+---------+------+------+-----------------------+ | 1 | SIMPLE | wp_posts | range | post_date | post_date | 8 | NULL | 262 | Using index condition | +------+-------------+----------+-------+---------------+-----------+---------+------+------+-----------------------+ }}} This optimization can be applied to any comparison between post_date and an already known parameter (from query_var). The only time it wouldn't be possible would be when comparing a portion of the date of two different posts (e.g. WHERE MONTH(x.post_date) == MONTH(y.post_date)) It's not much, but it's something. " ComputerGuru Old Tickets 41052 Need validation update in video widget ravipatel Widgets 4.8 normal normal 4.9 defect (bug) reopened 2017-06-15T05:45:17Z 2017-07-12T04:24:11Z "Without Validation not insert video widget content. When i have insert just text not validate this one." ravipatel Old Tickets 41051 Confirm use of weak password Field show when removed password ravipatel Users 4.8 normal normal Awaiting Review feature request new 2017-06-15T05:29:04Z 2017-06-15T05:29:04Z "Need to change jquery when password not exits hide ""Confirm use of weak password"" checkbox value. [[Image(http://imgur.com/a/Pmwe7)]] " ravipatel Old Tickets 41050 Cannot read property 'top' of undefined in belowEntryMetaClass (TwentySeventeen) ericdaams Themes 4.8 normal normal Awaiting Review defect (bug) new 2017-06-15T01:37:26Z 2017-06-15T05:29:38Z "I'm seeing this with TwentySeventeen version 1.3 activated: {{{ #!js global.js?ver=1.0:124 Uncaught TypeError: Cannot read property 'top' of undefined at belowEntryMetaClass (global.js?ver=1.0:124) at global.js?ver=1.0:239 }}} It only occurs in the following circumstance: * You have widgets in the sidebar menu. * You have a custom template (either defined in your child theme or generated by a plugin) that does not load the sidebar. If the above are both true, you'll see the error triggered on the `window.resize` event. I first encountered this while testing alongside [[https://wordpress.org/plugins/charitable|Charitable]] (create a campaign and then go to donate page), but you can also reproduce by creating a child theme and adding a custom `single.php` with the sidebar omitted." ericdaams Old Tickets 41049 Visual editor adds extra space to top of the post programmin TinyMCE 4.8 normal normal Awaiting Review defect (bug) new 2017-06-14T21:01:22Z 2017-06-20T18:35:13Z "When you have some html in the text mode, it saves and shows correctly: {{{
    }}} However, when you switch from visual to text again, it adds an empty (nbsp) line above the content. Even if you make no change to the visual editor (which shows by default), then go to text tab, it changes the content text!" programmin Old Tickets 41047 Allow to customize insert/edit link dialog box madeincima01 Editor 4.8 normal normal Awaiting Review enhancement new 2017-06-14T15:39:28Z 2017-06-26T16:06:23Z "Actually isn't simple to add attributes to the link in the editor (for example custom ""class"" or ""rel""). There isn't any simple way to add a new field/checkbox in the insert/edit link dialog box. The public function wp_link_dialog() in wp-includes/class-wp-editor.php hasn't any hooks or filters. Maybe it would be useful add some possibilites to edit this popup if needed." madeincima01 Old Tickets 41042 When using IE11 to edit a page the visual editor does not show any text or images atlasprimaryschool Editor 4.8 normal normal Awaiting Review defect (bug) new 2017-06-14T10:51:29Z 2017-06-15T02:14:45Z "When using IE11 to edit a page the visual editor does not show any text or images at all. Switching to the text editor shows all the html code and is editable. Switch back to the visual editor, click and drag to select content in the editable area and it will show the html code that was seen in the text editor. This does not happen in Google Chrome, nor did it happen with a previous version of WordPress." atlasprimaryschool Old Tickets 41041 YouTube subtitles no longer appear when embedding kangahealth Media 4.8 normal normal Awaiting Review defect (bug) new 2017-06-14T09:50:55Z 2017-06-14T09:50:55Z "All YouTube videos on numerous sites that we own no longer show our subtitles, nor do they have the subtitle options in 'settings' or the 'CC' button. Our sites are international and require the option to a) force subtitles in a specific language (we do this in the embed code) b) select subtitles in a specific language via the settings option There was no issue yesterday morning, but in the afternoon these options had disappeared across all videos on all websites." kangahealth Old Tickets 41039 `_delete_option_fresh_site()` continually queries the database dlh Upgrade/Install 4.7 normal normal Awaiting Review defect (bug) new 2017-06-14T05:32:48Z 2017-06-14T05:32:48Z "`_delete_option_fresh_site()` passes the integer `0` to `update_option()`, but `0` will later be fetched from the database as the string `'0'`. Each time `_delete_option_fresh_site()` is called, then, when `update_option()` checks whether the new value is the same as the current value, it will see the two values as different and attempt to perform the database update. The attached patch would instead pass the string `'0'` to `update_option()`." dlh Old Tickets 41037 Comment author can't edit their comment(s) if they aren't the post author henry.wright General normal normal Awaiting Review defect (bug) new 2017-06-14T00:26:14Z 2017-06-14T00:26:14Z "In {{{map_meta_cap()}}}, the {{{edit_comment}}} meta capability is eventually mapped to {{{edit_others_posts}}} which results in comment authors not being able to edit their own comment(s) if their comment(s) are on a different user's post. Note 1: The issue is specific to the author role. The editor role doesn't see the issue because this role has the {{{edit_others_posts}}} cap. Note 2: The problem doesn't exist if the comment author is also the post author. This is because, in such cases, {{{edit_comment}}} is mapped to either {{{edit_published_posts}}} or {{{edit_posts}}}" henry.wright Old Tickets 41034 importing users in multisite: should add existing users to the current blog pbiron Import 4.8 normal normal Awaiting Review defect (bug) new 2017-06-13T20:44:57Z 2017-06-13T20:44:57Z "When importing a WXR file in a multisite setup, if 1. an author in the WXR file exists in the multisite but **not** in the current blog; and 1. the ""import author"" route is taken (i.e., neither ""create new user"" nor ""assign posts to an existing user"" route is taken) then a ""Failed to create new user"" error is reported. Instead of that error, the existing multisite user should be added to the current blog. I can create a patch that implements this if folks think it would be a good idea." pbiron Old Tickets 41033 Cannot Change the Text Color of Links in the WordPress 4.8 Visual Editor jeffr0 Editor 4.8 normal normal Awaiting Review defect (bug) new 2017-06-13T19:40:40Z 2017-06-22T16:25:33Z "I'm able to verify the issue reported in the following support thread using Firefox 54 on my Macbook Pro. https://wordpress.org/support/topic/cant-edit-text-link-color-with-upgrade-to-4-8/ In short, you can not change the color of text in the WordPress 4.8 visual editor if it is turned into a URL first. However, if you change the color of text before it's turned into a link, it remains that color. This seems like a bug. " jeffr0 Old Tickets 41032 REST API: Date fields do not support ISO8601 jnylen0 REST API normal normal Future Release defect (bug) new 2017-06-13T17:46:15Z 2017-06-13T17:46:15Z "The post and comment `date` and `date_gmt` fields as well as a couple of others like the post `before` and `after` fields [https://core.trac.wordpress.org/browser/tags/4.8/src/wp-includes/rest-api.php#L776 claim to support ISO8601] but this is not entirely accurate. The actual format supported is that handled by the [https://core.trac.wordpress.org/browser/tags/4.8/src/wp-includes/rest-api.php#L776 `rest_parse_date` function]: `YYYY-MM-DDTHH:MM:SS` plus optional fractional seconds plus an optional timezone specifier in the form `Z`, `+XX`, `-XX`, `+XX:XX`, or `-XX:XX`. Additionally, WordPress behavior around timezones is complicated and poorly specified. The `post_date` database field is stored in the site's current timezone, and how to interact with this using `before` and `after` in particular is not clear. (The best way to do it is probably to avoid specifying a timezone string at all for these values, unless the site's timezone is known by the API client and specified exactly.) All of this needs to be documented at https://developer.wordpress.org/rest-api/ and any missing test cases added." jnylen0 Old Tickets 41029 The changed author is not making the coming revisons elisa-demonki Revisions 4.8 normal normal Awaiting Review defect (bug) new 2017-06-13T14:02:03Z 2017-06-13T14:02:03Z "Hi In WordPress 4.8 the changed author won't be changed in the new revisions (and autosave)." elisa-demonki Old Tickets 41026 Copy & Paste doesn't copy color styling issue in Wordpress 4.8 cliftonc0613 Editor 4.8 normal normal Awaiting Review defect (bug) new 2017-06-13T12:37:48Z 2017-07-15T15:58:07Z "Hey guys I have a question about 4.8. So in the last version of 4.7 you could copy colored text and paste it and it stay colored. In 4.8 you cannot do this. Was this a core change or is it an issue. See video https://www.useloom.com/share/c474162f78764f7d90572a78c5db0b48 --------- Operating System: Macintosh OS X 10.12.5 Screen Resolution: 1920 x 1200 Web Browser: Chrome 58.0.3029.110 Browser Size: 1920 x 1059 IP Address: Color Depth: 24 Javascript: Yes Flash Version: Not Installed Cookies: Yes User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36" cliftonc0613 Old Tickets 41022 "About: Change ""Contributing Developers"" to indicate there are more than just developers contributing" melchoyce Help/About normal normal Awaiting Review feature request new 2017-06-13T09:05:28Z 2017-06-20T18:31:06Z "It's been a sore spot for a number of contributing designers that the ""Contributing Developers"" (formerly ""Rockstars"") section is labeled ""developers,"" when oftentimes there are more than just developers within that section. There's a couple approaches we can take: - Change ""Contributing Developers"" to something like ""Lead Contributors"" or ""Major Contributors"" - Add a ""Contributing Designers"" section to specifically call out design contributions (though that doesn't help other non-designers getting hightlighted) - Find other ways to organize folks getting highlighted for their contributions entirely" melchoyce Old Tickets 41020 "Use target=""_blank"" for links in Wordpress news and events and updates" altonius Administration 4.8 normal normal Awaiting Review enhancement new 2017-06-13T07:48:36Z 2017-06-13T15:07:17Z "After upgrading to 4.8 Evan I clicked on the links to display info about the upgrade, however. When I did this it opened the link in the same window/tab. Is it possible to open this in a new tab by adding the target=""_blank"" attribute to the link. Likewise most of the links in the Admin Dashboard under ""News and Events"" open in the same window/tab - would you consider opening any of these links in a separate window/tab? To me this makes sense as they're external sites and though related, not directly related to the dashboard - and as you can head down a rabbit-hole when exploring new features / bugfixes it can be annoying to have to click back through multiple pages to get back to the dashboard." altonius Old Tickets 41017 Docblock improvements for 4.9 DrewAPicture General normal normal 4.9 task (blessed) new 2017-06-13T01:06:35Z 2017-07-25T22:47:27Z "Previously: * #39130 (4.8) * #37770 (4.7) * #32246 (4.6) " DrewAPicture Old Tickets 41015 moving site with index.php CBDesign58 Build/Test Tools 4.8 normal normal Awaiting Review defect (bug) new 2017-06-12T19:58:42Z 2017-06-12T19:58:42Z "For years I've been able to move my sites by just editing the index.php file and keeping my files and theme in the subdirectory. This works great when I have multiple sites/builds under the domain. As of the past few months, this is no longer working. WP is not recognizing the index.php file, but giving a parse error indicating a syntax error in the file (syntax error does not exist). Has WP changed this feature and we can no longer copy an edited index.php file but now have to move entire directories? If so, PLEASE change that back. Please let me know asap! Thanks" CBDesign58 Old Tickets 41013 Add Link to Plugins In WP Admin Bar GeekStreetWP General trunk normal normal Awaiting Review enhancement new 2017-06-12T17:42:56Z 2017-06-12T19:05:16Z "Arguably, plugins are one of the biggest parts of WordPress. When debugging a site, deactivating plugins is usually the first thing a dev would do in order to determine if the issue is with a plugin, theme or core file. I'd like to purpose we add a new menu item under the Site-Name menu, in the WP-Admin Bar, that displays: Dashboard, Themes, Widgets, Menus and '''a new item called Plugins'''. Linking to /wp-admin/plugins.php. This way, from anywhere on the front of the site, a user can quickly access the plugins page. As of now, you have to go to Dashboard > Plugins to get to the right screen. I'd also like to add a new menu item under the +New menu, in the WP-Admin Bar, allowing a quick link to add a new plugin. Just like we add a new page/post/CPT. I have a working prototype that can be found here: [https://wordpress.org/plugins/plugins-admin-bar/]. See Screenshots for proof of concept. This plugin code is not the traditional way of adding features into core, but the idea is pretty straight forward. Works on Multisite and Single Site installs. If approved, I'll add this appropriately to core following coding standards." GeekStreetWP Old Tickets 41012 YouTube embed options tomdxw Embeds 4.8 normal normal Awaiting Review defect (bug) new 2017-06-12T14:43:20Z 2017-06-12T14:43:20Z "On a YouTube video, if you click Share > Embed > Show more, there are several options for embedded videos. In my specific situation, I'd like to unset the "" Show suggested videos when the video finishes"" option. Which, in effect, just adds ?rel=0 to the iframe's src attribute. These options should be available to WordPress users, even if they don't have the unfiltered_html capability." tomdxw Old Tickets 41011 get_calendar generates query with invalid date formats andy General normal normal Awaiting Review defect (bug) new 2017-06-12T13:51:12Z 2017-06-12T14:13:04Z "Given a parameter like `?w=1400`, which is obviously not a week number, `get_calendar` will try to compute the date 9799 days into the year. It would make sense to check that `$w` is in a valid range, such as not greater than 53. At the same time, `get_calendar` does not check that `$m` is a valid date, resulting in `$thisyear == '0'` and a query of `SELECT DATE_FORMAT((DATE_ADD('00101', INTERVAL 9799 DAY) ), '%m')`." andy Old Tickets 41008 WP_Error wrote instead of category name in wp_options table, category_base field Neilgaiman General 4.8 normal normal Awaiting Review defect (bug) new 2017-06-12T12:31:13Z 2017-06-12T12:37:12Z "I just installed Wordpress 4.8, yet I'm not sure it's a bug specific of this version or not. The issue is documented in the following post: http://www.ryadel.com/en/catchable-fatal-error-object-of-class-wp_error-could-not-be-converted-to-string-wordpress-fix/ Long story short, it seems that sometimes (when some errors occurs, in my scenario was a I/O error) the category_base value of the wp_options table gets filled with a WP_Error json object instead of a category name. This raises an exception in the rewrite.php script (line 326) when the function tries to use that value against a regex, expecting a string. Sadly enough, it doesn't seem easy to reproduce. " Neilgaiman Old Tickets 41001 Recently Active Plugins Option does not reset when you delete a plugin. GeekStreetWP Plugins 4.8 normal normal Awaiting Review defect (bug) new 2017-06-11T17:25:39Z 2017-06-11T17:25:39Z "When you deactivate a plugin like Akismet, a value gets saved into ""wp_options"" under the option name ""recently_activated"". The value looks like: ''a:1:{s:19:""akismet/akismet.php"";i:1497201452;}'' When you reactivate Akismet, the value is updated and resets the option back to look like this: ''a:0:{}'' '''The Bug.''' When you deactivate Akismet and delete akismet, the ""recently_activated"" option keeps this in the option value. ''a:1:{s:19:""akismet/akismet.php"";i:1497201452;}'' when it should reset back to ''a:0:{}''" GeekStreetWP Old Tickets 41000 "Stop saying ""Happy blogging""" igmoweb Bootstrap/Load trunk normal normal Awaiting Review enhancement new 2017-06-11T10:44:13Z 2017-06-11T11:16:17Z "WordPress is still seen as a blogging platform instead of a CMS solution for many people. I believe we could stop saying ""Happy blogging"" in wp-config.php and welcome to another better expression. I'm not an English speaker so I'm not sure what could be a better sentence. Happy content editing? Happy CMSing? Happy writing? Related tickets: #36945 #37199 " igmoweb Old Tickets 40999 Insert/edit link plugin - nofollow option Stagger Lee TinyMCE 4.8 normal normal Awaiting Review enhancement new 2017-06-11T09:28:33Z 2017-06-11T11:15:35Z "- Insert/edit link - Link options Would it be nice to have there under ""Open link in a new tab"" one new option like ""Don't follow this specific link"" ? You made support for TinyMce in widgets now. And as I read it Google is now punishing websites if repeating links in widgets are not nofollow. Maybe first to ask. Is Link plugin for TinyMce done by WordPress coders or by TinyMce library coders ?" Stagger Lee Old Tickets 40998 Replacing static page that includes a snippet pachadiroglou General 4.8 normal normal Awaiting Review defect (bug) new 2017-06-10T19:37:39Z 2017-06-10T19:37:39Z "Replacing the front page with a static one that includes a snippet as content leads to a blank page. Viewing the page code on a browser the content div hides the code that should appear by adding The static pages works fine if not used as static. Tested with different plugins too. " pachadiroglou Old Tickets 40990 In IE youtube videos are not being played under mediaelement player imani3011 General 4.8 normal critical Awaiting Review defect (bug) new 2017-06-10T10:27:32Z 2017-06-11T06:31:22Z In IE it shows black box and youtube video does not embeds imani3011 Old Tickets 40988 Use objects for `get_item_schema()` calls schlessera REST API 4.7 normal normal Awaiting Review enhancement new 2017-06-10T06:07:54Z 2017-07-13T16:36:46Z "The `get_item_schema()` method of a REST API controller always returns a dynamically generated array of schema information. This dynamic nature is needed, because some keys/values can change based on the current environment/controller. This incurs a large performance penalty because the arrays need to be set up again and again, and as a side-effect, the translations that are being used for the `'description'` field are being loaded every single time. On a fresh, empty install of WordPress 4.8, making a request to `GET /wp-json/wpv2/posts` can spend a third or more of its time translating strings. Most of these translations are done multiple times, every single time an item schema is being requested. See blackfire profiling run here: https://blackfire.io/profiles/20516863-50e3-4df2-938a-7fa2f462abc8/graph I suggest turning the arrays that `get_item_schema()` returns into a collection of smart objects that implement `ArrayAccess`. This offers the following benefits: * Objects use up the memory for their keys once. * Objects can be cloned (with the possibility to make changes after the clone), making sure that translations will at the most be loaded only once for every individual string. * Objects can be extended and/or decorated, making it easy and clean to provide different structures for different use case, to get around `if/else` edge case handling. * Objects can provide ""lazily-loaded"" keys (through magic methods or the proxy pattern), allowing the descriptions to only be processed when they are actually being requested. This would avoid the translation work completely for a use case like I tested above. I expect this to shave around 30% off of the execution time of the above test case. It also makes the code more scalable, as large response sets might even incur yet a bigger performance penalty than the one I have recorded." schlessera Old Tickets 40984 Possible Bug with Named Orderby Meta Query SQL maiorano84 Query 4.8 normal normal Awaiting Review defect (bug) new 2017-06-09T19:51:56Z 2017-06-09T20:10:26Z "I don't know how easy this would be to replicate, but I can at least walk through the steps in identifying the bug, and how I was able to address it for my own use-case. On the web application we're building, we've added a simple meta field called ""spotlight"" to basically drive a single post to the front of the list, and apply some extra styling. To do this, I had built the following query: {{{#!php 'post', 'posts_per_page' => 3, 'orderby' => 'has_spotlight post_date', 'meta_query' => [ 'relation' => 'OR', 'has_spotlight' => [ 'key' => 'spotlight', 'value' => '1' ], 'standard' => [ 'key' => 'spotlight', 'compare' => 'NOT EXISTS' ] ], 'tax_query' => [ [ 'taxonomy' => 'post_tag', 'field' => 'name', 'terms' => 'News' ] ] ]); }}} In other areas of the web application, similar queries appeared to function as expected - the ""spotlight"" post would appear first in the list, with remaining posts ordered by date. However, for the above query, something interesting happened: A post with no spotlight metadata was appearing at the top of the list, and the actual spotlight post was appearing below it. Using PHPStorm and Xdebug, I set a breakpoint for the query and examined the object. Under the request property, the following SQL was generated: {{{ SELECT SQL_CALC_FOUND_ROWS wp_posts.ID FROM wp_posts LEFT JOIN wp_term_relationships ON (wp_posts.ID = wp_term_relationships.object_id) LEFT JOIN wp_postmeta ON ( wp_posts.ID = wp_postmeta.post_id ) LEFT JOIN wp_postmeta AS mt1 ON (wp_posts.ID = mt1.post_id AND mt1.meta_key = 'spotlight' ) WHERE 1=1 AND ( wp_term_relationships.term_taxonomy_id IN (724) ) AND ( ( wp_postmeta.meta_key = 'spotlight' AND wp_postmeta.meta_value = '1' ) OR mt1.post_id IS NULL ) AND wp_posts.post_type = 'post' AND ( wp_posts.post_status = 'publish' OR wp_posts.post_status = 'acf-disabled' ) GROUP BY wp_posts.ID ORDER BY wp_posts.menu_order, CAST(wp_postmeta.meta_value AS CHAR) DESC, wp_posts.post_date DESC LIMIT 0, 3 }}} When running this SQL directly in SequelPro, the following IDs were returned, confirming the order that I was seeing: 1 227 <-- Spotlight Post ID 225 After looking through the SQL statement, I decided to check exactly what Wordpress was seeing. After modifying the query to include everything from the wp_postmeta query, something interesting happened: {{{ SELECT SQL_CALC_FOUND_ROWS wp_posts.ID, wp_postmeta.* FROM wp_posts ... }}} I receive the following results: {{{ ID meta_id post_id meta_key meta_value 1 51 1 _edit_lock 1496942377:1 227 20794 227 spotlight 1 225 3305 225 _yst_is_cornerstone }}} It appears that the table that's being used to define the ordering - '''wp_postmeta''' - is not being filtered the same way as the other table alias '''mt1'''. Upon changing the order clause to use the filtered meta table: {{{ SELECT SQL_CALC_FOUND_ROWS wp_posts.ID, mt1.* ... CAST(mt1.meta_value AS CHAR) DESC }}} I received the correct results: {{{ ID meta_id post_id meta_key meta_value 227 20794 227 spotlight 1 225 NULL NULL NULL NULL 1 NULL NULL NULL NULL }}} This is strange to me, as this line should theoretically prevent other unrelated meta information from being included in the results: {{{ WHERE ... ( wp_postmeta.meta_key = 'spotlight' AND wp_postmeta.meta_value = '1' ) OR mt1.post_id IS NULL ... }}} It should be noted that simply changing the ORDER BY clause in my case - while it ""fixes"" the issue - is not technically correct. Instead, the primary meta query clause should also contain the same filtering that the second does. The complete query looks like so: {{{ SELECT SQL_CALC_FOUND_ROWS wp_posts.ID FROM wp_posts LEFT JOIN wp_term_relationships ON (wp_posts.ID = wp_term_relationships.object_id) LEFT JOIN wp_postmeta ON ( wp_posts.ID = wp_postmeta.post_id AND wp_postmeta.meta_key = 'spotlight' ) LEFT JOIN wp_postmeta AS mt1 ON (wp_posts.ID = mt1.post_id AND mt1.meta_key = 'spotlight' ) WHERE 1=1 AND ( wp_term_relationships.term_taxonomy_id IN (724) ) AND ( ( wp_postmeta.meta_key = 'spotlight' AND wp_postmeta.meta_value = '1' ) OR mt1.post_id IS NULL ) AND wp_posts.post_type = 'post' AND ( wp_posts.post_status = 'publish' OR wp_posts.post_status = 'acf-disabled' ) GROUP BY wp_posts.ID ORDER BY wp_posts.menu_order, CAST(wp_postmeta.meta_value AS CHAR) DESC, wp_posts.post_date DESC LIMIT 0, 3 }}} '''Notice that the first metadata left join contains the same filtering by meta_key as the second.''' I'm not sure what far-reaching consequences this might have, or if this issue has come up in the past. I imagine it's a bit of an edge-case. Let me know if this is something that you're able to reproduce on your end, or if you need more information in regards to this." maiorano84 Old Tickets 40971 Clicking More Details in Add Plugins page shows old version of Plugin Directory page hedgefield Plugins 4.8 normal normal Awaiting Review enhancement new 2017-06-09T11:09:29Z 2017-06-12T13:26:05Z "If you click the More Details link below the Install/Activate button of any plugin listed on the Add Plugins page, it opens a modal with the corresponding page in the plugin directory. However, in 4.8 this still uses the old styling, not the new plugin directory theme that was launched recently. If this was only a visual thing it wouldn't be much of an issue, but the old style also displays different statistics than the new design. It would be nice to bring this in line with what it looks like on wordpress.org/plugins." hedgefield Old Tickets 40970 Update and audit the screen-reader-text CSS class used in core afercia Administration normal normal 4.9 enhancement accepted 2017-06-09T10:25:05Z 2017-07-17T16:44:20Z "WordPress 4.8 has officially [https://make.wordpress.org/core/2017/04/23/target-browser-coverage/ ended support for Internet Explorer versions 8, 9, and 10]. I'd propose to review the `screen-reader-text` CSS class to update it with some more modern properties. At the very least, `clip` should be updated to a more modern syntax. `clip: rect(0 0 0 0)` is there to support old IE versions, I think IE6, IE7? Today, it should be `clip: rect(1px, 1px, 1px, 1px)`. The `clip` property itself [https://www.w3.org/TR/css-masking-1/#clip-property is now deprecated]. Its modern alternative is `clip-path` but at the time of writing it's not supported by IE11 (will never support it), Edge, and some mobile browsers, see: http://caniuse.com/#search=clip-path One option could be introducing `clip-path: inset(50%)` and keeping `clip` for old browsers. This should be carefully evaluated for some edge cases where `screen-reader-text` gets reset for some very special uses, for example: {{{ .post-com-count .screen-reader-text { position: static; width: auto; height: auto; margin: 0; } }}} Worth noting there are also some places in core where the `screen-reader-text` CSS class is slightly different, for example the admin bar, the embed template, and Press This." afercia Old Tickets 40958 force_balance_tags breaks Ninjaforms and probably other plugins that output html within js. programmin Shortcodes 4.7.4 normal normal Awaiting Review defect (bug) new 2017-06-08T21:16:48Z 2017-06-13T21:05:23Z "If you have a shortcode for Ninjaforms and use the post in a context that runs force_balance_tags() it seriously breaks the script. For example if you have a form id=14, add this : {{{#!php null, 'role' => array('Subscriber', 'Participant'), 'role__in => array('Editor', 'Contributor'), 'role__not_in => null ); }}} When calling `wp_dropdown_users` i don't see any dropdown list. While, according to above users and their respective roles the list should bring up the following users: {{{ aniket (matches exactly with 'role': Subscriber, Participant) cjx2009 (matches 'role__in': Editor) warrior (matches 'role__in': Contributor) }}} Even if I do not use a combination like above and just use `role => array('Subscriber', 'Participant')` nothing appears (I already have `'hide_if_only_one_author' => null,`). Furthermore, if I set `role => null` and use `role__in => array('Contributor', 'Moderator')`, again there is nothing when I am expecting user `warrior` will come up in dropdown list! But if I only use 'Contributor' the dropdown appears with `warrior`." subrataemfluence Old Tickets 40948 Load meta files earlier in `wp-settings.php` flixos90 Bootstrap/Load normal normal Future Release enhancement new 2017-06-08T12:18:49Z 2017-07-18T16:51:05Z "We're currently working on bringing meta functionality to sites and networks. While this is still in the early stages of discussion, we're sure that we would at least like to enable plugins to introduce this functionality (DB table and API), even if we come to the conclusion that site and network meta are not eligible for core itself (see #37923 and #25344 for background discussion on site and network meta). A general problem is that the meta functionality is not available when bootstrapping multisite and when using classes like `WP_Site_Query` and `WP_Network_Query` (which need to support `meta_query`). Therefore the meta files should be loaded earlier, in particular: * `wp-includes/meta.php` * `wp-includes/class-wp-meta-query.php` * `wp-includes/class-wp-metadata-lazyloader.php` They should be loaded together with the other ""early"" WordPress files. This does not only make sense for the above specific use-case, but also because the meta API is a generally reusable basic database interaction API and allows to work with arbitrary ""name-value"" pairs, just like options. The Options API is also available early, and the Meta API should follow." flixos90 Old Tickets 40940 Twenty Twelve uses invalid linear-gradient() syntax vrubleg Bundled Theme 4.7.5 normal normal Awaiting Review defect (bug) new 2017-06-07T14:57:13Z 2017-06-09T10:24:07Z "Twenty Twelve theme uses such construction for gradients: {{{ background-image: -moz-linear-gradient(top, #f4f4f4, #e6e6e6); background-image: -ms-linear-gradient(top, #f4f4f4, #e6e6e6); background-image: -webkit-linear-gradient(top, #f4f4f4, #e6e6e6); background-image: -o-linear-gradient(top, #f4f4f4, #e6e6e6); background-image: linear-gradient(top, #f4f4f4, #e6e6e6); }}} Notice this obsolete syntax: {{{ linear-gradient(top, #f4f4f4, #e6e6e6) }}} And compare it to the specification: https://developer.mozilla.org/en-US/docs/Web/CSS/linear-gradient It has to use ""to"" before the direction. So, it has to be: {{{ linear-gradient(to bottom, #f4f4f4, #e6e6e6) }}} or like this: {{{ linear-gradient(180deg, #f4f4f4, #e6e6e6) }}} It works now just because browsers parse this property from prefixed linear gradient, and prefixed linear gradient allows to omit ""to"", and it is actually parsed as ""from"". It will stop work when support of obsolete prefixed properties will be removed. And we have to replace all ""top"" to ""to bottom"" or to ""180deg""." vrubleg Old Tickets 40932 Word breaks the layout elisa-demonki I18N normal normal Future Release defect (bug) new 2017-06-06T19:43:12Z 2017-06-07T21:09:57Z Could we change the string ''Add'' in a symbol, like in the link flyout menu? Because the german word ''Hinzufügen'' for this string is too long and this breaks the layout in WordPress 4.8. The string appears in two places with different meaning, maybe a plus or enter sign is enough. elisa-demonki Old Tickets 40931 Warning: Division by zero in wp-includes/theme-compat/embed-content.php on line 33 aegis123 Embeds 4.7.5 normal normal Awaiting Review defect (bug) new 2017-06-06T13:03:32Z 2017-06-06T13:03:32Z "When embedding a post in another post I get the warning Warning: Division by zero in wp-includes/theme-compat/embed-content.php on line 33. It does show a embedded preview image of the post image. {{{#!php if ( $data['width'] / $data['height'] > $aspect_ratio ) }}} When change this to also check if width and height are larger than 0 the warnings go away. {{{#!php if ( ($data['width'] > 0 && $data['height'] > 0) && $data['width'] / $data['height'] > $aspect_ratio ) { }}} " aegis123 Old Tickets 40930 Twenty Seventeen: Sharing buttons not showing with Video, Audio, or Gallery post format chocopress Bundled Theme normal normal Awaiting Review defect (bug) new 2017-06-06T12:05:46Z 2017-06-06T16:01:50Z "'''What's expected:''' When sharing buttons are setup to show on the front page, they should be showing regardless of the post format. '''What happened:''' Sharing buttons aren't showing with Video, Audio, or Gallery format. [[Image(https://cldup.com/gbtIq-Ohq4-3000x3000.png,75%)]] Discussed with @thomasguillot, who figured out the cause: {{{ if ( ! is_single() ) { // If not a single post, highlight the video file. if ( ! empty( $video ) ) { foreach ( $video as $video_html ) { echo '
    '; echo $video_html; echo '
    '; } }; }; }}} If it’s not single, only the video is displayed and nothing else, the sharing buttons require something like the_content() but it’s not being called for video post formats. This also applies to audio, and gallery post format. " chocopress Old Tickets 40925 Review the usage of the change event on select elements afercia Administration normal normal Future Release defect (bug) new 2017-06-05T12:47:01Z 2017-06-05T16:09:43Z "See also #31634 The change event can be problematic when used on select elements because browsers fire the event in different ways across different platforms. In this ticket I'll try to clarify what this difference is, why it matters for keyboard users, and why some actions shouldn't be triggered when a select option gets selected. On macOS, when using the keyboard to navigate content and a select element gets focused, using the arrow keys always opens the select ""drop-down"": [[Image(https://cldup.com/rU6roN4wAO.png)]] This behavior allows users to explore the content of the select, scroll through the options, and select an option pressing Enter or Spacebar. This way, the change event fires after an explicit user action. Instead, on Windows using the arrow keys on a select doesn't automatically open the ""drop-down"". To clarify what happens, I've made a short video using the Archives and Categories widgets as an example: https://cloudup.com/iuFxQ7CkA7k Historically, this behavior was typical of all browsers on Windows, except Firefox. However, a recent change made Firefox behave like all the other browsers. For more details, see https://bugzilla.mozilla.org/show_bug.cgi?id=1350700 Since the drop-down doesn't open (it does only when pressing Alt+Down arrow), it's hard to scroll the list of options without firing the event at each arrow keys press. Users would need to explore the content of the select before making a choice, and to do so they use the arrow keys. However, while exploring the select content, the action associated to the change event runs. In the case of these widgets, the action triggers a full page reload. Actions that have a big impact like a full page reload or a complete change of context should only be triggered after an intentional choice of the user, i.e. when pressing a button close to the select. In other cases, when the action triggers minor changes, using the change event could be OK. The best option would probably be to evaluate the interaction on a case by case basis. There are a few places in WordPress where the change event is used this way, not pretending to be a complete list, here's some of them: Media views: - Filter by type - Filter by date Customizer - Menu > Menu locations - Static front page > A static page" afercia Old Tickets 40924 Making font_size data for wp_generate_tag_cloud_data filter more flexible mhmdshv Widgets 4.7.5 normal normal Awaiting Review feature request new 2017-06-05T09:35:29Z 2017-06-05T09:35:29Z "Hi, The 'wp_generate_tag_cloud_data' filter currently supports font_size, but the flexibility is so little. This data only accepts a number, and automatically appends a pt to it, setting the font's size. So for example if i set the font size by using the following code: {{{ add_filter( 'wp_generate_tag_cloud_data', function( $tag_data ) { return array_map ( function ( $item ) { $item['font_size'] = '8'; return $item; }, (array) $tag_data ); } ); }}} The result would be font-size:8pt . But if i want to unset the font size or for example use em/px, i won't be able to, unless i use preg_replace: {{{ add_filter('wp_generate_tag_cloud', 'filter_tag_cloud',10,1); function filter_tag_cloud($string){ return preg_replace(""/style='font-size:.+pt;'/"", 'tyle='font-size:unset;', $string); } }}} This feature will come in handy in some theme's that have their own way of styling and handling the tag cloud widget. I for example, have problem with this in two of my theme that are being developed, since the font size is having a bad effect on my theme's appearance. Here is a post on WordPress Stackexchange that we discussed this matter a bit further: [https://wordpress.stackexchange.com/q/225693/94498] Would love to see this in future. Regards, Jack" mhmdshv Old Tickets 40915 wordpress should issue a warning if no graphic library is installed waltercruz Media 4.7.5 normal normal Awaiting Review enhancement new 2017-06-03T14:58:23Z 2017-06-10T07:07:59Z "Hi people! I've installed wordpress on my site, and I had no library for image manipulation installed. Iin that case, I got no thumbnails. Due to css of my site, I was not initially aware of my site, cause the layout was right. So, I think that a warning on admin to the ones that don't have GD or imagick installed could be a good thing. I know that this is a strange corner case :)" waltercruz Old Tickets 40910 Limit writable directories required by WordPress unit test suite danielbachhuber Build/Test Tools normal normal Awaiting Review defect (bug) new 2017-06-02T16:21:06Z 2017-06-03T08:14:58Z "Some environments only permit writing to specific directories. But, the WordPress test suite currently assumes it can write to a variety of directories. Based on searches for `file_put_contents()`, `copy()`, and `symlink()`, here are the directories I found: * `tests/phpunit/data` * `.trac-ticket-cache.*` is created to store a cache of Trac ticket numbers. * `tests/phpunit/build/logs/` * `junit.xml` is created with the results of the test run. * `tests/qunit/fixtures` * `wp-api-generated.js` is generated by PHPUnit for use in QUnit tests. * `/tmp/` * Variety of files are copied out of `phpunit/data` into `/tmp/` for test-specific transformation. * `wp-content/themes` * `theme-file-parent` and `theme-file-child` are symlinked from the PHPUnit data directory into the theme directory * `wp-content/uploads` * Attachments are copied Generally, in write-restricted environments, the test suite fails when it tries to write to directories it doesn't have access to. More directories could be found by running the test suite against a write-restricted environment. To better ensure WordPress compatibility with a variety of platforms, we should ensure these file write requirements are compatible with limited write directories. Here are some strategies we can use: * Properly use `wp_tempnam()` instead of hardcoding `/tmp/` paths. * Permit some write directories to be configurable with a constant or environment variable. * Failing gracefully, in certain cases, when a file can't be written. cc @mikeschroder @octalmage" danielbachhuber Old Tickets 40903 Filtered posts_request query can break found_posts query andy Query normal normal Awaiting Review defect (bug) new 2017-06-01T16:54:45Z 2017-06-01T18:40:57Z "Suppose the `posts_request` query is built with `SQL_CALC_FOUND_ROWS`. The stage is set for `WP_Query::set_found_posts` issue `SELECT FOUND_ROWS()` because `$limits` is non-empty. Now suppose a plugin filters `posts_requests` to the empty string because it gets results another way. WP_Query will still go ahead and issue `SELECT FOUND_ROWS()` erroneously. Some plugins avoid this by filtering `found_posts_query` to the empty string. However, it seems like there is a better way to write the logic of `set_found_posts` so that it respects the filtered `posts_request` query and avoids the problematic statement: simply check the filtered query for `SQL_CALC_FOUND_ROWS` instead of looking at `$limits`. Proposed fix: {{{ private function set_found_posts( $q, $limits ) { global $wpdb; // Bail if posts is an empty array. Continue if posts is an empty string, // null, or false to accommodate caching plugins that fill posts later. if ( $q['no_found_rows'] || ( is_array( $this->posts ) && ! $this->posts ) ) return; - if ( ! empty( $limits ) ) { + if ( substr( $this->request, 0, 26 ) === 'SELECT SQL_CALC_FOUND_ROWS' ) ) { /** * Filters the query to run for retrieving the found posts. * }}}" andy Old Tickets 40901 get_comments_number_text() third argument parsing weirdly eclare Comments 4.7.5 normal normal Awaiting Review defect (bug) new 2017-06-01T13:43:43Z 2017-06-01T13:43:43Z "`comments_number()` is a wrapper for echoing `get_comments_number_text()`. Reference: https://codex.wordpress.org/Function_Reference/comments_number The 3rd parameter's description: Text to display when there is more than one comment. % is replaced by the number of comments, so '% so far' is displayed as ""5 so far"" when there are five comments. This doesn't seem to work as expected. In particular, the parser doesn't look just for '%' but also for strings with spaces in front or behind this sign, after which it processes it in a illogical way. For example, this code {{{ ... }}} results in: `Read on 2 komentarze...` (""komentarze is a Polish translation of ""comments"", which is ok). Where's the ""so far"" string? Now another example with text before the % sign: {{{ ... }}} The result is bizarre: `Read on2 komentarze...` With some testing it seems that some strings passed as the 3rd argument are being kept, but it's totally illogical and requires review. If this is somehow intended, it should be explained in the Codex. So far, even the Codex example doesn't work as intended. I also checked that I'm not using any `comments_num*` filters. Workaround: use `get_comments_number()` with conditional code." eclare Old Tickets 40899 '&' Is always escaped in the JavaScript template. tmatsuur General 4.7.5 normal normal Awaiting Review defect (bug) new 2017-06-01T08:41:12Z 2017-06-01T08:41:12Z "When I tried the JavaScript template, '&' was always escaped. Source: {{{ }}} Rendering: {{{


    Unscaped: Wo&r'l""d

    Escaped: W<i>o</i>&r'l""d

    }}} While checking the interpolation of the variable, '&' was always converted to '& amp;'. Is this a specification or a bug? " tmatsuur