__group__ ticket summary owner _component _version priority severity milestone type _status workflow _created modified _description _reporter Unpatched Enhancements 6286 "Proposed changes to ""E-mail me whenever"" Discussion Options" Comments 2.5 normal normal Future Release enhancement new 2008-03-18T19:14:55Z 2019-03-15T00:40:35Z "WRT the ""E-mail me whenever"" options on the Discussion options page: [[Image(http://img132.imageshack.us/img132/4215/picture1vf1.png)]] 1. For ""a comment is helf for moderation,"" the ""me"" is ambiguous. It should specify that it means the blog admin e-mail address. 1. For ""anyone posts a comment,"" again, ""me"" is ambiguous. In this case ""me"" means the author of the post. The comment notification setting is personal, and therefore should be set in the profile options (where it can retain the ""me""). Some authors may want e-mail notification, others might not." markjaquith Unpatched Bugs 6342 "Rapidly spamming/deleting comments can break ""infinite river"" feature on comment moderation pages" Comments 2.5 low minor Future Release defect (bug) assigned 2008-03-21T22:05:16Z 2019-03-15T00:41:30Z "Comment moderation pages have an ""infinite river"" feature whereby when you remove one comment (spam/delete), it'll load a new one at the bottom. Unfortunately, it doesn't seem to catch up if you click more rapidly than about once every 2 or 3 seconds, and you'll ""lose"" comments. At the end, you may just have one comment that, when dealt with, will be replaced by only one comment. This may have to do with doubleclicking the ""spam"" link, or maybe clicking the ""spam"" link of the next comment before the river action has finished." markjaquith Unpatched Enhancements 9117 Spam queue doesn't distinguish between filter sources Comments 2.7 normal normal enhancement new 2009-02-12T22:50:51Z 2019-06-04T19:21:30Z "1. On the Settings / Discussion tab, go to the Comment Blacklist box, and add the string ""the"". 2. Post a comment containing the word ""the"". It will be caught as spam. 3. Visit the Comments / Spam tab. Your comment is there, but there is nothing to indicate whether it was caught by the Comment Blacklist, or by Akismet, or by another spam filter. Result: neither the user nor WordPress knows how to prevent that comment from being caught in future. Many users will forget about the Blacklist feature and assume their spam filter plugin is faulty. Suggested fix: comments caught as spam should record the reason. This should be displayed to the user, and used internally by spam filter plugins to decide how to handle false positives. " tellyworth Tickets Needing Feedback 10653 Update comment_author when display_name changes SergeyBiryukov Comments 5.1 normal normal Future Release enhancement reviewing dev-feedback 2009-08-19T19:43:29Z 2021-04-05T12:31:54Z One thing that has bothered me recently is the fact that your previous comments doesn't get updated when your display_name is being updated. Which could cause some confusion. I wrote a function (see attached file for further reference) that takes care of this but I would love to see a similiar feature in the WordPress core. mptre Tickets with Patches 10931 Verify Comment Email Addresses of Registered Users Comments 2.8 normal normal Future Release enhancement assigned has-patch 2009-10-08T14:34:44Z 2021-05-06T09:05:36Z "When leaving a comment with an email address of a registered user, WordPress should force the visitor to login or change the email address in the comment form. Anyone can impersonate a blog's user if they know the user's email address." mtdewvirus Unpatched Enhancements 10975 comment form nonce Comments normal normal Future Release enhancement new 2009-10-19T06:49:16Z 2020-02-27T17:33:32Z "This adds a nonce to public comment forms, via the comment_form action. " tellyworth Tickets with Patches 11248 Paged wp_list_comments() should always output something boonebgorges Comments 2.9 normal normal defect (bug) assigned has-patch 2009-11-24T06:00:23Z 2019-06-04T19:21:40Z "Enable comment paging on your blog and visit `http://yourblog.com/a/single/post/comment-page-999999/`. Note no comments will be displayed. There's situations where the comment form will redirect you back to the wrong page (for example if you mess with the type parameter and exclude pings). The Walker should detect if there's no comments to be displayed on the requested page and if that's the case, then display the latest page that actually has comments." Viper007Bond Unpatched Bugs 11734 trackback_rdf() for IDN (xn--) Domains produces invalid HTML Comments 3.1 normal normal defect (bug) new has-patch 2010-01-06T01:10:55Z 2019-06-04T19:21:42Z "Hello The trackback_rdf() function from wp-includes/comment-template.php wraps the ""..."" output inside """" HTML comments, probably to be safe as not all Browsers understand them. When using Wordpress 2.9.1 on a site with an international domain name [1] that contains special characters like German ""Umlauts"" like äöü, this domain name is written as e.g. xn--tst-qla.de for täst.de. Now the output of trackback_rdf() suddenly gets a ""--"" which is the SGML/HTML comment separator mark [2]. Firefox 3.5.6 e.g. sees this as the end of the comment and therefore shows the final ""-->"" as text to the user. As the whole RDF tag is supposed to be invisible for the user, it's a bug in Wordpress :-( Here is an real world example output: {{{

}}} Sadly I have not yet come up with a solution. PHPs urlencode() does not escape a double dash - which is ok as its usually perfectly valid. Maybe someone with RDF experience has a good idea. bye, -christian- [1] http://en.wikipedia.org/wiki/Internationalized_domain_name#Example_of_IDNA_encoding [2] http://htmlhelp.com/reference/wilbur/misc/comment.html " lathspell Tickets with Patches 12104 'moderate_comments' capability by itself should grant the user the permission to See/Edit all comments from the Comments menu. Comments 3.0 normal normal Future Release defect (bug) new has-patch 2010-01-31T22:25:24Z 2021-11-08T19:10:31Z "I tried to create a Comment Moderator role today and realized it wouldn't work. My intention was to create a role for people who can't write or edit posts, but can keep an eye on the comment threads. I created the role like so: {{{ #!php add_role('moderator', 'Moderator', array( 'read' => 1, 'moderate_comments' => 1, )); }}} ... then created a new user with that role. When I logged in as my test user, I realized that it was for all intents and purposes a Subscriber. I couldn't see any admin panels but the Dashboard, my profile, and the Tools. I went poking around in edit-comments.php and discovered that it's checking for another capability altogether: {{{ #!php if ( !current_user_can('edit_posts') ) wp_die(__('Cheatin’ uh?')); }}} I double-checked wp-admin/includes/menu.php and it agreed that 'edit_posts' was the minimum capability to see this page, so I tried adding 'edit_posts' to my new role, and I still couldn't get there. Later on in edit-comments.php, when actually trashing a comment, there is a check for 'moderate_comments', but it's a moot point: this screen doesn't even show up in the admin menu, and if you navigate directly to it, you'll get the ""You do not have sufficient permissions to access this page"" message. I thought it was entirely possible I'd missed some finer point of creating roles, so I redid it with Justin Tadlock's excellent Members plugin, and that didn't work either. This behavior might be intentional, but if so, I'm not following the logic. I know roles are due for an overhaul in the next version or two." sillybean Tickets Needing Feedback 12363 Comment permalink wrong when only listing one comment type wonderboymusic Comments 3.0 normal normal defect (bug) assigned dev-feedback 2010-02-24T14:31:51Z 2019-06-04T19:21:46Z "If you pass the `type` parameter to `wp_list_comments()` (for example, to show comments only and no pings), then comment permalinks can easily use the wrong page number as they expect there to be pings included. This is apparent after leaving a comment and WordPress attempts to redirect back to your new comment. At first I was thinking you could tell WordPress that you're filtering to a type and it could compensate when determining the page number, but then I realized perhaps it'd just be better for `wp_list_comments()` to check if there were 0 comments returned for the query and if so, see if there are any of that type of comment available. If so, then we know we're on too high of a page number and can instead display the highest existing page. Then again this introduces SEO issues. Ideas on what to do are welcome." Viper007Bond Tickets with Patches 13363 Edit Comments: Pending > Approving shouldn't make them disappear from screen wonderboymusic Comments 3.0 normal normal Future Release enhancement assigned has-patch 2010-05-11T23:35:45Z 2023-11-16T17:40:18Z "Edit Comments: Pending > when clicking Approve the comments shouldn't just disappear from the screen. They should collapse and have an undo status like when you trash or spam a comment. ENV: WordPress trunk r14573 (3.0-beta2-14565) " lloydbudd Unpatched Bugs 13473 comment_status should be set to default_comment_status when commentstatusdiv is removed westi Comments normal normal defect (bug) reopened 2010-05-20T23:36:24Z 2019-06-04T19:21:51Z "When the Comment Status box is removed from the Add/Edit Post screens, posts should be created with the comment_status set to the value of the default_comment_status option. ----- I had hidden the Comment Status box via: remove_meta_box('commentstatusdiv','post','normal'); and made sure that default_comment_status was set to open: update_option('default_comment_status', 'open'); After adding a new post it displayed ""Comments Off"" when I was assuming that it should have honored the value of default_comment_status." jimmcq Tickets with Patches 13792 Invalid reply link from comment admin when comment nested level > max Comments 2.9.2 normal normal Future Release defect (bug) reopened needs-unit-tests 2010-06-09T07:05:56Z 2017-07-31T16:17:39Z "I have a blog with nested comments enabled, max depth of 4. When the last level comment is posted, it no longer contains a Reply link. However, in the Comment admin, the Reply link is still present. If used, this new reply will show up at the very bottom of the comment list once posted (even if other newer regular comments are entered, this new reply will still show up at the very bottom). The bug is, basically, that Comment admin doesn't respect the max nested value." archon810 Tickets Needing Feedback 16252 Allow comment reparenting to fix poor threading Comments normal normal Future Release feature request new has-patch 2011-01-15T23:12:25Z 2023-11-23T06:26:37Z "For the OCD among us, it would be super nice to be able to edit the comment_parent, to properly thread comments made in the wrong place/threading order. Choose your own UI, but even just a numeric editor in the Quick Edit area would be a huge enhancement." Otto42 Tickets Needing Feedback 16365 Comment transition for new comments Comments 3.1 normal minor enhancement new needs-docs 2011-01-24T21:07:46Z 2019-06-04T19:22:11Z "As far as I can tell wp_transitions_comment_status() does not get called for new 'comments' based on my testing and review of comment.php in wp-includes. There is a similar transition for posts that gets called for new 'posts' including hooks like 'new_to_publish' and 'new_to_private'. I feel that there should be a similar hook to this form comments so that plugins can hook into new comments differently from comments moved from one existing status to another (like comment_unapproved_to_approved'." MattyRob Tickets with Patches 16576 comment_form() fields being displayed only for non logged in users Comments 3.0.5 normal normal enhancement new has-patch 2011-02-16T18:15:44Z 2019-06-04T19:22:16Z "I've just noticed this - When using the '''comment_form()''' function and adding some comment meta fields,using the fields array in the $args, these fields are being showed in the front-end only for non logged in users. In this case, the registered users can never use these comment fields. Look at wp-includes/comment-template, lines 1561-1573 (WP 3.0.5), it parse the $args['fields'] in the else block - {{{ $field ) { echo apply_filters( ""comment_form_field_{$name}"", $field ) . ""\n""; } do_action( 'comment_form_after_fields' ); ?> }}} I think it is better that added meta fields should be displayable for all users (logged in and not logged in), or even to add a parameter to let the developer decide which extra fields are shown to logged or not logged users. " maorb Tickets with Patches 16612 WordPress should return nocache headers for requests with comment cookies Comments normal normal enhancement new dev-feedback 2011-02-21T22:45:21Z 2019-06-04T19:22:17Z "Most themes, when displaying the comment form, change the HTML to pre-fill username, email address, and website when comment cookies are received in the HTTP request. Since the response does not have explicit nocache headers, per RFC2616 (http://www.ietf.org/rfc/rfc2616.txt) intermediate caches can use heuristics to determine the cache TTL for the response. Since there is 0 freshness data in the response, it is not really possible to perform good heuristics, but in practice, caches will assign a default TTL to this type of response. The result is that private information input by user A when submitting a comment can be returned to user B when making a request for the same URL. To protect ourselves against this, we should call nocache_headers() when comment cookies are sent and the comment form is being displayed. Alternatively, we can send nocache headers for all requests with comment cookies regardless of the comment form being displayed or not (probably easier and maybe safer). http://humboldtherald.wordpress.com/2011/01/27/gremlins/ is a story likely caused by an aggressive cache and the lack of nocache headers." barry Unpatched Enhancements 17020 Some comment queries are not filterable Comments 3.1 normal normal enhancement new needs-unit-tests 2011-04-02T16:56:32Z 2019-06-04T19:22:21Z "Although WP_Comment_Query::query() is fully filterable, some supplemental comment queries are still unfilterable. The submitted patch adds the following hooks: * function get_approved_comments() - query filter 'get_approved_comments_query' * function wp_dashboard_recent_comments() - query filter 'dashboard_recent_comments_query'" kevinB Unpatched Enhancements 17763 comments_popup_link() need a get_* version Comments 3.2 normal normal enhancement new 2011-06-11T06:20:09Z 2019-06-04T19:22:34Z "Currently `comments_popup_link($zero = false, $one = false, $more = false, $css_class = '', $none = false)` has no get_*() version. Usage situation: Where the link needs to be used within a larger string being concatenated." dd32 Tickets Needing Feedback 17771 URL-encoded comment_author_url gets broken by MySQL varchar 200 length limit SergeyBiryukov Comments 3.2 normal normal Future Release defect (bug) reviewing dev-feedback 2011-06-12T03:46:44Z 2017-03-18T17:38:56Z "!WordPress sometimes pings back with long permalinks that exceed comment_author_url column length limit of 200, which results in generating unusable broken links to the post. It easily reaches to the limit, especially if the permalink contains url-encoded multibyte title as postname. (e.g. 23 characters of UTF-8 Japanese become a 207 characters long url-encoded string. Incomplete url-encoded string may trigger 400 Bad Request too.) '''Solution:''' In pingback(), use shortlink instead of regular permalink if the URL is longer than 200 characters. It seems to work ok with wp.me shortlinks." tenpura Tickets Needing Feedback 17913 Site-level comment options may override individual post settings. Improve help/docs. Comments normal normal Future Release enhancement new has-patch 2011-06-27T20:46:43Z 2019-11-18T18:11:40Z "Post comments may be automatically closed for a site's posts if site option 'close_comments_for_old_posts' is true and the post was published before 'close_comments_days_old' days ago. These two options are set in options-discussion and override the 'comment_status' of an individual post. The edit posts screen's comment meta box displays comments open/close status, allowing publishers to open or close comments for a single post. It's possible the site-level discussion settings will override the individual post yet we still might display a different post comment status than the site settings allow. 1. Enable site-level option to close comments on articles ( wp-admin/options-discussion.php#close_comments_for_old_posts ) 1. Enter a days value of 1 for maximum impact 1. Edit a post published over a day ago 1. View the Discussion meta box ( #commentstatusdiv ) 1. Interact with the 'comment_status' field I would like to better communicate expected failure and let the post author or editor know this particular setting has been overridden at the site options level. If the current user can manage options I might you could link to the override in the options page. I created a new test blog, set comments to auto-close after a day, and checked allow comments in the post screen. I was wondering why comments_open() was false for the post when I was looking at a checked box on the post screen." niallkennedy Tickets Awaiting Review 18630 Custom Comment Validation Error Comments 3.3 normal minor Awaiting Review feature request new has-patch 2011-09-09T19:49:33Z 2022-07-15T15:49:43Z "One of the things that bugs me about WordPress is not being able to customize the wp_die() function that is called on comment form validation. I have seen some people sugget core hacks, eek. I'm hoping that a hook is added to allow overriding of the default wp_die(). Maybe even a new template file wp_error.php that would be called first. I haven't found a lot of discussion on this in trac just #11286 and #10551" bandonrandon Tickets with Patches 19739 Filters to allow comments on draft & trash post_status posts Comments 3.3 normal normal Future Release enhancement new needs-unit-tests 2012-01-04T19:01:18Z 2023-03-02T15:52:31Z "I'd like to use comments on draft posts as part of an editorial workflow. Will this be as easy as adding a filter to fire before the current comment_on_draft action that can be checked before exiting? I'll try that and add a patch if it looks good. Related #13276. Not relevant to #18630, I think." cyberhobo Tickets with Patches 20302 Allow comment_form() to add attributes to
tag Comments 3.3.1 normal normal enhancement new has-patch 2012-03-25T15:48:53Z 2019-06-04T19:22:55Z "The standard method to allow Google Analytics to track comment submissions as a 'goal' is to add a piece of JavaScript code wrapped in an 'onsumbit' attribute: http://www.optimisationbeacon.com/analytics/track-blog-comments-in-google-analytics/ http://code.google.com/apis/analytics/docs/tracking/eventTrackerGuide.html We want something like the following: {{{ }}} However the current arguments submitted to comment_form() do not provide for adding attributes to http://codex.wordpress.org/Function_Reference/comment_form I was forced to perform a workaround in which the onsubmit code was inserted by JavaScript on the fly at runtime. So this is request to alter comment_form() such that arguments accepted provide for 'onsubmit' or other custom attributes to be appended on the tag." psbook Tickets with Patches 20487 Comment search isn't customizable Comments 3.2.1 normal normal enhancement new has-patch 2012-04-18T23:32:07Z 2019-06-04T19:23:01Z "*cross-posted to the wp-hackers mailing list last night* I work on a large news oriented WP site and first off, it actually scales remarkably well. We keep users, comments, and actual posts all in WordPress. However, due to our size, administering comments is causing us issues at the moment. Our last outage was caused by one of our comment moderators doing a simple comment search in the admin. The query took 16 seconds to execute, the next query locked, and, with our traffic, the DB couldn't handle the resulting queued traffic. Staying away from discussions of ""you should use Disqus"" or, ""you need more X for your mysql server,"" I think there is significant opportunity to improve the way WP handles comment searching. Every comment search takes the following form: SELECT * FROM wp_comments WHERE ( comment_approved = '0' OR comment_approved = '1' ) AND (comment_author LIKE '%TERM%' OR comment_author_email LIKE '%TERM%' OR comment_author_url LIKE '%TERM%' OR comment_author_IP LIKE '%TERM%' OR comment_content LIKE '%TERM%') ORDER BY comment_date_gmt DESC LIMIT #; As we can all see, this is a beast of a query. Even when the term is clearly an specific term (say an email or IP), or when the intent of the admin is known (e.g. clicking the IP link on a specific comment). Furthermore, there are no hooks activated in this process for plugins to use to say create an advanced comment search plugin. One might expect hooks like those activated in post search to be activated here, like ""parse_request"" and ""get_search_query."" Waxing philosophical, as posts, comments, and users are the three basic types of data to be stored and displayed in WP, one would expect them to have similar interfaces and functionality. They each have basic functionality of being able to retrieve a single item, a list (in full or in part), search for an element, or edit a single entry. For this reason I don't understand why each of their functionality isn't derived from something like an abstract class or an interface. The architecture here is also difficult in that you are not able to replace or extend a single class to change the functionality. Back on target. I propose that we add functionality by which we'll be able to search by exact match in addition to the existing full wildcard (left, right, or full wildcard is probably excessive) as well as specifying the field to search. This would allow my earlier use case of searching by IP to look for an exact match in the ""comment_author_IP"" field only, not searching the fulltext of every comment. This functionality can be created simply by: 1. Adding ""search_type"" and ""search_field"" to the WP_Comment_Query::query_vars data structure in wp_includes/comment.php 2. Replacing WP_Comment_Query::get_search_sql with something more robust, able to understand these new properties and construct the query on their basis 3. Upgrading WP_Comments_List_Table::prepare_items to accept the new queries and add them to the data structure it creates 4. Either modifying WP_List_Table::search_box to have some options of advanced search, or dropping a hook so that a plugin can easily modify it 5. Modifying the WP_Comments_List_Table::column_author to supply the correct query string to indicate an IP search If I can figure out a way to make this more similar to the signature of posts and users, or at least add some hooks at the right places, I can do that as well. This will add efficiency for everyone--particularly those who have lots of comments. I modified our core for this functionality today and we will fully QA it tomorrow. I made it on 3.2.1 as that is what we're running right now, and there are minimal changes in the affected files and functions between 3.2.1 and 3.3.1 and even the nightly. I can submit a patch as long as it passes our QA--how should I do that, off the nightly? Thanks, -Kenton Jacobsen" brokentone Unpatched Enhancements 20597 Allow WP_Comment_Query::query to filter by category Comments 3.4 normal normal enhancement new needs-unit-tests 2012-05-02T03:35:35Z 2019-06-04T19:23:03Z "The attached patch allows WP_Comment_Query::query to accept three additional arguments: * `cat` * `category__in` * `category__not_in` The resulting comments are then filtered by these category arguments as well as any other arguments. These arguments work the same way as their `WP_Query` counterparts. I would appreciate advice on the appropriateness of using `INNER JOIN` (as I have done here) to join in the taxonomy tables to the query." sambauers Unpatched Bugs 20846 Multisite: Network Users can post comments without being members of the site Comments 3.0 low minor Future Release defect (bug) new 2012-06-05T14:35:41Z 2020-05-05T16:27:27Z "This is probably an 'ever since inception' issue and I can replicate it on 3.4 Setup: Have a user added to your network but '''not''' to a site (domain.com/test). Set up domain.com/test to only allow registered users to comment. Remember, we've not added this new user to the site, just the network. Log in as that user and go to domain.com/test Oh look! You can comment as a 'registered' user. This should be check for 'Is this a user ''and'', if multisite, is this user a member of the site?' It's that or the wording needs to be clearer that anyone registered on the network can comment." Ipstenu Tickets Needing Feedback 20977 Add Dynamic Comment Statuses Comments 3.4 normal normal Future Release enhancement new dev-feedback 2012-06-15T17:12:07Z 2020-01-14T02:35:50Z It would be great to add some filters/actions that would allow plugin developers to add additional statuses to comments. supercleanse Unpatched Enhancements 21758 Do not require a file in comments_template() Comments 3.4.1 normal normal enhancement new 2012-08-31T20:22:16Z 2019-06-04T19:23:20Z "comments_template() is a very useful and reliable way to set up comments for a page, but it has a major downfall: it forces a file to be included when, in reality, one does not need to be. Numerous times it has been the case that I needed comments to be setup in the wp_query object, but did not want to output anything at that time. The hack I have used is simply to include an empty comments.php file. This method is less than desirable for obvious reasons. So, I propose that we simply add a parameter I'm calling $require that will control whether or not a file is included at all." mattonomics Tickets with Patches 21834 Comment History Comments normal normal feature request new has-patch 2012-09-07T20:30:47Z 2021-11-07T21:35:36Z "This ticket provides a simple patch for comment history in core. ''The Problem'': In at least a few places: ([comment:ticket:9117:10], [comment:ticket:15534:4], [comment:ticket:9495:3]) Nacin has mused about the desirability of introducing comment history to core, citing Akismet’s implementation as a model for how this might be done. There are good reasons for wanting this, as comment history could serve as a solid underpinning for a variety of other features such as more informative moderation emails, some indication of why a message was marked as spam, and even comment versioning. The idea is that to implement any of that, we really should have basic comment versioning in core, a la Akisment. ''The Solution'': Our goal was to expand the API so as to reproduce and streamline the basic history functionality provided by Akismet, port and tweak Akismet’s nice history UI, and keep the change set minimal. Comment history API: * added simple functions to /wp-includes/comment.php to get and update comment history. These in turn use existing comment_meta functions. UI: * there’s now a comment history meta box on the comment edit screen. It looks just like Akismet’s. This was implemented as a real meta box. A sorting function is also included. History Events: * this patch supports the following history events, each of which has a nice, plain-english (internationalizable) history message, which always includes the user responsible for the action and a timesince. * edit_comment (“edited by user”) * trashed_comment (“trashed by user”) * untrashed_comment (“un-trashed by user”) * comment_unapproved_to_approved (“user approved this comment”) * comment_approved_to_unapproved (“user unapproved this comment”) * spammed_comment (“user marked this comment as spam”) * unspammed_comment (“user marked this comment as ham”) ''Next steps'': Here’s what we’d think of doing next if this were to be introduced into core: * support more history events and provide more detail. In particular, support events where the comment is spammed as a result of a blacklist word or other reason. * include some of this detail in moderation emails ''Note'': * the Akismet plugin should be updated to use this new API instead of its own history functions * meta boxes on edit comment did not work properly until this: http://core.trac.wordpress.org/ticket/21499 (in 3.5) ''Who we are'': This patch comes from [http://profiles.wordpress.org/bbrooks Ben Brooks], [http://profiles.wordpress.org/mattoperry Matt Perry] and [http://profiles.wordpress.org/natebot Nathan Letsinger]. Enjoy" mattoperry Tickets Needing Feedback 22164 "Move comment ""keyboard shortcuts"" setting to comments -> screen options" Comments normal normal enhancement new dev-feedback 2012-10-11T14:14:23Z 2019-06-04T19:23:27Z "Seems like it would make more sense to move the comment ""keyboard shortcuts"" setting from ""Your Profile"" to the screen options pane of edit-comments.php. Something like: [[Image(http://f.cl.ly/items/1k210Z2V1o0b350I1n0V/keyboard-shortcuts.jpg)]]" lessbloat Tickets with Patches 22198 Realigning the Discussions Settings page chriscct7 Comments 3.4.2 normal normal enhancement assigned has-patch 2012-10-15T14:50:34Z 2019-06-04T19:23:31Z "[I looked for some tikets for this but didn't find any directly related, so hopefully I haven't missed a big one out there floating around.] The Discussions Settings page (options-discussion.php) always trips me up when setting up a new site. There's a lot of options, descriptions, directions, etc on that page — much of which is probably unavoidable. When I visit it, I always think that the hierarchy isn't quite right. To help with this, I thought of two half-measures. 1. A very simple solution: Put the ""Allow people to post comments on new posts"" at the top of the options list, with a little space below it. That would make that option the most prominent on the page, without making it stand out too much. Like this: [[Image(http://f.cl.ly/items/3e0c062W0N1l3J2D0q0Y/Screen%20shot%202012-10-15%20at%2011.56.02%20AM.png)]] 2. A more involved solution: I really like the new click-to-reveal-the-options at work in the ""Page on Front"" (#16379) workflow and thought it might work well here. *Something* in this direction: [[Image(http://f.cl.ly/items/022A1G3k0O3q0g1u380L/Screen%20shot%202012-10-15%20at%2012.12.09%20PM.png)]] The first could be accomplished for 3.5, but the second re-working could be a further down the line item. " saltcod Unpatched Bugs 22261 Recent comments widget makes additional queries when pagination is enabled Comments normal normal defect (bug) new 2012-10-23T14:19:59Z 2019-06-04T19:23:35Z A continuation of #15400. nacin Tickets with Patches 22301 Performance problem with Recent Comments widget Comments 2.8 normal normal defect (bug) new has-patch 2012-10-29T06:07:14Z 2019-06-04T19:23:37Z "When a comment is posted (or the status of a comment changes), the `widget_recent_comments`cache item is invalidated, which the Recent Comments widget uses to populate the widget content. On the next widget display, it will call `get_comments()` to repopulate the cache. The problem occurs when you have a very large number of comments, the MySQL query will use the `(comment_approved, comment_date_gmt)` index, but if MySQL has to scan too many rows in an index, it'll switch to table scan instead. As the `comment_approved` column is mostly the same value, this will almost always happen. This is compounded by the query occurring on every page load until the cache is re-populated - if the query takes 60 seconds to run, there could potentially be hundreds of instances of the same query running. So, we need a solution that either hides or eliminates how slow this query can be, and only runs it (at most) once per new comment. After discussing this with @matt, we have a couple of ideas: 1. Move this query to a `wp_schedule_single_event()` call, which has the bonus of ensuring only one is scheduled at any given time. The downside is that it may cause the cache to be outdated on a low traffic site. 2. Keep a queue of recent comments in cache, and push a new one onto the queue when posted. This avoids the query entirely, but there would be a race condition if two comments were posted at nearly the same time - one of them could be left out of the queue entirely." pento Tickets Needing Feedback 22579 Confusion of WP admin Discussion settings Comments normal normal Future Release enhancement new 2012-11-24T20:46:05Z 2019-11-05T13:26:24Z "On the ""Settings>Discussion"" page: 1) ""'''Default article settings'''"" should be replaced by ""'''Default comment settings'''"" (because these important settings do not only apply to posts (''articles'')), but also to pages! 2) ""'''Allow people to post comments on new articles'''"" should be replaced by: --> ""'''Allow people to post comments'''"" (best option in my opinion) or --> ""Allow people to post comments on new pages and posts"" Sorry if this is not the right place to make such suggestions." Lorangeo Tickets Needing Feedback 22889 Reconsider no-JS ?replytocom= links SergeyBiryukov* Comments normal normal Future Release enhancement accepted dev-feedback 2012-12-12T15:13:20Z 2023-03-03T07:03:13Z "We have a no-JS fallback for comment replies. Normally JS moves the comment form around. For people with JavaScript disabled, they follow the `?replytocom={123}` link. This results in a lot of extra crawling by search engines (potentially an additional crawl per reply-able comment!) in exchange for enabling an awkwardly executed, likely underused, and non-essential feature for non-JS users. I'd like to consider making comment reply JS-only." markjaquith Tickets Needing Feedback 23179 New avatar related option - use gravatar only for registered users Comments normal normal enhancement new dev-feedback 2013-01-11T15:40:59Z 2019-06-04T19:23:48Z "The use of gravater is problematic because there is no attempt to verify that a comment with which an email was used was actually left by the owner of the email (AFAICT gravatar doesn't even have an API for authentication). This makes impersonating to someone else that have a gravatar in a wordpress site comments much too easy. IMO non autogenerated gravatars should be displayed by default only for users for which it is known that they actually own the email address, which are usually only the registered users." mark-k Tickets with Patches 23233 Radio Button instead of Checkboxes on Comment Moderation option? Comments 3.5 normal normal enhancement reopened has-patch 2013-01-18T16:26:23Z 2019-06-04T19:23:51Z "Hi! I've been a loyal Wordpress user for years. This is nothing urgent, but something that may improve the user experience. In Settings > Discussion > Before a comment appears, there are two options: ""An administrator must always approve the comment "" and ""Comment author must have a previously approved comment"" Perhaps I have missed something here, but aren't these options pretty much either/or? If the first box is checked, it's rather irrelevant if the second box is checked, because the first checkbox would override it? If I'm correct, shouldn't this be changed from a both/and checkbox to an either/or radio button?" danielmount Tickets with Patches 23634 New hook for adding content after each comment chriscct7 Comments normal normal Future Release enhancement assigned has-patch 2013-02-26T19:29:57Z 2017-10-23T14:56:06Z "Similar to #18561 (which is for a new ""after post"" hook) add a hook that fires after each comment output with {{{wp_list_comments}}}." lancewillett Unpatched Bugs 23931 wp_insert_comment should require comment_post_ID Comments 2.0 normal normal defect (bug) new close 2013-04-03T18:41:58Z 2023-02-21T20:07:06Z "At this moment there is no check for example comment_post_ID. Not sure if there are more checks needed. Reason I asked are a few notices on the unit tests caused by WP_UnitTest_Factory_For_Comment. Those comments don't add a post ID what should change. Currently, if a null comment_post_ID is passed, the comment isn't connected to a post. This can create confusion. Also Unit tests should run with WP_Debug on." markoheijnen Unpatched Enhancements 25338 Comments of password-protected posts should not be shown to logged-in users without edit capability Comments normal normal enhancement new 2013-09-17T02:30:31Z 2019-06-04T19:24:16Z "Currently, if an user creates a password-protected post, Authors and lower roles cannot view the post neither on the front end nor in the backend, unless it was their own post (or they have the password). However, they can see comments of those posts while viewing edit-comments.php. Suggested that comments of password-protected posts should not be displayed to users without ability to view/edit the post in the admin." kraftbj Tickets with Patches 26596 Edit comments from wpAdmin don't process well radio button fields Comments 2.7 normal normal defect (bug) new has-patch 2013-12-13T08:38:04Z 2019-06-04T19:24:43Z "I'm filtering for 'wp_comment_reply' to add a custom radio button selector in the wpAdmin comments. Then the ajax request don't send this field value, always send the last one, checked or not. wp-admin/js/edit-comments.js process all INPUT fields as a text (except type button) I attach the patch to allow radio buttons but doesn't works for checkbox." corretge Tickets with Patches 28314 cancel_comment_reply_link() is unflexible - respond_id & post check Comments 3.9.1 normal major defect (bug) new has-patch 2014-05-20T13:03:57Z 2019-06-04T19:25:49Z "There are two found problems with the function {{{ cancel_comment_reply_link() }}} 1. You cannot define a custom respond id like #respond-POSTID. The respond id (#respond) is hardcoded. So the anchor is not working anymore, if you use a custom respond_id in your theme. 2. If you include the comments on the blogs page (loop) you have comment areas as much as posts. Now you answer to a comment of a specific comment (for example: http://example.com/blog/?replytocom=210#respond-821). This is working fine, just that the cancel_comment_reply_link() is going active for all posts and shows a cancel message under each comment area. It should check for the specific comment area/post and return the message just for the affected comment area/post. If you want I can create a patch for this two bugs :-) Best regards, Ninos" Ninos Ego Unpatched Enhancements 28959 Comments: improve comment moderation text and default style for better UX Comments normal normal enhancement new 2014-07-19T18:31:55Z 2019-06-04T19:26:13Z "The comment moderation email confirmation isn't as helpful as it could be: ""Your comment is awaiting moderation"" doesn't completely suggest the comment went through successfully. (This feedback originally suggested by Scott Berkun, I'm paraphrasing a bit.) ""When a commenter replies, the new comment appears in the middle of the screen, but buried inside the comment area is the message: ""Your comment is awaiting moderation"" -- often in very small text. Suggested improvements: 1. Provide a better default visual indicator that the comment reply succeeded -- this confirms to the commenter that they did everything right. 2. Improve the text to say '''""Your comment was submitted successfully and is awaiting moderation.""''' Attached are before / after screenshots to illustrate (with Twenty Fourteen as an example theme since styles could be theme-specific.)" lancewillett Unpatched Bugs 29462 comment pagination in reverse order should display a full number of the latest comments Comments 3.9 normal normal Future Release defect (bug) reopened dev-feedback 2014-09-02T07:12:47Z 2021-03-16T16:01:41Z "set the following discussion setting: break comment into pages with 5 top level comments per page and the last page displayed by default Comments should be displayed with the newer comments at the top of each page have a post with 6 comments only the last comment made is displayed by default instead of the expected 5 last comments." mark-k Tickets Needing Feedback 30909 Allow passing ID for comment_form container and title Comments normal normal defect (bug) new dev-feedback 2015-01-05T13:01:56Z 2019-06-04T19:27:27Z "Right now, there's a `div` hardcoded with `#respond` and a `h3` hardcoded with `reply-title`. These make it hard for the comment form to be used on archive pages, as they assume the comment form is only ever output on single pages. (There are other IDs output in the form, however these are controllable through `id_form` and `id_submit`)" rmccue Tickets with Patches 30979 Check for context menu before closing commentReply SergeyBiryukov* Comments normal normal Future Release enhancement accepted has-patch 2015-01-11T14:40:41Z 2021-08-27T13:34:20Z "Login to WP-Admin, go to the comments section and ""Quick edit"" or ""Reply"" to a comment. Bring up the context menu either with a right-click or the menu key, press ESC and the context menu and the comment box will close. [[Image(https://i.imgur.com/xnhrZDr.png)]] I understand that this is the expected behaviour but this can be frustrating at times. If you bring up the context menu while typing a long reply but decide not to autocorrect and press ESC to close the context menu everything you've typed so far is gone :( The ""Compose email"" section of both Gmail and Outlook.com close themselves when ESC is pressed but don't if the context menu is open. So I thought WordPress should also have the same behaviour. The patch checks for a right click or menu key press before doing `commentReply.revert()`." jesin Unpatched Bugs 31188 Very slow query in comments_template -> get_comments -> WP_Comment_Query->query boonebgorges Comments 4.1 normal normal defect (bug) assigned 2015-01-31T02:01:45Z 2019-06-04T19:27:50Z "In my quest to improve performance of core Wordpress functionality (see #31071, #31072, and #31171), I'm back with another optimization that is quite significant for large WP installations with lots of comments on some posts. The query in question: {{{ # Query_time: 25.314234 Lock_time: 0.000074 Rows_sent: 10 Rows_examined: 699220 SET timestamp=1422666393; SELECT wp_comments.* FROM wp_comments WHERE comment_post_ID = '87814' AND comment_approved = '1' ORDER BY comment_date_gmt DESC LIMIT 10; }}} As you can see, 25s is not great to say the least. The query isn't using an optimized index, which I've now created, at which point it started running in milliseconds. The index is as follows: {{{ CREATE INDEX `comment_post_ID_approved_date_gmt` ON `wp_comments`(`comment_post_ID`, `comment_approved`, `comment_date_gmt`); }}} I've verified the performance improvements using SQL_NO_CACHE as well as EXPLAIN. The post in question here had over 3000 comments, which isn't uncommon on our site (androidpolice.com). Interestingly, MySQL queries using a different strategy internally which isn't nearly this slow for posts with fewer comments. But at some point, it switches it up because it thinks it's better, and things go sour." archon810 Unpatched Enhancements 31282 finally introduce comments templating Comments 4.1 normal normal enhancement new 2015-02-10T13:18:31Z 2019-06-04T19:27:55Z "after spending several hours with styling my comments, comment form and using a plugin for the error messages, by default wordpress leads to a new unstyled page showing the errors and only leading back to the homepage if one presses the browser's back button, i'm asking myself why there are no templates and functionality for this all day task. please introduce: - a template for the comments ... yes i know there is comments.php but the comments themself must be templated in a callback function which is terrible (e.g. 'shape_comment' ) ); ?>) - a template for the comment form ... yes i know there is athe possibility to give the comment_form function $args, but this is much more terrible than the comment list ""templating"", having the need to ""template"" the comment form in an array (!!!...........) - a way that wordpress reloads the current post page if a user sends a comment and is missing required fields like the comment itsself or his/her email address. afterwards showing error messages besides (or wherever my template says so) the comment form fields. that would be a fundamental improvement and a must. i can't explain, why everything in wordpress is so easy to template but the comments. best regards" ageibert Unpatched Bugs 32299 Cancel comment reply link broken in AJAX call Comments 2.7 normal normal defect (bug) new 2015-05-08T01:23:46Z 2019-06-04T19:28:51Z "related #31333 and both of that & this could arguably be a dupe of #31100 but there case appears to be a server config issue, not using `cancel_comment_reply_link()` or `get_comment_link()` with AJAX. `cancel_comment_reply_link()` has the same issue as `get_comment_link()` has (#31333) which is that it relies on `$_SERVER['REQUEST_URI']` not the actual post permalink for the post's URL. " Shelob9 Tickets with Patches 32366 wp_count_comments() is hardcoded into /wp-admin/menu.php and queries all comments every single page load within the admin area, regardless of if edt_posts is removed from top menu or not Comments 4.2 normal normal Future Release defect (bug) reopened close 2015-05-12T23:07:12Z 2020-04-16T23:10:53Z "wp_count_comments() is hardcoded into /wp-admin/menu.php and queries all comments every single page load within the admin area, regardless of if edt_posts is removed from top menu or not. This is reproducible with 0 plugins and any core theme, as long as you have a large number of comments. Currently working on a site with 5,000,000+ comments and unless we comment out the following code in /wp-admin/menu.php, the server gets hammered. With multiple people in the admin area at the same time, it's even worse, since it loads on every single page load. The code: /wp-admin/menu.php - Line 94-97 (4.2.2) {{{ $awaiting_mod = wp_count_comments(); $awaiting_mod = $awaiting_mod->moderated; $menu[25] = array( sprintf( __('Comments %s'), """" . number_format_i18n($awaiting_mod) . """" ), 'edit_posts', 'edit-comments.php', '', 'menu-top menu-icon-comments', 'menu-comments', 'dashicons-admin-comments' ); unset($awaiting_mod); }}} it's wp_count_comments that causes the large queries, when you have a lot of comments, but I comment out his entire section so that there isnt any errors with removing the creation of $awaiting_mod since it's being called on the next couple lines, before it is unset. Before I found the source, and saw that it was hard coded, I was hoping for some sort of hook to disable this entire function and/or a way for the wp_count_comments() to not be called if the item was removed... but thats not currently possible. I'm new to working on core, so i'm not sure on the best way to attack this issue. I figured it was best to bring up the issue and learn how you guys tackle the code. Open to coding a solution myself if somebody can point me in the right direction. Thanks." justindocanto Tickets with Patches 32851 Comment e-mail address of registered user not updated when user's e-mail address is changed Comments normal major Future Release defect (bug) new dev-feedback 2015-07-01T05:13:01Z 2020-09-30T20:17:48Z "when i have register on blog and i have add 4 comment on different post. Now 2'nd day i have change my email address on my profile. now any one comment's reply is email gone my old email address which is not change after profile update on comments. i have fix this issue on one member please review it 2 link for more info. i hope u will understand me. [https://wordpress.org/support/topic/update-old-comments-with-new-registered-user-email-address?replies=6] [https://wordpress.org/support/topic/development-bump] now i have fix this bug using this one code {{{ function user_profile_update($user_id) { $commentarr = array(); global $wpdb; if( !current_user_can( 'edit_user', $user_id ) ){ return false; } if(isset($_POST['email'])): echo $email = esc_attr($_POST['email']); $wpdb->query(""UPDATE $wpdb->comments SET comment_author_email='$email' WHERE user_id=$user_id""); endif; } add_action('personal_options_update','my_profile_update', 10,2); add_action('profile_update', 'user_profile_update', 10,2); }}} " ravipatel Unpatched Enhancements 33627 In-Context Comment Moderation Comments normal normal Future Release enhancement new 2015-08-31T17:24:33Z 2021-01-27T19:20:14Z "One of the more painful points in the comment moderation UX revolves around knowing whether or not a comment is in context. Right now, WordPress says who a person was replying to and offers a link to the frontend of that comment on replies to a comment. However, it can be quite tedious to go view the original comments a bunch of people were replying to to see if the reply was in-context. An easy fix for this would be to offer a ""Show context"" link next to the ""replying to {name} link on replies, that when clicked, would ajax show the comment the pending comment was originally replying to. " chriscct7 Tickets with Patches 33717 Send Notification Email When a Comment is Approved From Moderation Comments normal normal Future Release enhancement assigned has-patch 2015-09-04T00:43:09Z 2021-05-13T20:02:21Z Currently in WordPress, commenters have no idea their comment is approved unless they visit the page often. When a comment is held for moderation, WordPress should send the commenter an email notification when their comment is approved. I'm using the [http://wptavern.com/an-easy-way-to-notify-users-when-their-comment-is-approved Comment Approved] plugin to add this functionality to WordPress but I really think it should be a core feature. jeffr0 Tickets Needing Feedback 33735 Reduce Duplication and Improve Comment Notification Email Functions SergeyBiryukov Comments low normal Future Release enhancement reviewing needs-unit-tests 2015-09-04T22:55:04Z 2021-01-27T19:20:55Z "Had touched on this in #33587. wp_notify_postauthor and wp_notify_moderator have some duplicative code that could be eliminated and simplified. The functions for notification also lack a filter similar to the one for displaying the comment text. Proposing the function to show the comment in text form in the notification be separated out into its own function with a filter, and the default text be improved somewhat. " dshanske Unpatched Bugs 34106 Comments should have real permalinks Comments normal normal defect (bug) new 2015-10-01T04:41:21Z 2019-06-04T19:32:37Z "The closest think we have to comment permalinks are links like this: `example.com/my-post/comment-page-3/#comment-123` This is very fragile: * comment-page-x is sometimes optional, as when oldest comments are displayed first, and `my-post/comments-page-1/` is the same as `my-post/` * If you change the number of comments per page, the link is no longer correct * URL fragments (the stuff after `#`) are client-side only. Remember hashbangs? https://www.w3.org/blog/2011/05/hash-uris/ * Pagination URLs are ugly and should not be used for canonical purposes I propose something along the following lines: * `example.com/comment/123` rewrites to `example.com/?comment_id=123` * `WP_Query` will translate `comment_id` into the proper values for `p` and `cpage` * `redirect_canonical()` will send you to `example.com/my-post/comment-page-3/#comment-123` Comment pagination settings can change at any time, and permalinks will continue to work." boonebgorges Unpatched Bugs 34110 WordPress Trackback Bug when Comment Pagination is Enabled Comments normal normal defect (bug) new needs-unit-tests 2015-10-01T11:40:36Z 2019-06-04T19:32:40Z "Hi, I just find a comment bug with wordpress which I think is there for a ling site, may be since v2.7+ but never actually fixed. '''Bug Details/ Reproduce process''' Inside your theme while fetching your comments after {{{ have_comments() }}} try to fetch comments only by using {{{ wp_list_comments( array( ""type"" => ""comment"") ) }}} and then below check if trackback exists and if they do print the trackbacks separately using {{{ wp_list_comments( array( ""type"" => ""pings"") ) }}} Now add a bunch of comments on any of your blog post which also have some trackbacks. Add more than 60 - 70 comments on that post. and from settings enable comment pagination option. So that comments get divided into several comment pages. If you are thinking this is never going to happen in real life, let me tell you I have blog posts which has more than 2.500 comments in it and none of them are spam comments. Now, after you enable the comment pagination, visit your blog page link i.e. example.com/some-post/ and you will see the trackbacks below your comments as it should show up now start navigation through your comment pagination, you will see the following - Trackback is showing on the normal blog post link Trackbacks also showing for /comment-page-1/ But when you will move further from comment page 1 you will only see the heading i.e. Trackback or whatever you have set, but not the actual trackbacks. This problem is also present in genesis theme, earlier I though it was a genesis bug but while developing a non genesis wordpress there I understood that it is actually a wordpress core bug." isaumya Unpatched Enhancements 34389 Comment pagination settings should discourage infinite comments-per-page Comments normal normal enhancement new 2015-10-21T16:37:20Z 2019-06-04T19:32:55Z "The default value for `page_comments` is `0`. See #12562. When a comment has hundreds or thousands or trillions of comments, the lack of pagination causes severe performance problems. Part of the spiritual journey described in #8071 involved forcing pagination. We tried a few things in #8071, but decided to leave the problem for a separate ticket. A couple of possible ways forward, some of which are mutually compatible: - Force comment pagination in all cases. This could be coupled with a bump in the default value of `comments_per_page`. Good: It's consistent, and it allows us to drop a checkbox from the UI. Bad: It breaks comment permalinks for many posts (though see #34106). - Force comment pagination only when the number of comments on a post is dangerously high. Good: It reduces permalink breakage. Bad: It's confusing for the user. - Do nothing for existing installations, but enable `page_comments` by default on new installs. This could be coupled with a bump in the default value of `comments_per_page`. - Add some sort of AYS message to options-discussion.php that discourages admins from disabling `page_comments`, or setting `comments_per_page` too high." boonebgorges Tickets Needing Feedback 34475 get_comment_link incorrect page number in returned url. SergeyBiryukov Comments 4.3.1 normal normal Future Release defect (bug) reviewing needs-unit-tests 2015-10-28T16:36:42Z 2019-10-03T22:15:05Z Since 4.3 core update the get_comment_link function returns incorrect page numbers for paginated comments. Have tried using default twentyfifteen theme with no plugins enabled and issue still persists. Property118 Tickets with Patches 34690 when user login is required to comment, there should be a link to registration Comments normal normal enhancement new has-patch 2015-11-15T19:12:17Z 2019-06-04T19:33:05Z "Right now when user login is required the login form only shows a message about the need to login, but if registration is open, there is no reason not to send the visitor directly to the registretion page. At the very least the default text of the link to the login page should be changed to some thing like ""Login or Register"" when registration is open." mark-k Tickets with Patches 35075 Comment cache ignores custom query vars boonebgorges Comments normal normal defect (bug) assigned has-patch 2015-12-14T14:41:42Z 2020-03-06T01:08:10Z "It's currently very possible to add custom query vars to the get_comments function, for themes and plugins to extend. A problem occurs, however, if the function is being used and a custom query var is being used, but no standard ones are changing. This is because it caches the first query, and every subsequent query is then assumed to be the same since custom query vars are ignored. I first thought about just using the entire query_vars array for caching, but decided there's probably a reason this wasn't done. So instead I decided it would make the most sense to make a filter for the cache keys so a plugin/theme can add its own keys that should be considered for caching." jason_the_adams Tickets Needing Feedback 35214 Custom Comment Types Comments normal normal Future Release task (blessed) assigned 2015-12-24T00:28:11Z 2021-07-13T16:02:18Z "It's time to take another look at Custom Comment Types. We have a nice stable example in post types, but there's a '''lot''' to do here, so we'll use this as a centralized tracking ticket for everything. As such, I'm sure the description here will be fluid for a while as we figure out how much there is to do. Here's a rough list of things that need to be looked at and addressed: * UI/UX - In order for custom comment types to be really useful, we need to put some serious thought into the UI/UX surrounding comments in the admin. * The `comment_type` field needs to start using `'comment'` instead of `''` for comments. This will mean an upgrade routine as well as some back-compat work. * We need to decide what to do about non-default comment types in various admin areas (comments table, recent comments, etc). The thing that makes most sense is for `WP_Comment_Query` to be adjusted to only show default comment types (comments, pingbacks, and trackbacks) by default. Additional comment types would then be handled by whatever plugin or theme adds them. Unfortunately, this is a breaking change (comment:58:ticket:12668) because right now those areas show all comment types. Maybe we can create new management areas to be able to pull these out of the default one? Lets put our heads together. * A lot of existing functions, like `comment_type()`, will need to be fixed to make room for newly registered comment types and their registered strings. Previous tickets for history: #25674 #12668 " aaroncampbell Unpatched Enhancements 35432 `wp_list_comments()` should perform a more modest fallback comment query Comments 4.4 normal normal enhancement new 2016-01-13T04:17:29Z 2019-06-04T19:33:53Z "Previously: #35175, #35356, #8071. In 4.4, `comments_template()` was updated so that it no longer queries for every single comment belonging to a post; instead, it only fetches the comments appropriate for the current comment-page. See #8071. This change introduced a bug in `wp_list_comments()`: since all of the post's comments were no longer available in `$wp_query->comments`, it was no longer possible to pass custom (read: differing from `$wp_query`) pagination params to `wp_list_comments()` and get the proper comments back. We addressed this problem in 4.4.1 by adding a clause to `wp_list_comments()` that falls back on the old behavior - querying for all of the post's comments - if non-default pagination params are provided. See #35175 [36157]. This fallback solution is obviously not ideal. Querying for all of a post's comments is what #8071 was supposed to fix. `wp_list_comments()`, like `comments_template()`, should be able to perform a fallback query that fetches only the required comments. The necessary logic already exists in `comments_template()`, so this may be a relatively simple matter of porting the functionality over, or abstracting it for use in both functions. cc @smerriman" boonebgorges Tickets with Patches 35501 "Dashboard page: incorrect work of ""Activity"" group box bottom counters" adamsilverstein Comments 4.4.1 normal normal Future Release defect (bug) assigned has-patch 2016-01-17T21:22:17Z 2019-01-10T22:26:26Z "STEPS TO REPRODUCE Create new post, add comment through front end, go to dashboard page, click showed up menu items Approve/Unapprove/Spam/Trash in different combinations: - click ""Approve"" and quick click ""Trash"", - click ""Unapprove"" and quick click ""Trash"" - quick click ""Approve"" twice EXPECTED RESULT: bottom counters ""All"", ""Pending"", ""Approved"", ""Spam"", ""Trash"" counts correct. ACTUAL RESULT: see attachment." antonrinas Tickets Needing Feedback 35503 "Dashboard page: comment status in ""Activity"" group box shows incorrect" Comments 4.4.1 normal trivial feature request new reporter-feedback 2016-01-17T21:54:34Z 2019-06-04T19:33:54Z "'''STEPS TO REPRODUCE''': log in (subscriber user), create new comment for post, log in (administrator user), approve comment on Dashboard page using ""Activity"" group box, click ""Approved (1)"", click ""Go back one page"" in browser. '''EXPECTED RESULT''': comment status - Approved '''ACTUAL RESULT''': comment status - Unapproved This problem was found in browsers Firefox 44.0b9, Chrome 47.0.2526.111 m" antonrinas Unpatched Enhancements 35650 title_reply_to should work when javascript is enabled Comments normal normal Future Release enhancement new 2016-01-28T21:51:05Z 2019-06-21T01:16:40Z "`title_reply_to` is a parameter in the `comment_form` function, and has even been around since 2.7 in the `comment_form_title` function, allowing you to display a different heading when replying to a comment, including who you are replying to. While a cancel comment reply link does appear, having a different heading is a very useful concept for making it clear to users exactly what they are doing. Except, nobody ever sees it because it only applies when javascript is disabled. Everybody* has javascript enabled. The javascript for replying to comments should be updated to change the heading based on this parameter. " smerriman Tickets with Patches 35651 No longer any consistent way to add content to bottom of comments form Comments 4.4 normal normal defect (bug) new dev-feedback 2016-01-28T22:12:22Z 2019-08-19T01:44:25Z "In #34731, there was a discussion on whether `comment_notes_after` should be directly after the comment form (now at the top by default), or at the bottom above the submit form (as the documentation described). The decision was to change the documentation. However, this now leaves no consistent way for themes/plugins to add content to the bottom of the form, above the submit button. Using `comment_notes_after` was a popular method to add notes like terms and conditios, or a subscribe checkbox etc, and consistent with the old documentation. All of these themes/plugins that relied on the positioning in the documentation will now have this output in the wrong place in the form. `comment_form_after_fields` isn't an alternative since it only applies when the user is logged out." smerriman Unpatched Bugs 35805 Reverse page order in wp_list_comments() with newest comments first boonebgorges Comments 4.4.2 normal normal defect (bug) reviewing needs-unit-tests 2016-02-12T00:21:26Z 2019-06-04T19:34:45Z "Hey there, since wp 4.4 there were lots of bugs in the wp_list_comments()-function. Some of them are already fixed, now I found another one. If you change the comments order from default (oldest first) to newest first, the page order is wrong (reverse page order). == Example == You have 4 pages by sending following param you get these pages: {{{ page=1 -> 4 page=2 -> 3 page=3 -> 2 page=4 -> 1 }}} == How I call this function == Inside the post-loop I'm calling: {{{#!php
}}} And comments-content.php has following part: {{{#!php $cpaged, // Variable defined before, default: 1 'per_page' => 2 ) ); ?> }}} PS: In ticketing system the version 4.4.2 is not available :-)" Ninos Ego Tickets Needing Feedback 35862 Comments screen: audit all the background color animations Comments 3.8 normal normal defect (bug) new 2016-02-18T17:26:13Z 2019-06-04T19:34:53Z "Noticed some weird behavior, to reproduce: go in the Comments screen (in the ""All"" view), and mark as spam or move to the trash an '''approved''' comment. The comment row background will quickly ""flash"" to red and then the comment row will disappear. Do the same on an '''unapproved''' comment: no red flash. There are also other cases where this happens, seems all related to pending comments. By the way, the JavaScript animations still run and the background is animated behind the scenes. It just can't be seen because the pending comment row background color is now set on the `th` and `td` elements that hide the change on the `tr` background. Looks like this JavaScript part wasn't updated after the CSS changes in WordPress 3.8. There are also other old things that missed to be updated, for example at some point JavaScript still uses `#FFFFE0`. This was the background color used for unapproved comments in WordPress 3.7 but they use `#FEF7F1` since 3.8. I'd propose two options: 1. Fix the animations :) 2. Get rid of them. Apparently, not so many users have complained about the (partial) lack of color animations in the last 2 years I'd lean toward the second option. There are several lines of JavaScript in `edit-comments.js` and `wp-lists.js` that could be removed, they are hard to maintain and being a bit old code they also violate the separation of structure, presentation and behavior principle. Yes, the JS could be refactored and maybe use a more modern approach but for, I'd say, a very little benefit. So before any patch attempt, this would need a decision. Any thoughts more than welcome. In the screenshot below, the red flash on pending comments, how it used to be on WordPress 3.7 [[Image(https://cldup.com/Ml9laEw1jQ.png)]]" afercia Unpatched Bugs 35937 "Visual improvements for the comment ""pending status""" Comments normal normal Future Release defect (bug) new 2016-02-24T16:25:05Z 2019-01-13T16:55:31Z "Splitting this out from #35392. While working on #35392, noticed and agreed there's room for some visual (and further accessibility) improvements. Specifically, the comment ""pending status"" relies on a small ""flag"" icon, followed by a `[Pending]` text. From a design perspective, this could use some love. Whether it would be some additional, descriptive, text or a new icon etc. it would be possible to expand the new text or icon with some `screen-reader-text` in order to provide a reasonably understandable feedback for assistive technologies users. Worth noting this applies to the Dashboard ""Recent Comments"" widget and the list of comments in the Comments screen and Edit post screen as well, where the pending status information is conveyed using just color. cc @melchoyce [[Image(https://cldup.com/IWyv7rKuEE.png)]] " afercia Unpatched Bugs 36058 "PHP notices and invalid ""View Post"" link on edit-comments.php when post type does not exist" Comments normal normal Future Release defect (bug) reviewing 2016-03-03T05:48:30Z 2017-05-06T17:13:37Z "Steps to reproduce: 1. Register a custom post type 2. Create a post 3. Create a comment on that post 4. Stop registering the post type 5. Visit wp-admin/edit-comments.php The markup built in `WP_Comments_List_Table::column_response()` for the ""In Response To"" column requires a valid post permalink, as well as the post type label corresponding to ""View Post"". Since permalinks to non-existent CPT objects cannot be valid, and since non-existent CPTs don't have any post type labels, it seems to me that we can probably bail out of this method early if the post type doesn't exist. Similarly, `column_date()` probably shouldn't attempt to link to the post if the post type doesn't exist." boonebgorges Tickets with Patches 36208 Comment queries should ignore comments associated with non-active custom post types Comments 4.4 normal normal Future Release defect (bug) new has-patch 2016-03-11T13:50:28Z 2023-10-17T13:16:37Z "As of 4.4 we introduced the `_doing_it_wrong()` (r34091) when checking meta capabilities on custom post types that aren't registered. This also spread and affected comments, primarily on the dashboard where we show comments and try to add links for these and check the users capability against them, they will produce this wonderful output: > PHP Notice: map_meta_cap was called incorrectly. The post type shop_order is not registered, so it may not be reliable to check the capability ""edit_post"" against a post of that type. Please see Debugging in WordPress for more information. (This message was added in version 4.4.0.) in /wordpress/wp-includes/functions.php on line 3827 Ideally, `WP_Comment_Query` should bypass comments associated to non-existing post types as well. In the attached patch I've introduced both `post_type__in` and `post_type__not_in` which accepts an array of post type string names. I've also added the default value for `post_type__in` to `get_post_types()`, as by default you'd never want to query for non-existing data any way, but this allows the query to be overwritten via filters, or directly with a new construct for those who have the need. I am wondering if the use of `post_type = 'any'` would need to short-circuit the new arguments to avoid breaking BC (current tests all pass with the patch applied though) ? Related #16956 What this looks like (from #34918): [[Image(http://crosseyedeveloper.com/wp-content/uploads/2015/12/commentcap.jpg)]] It also shows up on the Dashboard in the comments widget: [[Image(http://crosseyedeveloper.com/wp-content/uploads/2015/12/commentcap21.jpg)]]" Clorith Tickets with Patches 36409 Comments number is wrong Comments normal normal defect (bug) new needs-unit-tests 2016-04-04T14:21:26Z 2019-06-04T19:35:47Z "Hi, the comment number return the number of approved comments, this means all approved comments even those are replies to unapproved comments, for example if a user post comment and people replied to it, then the admin decide to hide this parent comment by disapproving it, the comment number will decrease only by one and keeping counting the hidden replies So there are two option to fix that : 1. Hold/Disapprove all children when disapproving the parent. 2. Recalculate the comment number and excluding comments has an unapproved parent. Regards, Sidati" sidati Tickets Needing Feedback 36424 graphically visualize if comments are closed (in wp-admin/edit.php) Comments normal normal Future Release enhancement new has-patch 2016-04-06T08:08:36Z 2018-03-12T17:02:29Z "it would be nice if the pages or posts list would not only show the number of comments per page but if it also could show a symbol if comments for this particlar page or post are closed. proposal: - the lock symbol https://developer.wordpress.org/resource/dashicons/#lock - or https://developer.wordpress.org/resource/dashicons/#edit combined with a kind of ""forbidden"" sign/strike, similar to https://developer.wordpress.org/resource/dashicons/#hidden " pixelverbieger Tickets Needing Feedback 36564 Last Modified for Comments Comments 4.4 normal trivial Future Release enhancement new needs-unit-tests 2016-04-17T20:44:59Z 2017-02-12T10:37:16Z "Related #28463, #19495. Posts have a last modified and last modified gmt, but comments have no such thing. There are several proposals indicating a need for comment revision, or tracking when the comment is first created. Wanted to explore the idea of having last modified and last modified gmt stored as comment meta triggered by update_comment as a simple, low impact way of adding this feature that could be used by a variety of plugins. This could be implemented by plugin hooking to edit_comment, but if such a feature is to be useful, it needs a standard storage format." dshanske Tickets Needing Feedback 36885 "When one uses custom callback function for comment list, ""Reply"" link would not show" Comments normal normal defect (bug) new reporter-feedback 2016-05-19T00:59:34Z 2019-06-04T19:37:59Z "It took too much time, but found the issue here in wp-includes/comments-template.php in get_comment_reply_link function. The OR conditions are likely to be true I imagine in many combination of situations although I am not too sure what combination causes bad things to happen. {{{ if ( 0 == $args['depth'] || $args['max_depth'] <= $args['depth'] ) { return; } }}} Well and good to check this, but why would the reply as well as login link disappear if any of it is true? Sorry if I am not getting this as I should. " remedy17 Tickets with Patches 37103 get_comments_number_text() should not replace '%' in post title Comments 4.2 normal normal defect (bug) new has-patch 2016-06-14T20:06:02Z 2019-06-04T19:38:56Z "Background: #13651 1. Create a post titled ""Hello % world"". 2. Add a couple of comments. 3. `comments_popup_link()` will produce the following output: {{{ 2 Comments on Hello 2 world! }}} Note ""Hello 2 world!"" instead of ""Hello % world!"", due to `get_comments_number_text()` treating `%` as a comments number. Reproduced with 4.5.2 and Twenty Sixteen. Technically introduced in [31388]." SergeyBiryukov Unpatched Enhancements 37537 Hooks To Improve UI & UX when making a plugin that modifies the Edit-Comment Screen Comments 4.5.3 normal normal feature request new 2016-08-01T12:00:27Z 2019-06-04T19:40:48Z "I am in the process of trying to modify the edit-comment form. While there are hooks for adding Meta Boxes here, more hooks for adding inputs and elements to the page would be useful. For example, I am attempting to add a dropdown menu that allows for the comment's author_id to be changed. To me, it makes most sense for this to be available underneath the existing author fields. Ideally, in the same box. At the moment this just isn't possible, " stewarty Tickets Needing Feedback 38925 Allow override of depth limits on comment reply link Comments 4.7 normal normal Future Release enhancement new dev-feedback 2016-11-24T06:41:07Z 2020-05-26T20:21:04Z "The core code currently hides the Reply link if a comment is at the maxDepth setting for comment nesting, but this appears to only be a constraint on the presentation. The API still allows replies through URL parameters and the REST interface, which demonstrates that there is not a functional reason for the constraint. I'm proposing that plugin authors are allowed to override this constraint by setting `$args['limit_by_depth'] = false` in a `comment_reply_link_args` filter. This requires only a minor, inconsequential change to comment-template.php per the attached patch. Note the '[https://wordpress.org/plugins/infinite-comment-replies/developers/ Infinite Comment Replies]' plugin currently achieves this by completely rewriting the reply link and thus masking everything that is handled in the core production of the link. The proposal above is a better option to achieve the same effect." TravisR Tickets Awaiting Review 39028 Comments on private posts or specific edge cases can get a confusting white screen error. Comments 4.4 normal normal Awaiting Review enhancement new 2016-12-02T14:29:01Z 2017-08-03T14:00:53Z "I have a plugin that uses the private status for a custom post type used in private BuddyPress groups. When a group member tries to comment on one of the post type he's getting a white screen. I've fixed the issue on my side, problem was about caps mapping. But still, i was pretty confused by this behavior. At first i thought it was a fatal error, but xdebug returned nothing, so i've looked in my error.log again nothing ?? Then i've found some returned WP_Error was missing data like the 403 status in `wp_handle_comment_submission()`. As this function was introduced in 4.4, i guess it first appeared in 4.4. I think it could be interesting to have a screen looking like this in this kind of cases : [[Image(https://cldup.com/ymyxLMacts.png)]] I suggest the attached patch." imath Unpatched Enhancements 39084 Introduce singular capabilities for managing individual comments Comments normal normal Future Release enhancement new needs-unit-tests 2016-12-04T22:14:50Z 2017-07-14T19:41:15Z "As we did in #35614 for taxonomy terms, singular capabilities should be introduced for approving, unapproving, spamming, unspamming, editing, and deleting individual comments. This would allow fine-grained cap checks such as current_user_can( 'edit_comment', $comment_id ) and current_user_can( 'approve_comment', $comment_id )." johnbillion Tickets Awaiting Review 39133 Check email length in is_email() Comments 4.8 normal normal Awaiting Review enhancement new has-patch 2016-12-07T05:38:44Z 2020-07-17T14:50:12Z "In reference to this ticket - https://core.trac.wordpress.org/ticket/38506#comment:12 It would be better to check email length within the is_email() itself instead of validating it at various other places. " PranaliPatel Tickets Awaiting Review 39282 The process for approving and then replying to a comment can be made more visible Comments 3.1 low normal Awaiting Review enhancement new 2016-12-14T18:17:51Z 2020-09-01T15:53:25Z "The workflow for approving and then immediately replying to a comment has a shortcut in WordPress, but it's not obvious. If you don't know about it, you can waste time and effort switching between the pending and approved views on the comment moderation screen after approving a comment and then wanting to reply to it. The `Reply` link on a pending comment is actually a shortcut for approving and then replying to a comment. The `Reply` link text should be updated to `Approve and Reply` to reflect this and make comment moderation a more enjoyable process." johnbillion Tickets Awaiting Review 39505 Add an option to add custom classes to comment_reply_link() Comments 4.7 normal normal Awaiting Review enhancement new has-patch 2017-01-06T14:08:03Z 2017-01-06T18:45:38Z In many cases, I want to add custom classes to comment reply link. I can use js or handle comment link string. But it's better if have an option to add custom classes to link via PHP. truongwp Unpatched Bugs 39566 WordPress ignoring previously approved comment for some comment authors rachelbaker Comments 4.7 normal major Future Release defect (bug) assigned needs-unit-tests 2017-01-12T15:41:04Z 2018-10-08T02:36:17Z "I seem to have a reproducible bug with the option ""Comment author must have a previously approved comment"". My client has a site that heavily uses guest commenting. They have selected the option ""...must have previously approved comment"". This works well most of the time, however more frequently some guests (identified by email) are being flagged as not having a previously approved comment even though they do. For one author (email) in question I am able to replicate this every time. - All other possible comment moderation disabled. - Comment as the guest in question, comment moderated. - Log in as admin, approve the comment. - Comment a second time as the guest, comment moderated again (shouldn't be) - Disable the option ""must have previously approved..."" - Comment a third time, now the comment is approved automatically. - Re-enable option ""must have previously approved..."" - Comment a forth time, the comment is moderated. This appears to be a bug to me, and I can reproduce it every time. Not sure how to troubleshoot this further from here." rperrett Candidates for Closure 39958 Comment reply/cancel links work badly when comment form is above the comment list Comments normal normal Awaiting Review defect (bug) new dev-feedback 2017-02-23T22:36:25Z 2018-01-15T14:41:01Z "If the comment form is below the list of comments, as in default WP themes, reply and cancel links work as follows: When you click reply, the form moves directly under the comment (page doesn't scroll). When you click cancel, the form jumps back to original position (page doesn't scroll). Consider any theme where the comment form is output before the list of comments. (This is a standard request, to make it easier for people to comment without having to scroll through lots of existing comments first). When you click reply, the form moves from its original position to under the comment, causing the whole page to scroll up a significant amount. The textarea gets focus, meaning if it has scrolled off the top of the screen as is quite likely, the page jumps to ensure it is visible, but you don't see important things like the reply heading, cancel link, or comment label. When you click cancel, the form reverts back to its original position, jumping the whole page content down significantly, often leaving you in a completely random part of the page. This is very disorientating from a user perspective. I'm not sure what a workaround is - perhaps some way of saving your vertical position prior to a click and restoring it after a click to make it look like there is no jump." smerriman Tickets Awaiting Review 40031 Consider Adding Web Annotations to WordPress Comments normal normal Awaiting Review feature request reopened 2017-03-04T05:20:30Z 2018-02-19T23:30:39Z "This is a strawman ticket published to generate discussion and hopefully concensus. The W3C has standardized [https://wptavern.com/web-annotations-are-now-a-w3c-standard-paving-the-way-for-decentralized-annotation-infrastructure Web Annotions] to decentralize annotations across the web ''(""annotations"" being a superset of commenting.)'' As WordPress' mission is to ''""Democratize Publishing,""'' and as WordPress is by far the most widely used tool for publishing content on the web that also allows other people to comment on said content, it would seem fitting ''(at least to me)'' that WordPress would empower users of WordPress to control their own annotations across the web, moving forward. How might to work? WordPress could offer three (3) new and yet related features: 1. Add enhancements to the commenting system to accept references to annotations. 2. Enable a WordPress site to be an ''""Annotation Server.""'' This would likely leverage the existing comment system where the comments could be associated with a new custom post type where each inidividual post could collection annotations for and represent one ""persona"" of a given registered user as well as how that persona could be presented to the outside world in the form of a URL that represents the user. 3. An ''""Annotate This""'' feature similar to ''""Press This""'' which can store annotations at the user's own WordPress site where the Annotate This UI could become the UI for commenting on all future WordPress websites (and potential non-WordPress sites) that offer feature 1. For those that doesn't offer feature 1 this UI could provide functionality to more easily transfer the comment to the foreign commenting system ''(such as copying it to the clipboard on user request)'' and possibly even implement commenting for specific well-known services ''(Twitter, Facebook, LinkedIn, Disqus, Medium, etc.)'' Note that some people's first reaction to this idea might be ''""that's plugin territory""'' -- which I can appreciate -- but there are four (4) reasons why I think this is core territory instead: 1. It is reasonable to assume that 80% of WordPress users would want to maintain their own comments in addition to their own posts, 2. This idea only really has benefits if it can become ubiquitous, e.g. If the 3 features are all available. If a plugin then an individual can only ever control one side of annotations thus dooming their implementation to obscurity. Note that a ''""Feature Plugin""'' slated for a future version of WP core is not ''""plugin territory""'' that I am arguing against. 3. It is a W3C recommendation, not some startup 3rd party service so it is likely to be adopted by many if not all of the web in the next few years. Why should WordPress not be the tool that helps define for the world how annotations should best be utilized, before some walled-garden like Facebook establishes the defacto-approach ahead of WordPress? 4. And finally, WordPress's mission is to ''""Democratize Publishing""'' and I cannot think of many other feature requests that are more ''""on-mission""'' than this one, Thoughts?" MikeSchinkel Unpatched Enhancements 40073 "WP_Comment_Query should support a comment type of ""comment""" Comments 4.8 normal normal Future Release enhancement new 2017-03-08T20:44:29Z 2017-03-13T16:18:07Z "Scenario: User is leveraging the `comment_type` field in their theme or a plugin, and desires all comments to have a type. They assign ""regular"" comments a `comment_type` of ""comment"" as that seems to make sense. If they then ask for those comments using `get_comments` or another function which leverages `WP_Comment_Query`: {{{ $comments = get_comments( [ 'type' => 'comment', ] ); }}} The returned list will not return any comments which have `comment_type` set to ""comment"", only those with no type at all. As this behavior (the swallowing of ""comment"" as a type entirely, rather than looking for `['','comment']`) is undocumented, perhaps `WP_Comment_Query` could be altered as such: {{{ 715 case 'comment': 716 case 'comments': 717 $comment_types[ $operator ][] = ""''""; ___ $comment_types[ $operator ][] = ""'comment'""; ___ $comment_types[ $operator ][] = ""'comments'""; 718 break; 719 720 case 'pings': 721 $comment_types[ $operator ][] = ""'pingback'""; 722 $comment_types[ $operator ][] = ""'trackback'""; ___ $comment_types[ $operator ][] = ""'pings'""; 723 break; }}} A sounder approach would probably be to allow a flag to be passed: {{{ 708 foreach ( $_raw_types as $type ) { ___ if ( empty( $this->query_vars['ignore_default_types'] ) ) { 709 switch ( $type ) { ... 729 } ___ } else { ___ $comment_types[ $operator ][] = $wpdb->prepare( '%s', $type ); ___ } ... 735 } }}} An alternative might be to throw an exception when setting `comment_type` to one of the default values using `wp_new_comment`, `wp_insert_comment` and similar functions. (I feel since there is no way to retrieve a comment when the type is one of these ""reserved"" words with standard WP functions, comments should probably not be able to be saved with a ""reserved"" type using standard functions if `WP_Comment_Query` is not altered.) At the very least, the documentation for comment ""insert"" functions should mention that there are reserved keywords on `comment_type`, note what they are, and that if you use one of them you will need to use the `comments_clauses` filter to allow them to be retrieved." rogerlos Tickets with Patches 40143 Comment template functions don't check for comment existence Comments normal normal Future Release defect (bug) new needs-unit-tests 2017-03-13T16:59:35Z 2024-02-08T16:10:20Z "Discovered during debugging an issue with Circle Lite theme, which uses [https://themes.trac.wordpress.org/browser/circle-lite/1.0.9/comments.php?marks=55#L42 comment_text( true )] in `kopa_comment_callback()` function. That, while being an invalid usage (the function treats `true` as a comment ID), causes an inconsistent behaviour, depending on the existence of the comment: * If the comment with ID 1 exists, the function returns its text, as expected. That's obviously not what the author of the theme intended, but still the correct behaviour of the function. * If the comment with ID 1 does not exist, the function returns the text of the current comment in the loop instead of an empty string. What happens is `get_comment( $comment_ID )` returns null (as expected), but then null is passed to `get_comment_text()`, which treats it as the current comment. After investigating more, it looks like most of comment template functions are either affected in a similar way or cause an undefined property notice when passed a non-existing comment ID. Let's bring some consistency here." SergeyBiryukov Tickets Awaiting Review 40164 Apace HTTP 414 error on deleting comments in bulk Comments 4.7.3 normal normal Awaiting Review defect (bug) new has-patch 2017-03-15T15:41:13Z 2017-03-15T21:23:12Z "Bit of an edge case, but I just had to delete 3000 comments from a WP site I took on and I was doing them in 200's (so not to over run the server and so I can check for any legitimate comments). Doing this, the first 200 comments were ""spanmmed"" fine, but then you do the next 200, it generates a 414 error as the url becomes something like: {{{ /wp-admin/edit-comments.php?s=&comment_status=moderated&pagegen_timestamp=2017-03-15+15%3A31%3A06&_total=200&_per_page=200&_page=1&paged=1&_ajax_fetch_list_nonce=ef4afc8347&_wp_http_referer=%2Fnew-site%2Fwp-admin%2Fedit-comments.php%3Fcomment_status%3Dmoderated%26paged%3D1%26spammed%3D200%26ids%3D814%2C365%2C2177%2C813%2C2021%2C812&_wpnonce=461233332d&_wp_http_referer=%2Fnew-site%2Fwp-admin%2Fedit-comments.php%3Fcomment_status%3Dmoderated%26paged%3D1%26spammed%3D200%26ids%3D814%2C365%2C2177%2C813 }}} Basically for every process it duplicates the url and if you have 100+ ID's in each request, it passes a really long url string 1) Is there a reason why all the comment ID's are passed to the url? 2) Can this be amended so in edge cases, so the 414 error isn't generated as it can and will frustrate some people." garethgillman Tickets Awaiting Review 40293 Comment template - warning Comments 4.8 normal normal Awaiting Review defect (bug) new has-patch 2017-03-29T07:15:59Z 2017-10-11T11:29:50Z "Hi, in the `comments_template` function, you are entering a divide-by-zero condition at line '''1379''' of the `wp-includes/comment-template.php` file. The line described above is like this. {{{#!php }}} I believe this will solve. {{{#!php }}} I'm using a default install with theme Twenty Seventeen. Thank you!" victorfreitas Tickets with Patches 40319 Apostrophe in commenter's name prevents comment_whitelist setting from working. Comments 4.0 normal normal Future Release defect (bug) new has-patch 2017-03-30T18:30:04Z 2020-03-20T05:26:22Z "If a commenter has an apostrophe in their name, and they have a previously approved comment, and the comment_whitelist setting is enabled (""Comment author must have a previously approved comment""), the commenter's comment will always end up in moderation. The cause of this can be traced to r38738. If the name has an apostrophe, it will be slashed; the author name was previously included directly in the SQL, with the slash properly escaping the apostrophe, but when the query was updated to use `prepare()`, the author name was not unslashed. Affects 4.7, 4.7.1, 4.7.2, 4.7.3, and trunk. I've attached a patch that addresses the issue by unslashing the two `expected_slashed` parameters." cfinke Tickets Awaiting Review 40352 WP REST API, Comments Not Triggering 'comment_post' Comments 4.7 normal normal Awaiting Review defect (bug) new dev-feedback 2017-04-04T06:50:37Z 2019-11-26T14:44:32Z "Hello, I’ve noticed that when comments are created using the WP API that notification emails are not sent out to the author of the post or moderators. (When testing, If I add the comment via the admin interface, it works as expected). On debugging, I noticed that the filter ‘comment_post’ is not being called when inserted via the API. For now, I used the following workaround: {{{#!php function mytheme_comment_inserted($comment_id, $comment_object) { wp_notify_postauthor( $comment_id ); } add_action('wp_insert_comment','mytheme_comment_inserted'); }}} I already posted on the support forum here: https://wordpress.org/support/topic/wp-api-comments-not-sending-notifications/#post-8987973 and it was suggested this could be intentional behaviour but that this also could, in fact, be reported as a bug? Thanks! Chris" stickypixel Candidates for Closure 40355 "Default to ""https://"" in comment author URL field" Comments normal normal Awaiting Review enhancement new dev-feedback 2017-04-04T15:56:58Z 2021-06-07T10:00:12Z "One pet peeve of mine with commenting on other people's WordPresses, is on new sites I haven't commented on yet (or aren't powered by Jetpack Comments) that I need to type `https://` in every Website field. Traditionally, this field is currently empty unless a cookie exists (see: `wp_get_current_commenter()`). Tangentially, recent efforts across the web to SSL all-of-the-things (`\o/`) makes this field an interesting opportunity to gently nudge the web in the direction of `https://` feeling more like the norm than the exception. A plugin can easily enable this (and I'll likely make one today) but I'll offer up the idea here first. Patch imminent." johnjamesjacoby Unpatched Bugs 40901 get_comments_number_text() third argument not used in certain situations Comments normal normal Future Release defect (bug) new needs-docs 2017-06-01T13:43:43Z 2019-06-21T13:02:54Z "`comments_number()` is a wrapper for echoing `get_comments_number_text()`. Reference: https://codex.wordpress.org/Function_Reference/comments_number The 3rd parameter's description: Text to display when there is more than one comment. % is replaced by the number of comments, so '% so far' is displayed as ""5 so far"" when there are five comments. This doesn't seem to work as expected. In particular, the parser doesn't look just for '%' but also for strings with spaces in front or behind this sign, after which it processes it in a illogical way. For example, this code {{{ ... }}} results in: `Read on 2 komentarze...` (""komentarze is a Polish translation of ""comments"", which is ok). Where's the ""so far"" string? Now another example with text before the % sign: {{{ ... }}} The result is bizarre: `Read on2 komentarze...` With some testing it seems that some strings passed as the 3rd argument are being kept, but it's totally illogical and requires review. If this is somehow intended, it should be explained in the Codex. So far, even the Codex example doesn't work as intended. I also checked that I'm not using any `comments_num*` filters. Workaround: use `get_comments_number()` with conditional code." eclare Tickets Awaiting Review 41037 Comment author can't edit their comment(s) if they aren't the post author Comments normal normal Awaiting Review defect (bug) new 2017-06-14T00:26:14Z 2019-11-22T11:42:32Z "In {{{map_meta_cap()}}}, the {{{edit_comment}}} meta capability is eventually mapped to {{{edit_others_posts}}} which results in comment authors not being able to edit their own comment(s) if their comment(s) are on a different user's post. Note 1: The issue is specific to the author role. The editor role doesn't see the issue because this role has the {{{edit_others_posts}}} cap. Note 2: The problem doesn't exist if the comment author is also the post author. This is because, in such cases, {{{edit_comment}}} is mapped to either {{{edit_published_posts}}} or {{{edit_posts}}}" henry.wright Tickets Awaiting Review 41110 "Display full content of ""Pending"" comment on WP Dashboard" Comments 4.8 normal normal Awaiting Review enhancement new has-patch 2017-06-21T05:42:37Z 2017-06-21T06:23:25Z """Recent Comments"" widget in WP dashboard displays a list of Pending and recent comments. A ""Pending"" comment has all the action items - approve, reply, edit, trash, spam. But, these items are of no use, because the complete comment text is not visible. It will be good to display the full content of the ""Pending"" comments. OR Add a toggle to display the full content without having to go to ""Comments"" page. " puneetsahalot Tickets with Patches 41339 WP_Comments_Query::__construct() should allow a 'status__not_in' parameter Comments 4.9 normal normal Future Release enhancement new needs-unit-tests 2017-07-15T19:47:02Z 2017-07-30T15:24:18Z "`WP_Comments_Query::__construct()` (and hence, `get_comments()`) currently allows a `status` parameter to get comments with a specific status. It would be useful to also allow `$status__not_in` to exclude comments with specific stati. Related: #41338" pbiron Tickets Awaiting Review 41581 Cleared Comments stuck in moderation Comments 4.8.1 normal normal Awaiting Review defect (bug) new 2017-08-07T18:32:40Z 2018-08-31T23:57:30Z "I am the third person to report this issue, since it was first reported in June on the [https://en.forums.wordpress.com/topic/comments-stuck-in-moderation-queue-even-though-akismet-cleared-this-comment?replies=44 Dot Com Forum]. A Staff Member responded to the ticket, at the time, and stated that they would be filing a Bug Report, but we have not heard back. A third user reported the issue on the [https://wordpress.org/support/topic/comments-held-in-moderation-even-after-previously-approved-comment/#post-9388458 Dot Org Forum] 2 months and 2 weeks ago. Not all cleared users are getting their comments bumped into moderation. This is the case for all three of us. The only plugin the other dot org user and I have in common is the Akismet plugin and I disabled that to confirm that it didn't fix the problem. Please advise." fb2ts Unpatched Enhancements 41731 Make it Easier to Locate Restored Comments SergeyBiryukov Comments 4.8.1 normal normal Future Release enhancement assigned 2017-08-25T19:30:34Z 2019-06-21T17:56:20Z "When a comment is in the trash, WordPress does not allow you to edit its details without restoring it first. After restoring the comment, it disappears from the Trash and the user is then required to locate it either by memorizing the post it's on or searching for it in the backend. It doesn't show up on the approved comments page because of its original published date. I suggest that if a single comment is restored, it takes users to the post it's on. Even better would be taking the user straight to where the comment is in the Discussions meta box. However, since users can hide this meta box via the screen options, I'm unsure how to account for that. Perhaps redirecting users to the post where the comment is displayed is enough?" jeffr0 Tickets Awaiting Review 41760 wp_list_comments callback params Comments normal normal Awaiting Review enhancement new dev-feedback 2017-08-30T18:44:15Z 2017-08-31T09:05:53Z "In `wp-includes/class-walker-comment.php`, methods `comment()` and `html5_comment()` have following order of @params: `$comment, $depth, $args`. However, when you try to modify comment markup using `callback` argument for `wp_list_comments()`, order of params is `$comment, $args, $depth`. Is it possible to make the same order of params?" milana_cap Candidates for Closure 41788 PHP Fatal error: Call to a member function has_cap() on a non-object in wp-includes/comment.php Comments 4.8.1 normal normal Awaiting Review defect (bug) new reporter-feedback 2017-09-03T22:16:34Z 2020-12-14T19:20:14Z "{{{#!php if ( ! empty( $commentdata['user_id'] ) ) { $user = get_userdata( $commentdata['user_id'] ); $post_author = $wpdb->get_var( $wpdb->prepare( ""SELECT post_author FROM $wpdb->posts WHERE ID = %d LIMIT 1"", $commentdata['comment_post_ID'] ) ); } if ( isset( $user ) && ( $commentdata['user_id'] == $post_author || $user->has_cap( 'moderate_comments' ) ) ) { }}} If get_userdata() returns false, this code can lead to a fatal error." kirbyde Tickets Awaiting Review 41826 WP_Comment_Query can generate negative offset in LIMIT clause Comments 4.9 normal normal Awaiting Review defect (bug) new has-patch 2017-09-07T11:40:49Z 2017-09-08T19:03:35Z "The {{{paged}}} argument in {{{WP_Comment_Query}}} was introduced in #38268 There's a problem with the {{{paged}}} as 0 case. '''Example:''' When the {{{paged}}} is 0 and {{{number}}} is 2, {{{WP_Comment_Query}}} generates the LIMIT clause: {{{ LIMIT -2, 2 }}} instead of {{{ LIMIT 0, 2 }}} According to the MySQL documentation, the offset in the LIMIT clause shouldn't be negative: https://dev.mysql.com/doc/refman/5.7/en/select.html I think we should handle it in the same way as in {{{WP_Query}}}, where the 0 case is treated as the default, that is 1. " birgire Tickets Awaiting Review 42459 "Comments metabox doesn't load all the comments when clicking ""Show more comments"" link" Comments 4.8.3 normal normal Awaiting Review defect (bug) new 2017-11-07T18:04:17Z 2018-07-31T18:11:29Z "Recently, I found an issue related to the Comments meta-box on a post edit screen. To reproduce the bug, go to the article with a certain number of comments. Suppose there are 25 comments. Then go to the post edit screen, enable the comments and scroll down to view all the comments(you will see 10). Then click the link ""Show more comments"" at the bottom of the section. You will see the second part of the comments (10 again), and the link ""Show more comments"" will disappear. You may notice that you can't load the remaining comments(5). Why this happened? My short investigation below. I found that on my opinion there is a mismatch in amount of loaded comments between the ''commentBox'' object(`/wp-admin/js/post.js`) and comments meta-box init script(`/wp-admin/includes/meta-boxes.php`). First have a look at `/wp-admin/includes/meta-boxes.php:741` {{{#!php }}} As you can see there are 10 comments set to be loaded. Then go to `/wp-admin/js/post.js:42-45` {{{#!js if ( ! num ) num = 20; this.st += num; }}} As you can see there is default `num` value set to 20. Important: then commentBox.st was increased by a `num` value. But now have a look at ""Show more comments"" link onclick attribute. {{{#!php Show more comments }}} As you can see `commentsBox.load(26)` call will update `commentBox.st` but then `commentBox.get(26, 20)` will be called (because `num = 20`). But to fit the init script(`meta-boxes.php`) it should be `commentBox.get(26, 10)`. My solution here is to set default `num` value to 10. So I guess `/wp-admin/js/post.js:42` should looks like this: {{{#!js if ( ! num ) num = 10; }}} Let me know if I missed something and we can't accept new default `num` value. I have tested it on my local end. It works well after I changed `num` default value to 10." rku4er Candidates for Closure 43015 function get_previous_comments_link not working in front page Comments 4.9.1 normal normal Awaiting Review defect (bug) new dev-feedback 2018-01-03T11:44:16Z 2019-06-24T16:29:01Z "Hey, function get_previous_comments_link generate wrong url in front page, but it's ok in typical page, it's because of the permalink, wordpress hasn't full permalink in front page." devlife Candidates for Closure 43183 wp-comments-post.php endpoint support for OPTIONS Comments normal normal Awaiting Review enhancement new reporter-feedback 2018-01-30T17:13:04Z 2019-07-01T12:24:37Z "Under some circumstance we may need cross-posting from one domain to another (without the wp-json API). At least lets preflight requests flow normally https://github.com/WordPress/WordPress/pull/338 " drzraf Candidates for Closure 43298 Add filter to hide comment types from showing up in the default query schlessera Comments normal normal Awaiting Review enhancement assigned dev-feedback 2018-02-12T15:05:23Z 2019-01-16T06:50:09Z "Comment types are not something WordPress supports by default. However, there is some data and API support for it. The `wp_comments` table contains a `comment_type` column which can be used for this purpose. The big downside is that by default these will be shown in all comment overview. Both on the frontend and the backend. There are plugins that already do this. The examples that triggered this ticket are [https://github.com/woocommerce/woocommerce/blob/d2e9b366121166c7cb26936bd2c251f3dd7ebd5d/includes/class-wc-comments.php#L110 WooCommerce] and [https://github.com/WordPress/gutenberg/pull/4685/files#diff-df5e27f1866a42a0c24ae7c0b17b1bc6R496 this PR on Gutenberg]. These plugins use the `where` clause in the pieces of the query to make this possible. I propose we add a 'simple' filter that can hide specific comment types from view. If `comment_type` is not queried in any other way, this blacklist will make sure that all comment types in the blacklist are not returned from the query. '''Why not wait for full comment_type support?''' Full `comment_type` support is a much bigger effort. This filter would benefit us in the short run and doesn't conflict with full `comment_type` support." atimmer Tickets Awaiting Review 43695 $depth and $args are switched when using custom callback in wp_list_comments() Comments 4.9.5 normal normal Awaiting Review defect (bug) new has-patch 2018-04-05T05:55:31Z 2021-11-26T11:12:27Z "For the custom function I am using the [latest function from walker](https://github.com/WordPress/WordPress/blob/master/wp-includes/class-walker-comment.php#L343) as a base. When you use custom callback in comments.php template: {{{#!php 'comment', 'format' => 'html5', 'style' => 'ol', 'short_ping' => true, ]; // Use our custom callback if it's available if( function_exists( 'custom_render_comment' ) ){ $args['format'] = 'custom'; $args['callback'] = 'custom_render_comment'; } wp_list_comments( $args ); }}} The arguments that get passed to custom_render_comment function are switched: {{{#!php NULL [""max_depth""]=> string(1) ""5"" [""style""]=> string(2) ""ol"" [""callback""]=> string(21) ""faeiv2_render_comment"" [""end-callback""]=> NULL [""type""]=> string(7) ""comment"" [""page""]=> int(0) [""per_page""]=> int(0) [""avatar_size""]=> int(32) [""reverse_top_level""]=> bool(false) [""reverse_children""]=> string(0) """" [""format""]=> string(6) ""faeiv2"" [""short_ping""]=> bool(true) [""echo""]=> bool(true) [""has_children""]=> bool(true) } } var_dump($args): int(1) */ } }}} The result is this error: {{{ Warning: array_merge(): Argument #1 is not an array in [...]/wp-content/themes/mytheme/inc/render-comment.php on line 56 }}} I haven't found any mention of switching arguments in the WordPressCodex. The fix is easy, just switch those variables, but I think it should be addressed somewhere in the documentation." vincurekf Tickets Awaiting Review 43759 CS: Fix violations for wp-includes/class-wp-comment-query.php Comments normal normal Awaiting Review defect (bug) new has-patch 2018-04-13T11:46:50Z 2020-10-16T00:46:01Z Working on a patch for this during WordCamp London, currently. jipmoors Tickets Awaiting Review 43792 get_comment_excerpt filter should tell if the comment was shorted or not Comments normal normal Awaiting Review enhancement new dev-feedback 2018-04-17T22:14:58Z 2019-01-16T06:50:09Z "The design I am currently working on has long comments shortened to 100 words, and a 'show more' / 'show less' link is added. I only want to add the 'show more' text if the comment has been shortened. There is a filter before get_comment_excerpt() returns that I can use to add my link. However it does not pass along information about whether or not the comment was shortened. As a workaround I can check if the comment ends in ""…"", but it would make sense to add a boolean value to the filter arguments to make this easier/cleaner." mattkeys Candidates for Closure 43946 Inconsistent encoding of comment_content Comments 4.9.5 normal normal Awaiting Review defect (bug) new reporter-feedback 2018-05-03T10:50:13Z 2018-05-04T12:39:24Z "The contents of the comments.comment_content field in the WordPress database are stored inconsistently depending on whether the user creating the comment was logged in or not. {{{ > select comment_ID, comment_content, comment_type from wp_comments where comment_ID > 7; +------------+-----------------------------------------------------+--------------+ | comment_ID | comment_content | comment_type | +------------+-----------------------------------------------------+--------------+ | 8 | This is a good & strong comment (comment, anon) | | | 9 | This is a good & strong comment (comment, auth) | | +------------+-----------------------------------------------------+--------------+ }}} In the example above, comment 8 was left by an anonymous user, and comment 9 was left by an authenticated user. Notice how the comment_content field has been HTML-escaped for ID 8, but not for ID 9. === Steps to reproduce: * Install a fresh copy of WordPress * As the site administrator, navigate to the default ""hello-world"" post * Leave a comment including characters that should be escaped when output to HTML, e.g. & * Log out * Navigate to the default ""hello-world"" post * Leave a comment including characters that should be escaped when output to HTML, e.g. & Compare the contents of the two comments in the wp_comments table. " leewillis77 Tickets Awaiting Review 44226 Link to Privacy Policy in comment consent Comments 4.9.6 normal normal Awaiting Review feature request new 2018-05-25T13:18:42Z 2021-10-29T09:31:19Z "Hi! It's possible add the url to privacy policy after consent in comments? Thank You!" paolobros Tickets Awaiting Review 44485 Allow some functions from comments-template.php to accept a comment or post ID Comments normal normal Awaiting Review enhancement new has-patch 2018-07-01T14:11:57Z 2018-07-01T14:11:57Z "Nowadays, it's not uncommon to have to use some templating functions outside of the loop. Most of them already accepts a comment or post ID (get_permalink, ...). But, that's not the case for some functions related to comments. I did a small update of the file to allow that." tristanleboss Tickets Awaiting Review 44923 Filter .children class on nested comments list Comments normal normal Awaiting Review enhancement new 2018-09-09T20:52:44Z 2019-04-21T07:19:28Z "The `start_lvl()` method of `Walker_Comment` should have a filter hook to customize the `.children` class. This will allow theme authors to utilize their preferred system or CSS framework for handling nested comment lists. And, `.children` is generic and requires writing nested CSS selectors to target it. This change would put the comment walker on par with the nav menu walker, where we have the `nav_menu_submenu_css_class` filter hook." greenshady Tickets with Patches 45498 Wrong order of arguments in call_user_func() for Walker_Comment::start_el() SergeyBiryukov Comments normal normal Future Release defect (bug) reviewing needs-unit-tests 2018-12-06T16:52:14Z 2019-01-16T05:46:01Z "Arguments order for rendering all types of comments is `$comment, $depth, $args` except for the custom callback: `call_user_func( $args['callback'], $comment, $args, $depth );` This causes every custom callback to throw an error when you use `$args` and `$depth` as you'd expect. For example, `comment_reply_link()` inside callback can not be used like it's suppose to be used, like so: {{{#!php 'div-comment', 'depth' => $depth, 'max_depth' => $args['max_depth'], 'before' => '
', 'after' => '
' ) ) ); }}} You need to replace `$depth` and `$args`, like so: {{{#!php 'div-comment', 'depth' => $args, 'max_depth' => $depth['max_depth'], 'before' => '
', 'after' => '
' ) ) ); }}} " milana_cap Tickets Awaiting Review 45585 comments ordering by date, orders them only for the current page. Comments 4.9.8 normal normal Awaiting Review defect (bug) new 2018-12-11T15:35:05Z 2018-12-12T08:15:33Z "'''Tested''': on 5.0 and 4.9.8 (found it on 4.9.8) '''Steps to reproduce''': 1. add comments (skip if existing) 2. change the comment dates 3. activate pagination in comments in wp-settings -> discussion and set comments display ""newest"". '''Mentions''' I did testing on both Twenty Seventeen and Twenty Nineteen, the result is the same, it will order comments by date for the current page, not all comments and then split in pages. '''Expected behaviour''' Order comments then split them in pages, now it does vice-versa, where it orders the comments by date after they are being split in pages." rwky Candidates for Closure 45998 Comments trashed after reply Comments 5.0.3 normal normal Awaiting Review enhancement new reporter-feedback 2019-01-16T02:58:34Z 2019-01-16T16:42:52Z "I found A Bug into your software. Which is Whenever I click on **Approve and Reply** option in comments, then it's automatically trashed.. Please Fix it." pkkarn Tickets with Patches 46017 """Mine"" comment count isn't updated when replying to or moderating a comment." Comments 5.1 normal normal Future Release defect (bug) new has-patch 2019-01-17T02:59:49Z 2019-01-24T04:40:53Z "To reproduce: - Visit `/wp-admin/edit-comments.php`. - Click Reply on a comment. - Type some text in the comment, click Reply. The ""All"" and ""Approved"" counts update as expected, but the ""Mine"" count doesn't." pento Tickets Awaiting Review 46243 WordPress Comments Core Query Comments 5.0.3 normal normal Awaiting Review defect (bug) new dev-feedback 2019-02-13T03:48:45Z 2021-03-26T16:16:24Z "Hello, **Issue:** We have over 400K+ posts and I saw this slow query on any WordPress area on each page. We had 2M+ comments. **Question:** This Query is working on all pages on Dashboard or Settings, Plugin section and any sections why does it? It should works on only all Posts list? **Solution:** I have noticed that Header Bar has Comments Icon and that has displayed the Pending Comments count. I have tried to disable it via custom Filter for following. {{{ function admin_bar_remove_comments(){ global $wp_admin_bar; $wp_admin_bar->remove_menu('comments'); } add_action( 'wp_before_admin_bar_render', 'admin_bar_remove_comments' ); }}} **Slow Query:** {{{ SELECT comment_approved, COUNT( * ) AS total FROM wp_comments GROUP BY comment_approved }}} **Environment Information:** WP Version 5.0.3 (also tested 4.9.8) Theme: Twenty Seventeen (other themes) Plugins: Query Monitor Thanks." Uranbold Candidates for Closure 46642 Comment form content textarea shouldn't be a required field Comments 5.1 normal major Awaiting Review defect (bug) new dev-feedback 2019-03-25T17:40:00Z 2020-01-23T11:07:04Z "there's a note on the top of the comment form that states: "" Required fields are marked "" and the comment