Make WordPress Core

Opened 4 years ago

Closed 4 months ago

#18517 closed defect (bug) (fixed)

Visual Feedback for Nav Menu UI

Reported by: sterlo Owned by: helen
Milestone: 4.3 Priority: normal
Severity: normal Version: 3.0
Component: Menus Keywords: has-patch needs-refresh
Focuses: ui, javascript Cc:


Currently if you go to:

Then click the plus sign to add a Menu and then without putting a menu name in, click create menu, it gives you a visual indicator that you've missed a critical bit of data.

But, if you try to add a Custom Link to an existing menu: If one forgets to add a URL and just adds a label then tries to save it, there is not 'tactile feedback'. It just sits there not doing anything.

It should probably be consistent with how the rest of the UI behaves.

Attachments (1)

18517.diff (1.1 KB) - added by pragunbhutani 2 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 @nacin4 years ago

  • Keywords needs-patch added
  • Type changed from enhancement to defect (bug)
  • Version changed from 3.3 to 3.0


comment:2 @jane4 years ago

Agreed, though it needs visual feedback, not tactile.

comment:3 @helenyhou3 years ago

  • Component changed from UI to Menus
  • Summary changed from Tactile Feedback for Nav Menu UI to Visual Feedback for Nav Menu UI

@pragunbhutani2 years ago

comment:4 @pragunbhutani2 years ago

I've added an addClass('form-invalid') to the event handler in nav-menu.js
Also updated class definition for .form-invalid to include .customLinkDiv

comment:5 @helen20 months ago

  • Focuses ui javascript added
  • Keywords has-patch needs-refresh added; needs-patch removed

comment:6 @slackbot4 months ago

This ticket was mentioned in Slack in #core by nacin. View the logs.

comment:7 @helen4 months ago

  • Milestone changed from Awaiting Review to 4.3

comment:8 @helen4 months ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 32690:

Nav menus: Provide visual feedback when attempting to add an empty custom link.

props pragunbhutani for the initial patch.
fixes #18517.

Note: See TracTickets for help on using tickets.