WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#10001 closed defect (bug) (fixed)

Allow translators to change the curly quotes

Reported by: nbachiyski Owned by: nbachiyski
Milestone: 2.8 Priority: low
Severity: minor Version: 2.8
Component: I18N Keywords:
Focuses: Cc:

Description

Currently: all quotes in posts are replaced by the curly quotes used in the English language: “ and ”

Problem: some languages use different curly quotes.

Attachments (1)

translate-curly-quotes.diff (1.8 KB) - added by nbachiyski 5 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 follow-up: azaozz5 years ago

This fixes it in wptexturize() but not in the admin. There are about 90 places with hard-coded curly quotes in there. Perhaps we have to make $opening_quote and $closing_quote global vars and make sure they are changed as soon as the translation functions are available (there are probably places where curly quotes are used very early).

comment:2 azaozz5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [11504]) Allow translators to change the curly quotes in wptexturize(), props nbachiyski fixes #10001

comment:3 in reply to: ↑ 1 demetris5 years ago

  • Cc dkikizas@… added
  • Milestone changed from 2.9 to 2.8

Thanks for this!

Replying to azaozz:

This fixes it in wptexturize() but not in the admin. There are about 90 places with hard-coded curly quotes in there. Perhaps we have to make $opening_quote and $closing_quote global vars and make sure they are changed as soon as the translation functions are available (there are probably places where curly quotes are used very early).

I thought this was not an issue with admin strings, since their typography was entirely up to translators. For example, I just use the appropriate quotations marks for the language:

#: wp-admin/includes/image.php:150
#, php-format
msgid "File “%s” is not an image."
msgstr "Το αρχείο «%s»  δεν είναι εικόνα."

... and I’m done.

Isn’t that so?

Note: See TracTickets for help on using tickets.