var pagenow in js not supporting plugins !

[arena]

javascript generated in the admin header do not support plugins

so modifiying this line

var pagenow = '<?php echo substr($pagenow, 0, -4); ?>';

into this

var pagenow = '<?php echo (isset($plugin_page)) ? $plugin_page : substr($pagenow, 0, -4); ?>';

[arena]

see ticket text !

[Denis-de-Bernardy]

shouldn't this be substr($page_hook, 0, -4), rather?

[arena]

Replying to Denis-de-Bernardy:

shouldn't this be substr($page_hook, 0, -4), rather?

No, in wp, pagenow is deducted from the php file name (admin.php, post.php etc ...)

in plugins, plugin pages have no relation with any php file (admin.php?page=toto ...)

[arena]

Replying to arena:

Replying to Denis-de-Bernardy:

shouldn't this be substr($page_hook, 0, -4), rather?

No, in wp, pagenow is deducted from the php file name (admin.php, post.php etc ...)

in plugins, plugin pages have no relation with any php file (admin.php?page=toto ...)

btw, plugin_page is more stable than page_hook, page_hook value changes whether the option is at the top of a plugin menu or not !

[azaozz]

pagenow is needed for managing table columns, adding $hook_suffix seems better.

[azaozz]

(In [11508]) Add $hook_suffix as js var, fixes #10008

[arena]

2.8.2 regression

[11508] has been discarded !!!

[arena]

changing milestone

[arena]

sorry, forget about [11508], #10008.diff is still pending

[dd32]

sorry, forget about [11508], #10008.diff is still pending

I believe the decision here is for $pagenow to be mimicked in JS, Its never set to the pagehook in PHP. If a plugin needs the plugin pagehook, they can use adminpage.

Do you have any arguments against that that would support it not being mimicked?