WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 8 years ago

#10016 closed defect (bug) (fixed)

<wfw:commentRss> may not return an RSS 2 feed

Reported by: peaceablewhale Owned by:
Milestone: 2.9 Priority: normal
Severity: normal Version: 2.8
Component: Feeds Keywords: has-patch commit
Focuses: Cc:

Description

When the default feed format is not RSS 2, the <wfw:commentRss> elements in the RSS 2 feed will contain links pointing to comment feeds in a different feed format. This behavior is unexpected for some applications which always look for a RSS 2 feed.

Attachments (1)

10016.patch (600 bytes) - added by peaceablewhale 9 years ago.

Download all attachments as: .zip

Change History (10)

#1 @Denis-de-Bernardy
9 years ago

itching to close this as a dup of #5802

#2 @Denis-de-Bernardy
9 years ago

  • Milestone changed from 2.8 to 2.9

punting per IRC discussion

#3 @peaceablewhale
9 years ago

  • Milestone changed from 2.9 to 2.8

This is not related to #5802. The feed format can be changed by a plugin. If the format is Atom, wfw:commentRss will return the Atom comment feed link because the feed format is not specified. That patch fixes to format to "rss2".

By the way, how may I join the IRC discussion?

#4 @Denis-de-Bernardy
9 years ago

  • Milestone changed from 2.8 to 2.9

irc.freenode.net, channel wordpress-dev

punting back to 2.9. only critical bugs should remain in 2.8.

#5 @peaceablewhale
9 years ago

Thanks. I finally noticed the blog post saying that only blockers should remain: http://wordpress.org/development/2009/06/summary-of-wordpress-dev-irc-meetup-for-20090603/

Unfortunately it is difficult to for me to join the IRC... 21:00 UTC is the time I am sleeping. (I am in Hong Kong, the timezone is UTC+8) I hope that discussion of bugs will remain in Trac.

#6 @peaceablewhale
9 years ago

  • Milestone changed from 2.9 to 2.8.1

Can this be patched in 2.8.1? I think this is a simple quick fix.

#7 @Denis-de-Bernardy
9 years ago

  • Keywords commit added

#8 @ryan
8 years ago

  • Milestone changed from 2.8.5 to 2.9

#9 @ryan
8 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [11864]) Force correct feed type for wfw:CommentRss element. Props peaceablewhale. fixes #10016

Note: See TracTickets for help on using tickets.