Incorrect behavior of "WP_Filesystem_FTPext -> exists"

[gothicquark]

FTP server on my web hosting returns something like a

ftpd: /www/dirname: No such file or directory

as a response of ftp_rawlist function. So this part of code works incorrectly

function exists($file) {
  $list = @ftp_rawlist($this->link, $file, false);
  return !empty($list); //empty list = no file, so invert.
}

My temporary workaround is:

function exists($file) {
  $list = @ftp_rawlist($this->link, $file, false);
  return !(empty($list) || (strpos($list[0], "No such file or directory") !== FALSE));
}

[Denis-de-Bernardy]

might we want to use ​http://fr2.php.net/manual/en/function.ftp-nlist.php instead?

[gothicquark]

This works great:

$list = @ftp_nlist($this->link, $file);

[dd32]

I'll try and confirm that nlist works as expected.

Bumping to 2.9 due to 2.8's close release, there'll be no time to test if this actually works correctly for the majority.

[dd32]

Tested on VSFtp (linux) and FileZilla on windows, Seems to work as expected with nlist()

However it needs to be mentioned that neither of these servers returned verbose errors on file-not-existing..

[dd32]

Tested with files/folders which existed/didnt exist.

not sure of the need for @ there, but might as well leave it in, it'll make minimal performance difference. (I cant remember why rawlist needed it, I think it was outputting Success messages as warnings)

[azaozz]

(In [11821]) Fix WP_Filesystem_FTPext->exists(), props dd32, fixes #10060