clean_url improperly scrapes %20

[noel]

clean_url will currently turn a url like ​http://jcksn.com/Noel%20Jackson into ​http://jcksn.com/NoelJackson

This patch fixes that problem, adding
x20 to the regex.

[noel]

Fix for spaces in clean_url

[Denis-de-Bernardy]

this one is a blocker imo.

[westi]

Replying to Denis-de-Bernardy:

this one is a blocker imo.

this can't be a blocker at this stage as it isn't a regression.

This will have to wait for 2.8.1

[westi]

Just tested this.

And clean_url('​http://jcksn.com/Noel%20Jackson') works fine already
What doesn't work is clean_url('​http://jcksn.com/Noel Jackson')

[westi]

Would be good to see a nice set of test cases to add for this.

Including all the things we are trying to remove.

I started with the bug here: ​http://svn.automattic.com/wordpress-tests/wp-testcase/test_includes_formatting.php

Patches welcome

[miqrogroove]

This is not a bug. The behavior described by westi is correct. I have reviewed the trunk code, compared it to RFC 1738, and it appears to be perfect. Spaces fall under the definition of Unsafe URL Characters and are never allowed to appear unless encoded.

If there is a cosmetic problem involving URLs that are passed to clean_url(), then we should have a ticket describing why and how clean_url() is being used at a higher level.

I don't object to westi's idea for test cases, but this is currently a matter of "garbage in, garbage out."