Make WordPress Core

Opened 17 years ago

Closed 15 years ago

Last modified 14 years ago

#1008 closed enhancement (worksforme)

metaWeblog API enhancements for WordPress - enclosure support

Reported by: canopus Owned by: markjaquith
Milestone: Priority: normal
Severity: normal Version: 1.5.1
Component: XML-RPC Keywords:
Focuses: Cc:


I attach a patched xmlrpc.php (only a few lines of code added).

This is for metaWeblog API enhancements including:

  • enclosure support in metaWeblog.Newpost, using own WordPress postmeta table system (line 847)
  • base64 decode for files saved from metaweblog.Newmediaobject (line 542)

With this, WordPress would be the first CMS capable of automatic podcasting publication from Podcast client software, like EasyPodcast.

  • canopus -

Attachments (3)

xmlrpc.php (37.0 KB) - added by canopus 16 years ago.
enclosure (879 bytes) - added by ryan 16 years ago.
enclosure code snippet
base64.diff (313 bytes) - added by ErikRose 16 years ago.
The base64 fix as a diff, as requested

Download all attachments as: .zip

Change History (13)

#1 @canopus
17 years ago

  • Patch set to No

16 years ago

#2 @matt
16 years ago

  • Milestone set to 1.5.2

#3 @markjaquith
16 years ago

  • Keywords bg|dev-feedback bg|2nd-opinion added
  • Owner changed from anonymous to markjaquith
  • Status changed from new to assigned

Did this make it into 1.5.2? I know a lot of work was done on xmlrpc.php

16 years ago

enclosure code snippet

#4 @ryan
16 years ago

It's not in 1.5.2. I snipped the relevant code. Maybe we could work this into wp_insert_post().

#5 @matt
16 years ago

  • Milestone changed from 1.6 to 2.1

#6 @matt
16 years ago

Submit this as a patch and we'll consider it.

#7 @Hoyd
16 years ago

Can anyone confirm that this actually works? I've been trying to add this code into my xmlrpc.php file to get enclosures to auto-generate using a 3rd party blogging tool and haven't had any luck with WP 1.5.2 or 2.0.1. If anyone has this working with either of these and can post the full xmlrpc.php file (or verify that the above one works), that would be awesome!

16 years ago

The base64 fix as a diff, as requested

#8 @rgovostes
15 years ago

  • Keywords has-patch added

#9 @westi
15 years ago

  • Keywords bg|dev-feedback bg|2nd-opinion has-patch removed
  • Resolution set to worksforme
  • Status changed from assigned to closed

This is _not_ a bug.

The base64 information provided by the client is decoded by the XML-RPC client code in class-IXR.php before the function in xml-rpc.php is called.

This happens here - http://trac.wordpress.org/browser/branches/2.0/wp-includes/class-IXR.php#L221 when the parent class parses the incoming XML-RPC message.

I have tested this for both the metaweblog api and moveabletype api and it works fine for me (using http://www.blogdesk.org)

#10 @Nazgul
14 years ago

  • Milestone 2.1 deleted
Note: See TracTickets for help on using tickets.