Make WordPress Core

Opened 5 years ago

Closed 8 months ago

#10086 closed enhancement (wontfix)

Better warning (JS confirm dialog) when upgrading themes

Reported by: demetris Owned by:
Milestone: Priority: normal
Severity: minor Version: 2.8
Component: Text Changes Keywords: has-patch close
Focuses: Cc:


I see three problems in the current warning:

  1. It’s not good UI English: “Upgrading this theme will lose...”
  1. It does not follow the layout of similar JS confirm dialogs in WP, which put the OK/Cancel phrase in a second line.
  1. It’s not accurate and may frighten people for no reason.

I attach a tentative patch for consideration.

Attachments (1)

t10086-better-theme-upgrade-warning.diff (1.3 KB) - added by demetris 5 years ago.
Tentative text tweak for theme upgrade warning

Download all attachments as: .zip

Change History (8)

demetris5 years ago

Tentative text tweak for theme upgrade warning

comment:1 Denis-de-Bernardy5 years ago

  • Component changed from General to Themes

comment:2 Denis-de-Bernardy5 years ago

+1. patch applies clean, haven't tested though.

comment:3 janeforshort4 years ago

  • Type changed from defect (bug) to enhancement

comment:4 janeforshort4 years ago

  • Milestone changed from 2.9 to Future Release

I think the new text actually makes it slightly more confusing for the end-user. Punting to next cycle b/c we're in string freeze for 2.9, can discuss more then. Would ilke to actually do an audit of all confirmation dialogs, alerts and error messages with 3.0 if possible.

comment:5 obenland9 months ago

  • Keywords close added
  • Severity changed from normal to minor

The string now lives in wp-admin/includes/theme.php. It hasn't seen any action in 4 years, can we close this?

comment:6 DrewAPicture9 months ago

  • Component changed from Themes to Text Changes

comment:7 helen8 months ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

It has been a long time, and the proposed text doesn't seem any better to me. Can re-open if somebody feels strongly about it.

Note: See TracTickets for help on using tickets.