Make WordPress Core

Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#10090 closed defect (bug) (fixed)

Vertical misalignment in Categories page, Description column

Reported by: demetris's profile demetris Owned by:
Milestone: 2.8.1 Priority: normal
Severity: normal Version: 2.8
Component: UI Keywords: has-patch commit
Focuses: Cc:

Description

The inherited p(aragraph) margins seem to cause a vertical misalignment. See attached screenshot.

I also attach a tentative fix. (It’s hackish and also a product of confusion, because I don’t really understand what’s going on with vertical dimensions here, and different browsers display this in different ways.)

Attachments (2)

t10090-categories-vertical-misalignment.png (5.0 KB) - added by demetris 15 years ago.
Screenshot of vertical misalignment in Categories page, Description column
t10090-categories-vertical-misalignment.diff (355 bytes) - added by demetris 15 years ago.
Tentative fix for vertical misalignment in Categories page, Description column

Download all attachments as: .zip

Change History (10)

@demetris
15 years ago

Screenshot of vertical misalignment in Categories page, Description column

@demetris
15 years ago

Tentative fix for vertical misalignment in Categories page, Description column

#1 @Denis-de-Bernardy
15 years ago

  • Milestone changed from 2.8 to 2.9

issues like this have been all over the place since 2.5, this can wait until 2.8.1.

#2 @Denis-de-Bernardy
15 years ago

The real issue, I believe, is margins/padding related. A potentially better patch would probably go something like this:

p {
  padding: 0px;
  margin: 0px 0px .5em 0px;
}

that way, we'd enforce the same margin across browsers (one of IE or FF uses paddings, while the other users margins), and we don't get vertical align issues in tables (where margins are not enforced as they are in div tags).

#3 @demetris
15 years ago

The reason I set the Milestone to 2.8 is that this particular one is misaligned by almost one em — which is too much. On the other hand, category descriptions are not the most-often used feature of WP, so not all users will see this.

#4 @Denis-de-Bernardy
15 years ago

  • Milestone changed from 2.9 to 2.8

I know... :-(

But lately, even rather major/niggling bugs have been punted.

#5 @westi
15 years ago

  • Milestone changed from 2.8 to 2.8.1

Punt this for now - it's not major and can wait

#6 @Denis-de-Bernardy
15 years ago

  • Keywords commit added

#7 @azaozz
15 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [11663]) Fix vertical misalignment and cell borders in IE, props demetris, fixes #10090 for 2.8

#8 @azaozz
15 years ago

(In [11664]) Fix vertical misalignment and cell borders in IE, props demetris, fixes #10090 for trunk

Note: See TracTickets for help on using tickets.