Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#10093 closed defect (bug) (fixed)

SSH2 Install note for '--enable-sockets' to be complied in PHP

Reported by: ShaneF Owned by: ShaneF
Milestone: 2.8.1 Priority: normal
Severity: normal Version: 2.8
Component: Upgrade/Install Keywords: has-patch commit
Focuses: Cc:


This has to be mentioned in the file otherwise people will get an error. This patch reflects to allow SSH2 and has instructions on how to install them just in case.

Attachments (2)

10093.diff (1.4 KB) - added by ShaneF 6 years ago.
10093.2.diff (7.5 KB) - added by dd32 6 years ago.

Download all attachments as: .zip

Change History (17)

@ShaneF6 years ago

comment:1 @Denis-de-Bernardy6 years ago

  • Severity changed from blocker to normal

comment:2 @ShaneF6 years ago

  • Keywords has-patch commit added
  • Owner changed from dd32 to ShaneF
  • Status changed from new to assigned

comment:3 @ShaneF6 years ago

  • Status changed from assigned to accepted

comment:4 @ryan6 years ago

[11063] introduced the new dependency? Is it a dependency we want to keep or workaround?

comment:5 @Denis-de-Bernardy6 years ago

  • Keywords reporter-feedback added

comment:6 @dd326 years ago

Is it a dependency we want to keep or workaround?

..I think that was meant to check for the streams extension, rather than sockets..

IMO, If they're going to install the SSH module, they've probably got streams anyway. Its really the best way to handle filesystem streams though (like in that case) as i dont think you can check in PHP fully if the data was really EOF'd or not.. It returns early when things timeout or something from memory

comment:7 @ShaneF6 years ago

I didn't even have the sockets extension loaded when I first installed the ssh2 extention and it worked like a charm. However, we need to include and have the check in file.php if we are going to keep the extention_loaded('sockets'); test in.

comment:8 @dd326 years ago

Like i said, The sockets test is not needed, that was an error.

But since you wrote some of that code, i've fixed a lot up so it works decently.. streams (not sockets) were a necessity at the time due to the way that the streams interacted on a lower level, I dont think it was possible to do it purely in php every time.

@dd326 years ago

comment:10 @dd326 years ago

  • Keywords reporter-feedback removed

attachment 10093.2.diff added

  • s/sockets/stream_get_contents/g
  • some comment changes
  • Few formatting changes.

comment:11 @ShaneF6 years ago

I'll retest it real quick.

comment:12 @ryan6 years ago

Tested? Okay for 2.8.1?

comment:13 @dd326 years ago

Okay for 2.8.1

I dont see why it isnt :)

comment:14 @ryan6 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [11632]) Enforce stream_get_contents() requirement for ssh2 fs. Props dd32. fixes #10093 for trunk

comment:15 @ryan6 years ago

(In [11633]) Enforce stream_get_contents() requirement for ssh2 fs. Props dd32. fixes #10093 for 2.8.1

Note: See TracTickets for help on using tickets.