SSH2 Install note for '--enable-sockets' to be complied in PHP

[ShaneF]

This has to be mentioned in the file otherwise people will get an error. This patch reflects to allow SSH2 and has instructions on how to install them just in case.

[ryan]

[11063] introduced the new dependency? Is it a dependency we want to keep or workaround?

[dd32]

Is it a dependency we want to keep or workaround?

..I think that was meant to check for the streams extension, rather than sockets..

IMO, If they're going to install the SSH module, they've probably got streams anyway. Its really the best way to handle filesystem streams though (like in that case) as i dont think you can check in PHP fully if the data was really EOF'd or not.. It returns early when things timeout or something from memory

[ShaneF]

I didn't even have the sockets extension loaded when I first installed the ssh2 extention and it worked like a charm. However, we need to include and have the check in file.php if we are going to keep the extention_loaded('sockets'); test in.

[dd32]

Like i said, The sockets test is not needed, that was an error.

But since you wrote some of that code, i've fixed a lot up so it works decently.. streams (not sockets) were a necessity at the time due to the way that the streams interacted on a lower level, I dont think it was possible to do it purely in php every time.

[ryan]

See #10195

[dd32]

attachment 10093.2.diff added

• s/sockets/stream_get_contents/g
• some comment changes
• Few formatting changes.

[ShaneF]

I'll retest it real quick.

[ryan]

Tested? Okay for 2.8.1?

[dd32]

Okay for 2.8.1

I dont see why it isnt :)

[ryan]

(In [11632]) Enforce stream_get_contents() requirement for ssh2 fs. Props dd32. fixes #10093 for trunk

[ryan]

(In [11633]) Enforce stream_get_contents() requirement for ssh2 fs. Props dd32. fixes #10093 for 2.8.1