#10112 closed defect (bug) (fixed)
Gears conflicts with Visual Editor
| Reported by: | link2caro | Owned by: | azaozz |
|---|---|---|---|
| Priority: | high | Milestone: | 2.9 |
| Component: | TinyMCE | Version: | 2.8 |
| Severity: | major | Keywords: | reporter-feedback has-patch |
| Cc: | Focuses: |
Description
http://demo.wordpressvn.net/
admin/admin
When Gears is enable and Turbo is active, Visual Editor does not work. I have my personal blog updated from 2.7.1 and got the same issue.
When Turbo is disabled, everything works.
Change History (7)
#4
@
17 years ago
No errors on the Turbo Page.
The Turbo menu (link) at the top right corner (next to Howdy,) does not appear when Turbo is inactive, by the way. I go to Tools and activate Turbo, it counts to 167/167, then it says Update completed.
And then the TinyMCE cannot load, all my sites and some of my friends encounter this issue.
This ticket was mentioned in PR #12972 on WordPress/wordpress-develop by @adrianmoldovanwp.
2 months ago
#7
- Keywords has-patch added
Dispatching this workflow with a specific version spawns jobs that start from a *newer* version. As reported in #10112, a run dispatched for 6.6.4 included "6.7 to 6.6.4" and "6.8 to 6.6.4".
Those are downgrades. wp core update declines to move backwards without --force, so the jobs pass having tested nothing — a green check for work that never happened, in a matrix large enough that nobody reads the individual job names.
Each matrix now takes its starting versions from a build-test-matrix job, which drops every version that is not older than the target. A job whose list ends up empty is skipped.
| Dispatched | Starting versions still tested |
|---|---|
latest, nightly | all of them, unchanged |
6.9.1 | up to and including 6.9, since 6.9 to 6.9.1 is a real upgrade
|
6.9 | up to 6.5, since a major target drops its own branch
|
6.6.4 | up to 6.5
|
#10112 addresses the same bug by generating matrix exclude entries. Generating the version lists instead keeps each matrix multi-dimensional, needs no supported-branch constant to bump every release, and handles pre-release entries such as 7.0-RC3 that an exact-match exclusion cannot remove.
<details>
<summary>Known limitation, unchanged by this PR</summary>
A minor target keeps its own branch, because 6.4 to 6.4.4 is a real upgrade. The called workflow runs wp core update --minor before the final upgrade step, so the minor update performs that upgrade and the final step is a no-op. When the target is not the newest release on its branch, the minor update overshoots the target and the target is never installed. This predates the PR; it is now documented in the workflow.
</details>
## Testing Instructions
The filtering only runs on workflow_dispatch. The push and pull_request triggers always use latest, which drops nothing, so CI on this PR exercises the unchanged path only.
Dispatch Upgrade Tests from this branch and check the spawned job list:
latest— every job spawns, same as trunk today.6.6.4— "6.9 to 6.6.4" and "7.0 to 6.6.4" are gone;Build Test Matrixreportsrecent-releases=[].6.9.1— "6.9 to 6.9.1" still spawns, "7.0 to 6.9.1" does not.6.0— bothupgrade-tests-recent-releasesandupgrade-tests-wp-6x-mysqlskip.
Watch for Matrix vector 'wp' does not contain any values in runs 2 and 4. That error would mean GitHub expands strategy.matrix before evaluating the job's if, which is the one assumption behind the != '[]' guards that cannot be checked without a dispatch.
Trac ticket: TBD
## Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5
Used for: Implementation, inline documentation, and iterative code review of the change. The approach — generating the version lists rather than generating matrix exclusions — was settled in discussion. I have reviewed the result and take responsibility for it.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
No errors are displayed when on the Turbo page? There was another ticket of someone recieving 403 errors on a tinyMCE file.. the end result was that tinyMCE didnt load.