WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#10117 closed defect (bug) (fixed)

Change update string to indicate if version is the original English one, or the local one

Reported by: xibe Owned by: ryan
Milestone: 2.8.1 Priority: high
Severity: major Version: 2.8
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

With 2.8, many people can know make real use of the automatic update tool.

Thing is, in the case of localized versions, the update message

You can upgrade to version %s automatically or download the package and install it manually:

...is displayed for the English version hours before the release of the local version, and not everyone is aware that it is the English version rather than the localized one.

While this is not an issue in the long term, it makes for a flood of messages on local support forums, with people asking why the translation is wrong or even gone. We can tell them to wait for the local version button to appear, but it'd be easier if such a message was displayed directly in the updating tool.

Attachments (1)

i18n-to-en_US-hint.diff (1.3 KB) - added by nbachiyski 5 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 follow-up: Denis-de-Bernardy5 years ago

  • Milestone 2.9 deleted
  • Resolution set to invalid
  • Status changed from new to closed

comment:2 in reply to: ↑ 1 xibe5 years ago

  • Keywords needs-patch added
  • Milestone set to 2.9
  • Resolution invalid deleted
  • Status changed from closed to reopened

see http://core.trac.wordpress.org/ticket/10114#comment:3

Indeed, I think this ticket is a very good continuation of your very own "The message could arguably be enhanced" - which is all I'm asking for here :)

Simply put, I'd like this string:

You can upgrade to version %s automatically or download the package and install it manually

...to indicate the locale at all times, whether it's the original en_US, or the user's current locale. Currently it only displays the locale tag for the user's current one, and I'd like it to also mention when the updates contains the original locale.

Seems pretty trivial to me, and would certainly lighten the burden on local communities when update-time comes.

And, by they way, the message added by r11273 is nowhere to be seen during the time between the en_US release and the local version release (AFAICT). Maybe I'm mistaken about when it is supposed to show up, but if your message implies that it should be displayed at that time, then something is wrong.

comment:3 Denis-de-Bernardy5 years ago

  • Milestone changed from 2.9 to 2.8.1
  • Priority changed from normal to high
  • Severity changed from normal to major

comment:4 ryan5 years ago

  • Component changed from Upgrade/Install to i18n

comment:5 Denis-de-Bernardy5 years ago

  • Type changed from enhancement to defect (bug)

comment:6 nbachiyski5 years ago

  • Keywords has-patch added; needs-patch removed

xibe is right. Users should be fully aware that:

  • There may be interim period before the release of the locazlied package.
  • If they upgrade to the English version it may break their translation.

Here is a patch, which:

  • Adds the en_US suffix to the WordPress version if the locale of the blog is different from en_US. We don't want en_US users too see this prefix. All other will see it and hopefully it will ring a bell.
  • When the preferred update is in English, but the current locale is different, shows a little hint below the buttons, which says: "You are about to install WordPress %s <strong>in English.</strong> There is a chance this upgrade will break your translation. You may prefer to wait for the localized version to be relased."

comment:7 nbachiyski5 years ago

  • Owner changed from dd32 to ryan
  • Status changed from reopened to reviewing

comment:8 ryan5 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

(In [11669]) Change update string to indicate if version is the original English one, or the local one. Props nbachiyski. fixes #10117 for trunk

comment:9 ryan5 years ago

(In [11670]) Change update string to indicate if version is the original English one, or the local one. Props nbachiyski. fixes #10117 for 2.8.1

Note: See TracTickets for help on using tickets.