Code optimisations for timezone dropdown builder.
|Reported by:||sambauers||Owned by:|
The new timezone dropdown builds noticeably slowly in 2.8 causing lag when opening the general options page in admin.
The main problem was with inefficient use of translate functions within the usort callback.
Secondarily, the loop which builds the actual options html was using a string concatenation method which pulls and pushes the same variable in and out of memory hundreds of times.
The following patch fixes both of these problems and generally tidies things up. Performance is improved noticeably.