WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#10192 closed defect (bug) (fixed)

Installer/Upgrader bugs and tweaks

Reported by: Denis-de-Bernardy Owned by: Denis-de-Bernardy
Milestone: 2.8.1 Priority: normal
Severity: normal Version: 2.8
Component: Upgrade/Install Keywords: has-patch needs-review
Focuses: Cc:

Description

Will post a big patch when I'm done testing the entire thing.

Attachments (1)

10192.diff (4.2 KB) - added by Denis-de-Bernardy 6 years ago.

Download all attachments as: .zip

Change History (5)

@Denis-de-Bernardy6 years ago

comment:1 @Denis-de-Bernardy6 years ago

  • Keywords has-patch needs-review added

first batch attached, for plugins.

tested except for this part, which seemed very wrong:

-	$update_plugins = get_option('update_plugins');
+	$update_plugins = get_transient('update_plugins');

...

-	delete_option('update_plugins');
+	delete_transient('update_plugins');

a few comments on the patch:

  • changes to wp-includes/update.php merely make the code conform with the comments
  • the addition of the $res->external allows to remove the link to "Plugin page on WordPress.org" thingy, which is irrelevant when the plugin is hosted elsewhere
  • $api->rating was missing a conditional statement

comment:2 @ryan6 years ago

(In [11585]) Plugin install fixes. Props Denis-de-Bernardy. see #10192

comment:3 @ryan6 years ago

(In [11586]) Plugin install fixes. Props Denis-de-Bernardy. see #10192 for 2.8.1

comment:4 @Denis-de-Bernardy6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

I'll open a new ticket if I find more.

Note: See TracTickets for help on using tickets.