WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#10214 closed enhancement (wontfix)

Further formatting separation in Kubrick theme

Reported by: brettz95 Owned by: iandstewart
Milestone: WordPress.org Priority: lowest
Severity: trivial Version: 2.8
Component: Themes Keywords:
Focuses: Cc:

Description

I was told to report this issue here (the theme is for one of the defaults).

Although I understand HTML5 is considering keeping the <small/> tag for the sake of things like legalese fine print, when text is made small merely due to a stylistic choice, it is considered best practice to separate the styling in the stylesheet. This lets structural code stay correct even if we wish to make our text no longer small.

For the Kubrick theme, in style.css, I'd suggest adding the following (since span won't inherit the current color otherwise):

.permlink {

color:#777777;

}

and then add .permlink to the small declaration (or use it in place of 'small' if you're not using 'small' elsewhere):

small, .permlink {

font-family:Arial,Helvetica,Sans-Serif;
font-size:0.9em;
line-height:1.5em;

}

Then in index.php (in place of where <small/> was used):
<span class="permlink"><?php the_time('F jS, Y') ?> <!-- by <?php the_author() ?> --></span>

Attachments (1)

smallFormattingToStyles.patch (6.0 KB) - added by brettz95 5 years ago.
Moving small formatting to style sheet

Download all attachments as: .zip

Change History (11)

comment:1 brettz955 years ago

  • Cc brettz95 added

comment:2 Denis-de-Bernardy5 years ago

  • Component changed from Formatting to Template
  • Keywords needs-patch close added
  • Milestone changed from Unassigned to Future Release
  • Priority changed from normal to lowest
  • Severity changed from minor to trivial
  • Type changed from defect (bug) to enhancement
  • Version set to 2.8

sending this to the will think about it in a few years bin.

comment:3 brettz955 years ago

For the amount of time you spent changing the priorities, you could have implemented what should be a very non-controversial patch. While it admittedly is not that big of a deal, I would think WordPress, in priding itself on good practices, attention to detail, and standards compliance, wouldn't have a problem to make a very easy fix for better stylesheet flexibility.

comment:4 Denis-de-Bernardy5 years ago

Well, that's the motto. For my part, I punted this in under 20s from lack of patch, and I couldn't care less if my site doesn't validate.

brettz955 years ago

Moving small formatting to style sheet

comment:5 brettz955 years ago

Ok, I've added a patch, and it covers all pages in the theme which use "small". But this particular patch wasn't about validation--just separation of structure from formatting. FWIW, the original creator of the theme stated he "heartily agreed" with my changes to keep them separate as I proposed. Thanks much...

comment:6 johnbillion4 years ago

  • Keywords needs-patch close removed
  • Milestone Future Release deleted
  • Resolution set to invalid
  • Status changed from new to closed

n/a now we have Twenty Ten

comment:7 nacin4 years ago

  • Component changed from Template to Themes
  • Milestone set to WordPress.org site
  • Resolution invalid deleted
  • Status changed from closed to reopened

comment:8 nacin4 years ago

  • Owner set to iandstewart
  • Status changed from reopened to assigned

comment:9 iandstewart4 years ago

  • Resolution set to wontfix
  • Status changed from assigned to closed

Going to mark this as wontfix out of concern for those using Default as a Child theme and expecting the markup to stay the same.

comment:10 brettz954 years ago

First, let me apologize to Denis for being a jerk in my earlier comment. I think I had just spent some time on the patch and was assuming something like that would make it in, but not accounting for the fact that everybody is busy, etc. I guess it's just that for contributors who care about the code, a "wontfix" or equivalent is not a fun thing to run into.

That being said, are that many authors really going to be depending on modifying the default styles for these smaller issues? It's not like these are modifying whole divs or anything, and my style changes were meant to replicate the same styling as before, just separating the formatting into the stylesheets where they belong. The author of this theme was himself in favor of the changes. And like other upgrades that sometimes need to break things a little bit if you can even call it that, this will give more control/clarity to users (and the type of users who have modified their stylesheets probably understanding the reasoning for the changes anyways and can easily fix whatever they've done).

I'll leave it at that, but I think it would be nice to go 100%. Thanks...

Note: See TracTickets for help on using tickets.