Various php notices in default-widgets.php

[mrmist]

The attached fixes various undefined index notices which appear when wp_debug is enabled and the widgets page is visited with various widgets and widget titles.

[dd32]

<?php checked(isset($instance['filter'])) ? $instance['filter'] : 0 ; ?>

That logic is wrong, Well, I mean the bracketing is.
Should be:

<?php checked(isset($instance['filter']) ? $instance['filter'] : 0); ?>

[mrmist]

Updated the patch as noted above..

[Denis-de-Bernardy]

nit picking, but things like this:

$count = isset($instance['count']) ? (bool) $instance['count'] :false; 

could also be written like:

$count = isset($instance['count']) && $instance['count']; 

[Mittineague]

I got an E_NOTICE with (with my version of a fix)

class WP_Widget_Search extends WP_Widget {
.....
	function widget( $args, $instance ) {
.....
//		$title = apply_filters('widget_title', $instance['title']);
		$title = apply_filters('widget_title', empty($instance['title']) ? __('Search') : $instance['title']);

And I haven't figured out how to fix this one yet

class WP_Widget_Text extends WP_Widget {
.....
	function widget( $args, $instance ) {

which has an index not defined for $instancefilter?

[mrmist]

Can this go in (with or without DdB's changes) before it gets stale?

[Denis-de-Bernardy]

r11757 fixed this, no?

[mrmist]

This particular issue has indeed been fixed.