WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

#10242 closed defect (bug) (fixed)

Media menu does not handle multiple lines

Reported by: xibe Owned by: azaozz
Milestone: 3.0 Priority: normal
Severity: normal Version: 2.8
Component: UI Keywords: has-patch tested
Focuses: Cc:

Description

This bug has been reported on the fr_FR forum back in Feburary, and it is still true for 2.8.

Some plugin add another item in the Media menu. While this is perfectly acceptable, some translation might already use the full width for the three default items (see first attached capture), and therefore any additional item would be pushed to a second menu line.

That should be no problem, but in effect that second menu line pushes the first one off-screen, leaving only the second one to be seen (see second attached capture).

The translation has since been reduced, but the issue remains: the menu should be able to handle numerous sub-lines, just because the use might want to use many item-adding plugins...

Attachments (3)

wp28-mediamenu-fr.png (49.7 KB) - added by xibe 6 years ago.
overlong fr_FR Media menu
wp28-mediamenuNextgen.png (45.2 KB) - added by xibe 6 years ago.
same fr_FR Media menu, with NetxtGEN Gallery plugin activated
10242.patch (504 bytes) - added by edward mindreantre 5 years ago.

Download all attachments as: .zip

Change History (11)

@xibe6 years ago

overlong fr_FR Media menu

@xibe6 years ago

same fr_FR Media menu, with NetxtGEN Gallery plugin activated

comment:1 @xibe6 years ago

  • Keywords needs-patch 2nd-opininon added

comment:2 @ryan6 years ago

  • Component changed from Menus to UI
  • Owner changed from ryan to azaozz
  • Status changed from new to assigned

comment:3 @azaozz6 years ago

  • Milestone changed from 2.9 to 3.0

No patch, moving to 3.0

@edward mindreantre5 years ago

comment:4 @edward mindreantre5 years ago

  • Keywords has-patch added; needs-patch 2nd-opininon removed

Vive la France!

Here's a patch. I converted the ul#sidemenu to a normal, non-floated UL. It looks like normal but can now handle very long lines. It don't look too pretty when it breaks up to two rows but them's the breaks, eh?

comment:5 @xibe5 years ago

Thanks Edward!

My cache doesn't seem to want to take it into account, but a quick test through FireBug shows that it's the right direction. It'd need a bit of spit'n'polish to make sure it stays preeety, but apart from that, thanks a lot :)

comment:6 @dd325 years ago

  • Keywords needs-testing added

comment:7 @ocean905 years ago

  • Keywords tested added; needs-testing removed

Works fine: http://grab.by/45hN

You can test it with

function test_tabs ($tabs) {
	$newtab = array(
	'1' => ('1 Gallery'),
	'2' => ('2 Gallery'),
	'3' => ('3 Gallery'),
	'4' => ('4 Gallery'),
	'5' => ('5 Gallery'),
	'6' => ('6 Gallery'),
	);
    return array_merge($tabs,$newtab);
}
add_filter('media_upload_tabs', 'test_tabs');

comment:8 @markjaquith5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [14661]) Update media upload window tabs CSS to support wrapping of tabs when they exceed the available width. props edward mindreantre. fixes #10242

Note: See TracTickets for help on using tickets.