WordPress.org

Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#1028 closed defect (bug) (fixed)

Comment whitelist never tested if no moderation keys

Reported by: ColdForged Owned by: ryan
Milestone: Priority: normal
Severity: minor Version: 1.5.1
Component: General Keywords:
Focuses: Cc:

Description

If there are no moderation keys specified in the discussion options, the comment is approved regardless of any whitelist settings.

Attachments (1)

comment-functions.php.patch​ (2.4 KB) - added by ColdForged 12 years ago.

Download all attachments as: .zip

Change History (6)

#1 @ColdForged
12 years ago

  • Patch set to No

#2 @matt
12 years ago

Patch seems to include a lot of needless whitespace changes

#3 @ColdForged
12 years ago

There was a change of scope to place a block that previously wasn't under a conditional statement under that conditional, necessitating a change in indent. How do you propose doing that without actually indenting?

#4 @ColdForged
12 years ago

Which is, of course, a snippy way of saying that I don't think it's needless in this case. Long day.

#5 @ryan
12 years ago

  • fixed_in_version set to 1.5.1
  • Owner changed from anonymous to rboren
  • Resolution changed from 10 to 20
  • Status changed from new to closed

​http://trac.wordpress.org/changeset/2414

@ColdForged
12 years ago

Note: See TracTickets for help on using tickets.