WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#10283 closed defect (bug) (fixed)

Incorrect check in wp_style_is()

Reported by: Denis-de-Bernardy Owned by: azaozz
Milestone: 2.8.1 Priority: normal
Severity: major Version: 2.8
Component: General Keywords: has-patch dev-feedback
Focuses: Cc:

Description

As reported in #10264. Shouldn't this be:

	if ( !is_a($wp_styles, 'WP_Styles') )
		$wp_styles = new WP_Styles();

Attachments (1)

10283.diff (482 bytes) - added by Denis-de-Bernardy 5 years ago.

Download all attachments as: .zip

Change History (5)

Denis-de-Bernardy5 years ago

comment:1 Denis-de-Bernardy5 years ago

  • Keywords has-patch dev-feedback added
  • Owner set to azaozz
  • Severity changed from normal to major
  • Status changed from new to assigned

untested patch, but presumably the correct behavior.

comment:2 azaozz5 years ago

Yes, looks like a typo but since that function is not used anywhere else, it took long time to find.

comment:3 azaozz5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [11655]) Fix typo in wp_style_is(), props Denis-de-Bernardy, fixes #10283 for 2.8

comment:4 azaozz5 years ago

(In [11656]) Fix typo in wp_style_is(), props Denis-de-Bernardy, fixes #10283 for trunk

Note: See TracTickets for help on using tickets.