#10292 closed defect (bug) (fixed)
Function wp_timezone_choice() does not properly check for last element
Reported by: | hakre | Owned by: | |
---|---|---|---|
Milestone: | 2.8.1 | Priority: | normal |
Severity: | normal | Version: | 2.8 |
Component: | Administration | Keywords: | has-patch tested |
Focuses: | Cc: |
Description
There is a minor flaw in wp_timezone_choice() which invalidates output. Additionally a variable name was in german lanuges which should be in english.
Patch attached.
Attachments (2)
Change History (9)
#2
@
15 years ago
German style plural forms are not uncommon in English, especially among engineering types. No need to change them.
#3
@
15 years ago
Well personally, I had not problem to read that german in there and understand it, but that might be because that is my motherlanguage. I thought it is uncommon to do so in wordpress dev and development.
The fix is pretty straight forward anyway. Will provide a second patch that is in german zones terminology for dedicated to all engineerettes out there.
#4
@
15 years ago
Sigh. I wish I'd gotten around to removing that " temporary! Not in final" bit from the patch before it actually got committed into the final release. ;-)
And there is a docblock correction as well.