Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#10292 closed defect (bug) (fixed)

Function wp_timezone_choice() does not properly check for last element

Reported by: hakre Owned by:
Milestone: 2.8.1 Priority: normal
Severity: normal Version: 2.8
Component: Administration Keywords: has-patch tested
Focuses: Cc:


There is a minor flaw in wp_timezone_choice() which invalidates output. Additionally a variable name was in german lanuges which should be in english.

Patch attached.

Attachments (2)

10292.patch (2.5 KB) - added by hakre 6 years ago.
10292.2.patch (983 bytes) - added by hakre 6 years ago.
Common Engineering Style Variable Naming Variant

Download all attachments as: .zip

Change History (9)

comment:1 @hakre6 years ago

  • Version set to 2.8

And there is a docblock correction as well.

@hakre6 years ago

comment:2 @ryan6 years ago

German style plural forms are not uncommon in English, especially among engineering types. No need to change them.

comment:3 @hakre6 years ago

Well personally, I had not problem to read that german in there and understand it, but that might be because that is my motherlanguage. I thought it is uncommon to do so in wordpress dev and development.

The fix is pretty straight forward anyway. Will provide a second patch that is in german zones terminology for dedicated to all engineerettes out there.

@hakre6 years ago

Common Engineering Style Variable Naming Variant

comment:4 @Otto426 years ago

Sigh. I wish I'd gotten around to removing that " temporary! Not in final" bit from the patch before it actually got committed into the final release. ;-)

comment:5 @hakre6 years ago

For Reference: #10288

comment:6 @ryan6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [11677]) Output final optgroup. Props hakre. fixes #10292 for trunk

comment:7 @ryan6 years ago

(In [11678]) Output final optgroup. Props hakre. fixes #10292 for 2.8.1

Note: See TracTickets for help on using tickets.