WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 21 months ago

#10297 closed enhancement (fixed)

Tabindex bug in Post - Write

Reported by: kovshenin Owned by:
Milestone: 3.5 Priority: normal
Severity: normal Version:
Component: Accessibility Keywords: tabindex ui gsoc has-patch needs-testing
Focuses: Cc:

Description

I'm not sure why the tabindex for the "send trackbacks to" field is 7. It conflicts with the in the custom fields "add new field" which is 7 (field name) and 8 (field value), so it's pretty annoying to have to press tab twice to get from field name to field value (through send trackbacks too).

Attachments (1)

10297.diff (777 bytes) - added by wojtek.szkutnik 4 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Denis-de-Bernardy5 years ago

  • Milestone changed from Unassigned to Future Release
  • Type changed from defect (bug) to enhancement

wojtek.szkutnik4 years ago

comment:2 wojtek.szkutnik4 years ago

  • Cc wojtek.szkutnik@… added
  • Keywords gsoc has-patch added

This fixes the tracebacks conflict, now "excerpt" and "tracebacks" are a 6.

Another nice improvement would be fixing the name->delete->update->value route in custom fields to name->value->delete->update , but I think it can't be done as long as this part of ui is table-based...

comment:3 wojtek.szkutnik4 years ago

  • Keywords needs-testing added

comment:4 azaozz4 years ago

  • Component changed from UI to Accessibility

IMHO we would need to review the use of tabindex everywhere. It seems it's not needed in many places and some are incorrect.

The order of "tabbing" through the screen is very important for screen readers. All browsers do it consistently from left to right and top to bottom so we would need tabindex only where we want to break that order (like on the edit post screen where title and content should be 1st and 2nd).

comment:5 wojtek.szkutnik4 years ago

Indeed. Related: http://core.trac.wordpress.org/ticket/6352

In the admin panel, tabindexes are used in only a few places, like the menu, where otherwise we would get multiple "expand menu" links, or the mentioned post edition screen. I will take a close look at all cases, while working on 6352

comment:6 sabreuse21 months ago

Most tabindexes have been removed in [21311]; tabbing now works as expected in the Custom Fields metabox.

comment:7 nacin21 months ago

  • Milestone changed from Future Release to 3.5
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.