WordPress.org

Make WordPress Core

Opened 11 years ago

Closed 11 months ago

#10303 closed enhancement (wontfix)

Provide better user feedback when content is changed by filters.

Reported by: tott Owned by: tott
Milestone: Priority: normal
Severity: normal Version:
Component: Formatting Keywords:
Focuses: Cc:

Description

When filtering content via kses, adjusting bad nested xhtml or similar no feedback is given to the user. The content is just stripped and the user is not informed about the changes made and why they happened.

Presenting a diff in the admin message should increase the UX.

Attachments (2)

admin-message-core-wporg.diff (2.0 KB) - added by tott 11 years ago.
core patches needed to implement desired behavior
admin-post-diff.php (2.3 KB) - added by tott 11 years ago.
possible plugin that implements text diff when content is filtered. put in wp-content/plugins/ and activate

Download all attachments as: .zip

Change History (9)

@tott
11 years ago

core patches needed to implement desired behavior

@tott
11 years ago

possible plugin that implements text diff when content is filtered. put in wp-content/plugins/ and activate

#1 @tott
11 years ago

  • Owner set to tott
  • Status changed from new to accepted

Attached is a possible solution for this. It relies on some additional actions and filters. I am not sure if this is the best way to get it done and would be happy about some feedback and ideas.

#2 @ryan
11 years ago

I don't think you need do_action_ref_array() here. do_action() seems like it would suffice.

#3 @Denis-de-Bernardy
11 years ago

  • Milestone changed from Unassigned to 2.9

@rboren: probably true, but it's more memory intensive.

#4 @ryan
11 years ago

  • Milestone changed from 2.9 to Future Release

#5 @DrewAPicture
7 years ago

  • Component changed from UI to Formatting
  • Keywords kses embed filters removed

This is almost revisions.

#6 @chriscct7
5 years ago

  • Keywords needs-refresh added; has-patch removed

Patch needs a complete refresh

#7 @pento
11 months ago

  • Keywords needs-refresh removed
  • Resolution set to wontfix
  • Status changed from accepted to closed

Generally speaking, the end user shouldn't run into issues with HTML being unexpectedly modified: the editor should handle transforming it appropriately (eg, embed HTML being pasted into a block).

Rather than presenting the end user with an error message they can't do anything about, it's better to fix whatever HTML handling failed in the first place.

Note: See TracTickets for help on using tickets.