WordPress.org

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #10348, comment 19


Ignore:
Timestamp:
06/04/11 13:58:00 (3 years ago)
Author:
blazerlocal
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #10348, comment 19

    v1 v2  
    1 I completely disagree with the whole "lets get more hosts to work with the Direct class" idea.  The Direct class is crap.  You want hosts to use the Direct class?  How about you get the devs of libssh2 to actively maintain it again?  It took two years for it to start supporting PHP 5.3 and it only started supporting that when someone else came along and took it over from the old devs.  And that they can make it compile doesn't mean they're going to be able to fix bugs with the implementation itself. 
     1I completely disagree with the whole "lets get more hosts to work with the Direct class" idea.  The Direct class is a mess.  You want hosts to use the Direct class?  How about you get the devs of libssh2 to actively maintain it again?  It took two years for it to start supporting PHP 5.3 and it only started supporting that when someone else came along and took it over from the old devs.  And that they can make it compile doesn't mean they're going to be able to fix bugs with the implementation itself. 
    22 
    33And the API just plain sucks.  Private keys have to be saved on the filesystem to be loaded whereas with phpseclib all they need be is strings.  You can take a key from $_POST without having to dump it to the filesystem as libssh2 requires.  To top it off, libssh2 requires you have a separate file for the publickey, which is brain dead, since the private key *contains* the public key.