WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#10357 closed enhancement (invalid)

Use strtr() when possible

Reported by: scribu Owned by: scribu
Milestone: Priority: low
Severity: normal Version:
Component: Optimization Keywords: has-patch close
Focuses: Cc:

Description

When replacing strings of the same lenght, it's better to use strtr() instead of str_replace() because it's faster.

Attachments (1)

strtr.patch (5.5 KB) - added by scribu 5 years ago.
use strtr() for single character replacements

Download all attachments as: .zip

Change History (6)

scribu5 years ago

use strtr() for single character replacements

comment:1 azaozz5 years ago

There are conflicting reports on which is faster, seems strtr() is a little faster only for very short strings but the difference is less than a microsecond.

comment:2 Denis-de-Bernardy5 years ago

  • Keywords close added

let's close then?

comment:3 Denis-de-Bernardy5 years ago

  • Component changed from General to Optimization
  • Milestone changed from 2.8.2 to 2.9

comment:4 scribu4 years ago

  • Resolution set to invalid
  • Status changed from new to closed

I guess it's not worth the trouble.

comment:5 scribu4 years ago

  • Milestone 2.9 deleted
Note: See TracTickets for help on using tickets.