atom: attachment/file/\d doesn't find attachment file

[mysz]

When I try to download some file via AtomPub, I got thousends of warnings in 793 and 794 (wp-app.php) about bad stream. It's because there is no checking about correctness of path, and because there is not full path to upload directory. I attach proposition of patch.

[mysz]

wp-app.php patch

[Denis-de-Bernardy]

can you outline steps to reproduce (server config, software you're using, etc.)?

[mysz]

Wordpress from subversion: r11705, IdeaWebServer (home.pl webhosting webserver), PHP as FCGI.
My upload path is /photos.
Now at my desktop i try to play with python:

h = httplib.HTTPConnection ('h2o.sztolcman.eu')
h.set_debuglevel (10)
h.connect ()
h.request ('GET', '/wp-app.php/attachment/file/166', headers={'Authorization': 'Basic '+base64.b64encode ('login:password')})

I enable log in wp-app.php, and I got there warnings I describe before.

With patch I attached, I can download requested file correctly :)

ps. I tried to download file via browser: ​http://h2o.sztolcman.eu/wp-app.php/attachment/file/166 and I got the same warnings, and file downloading never ends.

[josephscott]

I was able to duplicate the problem and confirm that the patch fixes it. I couldn't get the diff to apply though so I've uploaded a refreshed version of it.

@mysz can you test my updated version of the patch and make it works for you as well. If so then it should be fine to get committed into -trunk.

If we are going to have a another release from the 2.8 branch then I think this should get committed there as well.

Just FYI you can also fetch the file via the src attribute in the content element. I'm not really sure why AtomPub provides two different URLs to access the same file in this case.

[westi]

(In [11810]) Enable the APP attachment file download to work correctly rather than just returning a lot of php notices. Fixes #10372 for trunk props mysz.

[westi]

Re-open for 2.8 branch inclusion

[westi]

(In [11811]) Enable the APP attachment file download to work correctly rather than just returning a lot of php notices. Fixes #10372 for 2.8 branch props mysz.