White space should be collapsed after tags are stripped in wp_trim_excerpt

[sojweb]

I've a minor edit I'd like to propose: When wp_trim_excerpt strips tags from the post content, it leaves the white space surrounding those tags, and then pulls the first 55 characters, which could be blank. So, for a lot of my posts that had a big set of HTML tags at the beginning, the excerpt would be empty. The work around is easy: collapse the white space (which the browser would do anyway). I hope it seems logical. Diff file attached.

[sojweb]

*That should read: "first 55 words" in the description

[scribu]

Wouldn't a simple trim() do the job?

[rmccue]

I agree, trim() would be much simpler and probably more efficient. Make sure it's after the strip_tags(), otherwise there could be whitespace in the middle being left there.

[dd32]

No. a trim would not work.

the issue here, is that

$in = "A<test> <test> <test> B";
$in = strip_tags($in);
echo $in; //is now 3 spaces between a and b

when you explode by spaced, you end up with spaces being words, ie.

$in = "   ";
$in = explode(' ', $in);
var_dump($in);
---
array
  0 => string '' (length=0)
  1 => string '' (length=0)
  2 => string '' (length=0)
  3 => string '' (length=0)

This is what i'd use myself to get the words:

$a = "          This is a test";
preg_match_all('|\b([^\W]+?)\b|', $a, $words);
$words = $words[1];

result:

array
  0 => string 'This' (length=4)
  1 => string 'is' (length=2)
  2 => string 'a' (length=1)
  3 => string 'test' (length=4)

[azaozz]

Considering that strip_tags is run after wpautop() and the other filters on 'the_content', the pseudo-excerpt will always be one line text. If we want to avoid normalizing white space for the whole post, perhaps can use preg_split:

$words = preg_split('/\s+/', $text, $excerpt_length + 1, PREG_SPLIT_NO_EMPTY);

[sojweb]

Probably shouldn't count on wpautotop() running, as a lot of people (myself included) have it disabled, but preg_split would be just as good, just don't forget to strip tags from $text; otherwise you will probably end up with broken HTML. I've attached a diff file that uses it.

[Denis-de-Bernardy]

@sojweb: why the move of the strip_tags call in the patch?

[sojweb]

@Denis-de-Bernardy: You mean why remove it from its own line? It makes for one less variable assignment... I suppose I did it more out of habit than anything else. It doesn't make any real difference.

[Denis-de-Bernardy]

Replying to sojweb:

@Denis-de-Bernardy: You mean why remove it from its own line? It makes for one less variable assignment... I suppose I did it more out of habit than anything else. It doesn't make any real difference.

It makes things less readable? :-)

D.

[sojweb]

Readable? l33t h4x0r5 do not need readable code ;-).

[Denis-de-Bernardy]

Yayaya, and "If it was hard for me to write it, it should be hard for them to understand it!" Still... :-)

[sojweb]

Replying to Denis-de-Bernardy:

Yayaya, and "If it was hard for me to write it, it should be hard for them to understand it!" Still... :-)

Ha, exactly!

No, I'm totally with you... readability is worth the extra line.

[Denis-de-Bernardy]

alternative implementation:

​http://svn.wp-plugins.org/sem-fancy-excerpt/trunk/sem-fancy-excerpt.php

[Denis-de-Bernardy]

btw, the current patch is not utf8-safe.

[Denis-de-Bernardy]

see ​http://core.trac.wordpress.org/ticket/11669#comment:17 for the above-mentioned utf8 problem.

[Denis-de-Bernardy]

untested

[Denis-de-Bernardy]

I've added a utf8-safe version of the suggested patch, in case anyone's willing to test this.

[dd32]

(In [13942]) A better default except, Remove multiple white spaces from the except as well as splitting safely on UTF8 strings. Props Denis-de-Bernardy for the UTF8 split. Fixes #10376

[scribu]

I know it doesn't really matter, but in regex, isn't [\n\r\t ]+ equivalent to \s+ ?

[scribu]

Nevermind, I saw the comment above.