WordPress.org

Make WordPress Core

Opened 5 years ago

Last modified 3 years ago

#10384 new enhancement

Make IIS Permalink support enabled based on capability not on version number

Reported by: westi Owned by: westi
Milestone: Future Release Priority: normal
Severity: normal Version: 2.8
Component: Permalinks Keywords: has-patch commit early
Focuses: Cc:

Description

At the moment we enable the IIS permalink support based on checks for IIS7 and then some capabilities.

We should remove the version checking and work solely on capabilities so that we don't have to revisit when IIS8 is released.

Attachments (2)

10384.patch (8.8 KB) - added by ruslany 5 years ago.
Patch to remove dependency on IIS version
10384-whale.patch (13.4 KB) - added by peaceablewhale 5 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 peaceablewhale5 years ago

  • Cc peaceable_whale@… added
  • Type changed from defect (bug) to enhancement

see also #10186

ruslany5 years ago

Patch to remove dependency on IIS version

comment:2 ruslany5 years ago

  • Keywords has-patch added; needs-patch removed

The suggestion in the bug makes sense. There is no need to have a version check. It is possible to reliably figure out permalinks support on IIS even without version check.

I've attached the patch.

comment:3 peaceablewhale5 years ago

I think functions should be deprecated first before they are completely removed. In addition, some filters have to be preserved for existing plugins (if any). A new patch, based on Ruslany's patch, has been uploaded to improve backward compatibility.

peaceablewhale5 years ago

comment:4 peaceablewhale5 years ago

Updated patch to mark iis_save_url_rewrite_rules() @since 2.9.0.

comment:5 peaceablewhale5 years ago

  • Milestone changed from Future Release to 2.9

#10386 is depending on this report.

comment:6 peaceablewhale5 years ago

Changes made in #10435, if approved, has to be added to this patah too.

comment:7 westi4 years ago

  • Milestone changed from 2.9 to 3.0

Leave this for 3.0

comment:8 nacin4 years ago

  • Keywords commit added

Patch looks good.

comment:9 nacin4 years ago

  • Keywords early added
  • Milestone changed from 3.0 to 3.1

comment:10 nacin3 years ago

  • Milestone changed from Awaiting Triage to Future Release

comment:11 knutsp3 years ago

  • Cc knut@… added
Note: See TracTickets for help on using tickets.