WordPress.org
Get WordPress

Make WordPress Core

Opened 16 years ago

Last modified 5 weeks ago

#10384 new enhancement

Make IIS Permalink support enabled based on capability not on version number

Reported by: westi's profile westi Owned by: westi's profile westi
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 2.8
Component: Permalinks Keywords: needs-refresh close
Focuses: Cc:

Description

At the moment we enable the IIS permalink support based on checks for IIS7 and then some capabilities.

We should remove the version checking and work solely on capabilities so that we don't have to revisit when IIS8 is released.

Attachments (2)

10384.patch​ (8.8 KB) - added by ruslany 16 years ago.
Patch to remove dependency on IIS version
10384-whale.patch​ (13.4 KB) - added by peaceablewhale 16 years ago.

Download all attachments as: .zip

Change History (16)

#1 @peaceablewhale
16 years ago

  • Cc peaceable_whale@… added
  • Type changed from defect (bug) to enhancement

see also #10186

@ruslany
16 years ago

Patch to remove dependency on IIS version

#2 @ruslany
16 years ago

  • Keywords has-patch added; needs-patch removed

The suggestion in the bug makes sense. There is no need to have a version check. It is possible to reliably figure out permalinks support on IIS even without version check.

I've attached the patch.

#3 @peaceablewhale
16 years ago

I think functions should be deprecated first before they are completely removed. In addition, some filters have to be preserved for existing plugins (if any). A new patch, based on Ruslany's patch, has been uploaded to improve backward compatibility.

@peaceablewhale
16 years ago

#4 @peaceablewhale
16 years ago

Updated patch to mark iis_save_url_rewrite_rules() @since 2.9.0.

#5 @peaceablewhale
16 years ago

  • Milestone changed from Future Release to 2.9

#10386 is depending on this report.

#6 @peaceablewhale
16 years ago

Changes made in #10435, if approved, has to be added to this patah too.

#7 @westi
15 years ago

  • Milestone changed from 2.9 to 3.0

Leave this for 3.0

#8 @nacin
15 years ago

  • Keywords commit added

Patch looks good.

#9 @nacin
15 years ago

  • Keywords early added
  • Milestone changed from 3.0 to 3.1

#10 @nacin
14 years ago

  • Milestone changed from Awaiting Triage to Future Release

#11 @knutsp
14 years ago

  • Cc knut@… added

#12 @chriscct7
10 years ago

  • Keywords needs-refresh added; has-patch commit early removed

Refresh to avoid changing version numnbers in comments. Then re-eval for commit

#13 @chriscct7
9 years ago

@westi interested in looking at?

#14 @desrosj
5 weeks ago

  • Keywords close added
  • Milestone set to Awaiting Review

I came across this ticket going through ones missing a milestone.

When this was created, IIS market share was sitting around 35%. A lot has changed, and this number now sits at roughly 4% with less than 0.4% of all WordPress sites now using Windows-based hosting.

I'm going to add a close suggestion to allow time for any additional feedback, but I think this (and other IIS enhancements) can probably be closed out as wontfix.

Note: See TracTickets for help on using tickets.