WordPress.org

Make WordPress Core

Opened 11 years ago

Closed 10 years ago

Last modified 5 years ago

#10391 closed defect (bug) (invalid)

Fishy looking comment_agents in the livejournal importer

Reported by: Denis-de-Bernardy Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Import Keywords:
Focuses: Cc:

Description

Found this while looking into #10389.

There are things like:

// should this be an agent instead?
'comment_agent' => $lj_comment_parent,

...

// should be comment_parent instead?
while ( $comments = $wpdb->get_results( "SELECT comment_ID, comment_agent FROM {$wpdb->comments} WHERE comment_type = 'livejournal' AND comment_agent != '0' LIMIT 5000", OBJECT ) ) {

array( 'comment_parent' => $this->get_wp_comment_ID( $comment->comment_agent ), 'comment_type' => 'livejournal-done' ),

Change History (2)

#1 @beaulebens
10 years ago

  • Resolution set to invalid
  • Status changed from new to closed

Those are intentional. They are required to maintain and manipulate the threading of comments during import, and everything is cleaned up towards the end of the importer.

This could all potentially be rewritten to use the new commentmeta table in 2.9 though if someone was interested.

#2 @DrewAPicture
5 years ago

  • Milestone 2.9 deleted
Note: See TracTickets for help on using tickets.