#10435 closed defect (bug) (duplicate)
Canonical redirect does not work on IIS7
| Reported by: | sirzooro | Owned by: | markjaquith |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Canonical | Version: | 2.8.1 |
| Severity: | normal | Keywords: | has-patch tested early |
| Cc: | Focuses: |
Description
redirect_canonical() does not take into account that IIS7 may support url rewriting. Attached patch corrects this.
Attachments (2)
Change History (12)
#2
@
17 years ago
By the way, the name of iis7_supports_permalinks() will be changed later. See also #10384.
#3
@
17 years ago
- Cc added
- Keywords early added
- Milestone 2.9 → 3.0
This patch looks ok but I would like to get some more testing done on it - don't have IIS here.
Also would prefer to change this early in a release cycle just in case it causes issues.
Moving to 3.0 early.
CC'ing ruslany as hopefully he can test it for us and give feedback.
#4
@
17 years ago
Verified the 10435.patch and confirmed that it works.
However, in order to fix this completely the patch for #10187 needs to be applied. Otherwise wp_redirect function uses HTTP refresh header instead of a proper 301 redirect. This is not preferrable from the SEO perspective. I have also verified the patch for #10187 - see my comments for that ticket.
#5
@
17 years ago
Asking to those who care about IIS: What about merging this ticket with #10187? Maybe then this get's better into line.
#6
follow-up:
↓ 7
@
17 years ago
The suggestion makes sense. Should 10187 have a patch with both fixes and then resolve 10435 as a duplicate?
#7
in reply to: ↑ 6
@
17 years ago
Replying to ruslany:
The suggestion makes sense. Should 10187 have a patch with both fixes and then resolve 10435 as a duplicate?
Strictly spoken it's not a duplicate, but well, I'm for merging so we get the redirects into order together. Would be easier for IIS tester as well as for the committer.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
In order for the patch to work, iis7_supports_permalinks() has to be moved from wp-admin/includes/misc.php to wp-includes/vars.php. I have uploaded a patch to do this. Also tested on IIS 7.5 on Windows 7 RC with URL Rewrite Module 2.0 beta.