Make WordPress Core

Opened 20 years ago

Closed 20 years ago

Last modified 9 years ago

#1044 closed defect (bug) (fixed)

Parameter accidentally overwritten in code

Reported by: shelleyp's profile shelleyp Owned by: ryan's profile ryan
Milestone: Priority: normal
Severity: major Version: 1.5.1
Component: General Keywords:
Focuses: Cc:

Description

In the classes.php file, the generate_rewrite_rules function has a parameter called $feed. Unfortunately, the first functionality in the file accidentally overwrites this, so when it's tested later in the code, the value is no longer viable.

I've patched the code in my copy of the file to the following (first few lines)--:

function generate_rewrite_rules($permalink_structure, $pageflg = true, $feedflg = true, $forcomments = false, $walk_dirs = true) {

$feedregex2 = ;
foreach ($this->feeds as $feed) {

$feedregex2 .= $feed . '|';

}

And then use $feedflg later to test to see whether feed entries should be generated.

Change History (4)

#1 @shelleyp
20 years ago

  • Patch set to No

#2 @ryan
20 years ago

  • Owner changed from anonymous to rboren
  • Status changed from new to assigned

#3 @ryan
20 years ago

  • fixed_in_version set to 1.5.1
  • Resolution changed from 10 to 20
  • Status changed from assigned to closed

This ticket was mentioned in Slack in #polyglots by petya. View the logs.


9 years ago

Note: See TracTickets for help on using tickets.