get_home_path() fails when home url and site url differ in case

[Denis-de-Bernardy]

If you set your blog's url and site url to the same thing, albeit with differing caps, get_home_path() returns / instead of ABSPATH.

We should probably sanitize/lowercase the two. I've a user who was reporting the weirdest error related to an open_basedir restriction. No wonder it was returning errors...

[Denis-de-Bernardy]

The likelihood is it's also failing if the two differ by a www, but that's just another issue on top of the issues raised in #9873.

[dd32]

Sanitizing to lowercase is not going to work in all cases.

Remember most *nix filesystems are case sensitive, and thus, so are the URL's generated for paths.

Without knowing what that function does, given it generates a filesystem path, mearly ignoring the domain name part of the settings could be a middleground. (As thats the only part that can be considered to be case-insensitive on every platform)

[Denis-de-Bernardy]

Yup, we're on the same wavelength. I think it something like this, in get_home_path(), might do the trick:

$home = parse_url($home);
$home = $home['path'];
$siteurl = parse_url($siteurl);
$siteurl = $siteurl['path'];

[Denis-de-Bernardy]

As to the question on what it does, it's used to by save_mod_rewrite_rules().

[dd32]

see also: #10609

[hakre]

Is it possible taht exemplary data for the two values is provided so that this can be properly tested?

[Denis-de-Bernardy]

use: eXaMPLe.com and example.com

[hakre]

Might colide with #10970

[dd32]

just striping myself as owner off this. (Was automatically added based on the component at one stage)

[SergeyBiryukov]

Related: #20449

[dd32]

In [21224]:

Make get_home_path() work in more cases by being case insensitive and sanitzing Windows paths. In some cases (such as differing case of hostnames or paths in the site/home options, or when SCRIPT_FILENAME contains forward slashes) the function was failing to return the correct path, and would instead return /. Props to SergeyBiryukov for the initial patch. Fixes #20449 Fixes #10447