Opened 17 years ago
Closed 16 years ago
#10450 closed defect (bug) (worksforme)
Errors while downloading a updated version zip result in PCLZIP_ERR_BAD_FORMAT (-10) message leaving the user alone w/o a general information what happened.
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | Priority: | low | |
| Severity: | minor | Version: | 2.8.1 |
| Component: | Upgrade/Install | Keywords: | |
| Focuses: | Cc: |
Description
Looks like security probs getting this all untested & overheated. The 2.8.1 looks like being too much untested to be able to update to the next version (2.8.2) then.
Get a
PCLZIP_ERR_BAD_FORMAT (-10) : Invalid archive structure
message while doing the automatic update.
Regression on #10104 ?
Was not with that ticket there but this smells really fishy, someone who know about that ticket should really take care. Thanks.
Change History (8)
#2
@
17 years ago
- Keywords dev-feedback removed
- Priority changed from high to normal
- Severity changed from major to normal
- Summary changed from Regression PCLZIP_ERR_BAD_FORMAT (-10) [In Upgrade 2.8.1 to 2.8.2] to Errors while downloading a updated version zip result in PCLZIP_ERR_BAD_FORMAT (-10) message leaving the user alone w/o a general information what happened.
This time it worked.
Looks like we need a better error message in there. Those zipfiles are checksummed, right?
#3
@
17 years ago
- Milestone changed from 2.8.5 to 2.9
- Priority changed from normal to low
- Severity changed from normal to minor
After reviewing this is infact of having an incomplete zipfile. From what I can say now this case is pretty rare. Normally the download works well. I degrade the priority then.
#5
@
16 years ago
- Milestone changed from 2.9 to Future Release
this was fixed, no?
The underlying cause in one specific case was, yes.
The non-user-friendlyness of the error in the event it does happen in the future, is not.
Punting to future pending a patch to give a better error.
I'd suggest something similar to this:
if ( error == PCLZIP_ERR_BAD_FORMAT ) error = 'Download incomplete, Please try again, or seek help in the support forumsif problem persists'
#6
@
16 years ago
- Keywords dev-feedback added; needs-patch removed
On second thoughts, I'm not sure its really needed.. The technical error code can use useful, And a human-readable error is also presented.
So i'm not 100% that this should be changed, What are the devs thoughts? Perhaps change the error message along the lines of An Error occured during Unziping, The error is $error. You may try again, or seek help in the Support Forums or just leave it?
#7
@
16 years ago
I reported it firsthand and it turned out that I made this report in error. Now even the error message is documented here in trac. I think we should leave it as it is because of the level of detail of the error. Just close the ticket if you like. +1 leaving as-is + close of the ticket as invalid.
Try it again.
Sounds like you've got a issue with one of the HTTP transports returning incomplete data..