Make WordPress Core

Opened 13 years ago

Closed 12 years ago

#1048 closed enhancement (fixed)

Option to "mark as spam" in notification e-mail

Reported by: markjaquith Owned by: markjaquith
Milestone: 2.1 Priority: high
Severity: normal Version: 2.0
Component: Administration Keywords: bg|has-patch bg|commit
Focuses: Cc:


Notification e-mails offer a link to delete the comment, but not to mark it as spam. This could be very useful as new plugins or future versions of WordPress start looking at comments marked as "spam" in the database.

Attachments (1)

mark_comment_as_spam.diff (9.7 KB) - added by markjaquith 12 years ago.

Download all attachments as: .zip

Change History (10)

#1 @MC_incubus
13 years ago

  • Patch set to No

#2 @markjaquith
12 years ago

  • Milestone set to 2.0.1
  • Owner changed from anonymous to markjaquith
  • Priority changed from normal to high
  • Reporter changed from MC_incubus to markjaquith
  • Status changed from new to assigned
  • Version changed from 1.5 to 2.0

We still REALLY need this. Working on a patch now!

#3 @markjaquith
12 years ago

  • Keywords bg|has-patch added

Patch adds the following:

  • link in comment notification e-mail to mark as spam
  • link in comment moderation e-mail to mark as spam
  • post.php changes to handle mark as spam links clicked from e-mail (maintaining yes/no and referer check)
  • "Mark Comment as Spam" link on regular Manage Comments view
  • JS tweaks on Manage Comments view so marking as spam fades the post
  • AJAX PHP tweaks to handle marking as spam
  • "Mark Checked Comments as Spam" button on comment mass edit mode
  • Nice "fade" box with the "marked as spam" or "deleted" comments functionality (mass edit mode)

I also fixed the following bug:

  • deletion of comment via e-mail link would lead to the "delete_comment" action being fired twice, because it was being manually called in post.php (as well as already being called in wp_delete_comment())

Please, please, please consider this for WP 2.0.1! I'll be your best friend!

#4 @davidhouse
12 years ago

  • Keywords bg|2nd-opinion added
  • Milestone changed from 2.0.1 to 2.1

I really think it's too late for big new patches. I'll give it bg|2nd-opinion though, other people feel free to change the milestone if you disagree. MarkJaquith's reasons for a 2.0.1 include:

<MarkJaquith> davidhouse: because Akismet is bundled with WP, and no one is going to mark as spam if it takes 5 clicks to do it (click the delete link, click "no," click "edit' next to comment, scroll down and click "spam", click "edit comment" 
<MarkJaquith> davidhouse: but you're probably right. I just really want it in, and think it's save a lot of people a lot of hassle, as well as improve Askismet's spam bank

#5 @markjaquith
12 years ago

  • Keywords bg|commit added; bg|2nd-opinion removed

#6 @ryan
12 years ago

Got some JS errors in the list manipulation which prevented the deletion fade. Haven't investigated yet.

#7 @markjaquith
12 years ago

I'm seeing them too... patch rot. I'll get a new one up once i figure out what's going on.

#8 @markjaquith
12 years ago


Okay, found the problem. Try this one.

#9 @ryan
12 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [3529]) Option to 'mark as spam' in notification e-mail from Mark J. fixes #1048

Note: See TracTickets for help on using tickets.