WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#10504 closed enhancement (wontfix)

a pdf icon could be useful

Reported by: Denis-de-Bernardy Owned by: ericmann
Milestone: Priority: normal
Severity: normal Version: 2.8
Component: Media Keywords: has-patch tested
Focuses: Cc:

Description

Currently, WP displays PDF documents as, well, documents. It would make a lot more sense if they displayed with a pretty PDF icon instead.

Attachments (3)

pdf_icon.diff (2.1 KB) - added by ericmann 6 years ago.
Changes to include a crystal-style PDF icon in the media library.
pdf.png (4.0 KB) - added by ericmann 6 years ago.
Crystal-style PDF icon.
10504.diff (1.6 KB) - added by Denis-de-Bernardy 6 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 @Denis-de-Bernardy6 years ago

  • Component changed from Upload to Media

comment:2 @janeforshort6 years ago

  • Milestone changed from 2.9 to Future Release

Punting due to feature freeze and lack of patch/graphic submission.

comment:3 @Denis-de-Bernardy6 years ago

might as well close as wontfix, in this case. it's not as if there were many graphic designers who browing trac tickets...

@ericmann6 years ago

Changes to include a crystal-style PDF icon in the media library.

@ericmann6 years ago

Crystal-style PDF icon.

comment:4 @ericmann6 years ago

  • Keywords has_patch needs_testing added

Tracked down the locations in Core that needed to change in order to add a PDF icon for appropriate documents in the Media Library. Also created an icon from the GPL-compliant Crystal Interaction Design Project - the same project where existing Media Library icons came from.

comment:5 @ericmann6 years ago

  • Cc ericmann added
  • Owner set to ericmann
  • Status changed from new to accepted

@Denis-de-Bernardy6 years ago

comment:6 @Denis-de-Bernardy6 years ago

  • Keywords has-patch tested added; has_patch needs_testing removed
  • Milestone changed from Future Release to 3.0
  • Version set to 2.8

I've added a separate patch based on the first suggested.

comment:7 @Denis-de-Bernardy6 years ago

tests done are the obvious ones, i.e. add a pdf and see if the icon works in the various media screens.

comment:8 @azaozz6 years ago

All current icons are generic: image, audio, video, etc. If we start adding icons for specific document formats, what about doc, xls, ppt, psd, etc. Also another problem there is that these images (not the icons, the logos) are usually trademarks, not really open source.

comment:9 @dd326 years ago

I agree with azaozz here.

WordPress cant possibly include a icon for every type of file, it makes sense to leave them as generic icons.

Themes are able to display custom icons if they wish.

comment:10 @nacin6 years ago

  • Milestone 3.0 deleted
  • Resolution set to wontfix
  • Status changed from accepted to closed
Note: See TracTickets for help on using tickets.