Make WordPress Core

Opened 16 years ago

Closed 10 years ago

Last modified 10 years ago

#10596 closed feature request (wontfix)

Error when uploading zip package with parent and child themes

Reported by: newkind's profile newkind Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.8.3
Component: Upgrade/Install Keywords: needs-patch
Focuses: Cc:

Description

There's an error when you try to install a package containing parent and couple of child themes using zip package upload from the admin dashboard.

For example i got a 1 big directory called test_template which contains 1 folder test_parent and 3 folders test_child1, test_child2, test_child3. If i upload test_template directory using ftp everything's ok, but when i try to use theme uploader and zip package test_template.zip i get an error caused by not finding a style.css file inside of the test_template directory ... but when i add a style.css file to that directory installation goes fine but templates aren't working till i use ftp and delete that file from that directory. It's troublesome if someone is giving his templates to other users.

Change History (13)

#1 @dd32
16 years ago

  • Component changed from Upload to Upgrade/Install
  • Milestone changed from Unassigned to Future Release
  • Owner set to dd32

There's an error when you try to install a package containing parent and couple of child themes using zip package upload from the admin dashboard.

Yes, The theme installer as well as plugin installer, were only built to handle a single theme/plugin to be contained within.

If WordPress supports themes being in sub-sub-sub dir's of the themes directory, then it probably needs to be updated... but not sure how WordPress is going to detect which folder is to be copied..

#2 @newkind
16 years ago

maybe it could just check if all folders that are inside of the folder-container have style.css and if yes just extract the whole folder to themes ? :)

#3 follow-up: @josephscott
16 years ago

It sounds like what is being suggested is the a given theme directory (like wp-content/themes/my-theme) could have an unlimited number of themes inside of it. I don't like that idea. A theme, even a child theme, should be separate and self-contained from all other themes.

#4 @JohnMyr
16 years ago

Atm there is 3 theme frameworks in WP.org top 10 download list, and the repository has yet not been modified to show/support child themes. Support for a upload pack with child themes will benefit users now that theme frameworks have proven to be popular.

@josepscott: I`ll quote your from a reply by you over at Justin Tadlocks post about the theme repository need for change:

Because the install process is hands free we could add the necessary information to ensure that both child theme and the parent theme get installed.
http://justintadlock.com/archives/2009/04/10/the-wordpress-theme-directory-needs-an-upgrade#comment-113770

Adding some way to unpack a framework zip containing child themes will be a great solution, until other and better solutions are implemented in the install procedure and the repository.

#5 @JohnMyr
16 years ago

  • Cc JohnMyr added

#6 in reply to: ↑ 3 @greenshady
16 years ago

Replying to josephscott:

A theme, even a child theme, should be separate and self-contained from all other themes.

Agreed.

The problem is that since the theme repository doesn't support child themes, some theme authors end up packaging child themes along with the parent theme (obviously not a good idea with the theme installer).

The best solution seems to be to enable support of child themes in the repository. I'm not sure how feasible that is, but we're at a point where this concept is fairly mainstream and could definitely use some attention.

#7 @JohnMyr
15 years ago

Since better support for parent/child themes is implemented in WP since the theme repository was launched, and theme frameworks are the most (not featured) downloaded themes, maybe the repository should embrace the framework innovation by listing frameworks in a new list together with normal themes. Theres a lot of GPL theme frameworks in the making, and if its not technically possible to make one solution for both normal themes and frameworks/child themes, there should be two solutions. Maybe its possible to cut down from 15 to 10 featured and popular themes in wp.org, and include a new featured and popular listing with 5 frameworks. An enhancement for theme-install.php would be needed to. If its not possible to have one good solution, maybe its better to have two good solutions.

#8 @hakre
15 years ago

  • Keywords needs-patch added; upload theme child parent error package multiple removed

I think having this working would be good in respect to what canonical plugins its pointing towards to.

#9 @hakre
15 years ago

  • Priority changed from high to normal

#11 @dd32
13 years ago

  • Owner dd32 deleted
  • Status changed from new to assigned

#12 @chriscct7
10 years ago

  • Resolution set to invalid
  • Status changed from assigned to closed
  • Type changed from defect (bug) to feature request

Themes are designed to be self contained. Child themes are separate directories of their parent theme as the standard, and that isn't going to change anytime soon. Closing as invalid

#13 @johnbillion
10 years ago

  • Milestone Future Release deleted
  • Resolution changed from invalid to wontfix
Note: See TracTickets for help on using tickets.