![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 17 years ago
Closed 17 years ago
#10602 closed defect (bug) (fixed)
if WP_CACHE is defined as false advanced-cache file will still be loaded
| Reported by: | dandean | Owned by: | ryan |
|---|---|---|---|
| Priority: | normal | Milestone: | 2.9 |
| Component: | Cache API | Version: | 2.9 |
| Severity: | normal | Keywords: | has-patch tested |
| Cc: | Focuses: |
Description
Line 214 of wp-settings.php is prone to confusing people if WP_CACHE is set to FALSE (or any othe value that is not TRUE). The IF statement is only checking that WP_CACHE is set, not that it is set to TRUE:
if ( defined('WP_CACHE') )
@include WP_CONTENT_DIR . '/advanced-cache.php';
Something like this would be much better:
if ( defined('WP_CACHE') && WP_CACHE == true )
@include WP_CONTENT_DIR . '/advanced-cache.php';
This would be even better (pseudo-code... removing "@" from include statement), but I understand if it violates other more important concerns:
if ( defined('WP_CACHE') && WP_CACHE == true ) {
try {
include WP_CONTENT_DIR . '/advanced-cache.php';
} catch (Exception $e) {
die("Advanced cache not configured. " + $e->getMessage());
}
}
Attachments (1)
Change History (6)
Note:
See TracTickets
for help on using tickets.
try catch is php 5