Opened 16 years ago
Closed 15 years ago
#10607 closed defect (bug) (fixed)
return variable $new_array in wp-includes/wp-db.php is not initialized
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.0 | Priority: | normal |
Severity: | normal | Version: | 2.8.3 |
Component: | Warnings/Notices | Keywords: | dev-feedback |
Focuses: | Cc: |
Description
Concerns "function get_results($query = null, $output = OBJECT)".
If the query is valid, but the result is empty the "return $new_array"
$new_array is uninitialized.
You can see this, if you enable "error_reporting(E_ALL)".
"$new_array = array();" at the begin of the function will solve the error.
Attachments (1)
Change History (11)
#1
@
15 years ago
- Component changed from General to Warnings/Notices
- Keywords needs-patch added; variable initialization removed
- Milestone changed from Unassigned to 3.0
- Owner set to westi
#9
@
15 years ago
- Keywords dev-feedback added; needs-patch removed
During the dev chat today, it was brought up that is_null($result) could pose a problem for plugins as a result of [13671].
Checking for is_array() or !is_array() for whether there are or are not results is a similar situation. I made one fix in [13681].
While I doubt we do this elsewhere in core, I wanted to re-open for discussion, as this could definitely break some plugins and I'm not sure there's a good solution;.
+1 Also, put eyeballs on get_col_info()