WordPress.org

Make WordPress Core

Opened 11 years ago

Last modified 10 years ago

#10646 closed task (blessed)

Admin Menus Shouldn't Jump Around on Pageload — at Version 3

Reported by: filosofo Owned by:
Milestone: 3.2 Priority: normal
Severity: normal Version:
Component: Administration Keywords: 3.2-early has-patch needs-testing
Focuses: Cc:

Description (last modified by filosofo)

Problem: When I open an admin page, I see the menu item I want and go to click it, and just at that moment the admin menu suddenly expands so that I click the wrong item.

Solution: Instead of expanding the menus by retrieving their saved state and adding open classes with JavaScript, we should retrieve the saved state from usermeta (it's already being saved there) and print the menus with appropriate classes, accordingly, so that there is no jump.

Change History (3)

#1 follow-up: @strider72
11 years ago

If we make the change you suggest, I believe there will be no way to close a menu if someone accesses Admin without JavaScript.

#2 in reply to: ↑ 1 @filosofo
11 years ago

Replying to strider72:

If we make the change you suggest, I believe there will be no way to close a menu if someone accesses Admin without JavaScript.

Well, currently if you access the admin without JavaScript there's no way to open a menu, except for the current children and ones preset as open, so there doesn't seem to be too much concern about allowing the non-JS folks flexibility with saved open/close states.

However, if that's something people want, we could just make the open/close arrows into links that accomplish state change for non-JS users. That might be a good idea anyways, since the current, non-JS menu has arrows that do nothing.

#3 @filosofo
11 years ago

  • Description modified (diff)
Note: See TracTickets for help on using tickets.