current-cat-ancestor in wp_list_categories

[spathon]

The wp_list_categories should apply current-cat-ancestor like wp_list_pages not just current-cat-parent to the closest parent

[azaozz]

No patch.

[wonderboymusic]

10676.diff​​ rehabs the whitespace

[nacin]

Two considerations here:

• Are the ancestor queries OK and worth it?
• Does the class name we're going with make sense?

[nacin]

Punting pending answers to the two questions.

[jrchamp]

The class name makes sense. It's the logical conclusion given that I reimplemented it before finding this ticket.

I dislike the use of get_ancestors() because it has extra overhead, we already have the first term and only need to check the terms until the point that it matches. I'm attaching a modified version of this patch that doesn't waste time array_reversing and leverages the short circuit opportunities to often avoid the get_ancestors() call altogether.

Really, given the inherent static response given by the get_ancestors() call for the provided current_category, if the Walker_Category object initialized a private member variable with the get_ancestors() array the first time it was needed, you could easily use a simple isset on the member variable on all subsequent calls. Additionally, if this path were pursued I would recommend an array_flip to allow use of the isset language construct on the array of ancestor IDs itself rather than the much slower in_array() function.

[SergeyBiryukov]

#30635 was marked as a duplicate.

[marsjaninzmarsa]

bump.

[jrchamp]

Refreshed for 4.4

[boonebgorges]

The technique in 10676_wordpress_4_4.diff​ looks good to me. Improved cache support for get_term() in 4.4 should minimize the overhead of walking the ancestor tree like this.

Can we get tests for this? At least one, which would show the class being applied to multiple levels of ancestor. (We test these classes via wp_list_categories(): https://core.trac.wordpress.org/browser/tags/4.4/tests/phpunit/tests/category/wpListCategories.php

[swissspidy]

10676.2.diff​ is a new patch containing a unit test for the new class.

[boonebgorges]

In 36008:

Add current-cat-ancestor class to ancestor items in wp_list_categories().

Pairs nicely with current-cat-parent.

Props jrchamp, swisssipdy, ardathksheyna, wonderboymusic.
Fixes #10676.